From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 030E4C04FDF for ; Wed, 2 Aug 2023 17:48:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6C3EB2801D1; Wed, 2 Aug 2023 13:48:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6733C2801AA; Wed, 2 Aug 2023 13:48:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4ECE62801D1; Wed, 2 Aug 2023 13:48:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3B6062801AA for ; Wed, 2 Aug 2023 13:48:58 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id ECB9CA0F1F for ; Wed, 2 Aug 2023 17:48:57 +0000 (UTC) X-FDA: 81079900314.09.ADF1262 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf16.hostedemail.com (Postfix) with ESMTP id 34F2E180005 for ; Wed, 2 Aug 2023 17:48:55 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=mvxuU6kS; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf16.hostedemail.com: domain of djwong@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=djwong@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690998536; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2TZMOtf0ZCs/XvWGISZdpna3qFprKEVbglDpReQgO5E=; b=l9WgSv7Lo6qhQ9YLAazIdVHSLMhByKKbA+zsKf0dE8H6HB3hdFMjmMT+1jHaFfuzD8gjKe 1jg0WeVfetuQ1duVlPa/772tMpRb7hIXkn/hVSN1xwkwk5LGVZBr5emFEvCSqI9QAkNgb0 9WircyWQqKMfbGwFdRwlk7UU0IAJGgE= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=mvxuU6kS; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf16.hostedemail.com: domain of djwong@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=djwong@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690998536; a=rsa-sha256; cv=none; b=CuXeLy9xKVRFBZGCc8a6kVQ6FRRteXLoW54kzBSFwm/MQSEJ8hmkBuf9B2MAcsvgqv5ha3 nTLjwwukFqGty1MWEQN58Rccitqn1QHcY8p36QBy98BDXfrNIv+SIHeQWFITWfGniIXFur NE48xGdhACmbnJGK3epLYFB/VxUtZA0= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D2B11615A2; Wed, 2 Aug 2023 17:48:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2BB32C433C7; Wed, 2 Aug 2023 17:48:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690998534; bh=llcebvZe/hkTeRKgHM9EKZHOV4OnEZQnmHgz/2BQCWE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mvxuU6kSe40eik5JXODSzEUcQCom178bEIK/ueyoWRpPBYA045brCsn1TKHc//Xbp 0ObmccZq1JK/3BS0VYByWWa5KMlUgDASDUx+Tg3MIvNOAUYxUN5IA3Q6lhJnKpS+Kr sJpmoKfyS9TkkEjB5QiyyKjYqppx1pnxNqB5iMeyjJu+17+GIbmic7cVmXJSuLaPLd 3IndlMaTUYFSp0rFtJkAhEAA+wijtIBWkzROVqk80WuAfa/+5o+BWPM09WvvAR3rkz JrCY5Grb5YAFwp2aCPycS4pLSm1cHlwT5kTUQjtvoINT5B7AR/RvqxCMtj/D0aZcEn M8gGWOmNe33KQ== Date: Wed, 2 Aug 2023 10:48:53 -0700 From: "Darrick J. Wong" To: Jeff Layton Cc: Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Howells , Marc Dionne , Chris Mason , Josef Bacik , David Sterba , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Tyler Hicks , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Namjae Jeon , Sungjong Seo , Jan Kara , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , Miklos Szeredi , Bob Peterson , Andreas Gruenbacher , Greg Kroah-Hartman , Tejun Heo , Alexander Viro , Christian Brauner , Trond Myklebust , Anna Schumaker , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Mike Marshall , Martin Brandenburg , Luis Chamberlain , Kees Cook , Iurii Zaikin , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Sergey Senozhatsky , Richard Weinberger , Hans de Goede , Hugh Dickins , Andrew Morton , Dave Chinner , Anthony Iliopoulos , v9fs@lists.linux.dev, linux-kernel@vger.kernel.org, linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-mtd@lists.infradead.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH v6 5/7] xfs: switch to multigrain timestamps Message-ID: <20230802174853.GC11352@frogsfrogsfrogs> References: <20230725-mgctime-v6-0-a794c2b7abca@kernel.org> <20230725-mgctime-v6-5-a794c2b7abca@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230725-mgctime-v6-5-a794c2b7abca@kernel.org> X-Rspam-User: X-Stat-Signature: qxxw1b8nb48jbg454iogwzmnaqf9fzjw X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 34F2E180005 X-HE-Tag: 1690998535-785003 X-HE-Meta: U2FsdGVkX19WlSJYpzNVvx/TtAN5tqFP0LvC/MtdjYQPz1DJXkiOL75ScLfwCBrH1DlssBt7/W2Rc4fwd/gT9YaCo4gIwp/GSWbgQGmXSLW2tD3o+2rHlSt39Ntn6jbhJiURsR2P6gGFvkMkLTcrsJ9e5b8v2qXk0n0IWhbhr2gGXqFaIBJ9tokgqfqFHvKf20b2OyijWZ7BzSBfTN9mrpgCPhzNxtPL/BQfq3Z+JVqC5DkARj7fC4uXFdVHvgWZu/kBwLVBYZ5sRfEUbkqKukwXDubysFH0Qa9/rsTzYrSd9BO/jbjA3Jj7yMaZaesha+N7nI03bDp29e6EGXT/lPSE4tildtH6NE4m1EM/Dd6i+aJqWRt3giZW5FAdCnJIxxtqQALKQovCS1HGaZ8hl8wBETcmg8JSU/4wKFsEhuw8+NVfm8LUCZGioKTt5jEiqWdbT29EodtcDAv8cWNglvGZaTfYZLW3BshXgfDog+prLpLg5aKNkMZWJJXm2VRK/lel1TvB7xhsoHr4cw//lG/J0vhtRqlR9J/6OU4wmxMuusrN8MKdgf8bNpG1fYsoDt61sC90dF9ZH6ONOB++67etndd/jmBSsrI/v9UwTub1iGkSh4pKDpe4A/CA9F6rAqRI7PlF/TMAcUMTlbat00RMmF5BgfoNRzPyIYoHsjkhz8foyhkcvZ1t20cy8Kn9KXNC4AdTDbclVS9RqfP1eOHUQThZOBcZtWD4cA1fcjG6J2OcnkOq2n7AaOaBl8IrNYSd70pBtSlWR+rYaA0Rs1JdE2joDgZM+yqD1K80Wyu5UAOZfE0oIGL9goiOGKcrKnnbF4ZE7OyXkQ9aaxK4c9DQh0aiEIj9Q0u4BF4g8dFXaAwA/xf7Qhbra4H9uCB42oYe1WulCASAzof0mStwC27DEyiRs7Q4+168Uzz2u9vYaxzx4C2tFx6ZX0YZHOYIcRmZ4wbz9NMHJlZeWjs 2NEHVHR7 Cz7tPjTgmT8bt2QKSltiuKY1JaIajiDvWkeWl4lDjJV7AgMksreThHEPvRfzBntdoG0tqQsHmY0q74pdk3IFz8U6q2jrle3dgmVPFMozAw3Mfm60mmvTJS3+kxlZpBJqogaS27uIl6lyzNGxDyngsy0W8pzNHICUnQ8bxKBRpr41GsFpo2IfIx57D6mFqQYR+NTDQ4OJ1uiYXXdrvAGqFXGVQAggNd0JlkMuCJz0dkqlTbKdT6RXcmSeHmJiUbPhd8AJ8u0DBaQOFy5oClbp9i736uCJvxprB4nU13sUdljHIWZyTl6taKDPElpQXrOwbF396lWM5Hqog28VscALRnQdJHw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 25, 2023 at 10:58:18AM -0400, Jeff Layton wrote: > Enable multigrain timestamps, which should ensure that there is an > apparent change to the timestamp whenever it has been written after > being actively observed via getattr. > > Also, anytime the mtime changes, the ctime must also change, and those > are now the only two options for xfs_trans_ichgtime. Have that function > unconditionally bump the ctime, and ASSERT that XFS_ICHGTIME_CHG is > always set. > > Signed-off-by: Jeff Layton > --- > fs/xfs/libxfs/xfs_trans_inode.c | 6 +++--- > fs/xfs/xfs_iops.c | 4 ++-- > fs/xfs/xfs_super.c | 2 +- > 3 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/fs/xfs/libxfs/xfs_trans_inode.c b/fs/xfs/libxfs/xfs_trans_inode.c > index 6b2296ff248a..ad22656376d3 100644 > --- a/fs/xfs/libxfs/xfs_trans_inode.c > +++ b/fs/xfs/libxfs/xfs_trans_inode.c > @@ -62,12 +62,12 @@ xfs_trans_ichgtime( > ASSERT(tp); > ASSERT(xfs_isilocked(ip, XFS_ILOCK_EXCL)); > > - tv = current_time(inode); > + /* If the mtime changes, then ctime must also change */ > + ASSERT(flags & XFS_ICHGTIME_CHG); > > + tv = inode_set_ctime_current(inode); > if (flags & XFS_ICHGTIME_MOD) > inode->i_mtime = tv; > - if (flags & XFS_ICHGTIME_CHG) > - inode_set_ctime_to_ts(inode, tv); > if (flags & XFS_ICHGTIME_CREATE) > ip->i_crtime = tv; > } > diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c > index 3a9363953ef2..3f89ef5a2820 100644 > --- a/fs/xfs/xfs_iops.c > +++ b/fs/xfs/xfs_iops.c > @@ -573,10 +573,10 @@ xfs_vn_getattr( > stat->gid = vfsgid_into_kgid(vfsgid); > stat->ino = ip->i_ino; > stat->atime = inode->i_atime; > - stat->mtime = inode->i_mtime; > - stat->ctime = inode_get_ctime(inode); > stat->blocks = XFS_FSB_TO_BB(mp, ip->i_nblocks + ip->i_delayed_blks); > > + fill_mg_cmtime(request_mask, inode, stat); Huh. I would've thought @stat would come first since that's what we're acting upon, but ... eh. :) If everyone else is ok with the fill_mg_cmtime signature, Acked-by: Darrick J. Wong --D > + > if (xfs_has_v3inodes(mp)) { > if (request_mask & STATX_BTIME) { > stat->result_mask |= STATX_BTIME; > diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c > index 818510243130..4b10edb2c972 100644 > --- a/fs/xfs/xfs_super.c > +++ b/fs/xfs/xfs_super.c > @@ -2009,7 +2009,7 @@ static struct file_system_type xfs_fs_type = { > .init_fs_context = xfs_init_fs_context, > .parameters = xfs_fs_parameters, > .kill_sb = kill_block_super, > - .fs_flags = FS_REQUIRES_DEV | FS_ALLOW_IDMAP, > + .fs_flags = FS_REQUIRES_DEV | FS_ALLOW_IDMAP | FS_MGTIME, > }; > MODULE_ALIAS_FS("xfs"); > > > -- > 2.41.0 >