From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6694BC001E0 for ; Wed, 2 Aug 2023 15:35:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 074DF2801BC; Wed, 2 Aug 2023 11:35:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F407C2801AA; Wed, 2 Aug 2023 11:35:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DE1B32801BC; Wed, 2 Aug 2023 11:35:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id CC1842801AA for ; Wed, 2 Aug 2023 11:35:25 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9905C40DA9 for ; Wed, 2 Aug 2023 15:35:25 +0000 (UTC) X-FDA: 81079563810.18.929F116 Received: from outbound-smtp60.blacknight.com (outbound-smtp60.blacknight.com [46.22.136.244]) by imf22.hostedemail.com (Postfix) with ESMTP id B003EC001F for ; Wed, 2 Aug 2023 15:35:23 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf22.hostedemail.com: domain of mgorman@techsingularity.net designates 46.22.136.244 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690990523; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZpH65PVG33urOT60snR1gwoYahJwQVlXfOu+LlH1B3s=; b=SEj2fLXTanhi3KCfZhlrVAd01Sji+MuIru/dYfU/W3lAc3MdI1TYZTFdAR/5FsuuJrUU3b f3uulgYiP7QHDbrssEnGhXjCYzp9ePdj5ZMQBh/W58ESM6oRzFXa71eUmcvdgc1ANzwuRL H6kw/b/g3fghRczmf9/bnOzf6hQTq00= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf22.hostedemail.com: domain of mgorman@techsingularity.net designates 46.22.136.244 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690990523; a=rsa-sha256; cv=none; b=k5811/XmYppBCSrd/O6D8bXwQ7Rl7BMsXGma7haCVRahOiwS+joS1bIPKl0NTacuNFSLzv kUFDhSt19MF2VaabYsqfAS5gu2xqdT+CoMYZRS5AeuQ5BQSHhGDmGfF7Ae73G0poePbA+g s51lvRtqFqKS/l+FLr0CMLHcGRrahTA= Received: from mail.blacknight.com (pemlinmail01.blacknight.ie [81.17.254.10]) by outbound-smtp60.blacknight.com (Postfix) with ESMTPS id 165F2FAE5C for ; Wed, 2 Aug 2023 16:35:22 +0100 (IST) Received: (qmail 28242 invoked from network); 2 Aug 2023 15:35:21 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.20.191]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 2 Aug 2023 15:35:21 -0000 Date: Wed, 2 Aug 2023 16:35:19 +0100 From: Mel Gorman To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, Andrew Morton , Linus Torvalds , liubo , Peter Xu , Matthew Wilcox , Hugh Dickins , Jason Gunthorpe , John Hubbard , Mel Gorman , Shuah Khan , Paolo Bonzini Subject: Re: [PATCH v2 5/8] pgtable: improve pte_protnone() comment Message-ID: <20230802153519.ryds4omveq5zbtex@techsingularity.net> References: <20230801124844.278698-1-david@redhat.com> <20230801124844.278698-6-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20230801124844.278698-6-david@redhat.com> X-Rspamd-Queue-Id: B003EC001F X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 94d6bpn7u4gtjbkkswiykd3ttenwwrqi X-HE-Tag: 1690990523-691691 X-HE-Meta: U2FsdGVkX1/DDwcvjbBdSN9OQ3hy83MlYkzJiWyJypEtRuL9mydFOr1pPxxN9eHxd+B+ifjOEKHKpUfxrko78qELAc3BM3+seqK2ZCfgGLaaAHagYQD0trfNi4xEgjVJD7b4ubPuPLT8NgxiFo9oXtHvx9LAJR4rfRI9WOk/M4cenPDKw/xgj66j4H7xfcuDtuGAq0L+8TcCNt/0xliCPm9E8v8HtZJ37orCkFV+Et2pNebPD7g8CLq8HlkRHr9nqxSsNOtA8elNZBdotrp5DdTF7CGXPRnwaM+YA9yF1NnmL6758AvYApUwc+I9qAhYwA9iFN+3sDCabnnk8/BoXqAo2U7WlJbA641nefFQcE5H4NkgeOQRHN+6UYcwzSxV81b8GAAqCUR/jFBPK07Ojl7ZWGG8b19PbRF9SlaH8UbgkabcDZfHV8G02x2KGvQrYGE2eu3Z+lI4NFtoK2KHqsPA0ERShkFLnTNUFNghs+mCCPdE3cGJ01auwpqS9HqtzaDYvGbbfPtH7H43ciQPaYlxxAkLHLx7Gd0tIDLe0EDuMeHClku1gO9rxF0Y+vEEv1qHrCRD86YwO//oS0UQud4lavERzN7SWZm5LqQaC4beWCvQBmak8T3DfRRL7hUeg4FDiV1LSAIOaahCewHs+YIuTtOb7oSO6jWTTaIjOfBjwY77y0VuHcw/2RMtqGwGzoS4Xrl/i3TcFRKTQtXHe7BHHhnBds0hYNWrfQ0zoPdxhB0aHTlsEFn4kT/P7R7DZNlRqqk6FetrqWRr8E2dNMYhdtmwyt8J2A35XRxU5qp0ZWJgokV80wampI5D/9CDsIlb4AB5T1iXNIGyYvad+9jv6EWW3/vrrunUVPSLLriF1yvYf+K/FH1MqHb3wJlcwOU2+4Vt/lrK2SVRKJ6MkVtWuDfzkMidn1DMPoDXXoQpoJUBpkn5M39qR+rvZmBDyK6u+5frJbd/ZhGm8Jh 1nf71t0Y LNu59PYa5G9/4GrpqZuXLpDBiMy8tQPuSqSsUWnYLVVedHTrCcwOxaAbzFXLMLEyr03GPKH14pBQD3WLQ6z0zI7IEW78FUAUlC7FTApZNrsEDPsYtTyBzj5G3t25521WlVKwYqzRyK8/TLf58iIcTlt61NBujndPX6EX6vsHICqXSDwg8DtHvTtQj1n3pj9G65y0KID8WLp4/UvdUbnVoFn9h7hHGOq+N4xrIgFiSXtL5TcF8GYb2TjD1MpKma0SP3w4TQtBTWqyiSdswNfuD0iSIPVkzsob1ye7t5pD/f+YU7PM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 01, 2023 at 02:48:41PM +0200, David Hildenbrand wrote: > Especially the "For PROT_NONE VMAs, the PTEs are not marked > _PAGE_PROTNONE" is wrong: doing an mprotect(PROT_NONE) will end up > marking all PTEs on x86 as _PAGE_PROTNONE, making pte_protnone() > indicate "yes". > > So let's improve the comment, so it's easier to grasp which semantics > pte_protnone() actually has. > > Signed-off-by: David Hildenbrand Acked-by: Mel Gorman -- Mel Gorman SUSE Labs