From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 224D9C04FE0 for ; Wed, 2 Aug 2023 15:34:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD50C2801BA; Wed, 2 Aug 2023 11:34:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A84E22801AA; Wed, 2 Aug 2023 11:34:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 973DE2801BA; Wed, 2 Aug 2023 11:34:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 884912801AA for ; Wed, 2 Aug 2023 11:34:29 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 32E28160F5D for ; Wed, 2 Aug 2023 15:34:29 +0000 (UTC) X-FDA: 81079561458.17.AE8F79E Received: from outbound-smtp29.blacknight.com (outbound-smtp29.blacknight.com [81.17.249.32]) by imf21.hostedemail.com (Postfix) with ESMTP id 451621C000D for ; Wed, 2 Aug 2023 15:34:25 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=none; spf=pass (imf21.hostedemail.com: domain of mgorman@techsingularity.net designates 81.17.249.32 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690990466; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KGudnEZaRjK2/4n6VnYqiCgSBCZO+RRdp+jmpQBrg5c=; b=dnCEbhTgah4b5psHmGtxZK8Dm3z+natoDi3Kx5mJ2STB7+2t033mtAu06HignCsK4Y6Uhu ZG/poMy3S8jRLubvSrGB/7yTlWao/XXMjoW+w5SMJ4DpcDaXk9/3BivVRWZVHGUzvNWxZM A7KoSVDgfx0ZbZ7aSnKT2LLfzzaj3AI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690990466; a=rsa-sha256; cv=none; b=f3VeAn3lRtEPoP76Gi8qCBLeL46n9hN2y/FHG6P6dmVB/nwO9bnXjCFU57us60y2cyLq8y DQeupqxsaQ3qbGQPTZWD/sbebmdJx4Cp4MbLQScRoPoDhBFiC3m+42gCBdJcG7l+IT20KA VDVVg/MN5HbJ/PFgnl1L1G6Qbt6LoTY= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=none; spf=pass (imf21.hostedemail.com: domain of mgorman@techsingularity.net designates 81.17.249.32 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net; dmarc=none Received: from mail.blacknight.com (pemlinmail04.blacknight.ie [81.17.254.17]) by outbound-smtp29.blacknight.com (Postfix) with ESMTPS id 3C911BEEC5 for ; Wed, 2 Aug 2023 16:34:24 +0100 (IST) Received: (qmail 29631 invoked from network); 2 Aug 2023 15:34:24 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.20.191]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 2 Aug 2023 15:34:23 -0000 Date: Wed, 2 Aug 2023 16:34:21 +0100 From: Mel Gorman To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, Andrew Morton , Linus Torvalds , liubo , Peter Xu , Matthew Wilcox , Hugh Dickins , Jason Gunthorpe , John Hubbard , Mel Gorman , Shuah Khan , Paolo Bonzini Subject: Re: [PATCH v2 6/8] mm/huge_memory: remove stale NUMA hinting comment from follow_trans_huge_pmd() Message-ID: <20230802153421.x5455znvogns5dfv@techsingularity.net> References: <20230801124844.278698-1-david@redhat.com> <20230801124844.278698-7-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20230801124844.278698-7-david@redhat.com> X-Rspamd-Queue-Id: 451621C000D X-Rspam-User: X-Stat-Signature: 7ftd7dktw6ab8d5npisky973yty65yjo X-Rspamd-Server: rspam03 X-HE-Tag: 1690990465-623365 X-HE-Meta: U2FsdGVkX19p0AgYhSa4vZC0F+eG1QdLD71LXUc9YMu4iBqcNXp6xEGsCT/y/rjY6D8jdOMzDwT8q0qOaH+POnlRxOdqF0O/3PEoR6qcu/uHoXpg+qf7nORNAe5RXY4YfzYcUhoQdwmM+t63rQis288y0sSOt7Jjl9H5ur4Ro5mqi0yX7NCQxbtNIIdbGWXrVaI/8FMsHQu3hYwyFPbr8XVpPrR2sefAP5gk9Mvtv4wHpXcr4Thb4dm2vx+AM2IEquIask7Fe8pdF6+PWKzuDCiEbvAkRdkUsEmmmOcMEa/Sol9QVW8LYjBRierCEe1wgMYULUng1qYq3oDWMBjHMcaqKmtpIou4+Qft6vXc4n5YgDv5f9ZJHIw5o/IkSc+gerRBLLXvnqxXSH/22eC4ZMDvrhiCjnGKNDXjwYr6LNyAFzlgtjQyhDKIOTBGY9WVSTnELkRllfsDmXOk/PuC5QQAzZ/rVNEU2E/oPJClu5jppQztHpgOU2FQtdamclg4M9xAJKz48bOx5OFKG8FOPCiqV93m2AbwQamMqStrEbd77WTczPCloglw6bI2ss/yDWfSqUEQTgNr11B7LezuIRyQX5681XCQBwVwXvbJwUY9kgVgiv/qWRHwGZ5SKnt0DXmGTdKJvhfNy6Uo8XO+Vo9bTesrG2pd+arzwJ09TjhCaCaOPXyvFtERs6XW0FJ+tRJu3GrKYo7/tWeg8lUVORrOwIBAMFMge2phyK37d858OvkWNJ+Qq3FlIj7IJBu0VK0HtF7wYrslJeksEowFwe5iRgHd3giyWMFMPZIe2IghB7LjLaoclUUxmlVV5rRZvWYan8ZF8aeq5XoLUjGcFrNjy0XiaSdrmJOL9+jaZIl3Bn49+z6wc6HkPwF7VqeLKISaA8W85ID5DfIt+WUPqLp8o0rqflytOh9W8favBajCt1ClbmmYS5lSPIUmEoUry9r35H6D+OQxHBI6g2o Y91hW2Uj 1Q07XtVDHPFWnYD1N8Ka/4y0/SRP2+DS5osp086pvzRO1blbGdjRXvyyS7Sgru3ERIwGa5ZXI8wP++37DowESZF+SbgBZnlbcUKyR60jmcLSX014KFZP95dGyx0+gih0cLIdsUbOBY910ExQ59wwILacrLI9XQoAAlErYjkmhRHIX74IjdKTzURyHV22CLZ3se9WW4HJK7XEFN2PJgIeXjZILci6zY0uGgxg8h7tgsuCyGN2KlTtPO6PwM/qbBSeNbcDyMOfuOMjanq6BXrR8jD+zHnd6z3OwtIvaBnhf4etwrhs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 01, 2023 at 02:48:42PM +0200, David Hildenbrand wrote: > That comment for pmd_protnone() was added in commit 2b4847e73004 > ("mm: numa: serialise parallel get_user_page against THP migration"), which > noted: > > THP does not unmap pages due to a lack of support for migration > entries at a PMD level. This allows races with get_user_pages > > Nowadays, we do have PMD migration entries, so the comment no longer > applies. Let's drop it. > > Signed-off-by: David Hildenbrand Acked-by: Mel Gorman -- Mel Gorman SUSE Labs