From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 666F2C00528 for ; Wed, 2 Aug 2023 13:10:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 07343280179; Wed, 2 Aug 2023 09:10:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 02382280143; Wed, 2 Aug 2023 09:10:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E54C3280179; Wed, 2 Aug 2023 09:10:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D4113280143 for ; Wed, 2 Aug 2023 09:10:09 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9998E1C9FCD for ; Wed, 2 Aug 2023 13:10:09 +0000 (UTC) X-FDA: 81079197738.26.DED5C6B Received: from dggsgout11.his.huawei.com (unknown [45.249.212.51]) by imf26.hostedemail.com (Postfix) with ESMTP id 620A914003E for ; Wed, 2 Aug 2023 13:09:32 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=none; dmarc=none; spf=none (imf26.hostedemail.com: domain of thunder.leizhen@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=thunder.leizhen@huaweicloud.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690981774; a=rsa-sha256; cv=none; b=OX3qCYodk1ZS5Hf2KNmd+18bK/Nymdzqgzu/B9+zNrOgmS7bsCwEjv8YGcFVtupKMeCcxJ eT2HmuMF/gYFOoXBcCmooN/qZ9U2AA5SqxZTEBlpPJei7qLJwklEflJQKX7jKvBFs/ydkw 4x74VusCIQ84OCqAW+J/dLtWSUqfK1s= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=none; dmarc=none; spf=none (imf26.hostedemail.com: domain of thunder.leizhen@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=thunder.leizhen@huaweicloud.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690981774; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references; bh=YWeG5lQQJ7LAnQXkjgp4NhUimRLizyIWBSsijrzufrI=; b=sRCvoZd8AvGpPuzNnBznk21Zbt9swEk9zUQd508Jy5X3e/TBfEbwS8eCGmAOD2HcOIwgrc 1Bqjfim5TLJ4HFtwHa8UDmJXNMzhm3vpqcfVpYFj1UqrQEsP1iA3jJubg7IXnI60onUIbY GSX6s4gc4kNX5BAqC4mxO7zwHL0LFC4= Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4RGC4531QZz4f3jq1 for ; Wed, 2 Aug 2023 21:09:25 +0800 (CST) Received: from huaweicloud.com (unknown [10.174.178.55]) by APP4 (Coremail) with SMTP id gCh0CgAHvbCBVcpkDKSVPQ--.59231S4; Wed, 02 Aug 2023 21:09:24 +0800 (CST) From: thunder.leizhen@huaweicloud.com To: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, "Paul E . McKenney" , Frederic Weisbecker , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Boqun Feng , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Zqiang , rcu@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Zhen Lei Subject: [PATCH v4 0/2] rcu: Dump memory object info if callback function is invalid Date: Wed, 2 Aug 2023 21:09:16 +0800 Message-Id: <20230802130918.1132-1-thunder.leizhen@huaweicloud.com> X-Mailer: git-send-email 2.37.3.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:gCh0CgAHvbCBVcpkDKSVPQ--.59231S4 X-Coremail-Antispam: 1UD129KBjvJXoW7ZFWfXrW8KrWrCr4rXry8Grg_yoW8Gw13pw nxW3sxWr15Jry3CF13ZF1Ikry5Gay8KFsIk3ZxZws5Zw15Zr97uFykJr1IqF9xGF97K3W0 ya1YkF1jkr4DArDanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvYb4IE77IF4wAFF20E14v26ryj6rWUM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6r1S6rWUM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4 vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Ar0_tr1l84ACjcxK6xIIjxv20xvEc7Cj xVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x 0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG 6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFV Cjc4AY6r1j6r4UM4x0Y48IcxkI7VAKI48JM4IIrI8v6xkF7I0E8cxan2IY04v7M4kE6xkI j40Ew7xC0wCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F4 0E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_GFv_Wryl IxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxV AFwI0_Gr0_Cr1lIxAIcVCF04k26cxKx2IYs7xG6rW3Jr0E3s1lIxAIcVC2z280aVAFwI0_ Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVW8Jr0_Cr1UYxBIdaVFxhVjvjDU0xZFpf9x07 UKfO7UUUUU= X-CM-SenderInfo: hwkx0vthuozvpl2kv046kxt4xhlfz01xgou0bp/ X-CFilter-Loop: Reflected X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 620A914003E X-Stat-Signature: enfozzjtz7br57dexbg181kmtpjdrgyk X-Rspam-User: X-HE-Tag: 1690981772-674820 X-HE-Meta: U2FsdGVkX199LOAFu0M2ZYNxN+hn/htX5TbMY77mLPmRZo13BoJjvJQTj0cwDTVscB8jed2tmZrP+rNfbuAYUIAniAaL/K9ES7MOK//bMpFIgWfetsn4gxo1iuMlZcxC47Lb12pIzAnye4z89NEWFS5tLiBfXdjtcvYPoVsGCHzLBA9M7d+l2uT2SWMOd110Q9BqzCbzFo0DbXtkOGK6/w5s06l2n1QJd9W5E7kvOrsOpy0MIEGuEJiL7w+uf4P6CT6cGGgsyVYHvIDGCilLOBDvE/2urvDBpvz8XWCYRnfYrZK2yRP1Rud51vZMg+LUV6qOJhRev8ok3CdYJL7ocYn6SnQa89Nbbv6soEIjiG1aHMFh7/MCJXmjWT+uDGcLYCRAOPzeKh0L0kelV03EUqK859BUdD20Rz56aonZ7i9igQTbLkgnuqUlSCnX4YBQ8DPb+XOHOWJffr3Q2/4Y0SaUgsBONks9yAzD8I7I4/+1nzBH0mfNqGwi2f7PkpSflbIkyrCYZ5M0IF4x7Md+WJjmwNN+I/sZXRykDC7OlKZwLSqVGaqiVMSRYM6drpJiW9K3GxepJuEUe+/IiESb3rKXxjnGn3rDVB6yipEelKigy6i6+h2oMMliRd22c5C5fJ1DaEobWsiX/JlJ1PiCXJqUJj4jUazQTNJJdCYLRjZhPHBXtMdEdWjf+Fejlb0GVRQWpS3uGz9dOddc+3MZMRUBINOcw6I/hWBUTFCqkBmAgAiPkX0GvouTCFgJMuDGB9ZhvSsJaEGxl0XuaD8mVlhOxBGFXcVRtyd6Kjv1sWJJgf7tqAsQtDoLyMu6unburnYVNRzbp8ibiMbfGOjIyPIOqRazGKN9GlzrOdlAJQxJqTmYveaNntBvPcNvFS4YG4wAk4AOaIOK34LNiyVYebtrvt0aH7R54mHIgb0GooWX4M36p5HJwhbXMWjCQTPd9SnjX3nwNS+bh6T/VAN nKYX8YGE scgsbpnDWxojrYT9nE1wRg/SSAitMZZrZM4q8eG4Y+8moupQSkWv1oXAA5YnQji/y9IMpDoD5mI7+QjBAByjuMb4vilemDYtu91tBTVNe63DbO9/cKhP34QqDByvRtoDZghEE7WbHVoT2l9ax3VsN7Yzc76mG86liIKcDR3MuDbMrU8OOHlem70tmmJT3V/eoVn1lNJtgIRQakHtBE7syNcWfwwRF864WSI1ypLoU3iulrMS61j7CqJyurrABwa3AZ/rP2t6PEZrFKyjPXlwHPnusgbRrFNHW/y87S33WuPmVibb7tLBenspsc/J1vRJ+ZCGNxgfc8KF+1Tc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Zhen Lei v3 --> v4: 1. Remove kmem_valid_obj() and convert kmem_dump_obj() to work the same way as vmalloc_dump_obj(). 2. In kernel/rcu/rcu.h -#include +#include v2 --> v3: 1. I made statistics about the source of 'rhp'. kmem_valid_obj() accounts for more than 97.5%, and vmalloc accounts for less than 1%. So change call mem_dump_obj() to call kmem_dump_obj() can meet debugging requirements and avoid the potential deadlock risk of vmalloc_dump_obj(). - mem_dump_obj(rhp); + if (kmem_valid_obj(rhp)) + kmem_dump_obj(rhp); The discussion about vmap_area_lock deadlock in v2: https://lkml.org/lkml/2022/11/11/493 2. Provide static inline empty functions for kmem_valid_obj() and kmem_dump_obj() when CONFIG_PRINTK=n. v1 --> v2: 1. Remove condition "(unsigned long)rhp->func & 0x3", it have problems on x86. 2. Paul E. McKenney helped me update the commit message, thanks. Zhen Lei (2): mm: Remove kmem_valid_obj() rcu: Dump memory object info if callback function is invalid include/linux/slab.h | 5 +++-- kernel/rcu/rcu.h | 7 +++++++ kernel/rcu/srcutiny.c | 1 + kernel/rcu/srcutree.c | 1 + kernel/rcu/tasks.h | 1 + kernel/rcu/tiny.c | 1 + kernel/rcu/tree.c | 1 + mm/slab_common.c | 41 +++++++++++------------------------------ mm/util.c | 4 +--- 9 files changed, 27 insertions(+), 35 deletions(-) -- 2.34.1