linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Kemeng Shi <shikemeng@huaweicloud.com>
To: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	akpm@linux-foundation.org, baolin.wang@linux.alibaba.com,
	mgorman@techsingularity.net, david@redhat.com
Cc: shikemeng@huaweicloud.com
Subject: [PATCH v2 4/8] mm/compaction: correct comment of fast_find_migrateblock in isolate_migratepages
Date: Wed,  2 Aug 2023 17:37:37 +0800	[thread overview]
Message-ID: <20230802093741.2333325-5-shikemeng@huaweicloud.com> (raw)
In-Reply-To: <20230802093741.2333325-1-shikemeng@huaweicloud.com>

After 90ed667c03fe5 ("Revert "Revert "mm/compaction: fix set skip in
fast_find_migrateblock"""), we remove skip set in fast_find_migrateblock.
Correct comment that fast_find_block is used to avoid isolation_suitable
check for pageblock returned from fast_find_migrateblock because
fast_find_migrateblock will mark found pageblock skipped.
Instead, comment that fast_find_block is used to avoid a redundant check
of fast found pageblock which is already checked skip flag inside
fast_find_migrateblock.

Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
---
 mm/compaction.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/compaction.c b/mm/compaction.c
index 984c17a5c8fd..5c9dc4049e8e 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -1966,8 +1966,8 @@ static isolate_migrate_t isolate_migratepages(struct compact_control *cc)
 		block_start_pfn = cc->zone->zone_start_pfn;
 
 	/*
-	 * fast_find_migrateblock marks a pageblock skipped so to avoid
-	 * the isolation_suitable check below, check whether the fast
+	 * fast_find_migrateblock will ignore pageblock skipped, so to avoid
+	 * the isolation_suitable check below again, check whether the fast
 	 * search was successful.
 	 */
 	fast_find_block = low_pfn != cc->migrate_pfn && !cc->fast_search_fail;
-- 
2.30.0



  parent reply	other threads:[~2023-08-02  1:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-02  9:37 [PATCH v2 0/8] Fixes and cleanups to compaction Kemeng Shi
2023-08-02  9:37 ` [PATCH v2 2/8] mm/compaction: correct last_migrated_pfn update in compact_zone Kemeng Shi
2023-08-02 11:20   ` Baolin Wang
2023-08-02  9:37 ` Kemeng Shi [this message]
2023-08-02 11:31   ` [PATCH v2 4/8] mm/compaction: correct comment of fast_find_migrateblock in isolate_migratepages Baolin Wang
2023-08-03  1:50     ` Kemeng Shi
2023-08-02  9:37 ` [PATCH v2 5/8] mm/compaction: correct comment of cached migrate pfn update Kemeng Shi
2023-08-02  9:37 ` [PATCH v2 6/8] mm/compaction: correct comment to complete migration failure Kemeng Shi
2023-08-02  9:37 ` [PATCH v2 8/8] mm/compaction: only set skip flag if cc->no_set_skip_hint is false Kemeng Shi
     [not found] ` <20230802093741.2333325-2-shikemeng@huaweicloud.com>
2023-08-02  8:24   ` [PATCH v2 1/8] mm/compaction: avoid missing last page block in section after skip offline sections David Hildenbrand
2023-08-02 11:10   ` Baolin Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230802093741.2333325-5-shikemeng@huaweicloud.com \
    --to=shikemeng@huaweicloud.com \
    --cc=akpm@linux-foundation.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=david@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@techsingularity.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox