linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Kemeng Shi <shikemeng@huaweicloud.com>
To: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	akpm@linux-foundation.org, baolin.wang@linux.alibaba.com,
	mgorman@techsingularity.net, david@redhat.com
Cc: shikemeng@huaweicloud.com
Subject: [PATCH v2 2/8] mm/compaction: correct last_migrated_pfn update in compact_zone
Date: Wed,  2 Aug 2023 17:37:35 +0800	[thread overview]
Message-ID: <20230802093741.2333325-3-shikemeng@huaweicloud.com> (raw)
In-Reply-To: <20230802093741.2333325-1-shikemeng@huaweicloud.com>

We record start pfn of last isolated page block with last_migrated_pfn. And
then:
1. We check if we mark the page block skip for exclusive access in
isolate_migratepages_block by test if next migrate pfn is still in last
isolated page block. If so, we will set finish_pageblock to do the rescan.
2. We check if a full cc->order block is scanned by test if last scan range
passes the cc->order block boundary. If so, we flush the pages were freed.

We treat cc->migrate_pfn before isolate_migratepages as the start pfn of
last isolated page range. However, we always align migrate_pfn to page block
or move to another page block in fast_find_migrateblock or in linearly scan
forward in isolate_migratepages before do page isolation in
isolate_migratepages_block.

Update last_migrated_pfn with pageblock_start_pfn(cc->migrate_pfn - 1)
after scan to correctly set start pfn of last isolated page range. To
avoid that:
1. Miss a rescan with finish_pageblock set as last_migrate_pfn does not
point to right pageblock and the migrate will not be in pageblock of
last_migrate_pfn as it should be.
2. Wrongly issue flush by test cc->order block boundary with wrong
last_migrate_pfn.

Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
---
 mm/compaction.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/mm/compaction.c b/mm/compaction.c
index a8cea916df9d..ec3a96b7afce 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -2487,7 +2487,8 @@ compact_zone(struct compact_control *cc, struct capture_control *capc)
 			goto check_drain;
 		case ISOLATE_SUCCESS:
 			update_cached = false;
-			last_migrated_pfn = iteration_start_pfn;
+			last_migrated_pfn = max(cc->zone->zone_start_pfn,
+				pageblock_start_pfn(cc->migrate_pfn - 1));
 		}
 
 		err = migrate_pages(&cc->migratepages, compaction_alloc,
-- 
2.30.0



  reply	other threads:[~2023-08-02  1:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-02  9:37 [PATCH v2 0/8] Fixes and cleanups to compaction Kemeng Shi
2023-08-02  9:37 ` Kemeng Shi [this message]
2023-08-02 11:20   ` [PATCH v2 2/8] mm/compaction: correct last_migrated_pfn update in compact_zone Baolin Wang
2023-08-02  9:37 ` [PATCH v2 4/8] mm/compaction: correct comment of fast_find_migrateblock in isolate_migratepages Kemeng Shi
2023-08-02 11:31   ` Baolin Wang
2023-08-03  1:50     ` Kemeng Shi
2023-08-02  9:37 ` [PATCH v2 5/8] mm/compaction: correct comment of cached migrate pfn update Kemeng Shi
2023-08-02  9:37 ` [PATCH v2 6/8] mm/compaction: correct comment to complete migration failure Kemeng Shi
2023-08-02  9:37 ` [PATCH v2 8/8] mm/compaction: only set skip flag if cc->no_set_skip_hint is false Kemeng Shi
     [not found] ` <20230802093741.2333325-2-shikemeng@huaweicloud.com>
2023-08-02  8:24   ` [PATCH v2 1/8] mm/compaction: avoid missing last page block in section after skip offline sections David Hildenbrand
2023-08-02 11:10   ` Baolin Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230802093741.2333325-3-shikemeng@huaweicloud.com \
    --to=shikemeng@huaweicloud.com \
    --cc=akpm@linux-foundation.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=david@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@techsingularity.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox