From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90C3CC001DF for ; Tue, 1 Aug 2023 16:48:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 264E4940028; Tue, 1 Aug 2023 12:48:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 21501940010; Tue, 1 Aug 2023 12:48:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0B585940028; Tue, 1 Aug 2023 12:48:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id F1F02940010 for ; Tue, 1 Aug 2023 12:48:36 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B804940269 for ; Tue, 1 Aug 2023 16:48:36 +0000 (UTC) X-FDA: 81076119432.09.2186888 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf06.hostedemail.com (Postfix) with ESMTP id 2A364183AB7 for ; Tue, 1 Aug 2023 16:06:51 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=vCrg74c7; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf06.hostedemail.com: domain of jpoimboe@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jpoimboe@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690906014; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kxxCPcTsx4r18LCe1+LuClSP4UFHC4cFlCdPTUyFAC0=; b=PSxN7qJX30u3KxgowD02fpT7J3T8ltUba2z1/BX4Jkzp7QEdisP5qUi9fEvLCAgJJwA7oP +S84O7/lArPLYXjuV2Lo/pHgdA2hAlz3b1C8IXEbFn+eU9VHIoekXAyKg1W1u86dIjxi4I uEFpNJds2M7LCfkh5DrZkpq++UFs68w= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=vCrg74c7; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf06.hostedemail.com: domain of jpoimboe@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jpoimboe@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690906014; a=rsa-sha256; cv=none; b=tcc1VmkohZS0WRaNs3apbMm6jQO8BivbWHyv2LMITgl1FRv1o9YBxynl3S8dmy4QvxTOzc sHJyoSzGjtLSqJdXL+Vbu/sAdfs4oUumNEY+PDeYPYrzBCzT4dquTIuk98jMyDq9ttA9C/ AZrEKcaxVGiKRCseF5rkP9ohxZNtsfM= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7894E615ED; Tue, 1 Aug 2023 16:06:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A6E4C433CA; Tue, 1 Aug 2023 16:06:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690906001; bh=BBcCALZSvC2LFhRKcMqxP8rdH2NP0e0xXifPtDkOjO8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vCrg74c7T3Iz63b0Kd6NgZegwDi8uBiXQoM380X5QyO9JQStSJ1vVIYg5lBwm6mGw G5KOxDdFaZ7Piz25JAUwBZD/3gaIndaeQTHekVYLS3qu/aHMvXlBS74Y+fcyy1aTEk ekFWbXUbEVFdALD5l54i41nQHanZW89VH2ePBQMh5U9QZ5HMo56dgNJvyaeiY04Jyl Xf14Hk85AfA++XUjsYmfdUWau4GAJM10KRtVfqcqHC8KYUuOhv/aWt7bPVRl++OF56 Y2ze4WvLuzReIZF+YcVIa7kCLw1OcNEHpfPPSiU8sxiQPotRbp7L6618dtrmlDOhKL o2cGG2hsMdBsQ== Date: Tue, 1 Aug 2023 11:06:36 -0500 From: Josh Poimboeuf To: Peter Zijlstra Cc: Valentin Schneider , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, x86@kernel.org, rcu@vger.kernel.org, linux-kselftest@vger.kernel.org, Steven Rostedt , Masami Hiramatsu , Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Andy Lutomirski , Frederic Weisbecker , "Paul E. McKenney" , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Boqun Feng , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , Jason Baron , Kees Cook , Sami Tolvanen , Ard Biesheuvel , Nicholas Piggin , Juerg Haefliger , Nicolas Saenz Julienne , "Kirill A. Shutemov" , Nadav Amit , Dan Carpenter , Chuang Wang , Yang Jihong , Petr Mladek , "Jason A. Donenfeld" , Song Liu , Julian Pidancet , Tom Lendacky , Dionna Glaze , Thomas =?utf-8?Q?Wei=C3=9Fschuh?= , Juri Lelli , Daniel Bristot de Oliveira , Marcelo Tosatti , Yair Podemsky Subject: Re: [RFC PATCH v2 11/20] objtool: Flesh out warning related to pv_ops[] calls Message-ID: <20230801160636.ko3oc4cwycwejyxy@treble> References: <20230720163056.2564824-1-vschneid@redhat.com> <20230720163056.2564824-12-vschneid@redhat.com> <20230728153334.myvh5sxppvjzd3oz@treble> <20230731213631.pywytiwdqgtgx4ps@treble> <20230731214612.GC51835@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230731214612.GC51835@hirez.programming.kicks-ass.net> X-Rspam-User: X-Stat-Signature: 7tqxkkqhe47yug8hwtr6k1kyqbnyy5rf X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 2A364183AB7 X-HE-Tag: 1690906011-738223 X-HE-Meta: U2FsdGVkX19doCGl++7zSZSJtUUfMo46M8ilAMjE3uv5wJbYPG6B0F8+LJQO5rjunnS5o+7QchPUmISIuFy3Vt2tJX+Ve+DBSikiCJ9IsnjbPQUxUjUy7pDWs3yi8AgP/ZfYYhjgdva0PhFGR4xLlW40VljGQ6AqAuTU2UDq5Ep5S+izLOXwyRZS1tVB8MPtRoacvbZYYldaNkB0aeEZYbtogEY53qh/eP1aBob2NdPbDV+MN44wXUixfEGu4pnKW3O71SkEmOjx4TVQz1C54oP4NzUVGHxuzSmuApk+VS41hLQg8Qif0eB3r3ycbstdWFM0M8GtCNSJXh7A2Ztp9zjVMUOfXAYPArbRoe+LSMfIPIM63d1RMr1u/CiGVGd4+UBINS99i5thqkiNSSLnWuOgdtN3qiNzuM18U4t/ZYfPD0btRyIHJJcRM28vTgHxZzuKvluYzrgVIBWVnsqg12ePoiBb/YPcvCZVdeW6SmC+AfI7rTgdtHpiF4/dquhxc1xC/Ug2nb7K3Dx5yb6u0hxkFYNMQEjGJst9sjACZlFZaXNMJKYg1psKjGI/dyeDXaPIMucKnZrIol0YV/cuCtO/t32xIPhSqEB2NU9YfftKaK6mUv5lGXm5NQNx+Xvdc40JRCJL9v1ayH/eiIXkSiozBIrOvx/K+XHqPHOCT5ilyTRCwceF+qCkr9ZS8F7RTfV1opZ5KacRy2m+xjMRz5j1vXNoPgCohcShNftNGaWyOIe9ePD/O06Yiax6oQ2uAjxOJEZe67fmNMEt7BIfEC3pRiUGokWKv5UmhTGS1HWA+ry6jXD1Nue9k4xj4BwEXAVTBpgIvPAMsQaWxmwymYx3KNQ9Yjhqi1oCBX0jXnYqHXVvVyPhYQMxVbGtHIfQnyj+aCVoDfXrl925RNB46GnvXb7r8husGkHiYiKJD94saM4FXI0p4yWXRS76x8x2SLPEGshwLExXPm20IR6 jF+In1oH GeTfhsfo6f8AjxQMEImC3iImnMJzrgkpL3XoNqjdhFXBp0b9LuZHHmGtoq8PRJbg2uSAWGiWYEOR4vfKbsOSDp+YibFo/raIH/pblsec6NY2Uu3QaaVXFqcZlW5YpfR65XsnKLDiuZjekZ1/rtcGFFs//up8iTxyAUzp/Bl8nSZutDjrvBZsiYWAjI9D2iF+Xq+JcXxJc5ASkwJNG5tmWOI69MrKXuz91CeO+u8v7MVKgREfEyB27W0te816cYdPAHRjjKPGQF/ttJBOhLt8SBvm/lWh0haH6VaNZc4fKc71/V4cEjxocxjJhuR+lhbSC9z32GuISWe114yFWsCjRgM+LkBXCeJKRvkRwW/fYmfAhznvaQI+yhnpAodiOrrG4VDgD0UvZAbNRn8uBp24fEgG+iA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 31, 2023 at 11:46:12PM +0200, Peter Zijlstra wrote: > > Ideally it would only print a single warning for this case, something > > like: > > > > vmlinux.o: warning: objtool: __flush_tlb_all_noinstr+0x4: indirect call to native_flush_tlb_local() leaves .noinstr.text section > > But then what for the case where there are multiple implementations and > more than one isn't noinstr? The warning would be in the loop in pv_call_dest(), so it would potentially print multiple warnings, one for each potential dest. > IIRC that is where these double prints came from. One is the callsite > (always one) and the second is the offending implementation (but there > could be more). It's confusing to warn about the call site and the destination in two separate warnings. That's why I'm proposing combining them into a single warning (which still could end up as multiple warnings if there are multiple affected dests). > > I left out "pv_ops[1]" because it's already long enough :-) > > The index number is useful when also looking at the assembler, which > IIRC is an indexed indirect call. Ok, so something like so? vmlinux.o: warning: objtool: __flush_tlb_all_noinstr+0x4: indirect call to pv_ops[1] (native_flush_tlb_local) leaves .noinstr.text section -- Josh