From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BC7EC04A94 for ; Tue, 1 Aug 2023 19:12:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 961CA2800EF; Tue, 1 Aug 2023 15:12:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 910C92800C8; Tue, 1 Aug 2023 15:12:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8007D2800EF; Tue, 1 Aug 2023 15:12:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7428B2800C8 for ; Tue, 1 Aug 2023 15:12:09 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3A43480591 for ; Tue, 1 Aug 2023 19:12:09 +0000 (UTC) X-FDA: 81076481178.14.941C5C5 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf26.hostedemail.com (Postfix) with ESMTP id 49DDF140007 for ; Tue, 1 Aug 2023 19:12:06 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ZEdvlhTz; spf=pass (imf26.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690917126; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TOGctaEzDECl/yLMwuUy74YcBXQlF5RzFPEXWjzwLOE=; b=sHDxZK3qPLrrQd6tixspORZYKtYXJ+j6N2HeXi+TJNglZ3KGT34oFzv5IK5Xq4wDctJZdz dkihoED9gJFXGGUq/shW3bV2fnuT3+6M+lLEj0E50G4nf0ghdfwZkwL9TDNkC4XkTiqY4Q rl0zVd1DY95tSBGaSrnEVCS4VhDgW5Y= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690917126; a=rsa-sha256; cv=none; b=75c8Kz7r7ZJSqkZsVcydpMvWQPYI9vpCM28yU4i4XKWUIGKnpv+uqdVM1iFnl59mhPZMWO 62Nw4PQywXCSKAouFFDSzXQhf748+wHDlM4zcjvSlRgfXO8SpnWOCwchKzXg9OdsG2uQON eJdTFThW78odRAwCwsQrZ+eFf92/cM4= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ZEdvlhTz; spf=pass (imf26.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 40E50616A0; Tue, 1 Aug 2023 19:12:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 648E4C433C7; Tue, 1 Aug 2023 19:12:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1690917124; bh=4bXA5LiSffF092ekI7PffAzaTl6bqdrbyGn+kgTWpbE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ZEdvlhTzezxEqSfa0ASwLVi0dnTnxkbKdEU2UkKjHfsFUTlLYHL++IN6NTL+wt6xy bDzxreMQo07YDJuakNU+RKRtWd9GaOmcWnM/HsAdz8JTb3I8JesU6O9y4PBfNdN5Es dPUSZe/J7gNzd2X7GnCJGgdhUFdn3XT5yQg2D70c= Date: Tue, 1 Aug 2023 12:12:03 -0700 From: Andrew Morton To: Kemeng Shi Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, baolin.wang@linux.alibaba.com, mgorman@techsingularity.net, willy@infradead.org, david@redhat.com Subject: Re: [PATCH 1/5] mm/compaction: allow blockpfn outside of pageblock for high order buddy page Message-Id: <20230801121203.a58e15d4f290721746340801@linux-foundation.org> In-Reply-To: <20230729174354.2239980-2-shikemeng@huaweicloud.com> References: <20230729174354.2239980-1-shikemeng@huaweicloud.com> <20230729174354.2239980-2-shikemeng@huaweicloud.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: z6zcku9yd5mtu9qm7u54t5fwjiey71dq X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 49DDF140007 X-Rspam-User: X-HE-Tag: 1690917126-870338 X-HE-Meta: U2FsdGVkX19Klo82e11f22uY3Okd4onR1uWYK7TBaDs1M1XHxvV649bD1az840ggWPolyqrv5QUYezWtE5oOb3N1rJocEqXdczn0Go4wHW85SWGna0Z02y21cdPy7nw17xRGNq66ylfGTWdxY2NqRakZkViVwKNJUmR6muJtvfNE8VudMcHJyFMkTlmtTeU4QUz0l1D724F2XCQDmW82Rm5JjrXVR0qbCtGcxgvEjGSchLcUZWRIN0+ygtsX3fkl+tHuZ5y8YuUS/UtK7vGjVYE2zyN8P0bDNBs3JSmhiDZGb61c1hhYKEP8PBnt4Yly1cj5feSPAjFGobERyPjizvt260XfUw2p70gyO811CXatB0RjS4+ZyemTx62sCsePqj3yE3vHZ5M8ggX9oprytW5kry0xzj+FBkUjq0FIMLa1R6PFHVcbxbcSOkUxDnqUrqJuZraWCo1yz1LO2u/JEL/ig77Ov4fPVI+0tSpC/R4xp2+/0noZhP45xnDcMI9f13ASPGtLGwViXsDP8klqscaohAT5mCAW88kYC2X8IJk70JlhUrGKiDFORCEGAgM8oPUM1f2rgx6XODft3lMiLd0fnzjdqWIQexm+4cSPtymXl/ebmImtJ1Vt/IOEe47eP0uoR0HFxZAwB+QW0r2uMTvYJwQM0w0sUXnaii1jO3e5IjJrf77JwLAq6A09qk4MnRRANBwim5amIlgbTx8kPul8FBhowkMIGmUEcPDMkjsL4Q2ow1PMBNFr+7XL7Nngx/mlMJNec+QQyDDxU3mSmPyvw5r8/4Nqbk+eMP5R9ffJG8NnaJWGQlcuP9y4KfbKnYOqOYLkgx7ovNivdIhXZ/4+LWWA3DFW/1nU8zg2HKMzhUZdiZZy3V7BQ526OWlgHaU39iWmDeQsmnXQ3GpxzmfHuvNWjEM4TSPUvNMnnJh2kKxD5NoXch86QRz3Jx0okh8cS1BG8U7x6zT3BZs XgTOzWIY drQhJY8RBHQUACD2Wp+n7nACIhKqr6LK6BK3V/4i8SHNPnNuQKKvf1jkrXrURiYOTnIOCp/YdELPUYPTJmlPmVOhi2cqHpHAh5IXT5F2tjIjMKMqJnRrWvJPsLUJdx76J4f8XHDUvoxGePAYtKxajnqpR7IuvP+LsoMrTbjZXzCBs4+p+5IA/QGZiAIOOp7CE5m3gDIbq4gzqtTZOOu6K0E0o7uYhIRuymfCOrlxPkTrvjcFrpMzbOonfmX8Qi8mIkMbHyDAhjxWTruY5irM9oBBV7Z+BCs3wt4oVCpCqT/X4B9l2hEXhBGP0baQBLRRRnu6asuh2fwRfj1B9G8wSBtY9jn9iMwUuLGpq0W+u2rb8d8JaB7m8jlWkRRrKrmu7hAj+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, 30 Jul 2023 01:43:50 +0800 Kemeng Shi wrote: > Commit 9fcd6d2e052ee ("mm, compaction: skip compound pages by order in > free scanner") skiped compound pages to save iterations and limit blockpfn > to reach outside of page block in case of bogus compound_order. While this > also limit pfnblock outside page block in case a buddy page with order > higher than page block is found. After this, isolate_freepages_range will > fail unexpectedly as it will fail to isolate the page block which was > isolated successfully by high order buddy page in previous page block > and abort the free page isolation. > > Fix this by allow blockpfn outside of pageblock in case of high order > buddy page. > > ... > > @@ -1418,7 +1420,7 @@ fast_isolate_around(struct compact_control *cc, unsigned long pfn) > isolate_freepages_block(cc, &start_pfn, end_pfn, &cc->freepages, 1, false); > > /* Skip this pageblock in the future as it's full or nearly full */ > - if (start_pfn == end_pfn && !cc->no_set_skip_hint) > + if (start_pfn >= end_pfn && !cc->no_set_skip_hint) > set_pageblock_skip(page); > } > This needed alteration for mm-unstable changes: @@ -1441,7 +1443,7 @@ fast_isolate_around(struct compact_contr isolate_freepages_block(cc, &start_pfn, end_pfn, &cc->freepages, 1, false); /* Skip this pageblock in the future as it's full or nearly full */ - if (start_pfn == end_pfn) + if (start_pfn >= end_pfn) set_pageblock_skip(page); return;