From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F8C9C04FE1 for ; Tue, 1 Aug 2023 08:55:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2BA128E000A; Tue, 1 Aug 2023 04:55:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 26A2E8E0002; Tue, 1 Aug 2023 04:55:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 10C888E000A; Tue, 1 Aug 2023 04:55:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id F2CDC8E0002 for ; Tue, 1 Aug 2023 04:55:10 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B53881A0BCD for ; Tue, 1 Aug 2023 08:55:10 +0000 (UTC) X-FDA: 81074926380.25.02AE8A7 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by imf09.hostedemail.com (Postfix) with ESMTP id CD4D7140002 for ; Tue, 1 Aug 2023 08:55:08 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=rivosinc-com.20221208.gappssmtp.com header.s=20221208 header.b=Bpl0+hsz; dmarc=none; spf=pass (imf09.hostedemail.com: domain of alexghiti@rivosinc.com designates 209.85.221.47 as permitted sender) smtp.mailfrom=alexghiti@rivosinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690880108; a=rsa-sha256; cv=none; b=AnqJCU6X+BGKQEpyCtmzeK+Br4gxlJ+f2++D5nF8UxG5mUIvdarPAIKx4WCStkLO9aVBLV tXxSr0ssMjmTQXHCVJumWdJ3s1dItJObT6q/FsfvwqCv8T0KHoguSnDkyrkQArNa0N/W/m dB+UlJT3yfdgnaV7iXPBz28k5Ypf2iI= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=rivosinc-com.20221208.gappssmtp.com header.s=20221208 header.b=Bpl0+hsz; dmarc=none; spf=pass (imf09.hostedemail.com: domain of alexghiti@rivosinc.com designates 209.85.221.47 as permitted sender) smtp.mailfrom=alexghiti@rivosinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690880108; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VJvQhuwass6T7QyQKJFHTMKHPeCPiB8wQ+ZaCt6WMq4=; b=WtbmIS0RZaMl/kQTatnmgXWPjKlf4GB6JOPlvRsE0/wirA2PKkX1xAZNl9iuZnrCjvKwX7 S0ezDdIymB7CpNyEhA64glk8thK+gNyaSliWfRIqnMwSUJ86gwVU+UhNeEelKJjFrASvXF A54FrsRofe3BZZUTUX3Gs8ukHKkhLCQ= Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-317798b359aso4796527f8f.1 for ; Tue, 01 Aug 2023 01:55:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20221208.gappssmtp.com; s=20221208; t=1690880107; x=1691484907; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VJvQhuwass6T7QyQKJFHTMKHPeCPiB8wQ+ZaCt6WMq4=; b=Bpl0+hszwA8UQR0niUcF7oQehlmgEjs5cHo4HxCIX40QXmvTR8LBEK7tQ+cI0LB3ay rxJOT3sKokH5JRnOmREiUvCfxX57njbV54QplHg6i6M4zYzPTGgb5q/+1VpctU4MpRch 2LyVMmWtMmogjAz6kCV0lm+c04Jpvg/Gg9NtpVwOclOafX1Kzkd5tX9nP0yk93e9KsXw ZvlG5WTrZQrtnkYLM60wCSK51DxKXb8RPjLidqJQRRr7d92QPdT10NppoNWWqJeyOPUC Py/mV7zxhLphurocEHr98As//5wdmGubwQw9Noeeewke4b5x/ZM2cUOii4fja8jMV1qz OdPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690880107; x=1691484907; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VJvQhuwass6T7QyQKJFHTMKHPeCPiB8wQ+ZaCt6WMq4=; b=cke7/yBXiYv+ckCP4F4KyzvmDW8Jhl6F/P6raL/8AIcH+niBH5Efdd2SSsvGJbcC4o 7tn2Eq06+QfiLmAk6aY5U+Xn8b26WR0fcz4L3Xjh+VIh8qn9z3nad3d2YOeShVie+c0Q hzk2xzCG/8zRoWMirK3KR4MaCDv/NsA/UEvbgrvfrkC7JcqyDV7STEf1LyTlSGOyPzMU SI5a6JrpUquwXxDJTtaajn7gf0x/rhJWF5+19x/jx8npYdxVgk5IKk54SAu2xSEd2zEY o2swxU7ZL7zaCrMSM/tg70NkCRtW1ohwUSwsH68zcyj55daTluAgo2micMdPypPegzR6 TxMw== X-Gm-Message-State: ABy/qLbMMmt1dtopmLC3xEzQY/z8UkFgEuc+6G1S/YihyV3YuQJn+B8p dTmxH8y1lEjs7CGqvurHhkVNBg== X-Google-Smtp-Source: APBJJlHOJJYLrg+ra70JvNHoDNhW65vTt6zyHcHStm5ugNLuPe77B6588sTpV0o89m8oxwcr4IjNuw== X-Received: by 2002:a5d:4909:0:b0:311:1aee:4e1d with SMTP id x9-20020a5d4909000000b003111aee4e1dmr1817877wrq.33.1690880107294; Tue, 01 Aug 2023 01:55:07 -0700 (PDT) Received: from alex-rivos.ba.rivosinc.com (amontpellier-656-1-456-62.w92-145.abo.wanadoo.fr. [92.145.124.62]) by smtp.gmail.com with ESMTPSA id h18-20020adff192000000b003113ed02080sm15296992wro.95.2023.08.01.01.55.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Aug 2023 01:55:06 -0700 (PDT) From: Alexandre Ghiti To: Will Deacon , "Aneesh Kumar K . V" , Andrew Morton , Nick Piggin , Peter Zijlstra , Mayuresh Chitale , Vincent Chen , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Alexandre Ghiti , Andrew Jones Subject: [PATCH v3 1/4] riscv: Improve flush_tlb() Date: Tue, 1 Aug 2023 10:53:59 +0200 Message-Id: <20230801085402.1168351-2-alexghiti@rivosinc.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230801085402.1168351-1-alexghiti@rivosinc.com> References: <20230801085402.1168351-1-alexghiti@rivosinc.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: CD4D7140002 X-Stat-Signature: bf9t5g9iabfp51bbpab8fcs7qmh39119 X-HE-Tag: 1690880108-179503 X-HE-Meta: U2FsdGVkX1/dc56DFFY7Z4U98rAe6m4OvWFRn5qkdOTVL7/TzqEJ6imZfMUw9Dref7T8UCBc45H7qYVYD+fJxlYjlxdGBz8iQMlpQmcH5mCTry2UnMyevu93yk3XrQdBciq3yJX8DV+diJlYEqmFWlZFMrbjykbrTGweBR/grCUyiX1xONFojmwp4sjac3zRb/yN3c06BXvr1NhLR2skksr+4BgwWX3i3tGTNXrx2AWxvzXk92qxjMDNHn+hu/30t0VdIsenZWNSI6pWyeZIFDRGKRriMX2t4teMEUnkjitq3HNYDJH/YfINaI8CdvuG0oOOYVxP8ZmgJmXoYKujkw9sM1j2q0mbbIsNwy7gtVSqH96s0YCqMzSjPNnJflixLtDpHO1qbV68wjp8sAfBl+044uTSiDSh1Jug5j+KXBzGpmxX9P1Gg3ww2z23UM7zZd4kaHPrA8ZY5WLDNCmv1A8D+4rBBQJplSu0eSBsOg6aMD9S1HUMahgOZhXgXCJz3naP+EzY5TiotfnAaqLhkpSQ18Sn6cDnhKdJug0xLQS0dXTrfvltuKyTmTODX6UIjys5h5wXah2wAt50L5OnBr1nFOMFcgHB42vDxRuuSsQC8PWvRakBVDsh+W2HtuvRO/NEeDJ50GiMOpMXTRgVCRuQFhNKB1y+HTx+gANpNJhJH6AOR40y5O0Cq8qi7KgJ9f2vJxiHNf6jA40GZX4xw1iOH8VknptO/9UgG1vqUxplL8AbISfLgawwM18bCEi1Fwvu/k21q+SF+tcORAqMB1mSweAXZ5L8MX4xqjHf2VWYDhWXo3yUk9fic+WEegKk4Jtfpi0CPUpQzPZo5F0QEgJcj6UllwumUbRF3mtvzBagvyToZ5ZsPvq1TOpxJdbTpo1r8lAq0GxQKeq0TQeQLd5ZOfT/aAgJVgD3gy1xHEEJRDEInTdUypCyhgR4Q4ZIesNMuYVRfFpHFRDaDNz 181aF8b7 9HJECJ4WfPaNzq+qpnx9EU+EZrZWRJ5vqK8CkP4LkBlkFw81gpTssPNhz1i8JvPnX6jkRr9xd2s681CVS+VMLLeJWQsFpPl8nmJ5a2WddFZVINQp+kC5u1ZZV7B9NOMSeS0345+T/i+ehwax0qAi9aYKT+bBMeuJ2irEXdZLkvYndAhumtRuWoH/UCM01m+wwDDKQ4sv3VyXY1oaoMi8i2sNBxSw/Kt+Wk0OsNEtkYnUMYVfbCAWFK3J7GHp55DdAo3a4mUh4GPIrSX774oJ9B1RdmSZa8oJxdPXfYN5JGQUH3QwXhVXXvgyz5ij7nRZu5k6mhEl6ciYLEhZI6en6OYY4bvgdUKYFJn+Nw4K8fftVd9s2VAknRtQtFxCALpDnFQ05572HbrkRBubNZwxJZIlQygIVdGxnC92Z9aHQ/k86NGA2jqpVf+PANaiJX+CC3HzWd5lV2tTfDMCOdoyfiwneURQpPFc4v8p8rPdlje+Q8bp18lDeHpSK9X/eQY43PuIOW8be7R5Tev8nGmDjS96Btl/ykg/KhETlcGQQxXBTXGY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: For now, flush_tlb() simply calls flush_tlb_mm() which results in a flush of the whole TLB. So let's use mmu_gather fields to provide a more fine-grained flush of the TLB. Signed-off-by: Alexandre Ghiti Reviewed-by: Andrew Jones --- arch/riscv/include/asm/tlb.h | 8 +++++++- arch/riscv/include/asm/tlbflush.h | 3 +++ arch/riscv/mm/tlbflush.c | 7 +++++++ 3 files changed, 17 insertions(+), 1 deletion(-) diff --git a/arch/riscv/include/asm/tlb.h b/arch/riscv/include/asm/tlb.h index 120bcf2ed8a8..1eb5682b2af6 100644 --- a/arch/riscv/include/asm/tlb.h +++ b/arch/riscv/include/asm/tlb.h @@ -15,7 +15,13 @@ static void tlb_flush(struct mmu_gather *tlb); static inline void tlb_flush(struct mmu_gather *tlb) { - flush_tlb_mm(tlb->mm); +#ifdef CONFIG_MMU + if (tlb->fullmm || tlb->need_flush_all) + flush_tlb_mm(tlb->mm); + else + flush_tlb_mm_range(tlb->mm, tlb->start, tlb->end, + tlb_get_unmap_size(tlb)); +#endif } #endif /* _ASM_RISCV_TLB_H */ diff --git a/arch/riscv/include/asm/tlbflush.h b/arch/riscv/include/asm/tlbflush.h index a09196f8de68..f5c4fb0ae642 100644 --- a/arch/riscv/include/asm/tlbflush.h +++ b/arch/riscv/include/asm/tlbflush.h @@ -32,6 +32,8 @@ static inline void local_flush_tlb_page(unsigned long addr) #if defined(CONFIG_SMP) && defined(CONFIG_MMU) void flush_tlb_all(void); void flush_tlb_mm(struct mm_struct *mm); +void flush_tlb_mm_range(struct mm_struct *mm, unsigned long start, + unsigned long end, unsigned int page_size); void flush_tlb_page(struct vm_area_struct *vma, unsigned long addr); void flush_tlb_range(struct vm_area_struct *vma, unsigned long start, unsigned long end); @@ -52,6 +54,7 @@ static inline void flush_tlb_range(struct vm_area_struct *vma, } #define flush_tlb_mm(mm) flush_tlb_all() +#define flush_tlb_mm_range(mm, start, end, page_size) flush_tlb_all() #endif /* !CONFIG_SMP || !CONFIG_MMU */ /* Flush a range of kernel pages */ diff --git a/arch/riscv/mm/tlbflush.c b/arch/riscv/mm/tlbflush.c index 77be59aadc73..fa03289853d8 100644 --- a/arch/riscv/mm/tlbflush.c +++ b/arch/riscv/mm/tlbflush.c @@ -132,6 +132,13 @@ void flush_tlb_mm(struct mm_struct *mm) __flush_tlb_range(mm, 0, -1, PAGE_SIZE); } +void flush_tlb_mm_range(struct mm_struct *mm, + unsigned long start, unsigned long end, + unsigned int page_size) +{ + __flush_tlb_range(mm, start, end - start, page_size); +} + void flush_tlb_page(struct vm_area_struct *vma, unsigned long addr) { __flush_tlb_range(vma->vm_mm, addr, PAGE_SIZE, PAGE_SIZE); -- 2.39.2