From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3690C001DC for ; Mon, 31 Jul 2023 16:27:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 91F306B011F; Mon, 31 Jul 2023 12:27:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8CF976B0120; Mon, 31 Jul 2023 12:27:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 798086B0121; Mon, 31 Jul 2023 12:27:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5D5C36B011F for ; Mon, 31 Jul 2023 12:27:11 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4907F809A0 for ; Mon, 31 Jul 2023 16:27:10 +0000 (UTC) X-FDA: 81072436620.14.8C52973 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf21.hostedemail.com (Postfix) with ESMTP id 6C1541C0009 for ; Mon, 31 Jul 2023 16:27:08 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=IQvivOIy; spf=none (imf21.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690820828; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dU0TNTItAAq53ja17hrx8d+tgkyLwTjLd3CGYi7SCVg=; b=64yrTmV/y0f/574lYV3qtN/+jtdWcZgdcCwNI7jRAppGEeKAhupV5YXwpOl2QJnDu6fq/q YwPlkryomJGmgofzppNJ3R8FqA1kMLrUc7BxVXGMC6aoUB+1+VDTxU49Y72fC1oBkhtR6w g80aay5F78T4IVoTVWU08d6pHQ3JxhA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690820828; a=rsa-sha256; cv=none; b=5+D5r/CVSjQZ+2CXroP8OL9+DJBWEF3uKIhvGTywtaxZhn7UoBU1xGKWkv8AWvNR0i6/J2 BMITxL/Cfyro6or5UgDIRrHTD2TpAOZdzRS4WkLd40x39ugOQzaltTJraIgQpaxTPnalVq nH0B9hdb1W+JRsSmWznPTx9V+a8pdV8= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=IQvivOIy; spf=none (imf21.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=dU0TNTItAAq53ja17hrx8d+tgkyLwTjLd3CGYi7SCVg=; b=IQvivOIyFLJ0rRqcEK/y/ew/Qa GTzQ+Wv3uaAkCg2eE6zbfNI/8TY7jYUtH8gwCBX2uLNYg1qYRgLtpf50OMX2f8R4PiMNheZTqaCMj gsDnzbt6iLJ2ogPfXiy5B1yGJkpymooMhJLnbG1gOd9tnpO2ua60Bl8DFJ2nTGFo1jSDYU7EFAj6Z qdcX8PhHtdN23Ph3fWI6pmQHf1lPPLdCk3F+8L8puTRHvzPNvH8Od98TqUEFlzVtPnejq2LoTBfEA lI6xJpAV+tsOTRcnMbpLBFscQsxkrtJbeoPusjq4HlTexCFBs2auGsrQK1GkQ7QcaTFzOB70AuV+d 6z58ms9A==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qQVjM-00Ct4d-0o; Mon, 31 Jul 2023 16:26:48 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id CDC5D300134; Mon, 31 Jul 2023 18:26:46 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id BEB55203C783E; Mon, 31 Jul 2023 18:26:46 +0200 (CEST) Date: Mon, 31 Jul 2023 18:26:46 +0200 From: Peter Zijlstra To: Thomas Gleixner Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org, mingo@redhat.com, dvhart@infradead.org, dave@stgolabs.net, andrealmeid@igalia.com, Andrew Morton , urezki@gmail.com, hch@infradead.org, lstoakes@gmail.com, Arnd Bergmann , linux-api@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, malteskarupke@web.de Subject: Re: [PATCH v1 03/14] futex: Flag conversion Message-ID: <20230731162646.GO29590@hirez.programming.kicks-ass.net> References: <20230721102237.268073801@infradead.org> <20230721105743.887106899@infradead.org> <87bkfsnja3.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87bkfsnja3.ffs@tglx> X-Stat-Signature: isjfc6qahdn8z4zhkfo95azjfe1z5f6z X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 6C1541C0009 X-Rspam-User: X-HE-Tag: 1690820828-271996 X-HE-Meta: U2FsdGVkX1//6pnXDS8Cc8tt5LZSMWiOCg3ODP0LF3B1UMsI1MFQhnmoeF2zgHWtmE9uvnVWTrN+2KC3z9UJetAhSmVVcxwS2PF8+dGqwzfAT0m4RU1d0kvE3KCkaPnd4NfRJ4ANlC3zzr/8nb+j4IBJ/t4ZNFajyuVVd3hOERRRVLrdl1v3FP7BdtjpQyARZvi0F7FA/quiclGN61V9Mni9ISJSmmSpx2jnLixzQFaMw3oYH4Qny2W5PyT28tQK6wddYVs/KSaEhi3mxv3kL/qqjws5oldp/sm0rafDjhUFiAfj6z6m5TEA+IYTbXllkKCjPXE+pMCuOVXoJ3AaqZRAMJg8Dt49zmF/9EYLaqUA8q0y6N+mwW/s9MhTSEp6z4yKOTZKKkhAq0aRAsT8tBEqpboD9MNt1hEIGZ2g3QojQbrePspkAyEBaY2uCco04jUnrNOvHXmjONqMlg5kGfcaZzP3bCFAvIO6sE7CXG/7W8iaSpgapa+fL9A4Fo3kWSZUBcNOFHoQNHx80uONI8PK+L4wAVePmDPW81Zqx0/U/Z+1TGGfSiDP6uF92Wd81SLp+twF5QNWVFYcZyA1sZRV/g8ANo4BpR7hW4oYJI80iF+FYJY6RkhYMVq2wyfMs57uTnqayTl+pEUgsJ5lareAbP4nXs+0hVU/Ha+1tpYVVefrB53GLH7zPkQbd7aDPEmF/30rHRGGf95ri3e59rm6KFP8j6zgtOqh9yANannRt/R0vlk1LHwSc4Mg9AcIR2Dc+hdSN4tHRSO0cmLTCuxNB20MhKBQ4BRGWFUgm32d8yw5Pw+2IRosJe05XtPFsnv9BQrhQ5P6uNdqNGv1TrZztBehK7nxJpouL5YyEQJ4bGDVRJEjo/9zbRuE8bd9J4Wx2Qo1SZ6gE4yqkJCJeL5lVM+2qyRNpU2zCrArnlwbuo433lpWxkZd5BuDyLZNuqjKnOtrGRBmCswaAWG 8ulo9ata m28LHuXJOzej1rPaw1z2BHhKyKzaIp2CcZIutG+BblfC09/MO4W3LzxpcgUaO2XtcdVHoca2SOKhZ80NSQedmzeTsBZaI8/nmOcK5/+WJowjoBMoOoLhT+YbJI/L5J1wcimv1yeAfShMsWao= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 31, 2023 at 06:21:56PM +0200, Thomas Gleixner wrote: > On Fri, Jul 21 2023 at 12:22, Peter Zijlstra wrote: > > + > > +static inline bool futex_flags_valid(unsigned int flags) > > +{ > > + /* Only 64bit futexes for 64bit code */ > > + if (!IS_ENABLED(CONFIG_64BIT) || in_compat_syscall()) { > > + if ((flags & FLAGS_SIZE_MASK) == FLAGS_SIZE_64) > > + return false; > > + } > > + > > + /* Only 32bit futexes are implemented -- for now */ > > + if ((flags & FLAGS_SIZE_MASK) != FLAGS_SIZE_32) > > + return false; > > + > > + return true; > > +} > > + > > +static inline unsigned int futex_size(unsigned int flags) > > +{ > > + unsigned int size = flags & FLAGS_SIZE_MASK; > > + return 1 << size; /* {0,1,2,3} -> {1,2,4,8} */ > > Lacks a new line and the comment is both misplaced and kinda obvious, no? Yeah, it was a more complicated transform at some point, I'll fix.