From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E726C41513 for ; Mon, 31 Jul 2023 16:26:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 156A36B011D; Mon, 31 Jul 2023 12:26:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1076C6B011E; Mon, 31 Jul 2023 12:26:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F37E728006E; Mon, 31 Jul 2023 12:26:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E0E116B011D for ; Mon, 31 Jul 2023 12:26:02 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A5A1F1601DA for ; Mon, 31 Jul 2023 16:26:02 +0000 (UTC) X-FDA: 81072433764.10.5213CA8 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf06.hostedemail.com (Postfix) with ESMTP id 217B2180014 for ; Mon, 31 Jul 2023 16:25:59 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=niqvBOYZ; spf=none (imf06.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690820760; a=rsa-sha256; cv=none; b=2IFtTmJ8yN+M/nmCXo2ycXqPKm3rbcKTSz5v/bLu5kuQKukdRc9vwnlE90aOzg1CWH4b2W esYlb7JQYcGVhFbdAtmkanNz2qHeVtccezhcw2CAoQyXVT349PycFo6m0NdtzeZ6EIG0sw Pz8fDMbTP5uOhie2daom88jc15M+U18= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=niqvBOYZ; spf=none (imf06.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690820760; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MjS3rbs97pcRqmVTM4Ntvkn5tG97L9HJKbZqV2SijdA=; b=tDdi9Irf4k7F+Cdxcn9CRK4UrR2nKyTrYKWluZ9dZR4Ic0vxEf1fG0r8BS2U1+ZkqEmBiG S51wjMP1AFybxzZXTfHZC/n9lWTpTKd/iZLDS0B/6sVOhXxcEY07cXath6WByp70AYfomw 1og4XRVUQN2V3tk/P2V8fN+hdgDcwSk= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=MjS3rbs97pcRqmVTM4Ntvkn5tG97L9HJKbZqV2SijdA=; b=niqvBOYZHOXE+q73f6SrdABTZ4 fZF5s6RZfVGQvPiG3mFm10Bo/YzgdCgZeT9nAsXkmbQlEUpJ81BzQ/C2Rae2mo3y/ax5ubkKzVnPH FxTf+IGC6MO3OJiff45Jr/SBmTsSLXu1TL/RrC+TAU1nmw7Hmo7ihKY//N7dvQsGnFdyxrIT3sKhN XDe41iSWEvv4P2xFIYl1Xj4kZM06WleapB9notMo/ccxEWK4GssPIItQdDhvgd9zfFsYBroTMZzi5 7tRbyMK6qIsNlQST+Qf5fQDGFFUbZ5CrzKSYULOKg04mTpkAaLqozLTjX+2+u+3Ck7xs1ydQM5sC6 UX9EwdMw==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1qQViP-002cvL-7X; Mon, 31 Jul 2023 16:25:49 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 8404C300134; Mon, 31 Jul 2023 18:25:48 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 4D19F203C783E; Mon, 31 Jul 2023 18:25:48 +0200 (CEST) Date: Mon, 31 Jul 2023 18:25:48 +0200 From: Peter Zijlstra To: Thomas Gleixner Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org, mingo@redhat.com, dvhart@infradead.org, dave@stgolabs.net, andrealmeid@igalia.com, Andrew Morton , urezki@gmail.com, hch@infradead.org, lstoakes@gmail.com, Arnd Bergmann , linux-api@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, malteskarupke@web.de Subject: Re: [PATCH v1 02/14] futex: Extend the FUTEX2 flags Message-ID: <20230731162548.GN29590@hirez.programming.kicks-ass.net> References: <20230721102237.268073801@infradead.org> <20230721105743.819362688@infradead.org> <87edkonjrk.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87edkonjrk.ffs@tglx> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 217B2180014 X-Stat-Signature: 7ckyzwzm86tjrwsf9mia1p16owqdbuwc X-Rspam-User: X-HE-Tag: 1690820759-289671 X-HE-Meta: U2FsdGVkX19K2kL4SUckiNT2thrq82v4RXZfKBAWGW3PPpBtFRLKDQIcLYh0nCjvL/GzVaZfRI5jAsMGbGqu3ZhrO5edHbYe0GFLdpgmpbx7WTt4+2Vp7eJUbRrWcJqveXQuKDhnRNCxOs6K+SelVZJnK6qIuYKUaNQ4di+QyplTfxwlhajEqIQjCiafTWXRea/ET8/XCfoac49jaaTXrbN/ZCP24estL/TgK6zgDMnH6T5Mf7InNqqVBgi3ZomMpQhcjvfPLKz7YLQLJysxIH4xZNjHyTc7skz0N3x9UQSKRX02SMlP5/FRpi2G4yQFWg/ZX/HzVTmnZbocfpTRI1p3PGF5btxULwmhALj2i86ZjY2+wwEfHW8hKseuRyt9GIWtbS1uYRFo9OXHa82d1yJ55Sg3V8xxi9n2DOtkYYGvwJveryWno5YHnqkfSQAn30XeCyJN5SdaVxo+PcyR3+0RxDCBXwabbc26te6VOdsE4dzXvMhv4wsckla7ncSaBcCm+NzHlZjNdsy/+N2479FXIcKV9Jx2DJUAAPT+rBDwo4UEsRlVpAdX11/RTOt4kMWPFNdGyvBwba4TPr1MdB1Dk6N5xIRuxtuLcY7XiS8G5rtAacan9JrzU1q+nNJ2DmG4amWyx8K0WYMLxRSXkowRD5IBfmMcT3uz8fI5QaGiEb+zSF2gznS+5q0hWFy2PN5nLijzi9esGSd9GmpYxm5J23djAYQ3wxrl63iP9rvBlQlOM8zOb+D9zTaLNn5TkuLHwcSwMlRQsbKTXprUDIbR+WVfk9E2Jy121HCy6TTQXQv444yfBzQmuLWfkfX3+5Vt4+VLlBDy3yRnszA966Bul8IPbAPWsf61SfkRaXEi7iPEutm9FCzoCT50K63eoZJfJJI+TNCS9AMNKiqAphYwj1ZvfAbDpIm6ORg+l1CHTpAdP85bBDDVzQTeY2/tJxgp2lv7fojExZ/CF81 TPLqHkSG bxu5ciV67CWqCHtcc5OdZzA9Dz6xcmSRhG4/6ctkWMlWnEqZCxZ/qa52eUjvbFFpjSuiKRVdLYByc/ouH2IL4aV6b0dIV0RE/9Fwg7obh1NCyoYF6BxbLx+bp7KxKMu7LHCMdc4J7HtUI6JU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 31, 2023 at 06:11:27PM +0200, Thomas Gleixner wrote: > On Fri, Jul 21 2023 at 12:22, Peter Zijlstra wrote: > > +#define FUTEX2_8 0x00 > > +#define FUTEX2_16 0x01 > > #define FUTEX2_32 0x02 > > - /* 0x04 */ > > +#define FUTEX2_64 0x03 > > +#define FUTEX2_NUMA 0x04 > > /* 0x08 */ > > /* 0x10 */ > > /* 0x20 */ > > --- a/kernel/futex/syscalls.c > > +++ b/kernel/futex/syscalls.c > > @@ -183,7 +183,7 @@ SYSCALL_DEFINE6(futex, u32 __user *, uad > > return do_futex(uaddr, op, val, tp, uaddr2, (unsigned long)utime, val3); > > } > > > > -#define FUTEX2_MASK (FUTEX2_32 | FUTEX2_PRIVATE) > > +#define FUTEX2_MASK (FUTEX2_64 | FUTEX2_PRIVATE) > > > > /** > > * futex_parse_waitv - Parse a waitv array from userspace > > @@ -207,7 +207,12 @@ static int futex_parse_waitv(struct fute > > if ((aux.flags & ~FUTEX2_MASK) || aux.__reserved) > > return -EINVAL; > > With the above aux.flags with FUTEX2_32 set will result in -EINVAL. I > don't think that's intentional. FUTEX2_8 0 FUTEX2_16 1 FUTEX2_32 2 FUTEX2_64 3 Therefore FUTEX2_64, when used as a mask, includes then all. Arnd suggested adding FUTEX2_SIZE_MASK or something. And I initially had something like that, but pulled it for not wanting to pullute the uabi. Can easily add back.