From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A178AC001E0 for ; Mon, 31 Jul 2023 18:17:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 09934280095; Mon, 31 Jul 2023 14:17:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 047D528007A; Mon, 31 Jul 2023 14:17:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E7879280095; Mon, 31 Jul 2023 14:17:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D917028007A for ; Mon, 31 Jul 2023 14:17:44 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 9B46AC0B77 for ; Mon, 31 Jul 2023 18:17:44 +0000 (UTC) X-FDA: 81072715248.04.80C7655 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf05.hostedemail.com (Postfix) with ESMTP id AA10B100011 for ; Mon, 31 Jul 2023 18:17:42 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of "SRS0=e2oU=DR=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=e2oU=DR=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690827462; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AI5ICh+KtDYiJ7owvwGxG8K23l39lKZHepcOY1Fhoa0=; b=Wl3y4gDX77UP6P9KoEzOxxG/cjdo7pMQgFRPWh25888iCacslvyC9hWyzd+MAtVsKX+v1p JvCCJuaWaTHzEmn5c6hIXkG34suRtyperRf6Rd8tVkgQRyj9Bbdwt05NwsL/9P4yYFijUJ NAqU3tG+IbMdoifqRX5JJsvVT4Yq5Cg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690827462; a=rsa-sha256; cv=none; b=QHfg243aovH8MqNeVQP+zPjzkC0ARasMGvShAlY5KupECa5ZgYUJH6reKuEZipugypH6SL DvNizdPGuDSj/uOupOdO59isFc43DYsDTWPRJnf3NXKAZS1R4VVSgeSxIGSiCJQgGkq7tb muSxnHra7gSW06TvgUgynWFzlU91ahI= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of "SRS0=e2oU=DR=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=e2oU=DR=goodmis.org=rostedt@kernel.org"; dmarc=none Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 637D861269; Mon, 31 Jul 2023 18:17:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 51B5FC433C7; Mon, 31 Jul 2023 18:16:55 +0000 (UTC) Date: Mon, 31 Jul 2023 14:16:26 -0400 From: Steven Rostedt To: Dan Carpenter Cc: Valentin Schneider , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, x86@kernel.org, rcu@vger.kernel.org, linux-kselftest@vger.kernel.org, Masami Hiramatsu , Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Andy Lutomirski , Peter Zijlstra , Frederic Weisbecker , "Paul E. McKenney" , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Boqun Feng , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , Josh Poimboeuf , Jason Baron , Kees Cook , Sami Tolvanen , Ard Biesheuvel , Nicholas Piggin , Juerg Haefliger , Nicolas Saenz Julienne , "Kirill A. Shutemov" , Nadav Amit , Dan Carpenter , Chuang Wang , Yang Jihong , Petr Mladek , "Jason A. Donenfeld" , Song Liu , Julian Pidancet , Tom Lendacky , Dionna Glaze , Thomas =?UTF-8?B?V2Vpw59zY2h1aA==?= , Juri Lelli , Daniel Bristot de Oliveira , Marcelo Tosatti , Yair Podemsky Subject: Re: [RFC PATCH v2 06/20] tracing/filters: Optimise scalar vs cpumask filtering when the user mask is a single CPU Message-ID: <20230731141626.1b180ab1@gandalf.local.home> In-Reply-To: References: <20230720163056.2564824-1-vschneid@redhat.com> <20230720163056.2564824-7-vschneid@redhat.com> <20230729155547.35719a1f@rorschach.local.home> <04f20e58-6b24-4f44-94e2-0d12324a30e4@kadam.mountain> <20230731115453.395d20c6@gandalf.local.home> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: AA10B100011 X-Rspam-User: X-Stat-Signature: rme76a668drqofb6ojxfjpq8qhnrkj4e X-Rspamd-Server: rspam03 X-HE-Tag: 1690827462-136442 X-HE-Meta: U2FsdGVkX18pUeeYGG0rQrefbxTrZt7ii9LIr2oezFFP/MNOdW97dTD+FKf/5yYXHUAzrGW5f9wcCL0PlVWEvqu7LrrCZJaz42tDfURYrZkQHWPM/EZEKLqOsWDkIn3jaiJexnLgAaOHKF0BIB/TvExWSGzkOyKAXppusnzH4edTW2SB+HRVT9nI8apJn8EjdpXKpAM8N4oHcmt3YG9s5i+bRK+Oj3sFo2fzzJ7VD0+Vqi1ogZsFKE9VSbBn2pOnSiYYSYFH3sxFkbGDXydGiAZ6oHTKkNIKmGhzTtoxh++E3f268ma7OJw7EXnjoC4RxFa4TZpDjFKjZihBljhYbAQBjUg4bnBao7Mq7PWOqgD1wHAiOLp5EnkZebQIEQuJu7CqJHSbNjOTJBwL11niwY/Tp6ucfj9i8fgDO2swgGcwDIt+H6pTlJPouPsi05yDh2uBHddR5Ip1oM40/2BC/b1cxEKgcnHTNH544Z7uvxnnixlKAU9T29ZLbLOLsK8kikGadCvLRwPNCp5hpj478AA1pyqly1caXILWlRcrKMtxewRmRH6GRu2JeIfcZiQi99G6Vi3OFPMPAtc4oYO1rYa8GPuRniE4ogKSEgbilE4PLSNQt8WGQVwhzsXlRqy9LqOvY8mtvFzZspNJyPq/CQQdkYVukPVJTDl07y4z03cvByRexSf6Vbf66C5ekCfmq7pjdohvEZ38DTB4V7yhvSCOqJWNk+Fuw4XadQT35uNYlgEGaPQ8P0nOrzYrU3nOORnoOo1oXoSG+0UAGWCZjwaq7wQoLrtTeTFTozUuReNlSUjVqwTGmhuGc2X5Bf1+MQJGSwORHITZYglPsv1NqgjgxEt6SwzAQUwMkxQaGc6TUsfOKX1RLKrZ6zC7biOiVC063MrTuH6HrHpyb0dbEOWL3IJsw4++iie/07yQTrsR2g3yXeuQhxO3hcBi18OOf8qDJBKFhlbMlaga8bH R9m7Tr2C g9CtxBaD4kRzTvT+fKx0iw1iEZN8zx10gB3by8MXATHuZXOG/RSiSSPu+kQtpT6X31UQYWiuK9xoEO9yz7O/lxYK3y5Zx+PWN5cU+DfN7yFb3gzOGuXPYK8BXA8kPvOIlJbYmd0r1HtLVQvY6IRDVL1Sv3EMIEFZ8ZBBFhKyoTejcTTekdg6VyNn2sAdSvrF45GCFHPupOmPJC+hYfselLCxhUscZdn0LW502cGoXrP1CEmGFQsiLt+/wD20/oBKhZP+oDZ6NcmZGqiNS/Y4XC17e1CTX6dwlpy/1LKCClGN7J+0UrgyBVrWmh8sBGkxsSNXSIPoquk1tp0H7QRHtRbuXhPreKv4mQNPCvf/NePg/Dh8hIHcssxhXxstQM5SzKtgS46dGmdlL6vR8nGGmzXyuNqUE083+qQD5l4OrAXYbieEio4lxHAVPx1p+kt2F76BN921s42Zt7y0QG7DMriSbae0JDe0uLqyg34unoi2vYfng/vHED0PgBFFESaerM2pmVay1fQNpcgVNrMK9GfO82NLtRAOmAwmaR9cVxDRF4Xs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 31 Jul 2023 19:03:04 +0300 Dan Carpenter wrote: > > > > Nit, the above can be written as: > > > > > > > > pred->op = pret->op != OP_BAND ? : OP_EQ; > > > > > > > > > > Heh. Those are not equivalent. The right way to write this is: > > > > You mean because of my typo? > > No, I hadn't seen the s/pred/pret/ typo. Your code does: > > if (pred->op != OP_BAND) > pred->op = true; > else > pred->op OP_EQ; Ah, for some reason I was thinking the ? : just was just a nop, but I guess it is to assign the cond value :-/ But of course every place I've done that, it was the condition value I wanted, which was the same as the value being assigned. Thanks, -- Steve