From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAA8EC001DE for ; Mon, 31 Jul 2023 15:55:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 24FF1280023; Mon, 31 Jul 2023 11:55:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D9A86B00D4; Mon, 31 Jul 2023 11:55:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 05428280023; Mon, 31 Jul 2023 11:55:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id EB61F6B00D3 for ; Mon, 31 Jul 2023 11:55:05 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A4699A0119 for ; Mon, 31 Jul 2023 15:55:05 +0000 (UTC) X-FDA: 81072355770.20.66BFB3B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf03.hostedemail.com (Postfix) with ESMTP id B312320002 for ; Mon, 31 Jul 2023 15:55:03 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of "SRS0=e2oU=DR=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=e2oU=DR=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690818903; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K/wUrF6c5zWmuZIjPo03/SJU0DsfRfBL5ZcrdRWrJNo=; b=K/w3yPExnpjUnYQ2Weym2BRf8q8kBwebfEkANKwJRWzurSJw/+aq6zPPaeNfvwJaB38Y3s dccJwfISrBB3FXv+Zeq88bfjWuRy9nJeOOoxGAwdwLth24U4shP1jrV8fJkd349AzgOfL7 BgGEwzmiXomMMmI3eTXNyTQnM0aiSIw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690818903; a=rsa-sha256; cv=none; b=iGYf7muzo19q5k/HBMbd0/Pc/c4kgEmr1TbNVq5We9Te+stKE44z4MljYQXgPW97cB9QGP N8jtsKWhvSIWAqZMNqXe/0ebxnvo746b+GyzwDW31pTlPLnu5RlPlc/3zyPxd1SlBzPZDf LBEJ6/vJXe8C2vcYvAQNpS7R4cFcz0Y= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of "SRS0=e2oU=DR=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=e2oU=DR=goodmis.org=rostedt@kernel.org"; dmarc=none Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8ACCD611CA; Mon, 31 Jul 2023 15:55:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 494BDC433C7; Mon, 31 Jul 2023 15:54:55 +0000 (UTC) Date: Mon, 31 Jul 2023 11:54:53 -0400 From: Steven Rostedt To: Dan Carpenter Cc: Valentin Schneider , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, x86@kernel.org, rcu@vger.kernel.org, linux-kselftest@vger.kernel.org, Masami Hiramatsu , Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Andy Lutomirski , Peter Zijlstra , Frederic Weisbecker , "Paul E. McKenney" , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Boqun Feng , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , Josh Poimboeuf , Jason Baron , Kees Cook , Sami Tolvanen , Ard Biesheuvel , Nicholas Piggin , Juerg Haefliger , Nicolas Saenz Julienne , "Kirill A. Shutemov" , Nadav Amit , Dan Carpenter , Chuang Wang , Yang Jihong , Petr Mladek , "Jason A. Donenfeld" , Song Liu , Julian Pidancet , Tom Lendacky , Dionna Glaze , Thomas =?UTF-8?B?V2Vpw59zY2h1aA==?= , Juri Lelli , Daniel Bristot de Oliveira , Marcelo Tosatti , Yair Podemsky Subject: Re: [RFC PATCH v2 06/20] tracing/filters: Optimise scalar vs cpumask filtering when the user mask is a single CPU Message-ID: <20230731115453.395d20c6@gandalf.local.home> In-Reply-To: <04f20e58-6b24-4f44-94e2-0d12324a30e4@kadam.mountain> References: <20230720163056.2564824-1-vschneid@redhat.com> <20230720163056.2564824-7-vschneid@redhat.com> <20230729155547.35719a1f@rorschach.local.home> <04f20e58-6b24-4f44-94e2-0d12324a30e4@kadam.mountain> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: B312320002 X-Rspam-User: X-Stat-Signature: nt47worersyowqiykzx3x691gtc9j3rf X-Rspamd-Server: rspam03 X-HE-Tag: 1690818903-51363 X-HE-Meta: U2FsdGVkX1+I/6odn2aari2Ah9TP7VTxG6a/nFjx0VbTvlUU6pjZ+PRU820JKBRsz9+zZkQpIwDrXSudsCktDuQES+qiqVhr2PEKJh/K3L5Fit72d7oIJU6YmspntYUZaD1jy7hhASECNLlOEwGIhjuXqevgjoC3EZRxUOzOm6jg6MvVE9AXGEiUYhsFbQEPoVzNYWFRbbRwJeXrK9KfarQVdQfyfIJ0fl1t8ebi8yJ7dDaaYWK5uRFTT66gIwpwFGl2+51q6u5316gmgplLRB1cUz0pO2MCoFGd7CHspfO0FrtasWW8hlcaetblXH07DNxD6p73b9vQd9docP61FYwUF4EDIvBT9YuublvI/IZol7AxvouWSH3GhOKXLHW8UK1qKQN7VkIFffzjB/N829NZ1MogpIgTKF2XX3aGngYoRxKiPfwpIk8vXi/NrpZk6EQWXe/YRTezEyT6I6QW8WoYLBA1NOojel6/RlsvC9vqzlfVyhRdjJN7bhsJeGvdJ02z5HMWQWPPoOhqSBkbyL+AcgtggCTT/2qwlXjqu5W9zWfbJ2eKa8//9EYt8rHYqe7xUvIjOdqTC0F6fz7dBQsm5Ymn9CKgcszHTTy4o9rcWvQ5H1DbH55sSj+5u4A8BfveRrfdgRMs3LxyzowCsdAwW5nU9n+PMCBKaRVoCGmDf24emnWoWkI85c8OT6K7DFJJDKCoQyWosx5gHk2wo9LIuWWqq0R0iiHzont4QdZsog9lsRTGgv3Kr4Xm7zcFS4oaRUaRa9ZJJvE8K69rBtFfPSI6WK+BBGx0MMHZrReZcN/WSYM4bSam4623qV8blU/16zMuMjE0LbDLBrULiBm+XSR+diVfIoT8SYpIW1UDv5X3yl5QZ+/9Oe7mSoEORypXch8/IX/C2Vqoj8QAdocHUIdNhTPrK3QfFHV2CCwbWUnhdb4jXlMnXZz0mxR09RZMCm0Uq611WdeUm76 IcanGH1q tCg03hXjZqLrn3yIWnSNdUQB++j7fgBhDNVlZvRWwA0foQgvWWHaU5zh5mApPiKmrDMkwnU6uxB7i15VlKu4k6KpSkWLDGup75Mj1mp9cDduj88/XQ9bxgYYxaJ96K7Opw3FaxJYhH1lnnWaQgsDsBWaE+EnyNy/LIycc9tRS6qWYLA6B9sRc0akaprY4tbnTq5rVfS5zaBnQ747E0D0X2QCPEOt/okHYJc0MG4mCWhydvNxeS1cd8OW+/6yDpUGUHhBkofCfcYf7P1hSVN08CVaBUDHzYv2SxGkc94CCriP+t+zq9XmMg8DKmeyBxfh8GqBO5HDTIW5IZ+9BFvRR5HU4OM87Y5vPFR+6XpNhP0B48XB3ti8D+1fIygcVqrZ//fZqVENn7meu0Cnnr7Mucsu6d4rWqHumZiNhvs6RTSD1Su/93VmUp5R7IpXYLRh7VjRpoH2XNVaGeNibbkwrBzivjMkcIhIn1HUc+2GOKV7CzMjBbwXyORAFEmHzJfjO6uDhDTlUbXYcLBTEMUrZausIT+/HCjletffR9PotxsFNQig= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 31 Jul 2023 15:07:52 +0300 Dan Carpenter wrote: > On Sat, Jul 29, 2023 at 03:55:47PM -0400, Steven Rostedt wrote: > > > @@ -1761,6 +1761,11 @@ static int parse_pred(const char *str, void *data, > > > FILTER_PRED_FN_CPUMASK; > > > } else if (field->filter_type == FILTER_CPU) { > > > pred->fn_num = FILTER_PRED_FN_CPU_CPUMASK; > > > + } else if (single) { > > > + pred->op = pred->op == OP_BAND ? OP_EQ : pred->op; > > > > Nit, the above can be written as: > > > > pred->op = pret->op != OP_BAND ? : OP_EQ; > > > > Heh. Those are not equivalent. The right way to write this is: You mean because of my typo? > > if (pred->op == OP_BAND) > pred->op = OP_EQ; But sure, I'm fine with that, and it's probably more readable too. -- Steve