From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CAF8C001E0 for ; Mon, 31 Jul 2023 15:48:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8D9BF28006B; Mon, 31 Jul 2023 11:48:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B132280023; Mon, 31 Jul 2023 11:48:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A06F28006B; Mon, 31 Jul 2023 11:48:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6C993280023 for ; Mon, 31 Jul 2023 11:48:16 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 37317A0325 for ; Mon, 31 Jul 2023 15:48:16 +0000 (UTC) X-FDA: 81072338592.21.D27DF5D Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf04.hostedemail.com (Postfix) with ESMTP id 3B1194001C for ; Mon, 31 Jul 2023 15:48:13 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf04.hostedemail.com: domain of "SRS0=e2oU=DR=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=e2oU=DR=goodmis.org=rostedt@kernel.org" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690818494; a=rsa-sha256; cv=none; b=4tNerffiH9KHcoo7vLBzkEQego6HLdnVg3FnYuoKkNhtNz6MBD97PG9xsy2kN/tGMcjL1Y lrIpY4yvyXKf2npU/oAsjtw29jMCH2bOEh2vkZhINC0dAwhnHTkzeCn2K69e5XIDc8oMh1 QY6LSKI2YrwSjwwr5mT4RW/ivKhKrXM= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf04.hostedemail.com: domain of "SRS0=e2oU=DR=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=e2oU=DR=goodmis.org=rostedt@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690818494; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vhjOuHE5ikgf/US/XO9plciU49/CLHuHMPFchskh4k8=; b=TGXcOIOJBAYfdgL/Tm3cnkQd6uhNQaCIEtRC/e6i7xP+5Ww+G22I8y9GzYhKqOtb1A3nAE s4rVMqrH6NhHGtNvrIMgGTW5nbVQpHahccZS+TwfvYOClNcQpGQhdwY+0RX4S9UySO4aW8 vNWBxEVHlfq6gmUzRQniqKwAaa0zF0I= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 19701611B8; Mon, 31 Jul 2023 15:48:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AAAFBC433C8; Mon, 31 Jul 2023 15:48:05 +0000 (UTC) Date: Mon, 31 Jul 2023 11:48:03 -0400 From: Steven Rostedt To: Valentin Schneider Cc: Josh Poimboeuf , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, x86@kernel.org, rcu@vger.kernel.org, linux-kselftest@vger.kernel.org, Masami Hiramatsu , Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Andy Lutomirski , Peter Zijlstra , Frederic Weisbecker , "Paul E. McKenney" , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Boqun Feng , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , Jason Baron , Kees Cook , Sami Tolvanen , Ard Biesheuvel , Nicholas Piggin , Juerg Haefliger , Nicolas Saenz Julienne , "Kirill A. Shutemov" , Nadav Amit , Dan Carpenter , Chuang Wang , Yang Jihong , Petr Mladek , "Jason A. Donenfeld" , Song Liu , Julian Pidancet , Tom Lendacky , Dionna Glaze , Thomas =?UTF-8?B?V2Vpw59zY2h1aA==?= , Juri Lelli , Daniel Bristot de Oliveira , Marcelo Tosatti , Yair Podemsky Subject: Re: [RFC PATCH v2 02/20] tracing/filters: Enable filtering a cpumask field by another cpumask Message-ID: <20230731114803.019158b9@gandalf.local.home> In-Reply-To: References: <20230720163056.2564824-1-vschneid@redhat.com> <20230720163056.2564824-3-vschneid@redhat.com> <20230726194148.4jhyqqbtn3qqqqsq@treble> <20230729150901.25b9ae0c@rorschach.local.home> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 3B1194001C X-Stat-Signature: omuchowauk7y53yz1d41ikmcso4h8u4h X-Rspam-User: X-HE-Tag: 1690818493-451944 X-HE-Meta: U2FsdGVkX1+thXCAbIPQ6M4BpSInBEaqULB9jcsYdd49L8GkjdF1qGVxnnpxUqTxAYyBnPHb7MwoDEjXZv2V7oT51Y1rvEvuOYLt1bzCYcb7+SL6tsu05yaS7KhMrXWQK4Cx6nbkRjAknEYtPYVJlipLozEL4SWZWwjZQOKTdjtDbL0BYRbEUi0wmXnqdSToU55OxEyll3Hv8VZS0tKoTJtridfOzQU5Zf+2YuPkQSYTuUWg8nzuUmc095iZ7Wk0DkozvHCngVeG36Ic2IkG2i3xB2OdBPfZwK0BvJ8/ibao+jr1Gdt6yxReVnZglTIHPvU0vXc787OgvHQHhRoqZjkBtfLJzeStDB8Mwo4arb5gStTgxz5i+UrvemtItxm7KlQBzVRnM4VypYR4TQgZn+c7htZCmWRzj1V+iT7mDYu8jixK1PFtOTErvfXvdYWTzJ4Cl2qNM70YLxs1csG+5pZYan6Mf5LOnUru8V+RPNfzjlLmnSfLcMlTNUvgRib8otEnrpIe5BphVIsCzOYfe7Z6PS7pMzlRP6b9TWHT4TCCZtNYZCyirTsBrK4pk5WbOO8+0/Vpt4seggmggeL3rokIZVCl6pnXGqTU9fXad4kc6xbnNQ5E97ux8/vppWLibrmmOdaKtMoGOpwcj6HaTTjNLOzbWw07C8UnaIT05Da+wsNfqZRHGwjNedZkxtLNDzvdwsagE0NTpe6bms1yEtTgdBzp97Po0myUk/y/Knmy21K+sUFQ9TFflF0M4sh/Jf8GCM2GqB864D0jXQXHqGoacaSOr1y1W3eAgk6gnuHMCoucCAcDp6aT/TKMLsk6I/c7VrghCHDdsnvYjQVoYlF1DV3lM3HgfND4hAi3BbvEeZW5FT/JViYDq8pb3T4kWH16+4sN55j9EJeCK0F78THOGQvEx8bXuk5slpSfm78dbKjEee2CPkNDUDzk/MYDnY+xSzP8jlZlKP/+5xx k1+mkAzS 3ltwGjRms+V7OHSQqhUXxblLqpjJE8ebFS7WilH7931IZaqk9YoN1eZEhPCoxO2D0wq2ef/R7AfG8F9QWzFbbyx6mDk793Hh7cZa+9uksm7wkbS4gsl/P76YnoTq2TtmSH3j9xFXxhTSwqfWESYj7jGM8KPqMDpDzXh2TZZVds/Y+O6uIXTH6mgKv2dEKum9CkorB0+07IYUiMaqU8F9sHlDMsvVXFlsaHt48hxujX+9Whnki738DPy7JKZk85pq/KWRlpgw+pS1tJKD8ndrDrDpngDhgvVV0FBLHYzuJE+gXiCDQ0kx50atF1STQrO8fyD+mOsRefHZ7KSzHuCnN44e8Y83tsgzR371haqv2G/A5buw0eYRDuUlCenCg+YvNt4rXlLEMkrwYOqrig5qpT7hH7XlGoVrTUTVw04FFBGzxeMCHCsI83RITLGNDSqjS1NxQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 31 Jul 2023 12:19:51 +0100 Valentin Schneider wrote: > > > > Also, when you do an empty for loop: > > > > for (; str[i] && str[i] != '}'; i++); > > > > Always put the semicolon on the next line, otherwise it is really easy > > to think that the next line is part of the for loop. That is, instead > > of the above, do: > > > > for (; str[i] && str[i] != '}'; i++) > > ; > > > > Interestingly I don't think I've ever encountered that variant, usually > having an empty line (which this lacks) and the indentation level is enough > to identify these - regardless, I'll change it. Do a "git grep -B1 -e '^\s*;\s*$'" You'll find that it is quite common. Thanks, -- Steve