From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80215C001DE for ; Mon, 31 Jul 2023 10:50:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CBF8728001A; Mon, 31 Jul 2023 06:50:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C6EB76B00D1; Mon, 31 Jul 2023 06:50:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B5DC928001A; Mon, 31 Jul 2023 06:50:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A78426B00D0 for ; Mon, 31 Jul 2023 06:50:39 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 71A9B1201C2 for ; Mon, 31 Jul 2023 10:50:39 +0000 (UTC) X-FDA: 81071588598.24.CEB0012 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf19.hostedemail.com (Postfix) with ESMTP id 523611A000E for ; Mon, 31 Jul 2023 10:50:36 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=LfsIvVgX; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="X5g/KyOp"; dmarc=none; spf=pass (imf19.hostedemail.com: domain of jack@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690800636; a=rsa-sha256; cv=none; b=j4lknWGA9yTLSIC6GDBEByZvGRXLWG+U13izzdSY8XzsXwR58/ZXIebNwu/Vhj4X3shz24 hE44ZfbmNJtgUlurW16JmIWLxDZheEzGagGpuz8ALCmQ3zQ9grLul7FTpebiM2WHLMU+l0 vHyDef0aZWQRdtP+/MkL1h7aehK+0KQ= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=LfsIvVgX; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="X5g/KyOp"; dmarc=none; spf=pass (imf19.hostedemail.com: domain of jack@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690800636; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PJDu3H9G0xjlLFp1Wxvq9yQHkB2Q9jBIbPsGkP5jLhY=; b=pEVfRO0Xs8zfjfSbE2r1y0a88a7d2zX/qWfTec7NUEUubVe+nsdYYcCdVB0YLk2qrj+GZp PQNmyj+vlxwNxrSGMR8MtS9n8vGSOxLC3cs6cI+mlt7HOPkJwGKYXELKeB7asIJfFmblTW Rb95GuMXHeaFki1KPdV9d1sC68Rmnl4= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id ED50E22197; Mon, 31 Jul 2023 10:50:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1690800635; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PJDu3H9G0xjlLFp1Wxvq9yQHkB2Q9jBIbPsGkP5jLhY=; b=LfsIvVgX25rf01P6sVcmZRL3nPMT3sPJRPMrpOspwMqpMg9mmQx6AkDi/eF6WU32a2Vp6x /7YLD1OJK0u+bqfGa4P87gaOpA6/QZlHA1eZkenSQs1V9CjuRPICqxTQ9KdHYFZ84hOqsV 4L46K3Rf4+bEtg2brIa/aboXrQrqviE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1690800635; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PJDu3H9G0xjlLFp1Wxvq9yQHkB2Q9jBIbPsGkP5jLhY=; b=X5g/KyOpcE2CiMGegP9N6Ypxz5sWUyAuayNnMILk5q3XabEg0BuGZ7c8jHqKycooaqKD7s Ajq9KEorZZBfWcDQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D6932133F7; Mon, 31 Jul 2023 10:50:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ovhUNPqRx2R2ZgAAMHmgww (envelope-from ); Mon, 31 Jul 2023 10:50:34 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 457F5A0767; Mon, 31 Jul 2023 12:50:34 +0200 (CEST) Date: Mon, 31 Jul 2023 12:50:34 +0200 From: Jan Kara To: Haris Iqbal Cc: Christoph Hellwig , Jan Kara , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, Jens Axboe , Alasdair Kergon , Andrew Morton , Anna Schumaker , Chao Yu , Christian Borntraeger , "Darrick J. Wong" , Dave Kleikamp , David Sterba , dm-devel@redhat.com, drbd-dev@lists.linbit.com, Gao Xiang , Jack Wang , Jaegeuk Kim , jfs-discussion@lists.sourceforge.net, Joern Engel , Joseph Qi , Kent Overstreet , linux-bcache@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org, linux-mtd@lists.infradead.org, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-nvme@lists.infradead.org, linux-pm@vger.kernel.org, linux-raid@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-xfs@vger.kernel.org, Mike Snitzer , Minchan Kim , ocfs2-devel@oss.oracle.com, reiserfs-devel@vger.kernel.org, Sergey Senozhatsky , Song Liu , Sven Schnelle , target-devel@vger.kernel.org, Ted Tso , Trond Myklebust , xen-devel@lists.xenproject.org Subject: Re: [PATCH 01/32] block: Provide blkdev_get_handle_* functions Message-ID: <20230731105034.43skhi5ubze563c3@quack3> References: <20230629165206.383-1-jack@suse.cz> <20230704122224.16257-1-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 523611A000E X-Stat-Signature: gix46ztah3tnczktkzwu3zkqeayc5qca X-HE-Tag: 1690800636-532589 X-HE-Meta: U2FsdGVkX1+cibl0fEwrJoQG0p0h+OsIn1dDDnb0+5ffHCHpSmlhxiYp67IaeN1SGN6FxpEi8T5aj9zLktR+ZQ+kFgwkCye0WSO0oC4Yj7TvU8xWJMP+duG5Lcp7PsL3asF1O/ak9BavB11uzIWUCnHA5WaTXriG8aIR3get6Qm0wvBWKYauMoG48O+KYD//0jx9axj8j0mct1GShgO3zanZALx4T3uwGBeKGFtoqsZOhuDx5K1g43o7vFiGKacCfpsJn6ox3Hoy6YIJrdjfUnLNIr9HR6SO+QqbyKHkyr5aQIbDa3kkEK3IEiybUgr60cTxdWFTEwJdItzCNaaaZ7XfdHGSzav1p07UTLzcOr0qc9gd6p9gL8WzY6pqJKbHbLxewgu+ZkWiSJnWjdXeSNoeOqWn39pvch9W/tnlN6GV9dyPDx8S88xeRroO0EcGEAZ9QE2DsFFO8xegRoGNrybI2D/gId1cWa46H4xziXiPG7iAAzv6qv9XlvzMQC7s36jSBEp5PyPDhTxeLOpZU80h0Xa9i6UJRBI4RDP0W8Vs6sLKMrg6hK0D+HEzC7oAL/+/f2CifCqwbHzG9q2Fv/P34TV7b88NVhOmE5OmfduI8rssrl9fbnKMuxncfxvl2wzBgeG+RbJoTcGb/MpWbFzVeA5cvV9sZzTvxXF4mypYQZHjNdHhSLsVp94K4aafG9DAIpRNSkbQDT90yAa4YAmicYkFK1HxSBLvQON2qB74+HJCgc0k0nTHJSOx26jbrSoaE2XKlPzl0H1pcCfuzjFL7II5C/uG4eofg6LnSb5kLTXt046D/Nyphhlue9hWohDwxSecS7IiAcs/cQu1xeRNHaVwHFT++pIFatjKvkRNMPnSey/K0T6jVOaWbDAnK6l3evu9W34RCEV87Rew0M91GdI4GCRITvUtoz3qtDLzMf4iyHnQjyeugjLneRNkfAAaAs22bZx+KGlOerc idjzq3N2 hefT+D72fAeub7t5bqoJsjaIyLG8q39v5iRh3xjm96ul7FVWavHEsZo+SWpJzXxpU4Ksy2mii3dcdHOcnjtM4jr9vXFFySUvyvphutVE/3aT3iB76zId+19vFdt6ApVMkjuKLSNVbasVsuvhuYqV8r5ZAg3ab9luj9EqbP/gO/VvHCB8h39JK1cGh09nAjoSofdWTX5yL4VjZ6Nj48ZmbQ1kz7q/X0JZHyZ6zSI5J1qqve8KPqapzH0GgfL9uBSpob34EYITwF8KXRW6uot8c6BUzvwKx/7utKubdJqLI5JyxJ+29QAGvPktY1AOD4EfZResebkO3lD9KOTHHrtEW0f/PO1giMdqkXk6JitB8b+UvGj+gykbsLWOgarrI9Q8n9HAbpPWjHUpAgrTbACguVUChk8tG9KEsBbOmMmW/EX1zeJHnNL2qK3aC0g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 12-07-23 18:06:35, Haris Iqbal wrote: > On Thu, Jul 6, 2023 at 5:38 PM Christoph Hellwig wrote: > > > > On Tue, Jul 04, 2023 at 02:21:28PM +0200, Jan Kara wrote: > > > Create struct bdev_handle that contains all parameters that need to be > > > passed to blkdev_put() and provide blkdev_get_handle_* functions that > > > return this structure instead of plain bdev pointer. This will > > > eventually allow us to pass one more argument to blkdev_put() without > > > too much hassle. > > > > Can we use the opportunity to come up with better names? blkdev_get_* > > was always a rather horrible naming convention for something that > > ends up calling into ->open. > > > > What about: > > > > struct bdev_handle *bdev_open_by_dev(dev_t dev, blk_mode_t mode, void *holder, > > const struct blk_holder_ops *hops); > > struct bdev_handle *bdev_open_by_path(dev_t dev, blk_mode_t mode, > > void *holder, const struct blk_holder_ops *hops); > > void bdev_release(struct bdev_handle *handle); > > +1 to this. > Also, if we are removing "handle" from the function, should the name > of the structure it returns also change? Would something like bdev_ctx > be better? I think the bdev_handle name is fine for the struct. After all it is equivalent of an open handle for the block device so IMHO bdev_handle captures that better than bdev_ctx. Honza -- Jan Kara SUSE Labs, CR