From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Mike Kravetz <mike.kravetz@oracle.com>,
Muchun Song <muchun.song@linux.dev>,
Mina Almasry <almasrymina@google.com>, <kirill@shutemov.name>,
<joel@joelfernandes.org>, <william.kucharski@oracle.com>,
<kaleshsingh@google.com>, <linux-mm@kvack.org>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
Kefeng Wang <wangkefeng.wang@huawei.com>
Subject: [PATCH 4/4] arm64: tlb: set huge page size to stride for hugepage
Date: Mon, 31 Jul 2023 15:48:29 +0800 [thread overview]
Message-ID: <20230731074829.79309-5-wangkefeng.wang@huawei.com> (raw)
In-Reply-To: <20230731074829.79309-1-wangkefeng.wang@huawei.com>
It is better to use huge_page_size() for hugepage(HugeTLB) instead of
PAGE_SIZE for stride, which has been done in flush_pmd/pud_tlb_range(),
it could reduce the loop in __flush_tlb_range().
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
arch/arm64/include/asm/tlbflush.h | 21 +++++++++++----------
1 file changed, 11 insertions(+), 10 deletions(-)
diff --git a/arch/arm64/include/asm/tlbflush.h b/arch/arm64/include/asm/tlbflush.h
index 412a3b9a3c25..25e35e6f8093 100644
--- a/arch/arm64/include/asm/tlbflush.h
+++ b/arch/arm64/include/asm/tlbflush.h
@@ -360,16 +360,17 @@ static inline void __flush_tlb_range(struct vm_area_struct *vma,
dsb(ish);
}
-static inline void flush_tlb_range(struct vm_area_struct *vma,
- unsigned long start, unsigned long end)
-{
- /*
- * We cannot use leaf-only invalidation here, since we may be invalidating
- * table entries as part of collapsing hugepages or moving page tables.
- * Set the tlb_level to 0 because we can not get enough information here.
- */
- __flush_tlb_range(vma, start, end, PAGE_SIZE, false, 0);
-}
+/*
+ * We cannot use leaf-only invalidation here, since we may be invalidating
+ * table entries as part of collapsing hugepages or moving page tables.
+ * Set the tlb_level to 0 because we can not get enough information here.
+ */
+#define flush_tlb_range(vma, start, end) \
+ __flush_tlb_range(vma, start, end, \
+ ((vma)->vm_flags & VM_HUGETLB) \
+ ? huge_page_size(hstate_vma(vma)) \
+ : PAGE_SIZE, false, 0)
+
static inline void flush_tlb_kernel_range(unsigned long start, unsigned long end)
{
--
2.41.0
next prev parent reply other threads:[~2023-07-31 7:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 7:48 [PATCH 0/4] mm: mremap: fix move page tables Kefeng Wang
2023-07-31 7:48 ` [PATCH 1/4] mm: hugetlb: use flush_hugetlb_tlb_range() in move_hugetlb_page_tables() Kefeng Wang
2023-07-31 23:40 ` Mike Kravetz
2023-08-03 0:26 ` Mina Almasry
2023-08-01 2:06 ` Muchun Song
2023-07-31 7:48 ` [PATCH 2/4] mm: mremap: use flush_pmd_tlb_range() in move_normal_pmd() Kefeng Wang
2023-07-31 11:05 ` Catalin Marinas
2023-07-31 11:20 ` Kefeng Wang
2023-07-31 13:58 ` kernel test robot
2023-07-31 21:43 ` kernel test robot
2023-07-31 7:48 ` [PATCH 3/4] mm: mremap: use flush_pud_tlb_range in move_normal_pud() Kefeng Wang
2023-07-31 16:42 ` kernel test robot
2023-07-31 7:48 ` Kefeng Wang [this message]
2023-07-31 8:33 ` [PATCH 4/4] arm64: tlb: set huge page size to stride for hugepage Barry Song
2023-07-31 8:43 ` Barry Song
2023-07-31 9:28 ` Kefeng Wang
2023-07-31 10:21 ` Barry Song
2023-07-31 11:11 ` Catalin Marinas
2023-07-31 11:27 ` Kefeng Wang
2023-07-31 13:18 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230731074829.79309-5-wangkefeng.wang@huawei.com \
--to=wangkefeng.wang@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=almasrymina@google.com \
--cc=catalin.marinas@arm.com \
--cc=joel@joelfernandes.org \
--cc=kaleshsingh@google.com \
--cc=kirill@shutemov.name \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=muchun.song@linux.dev \
--cc=will@kernel.org \
--cc=william.kucharski@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox