From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D2EFC001E0 for ; Sat, 29 Jul 2023 19:55:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0D5B28D0002; Sat, 29 Jul 2023 15:55:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0876B8D0001; Sat, 29 Jul 2023 15:55:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E8FDD8D0002; Sat, 29 Jul 2023 15:55:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D93B68D0001 for ; Sat, 29 Jul 2023 15:55:56 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id A78681C9222 for ; Sat, 29 Jul 2023 19:55:56 +0000 (UTC) X-FDA: 81065705112.26.E91D2E0 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf19.hostedemail.com (Postfix) with ESMTP id EE4991A0004 for ; Sat, 29 Jul 2023 19:55:54 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf19.hostedemail.com: domain of "SRS0=Uptn=DP=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=Uptn=DP=goodmis.org=rostedt@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690660555; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h6miVVzjsO87Gxv82Zzfj8Yza+IeNbksTDhhqv517Mk=; b=h50G7zSrUD7RadIVUIAxowMgaMRlqX9qvaNqLiacsoNsbzMWK9y6JIvcE4jtqpont0+WVX T5W2EuIYMsNGynoE5rdKU2q6K4sbtfBoxceq8OQ4U2iNf6xX4faXGOP/9IqpJgNfw1mMLU KWjmvH9QR2dtiPnBqbQ4d8/Wyrzf3WI= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf19.hostedemail.com: domain of "SRS0=Uptn=DP=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=Uptn=DP=goodmis.org=rostedt@kernel.org" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690660555; a=rsa-sha256; cv=none; b=rdHqS9rnQMBrVDtLqWBK9d8Dx8KIUO59Vow+rbuCCd5+RXZD5f/s8/5LyjaJVgcZhSl8o5 2I5YoGKLAWceZTQn4/lMA5SsP5l89BTuA6RfbkObpVeG42tcGe3sjAR8X4Rgah3SYgO2Am xVfGGOmUWB4C8Sx7wiDp/567qVRgQF4= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A681C6092A; Sat, 29 Jul 2023 19:55:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EA441C433C7; Sat, 29 Jul 2023 19:55:48 +0000 (UTC) Date: Sat, 29 Jul 2023 15:55:47 -0400 From: Steven Rostedt To: Valentin Schneider Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, x86@kernel.org, rcu@vger.kernel.org, linux-kselftest@vger.kernel.org, Masami Hiramatsu , Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Andy Lutomirski , Peter Zijlstra , Frederic Weisbecker , "Paul E. McKenney" , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Boqun Feng , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , Josh Poimboeuf , Jason Baron , Kees Cook , Sami Tolvanen , Ard Biesheuvel , Nicholas Piggin , Juerg Haefliger , Nicolas Saenz Julienne , "Kirill A. Shutemov" , Nadav Amit , Dan Carpenter , Chuang Wang , Yang Jihong , Petr Mladek , "Jason A. Donenfeld" , Song Liu , Julian Pidancet , Tom Lendacky , Dionna Glaze , Thomas =?UTF-8?B?V2Vpw59zY2h1aA==?= , Juri Lelli , Daniel Bristot de Oliveira , Marcelo Tosatti , Yair Podemsky Subject: Re: [RFC PATCH v2 06/20] tracing/filters: Optimise scalar vs cpumask filtering when the user mask is a single CPU Message-ID: <20230729155547.35719a1f@rorschach.local.home> In-Reply-To: <20230720163056.2564824-7-vschneid@redhat.com> References: <20230720163056.2564824-1-vschneid@redhat.com> <20230720163056.2564824-7-vschneid@redhat.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: EE4991A0004 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: qr4u5drbpsgukdfdb64y189fnjtughu6 X-HE-Tag: 1690660554-320153 X-HE-Meta: U2FsdGVkX1+b1WNiQTgtMrhkhFKxxIEdkVV6EESpY5jiAsV6p/pGB0TZyCDWRSh5oM8czRblN8zFguybjL6pFmS1K/YlJylTT4NjthKGgNr9zOJEh10/OHA+Q5RRkg6HZcv5TWEyOIlFqFm08fhMoXBG8bS11SjtnlTL6u18MElWPWtvL/gzlxisBFSc8oSiYBo+/AscWlzKTPkdQe6+ufLMut1mTXOnb6PnXkFQTbHd6JaJSPZbOLlIVO68zwvsClYku9R8nbP7NV5qQOfISLtgIlRzWZnf5gbXCej4mDRlVFx3UIfRDo2Ug1/dMM0u5XfDMHjGkV4/NzlK6C6TwNlQTljpOqxDIlkqGwfSj0qAF4yTZ+D3FCdx+VCwXUcnGA6gZIqjGuDg3z7ZHwEeg+RDi6KRyjzJsK5WsngFPwAMWnyHIXrbJWrE99cr3mfd+Nx9Akqx02jvcDIAFBuqOt9tA1JHHDcZaroAx1q806jjN2HqmGj8yt6Y4VInHm7ZtG8bi9xUaFhrSzQQEHgSrX6Yui69jRgTTc5bIPUVIQ7g1HypSTbXU6HTkkm4jKmzz5UUKWNyZYMtj1QzamtQdYts2UM7RLU4Uy8DimNh2gab2HWjAXSvqc4HfJSyX1owfmoFwf5lOiWQXTscu4QVKzN27/rEQOsk7cRL6T88QyqtAvo/FIthv9k3bmhqXZdMYXSPyhI3+jDuJuACGa94Jl77faX0CRxx9T2erq6JYUEPwLUfwEP8gYyWAi6DA5jAkjghGoVTx/LckHbvncLCOEM2AyBKu9W6ZXisTTgc5E9h+fgMStPnHDpItrUxnbOgEPKtZHCivbIjlbwRb4ZPH74IbIcErPG7czcZleM3plZtTxehTdkyZ6Py+gbGT7LyW/gyeVNBt57wJQwWjK5b5oK7391mq5l98CR1OJOvLHJPU8mfHeThwfizX86hdT749uSw8THP0R6y9V2Cs+C 6f9d/oE5 7jUmDVxTpLBQlXnQ+s2Lf356mtreLxWEm7kg0kmwhPrFtGA3QHFMtNWwDfY4iZt7pm89cOPS7Ch4yHeKgYR9NbZLY57Y2HsHOX0WOYF6mpAq878FYRL5F5ke+hFGzq+mEjBdr4qK9p52YuDb4IzWmMXM2TKR2gHtEdkXsB/v4GjTxE2XjS5hLCdXrJ47Z14I+LURVt8dKVkziUwTu0/ZvVCSX5r+dD0Ptfq7/SeE0Kxarqe9VWtHQQgKKxyjvoptfG3IAO50LbrNC3cv0wfdPBf2DWNkP2Ccr9Wsa8Od5WZiq8gYiGLuKf8bK50ct1PLY4ggUeOFOOP6Wn8HeXs5oBj0PUzQsPvmRrUmdh8uzrDaXiBiivdZjblzToVbBhXZS1qSXbCIXvnihvNHrdpDLMxDItXznPaSTXyYWIq5FBY3J7oc/jQPRIHiLfK8Kok1z48Us4nfewYhqSQENwIopCz9mtl7r5QDH1WY8E9uB5tdtVjON0T5kTwc75nMcnCZfNj9WfQ5zhyQyY2Ht87hCvhaieuDKGiJD/r7oxyPUEPMDEB1tLfS926EJwPctc/SJthlx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 20 Jul 2023 17:30:42 +0100 Valentin Schneider wrote: > Steven noted that when the user-provided cpumask contains a single CPU, > then the filtering function can use a scalar as input instead of a > full-fledged cpumask. > > When the mask contains a single CPU, directly re-use the unsigned field > predicate functions. Transform '&' into '==' beforehand. > > Suggested-by: Steven Rostedt > Signed-off-by: Valentin Schneider > --- > kernel/trace/trace_events_filter.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/kernel/trace/trace_events_filter.c b/kernel/trace/trace_events_filter.c > index 2fe65ddeb34ef..54d642fabb7f1 100644 > --- a/kernel/trace/trace_events_filter.c > +++ b/kernel/trace/trace_events_filter.c > @@ -1750,7 +1750,7 @@ static int parse_pred(const char *str, void *data, > * then we can treat it as a scalar input. > */ > single = cpumask_weight(pred->mask) == 1; > - if (single && field->filter_type == FILTER_CPUMASK) { > + if (single && field->filter_type != FILTER_CPU) { > pred->val = cpumask_first(pred->mask); > kfree(pred->mask); > } > @@ -1761,6 +1761,11 @@ static int parse_pred(const char *str, void *data, > FILTER_PRED_FN_CPUMASK; > } else if (field->filter_type == FILTER_CPU) { > pred->fn_num = FILTER_PRED_FN_CPU_CPUMASK; > + } else if (single) { > + pred->op = pred->op == OP_BAND ? OP_EQ : pred->op; Nit, the above can be written as: pred->op = pret->op != OP_BAND ? : OP_EQ; -- Steve > + pred->fn_num = select_comparison_fn(pred->op, field->size, false); > + if (pred->op == OP_NE) > + pred->not = 1; > } else { > switch (field->size) { > case 8: