From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F38C2C001DC for ; Sat, 29 Jul 2023 19:34:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DBE7A8D0002; Sat, 29 Jul 2023 15:34:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D6E0D8D0001; Sat, 29 Jul 2023 15:34:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C35828D0002; Sat, 29 Jul 2023 15:34:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id AE9C38D0001 for ; Sat, 29 Jul 2023 15:34:45 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 7BF2E1C9297 for ; Sat, 29 Jul 2023 19:34:45 +0000 (UTC) X-FDA: 81065651730.02.DCCB022 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf09.hostedemail.com (Postfix) with ESMTP id 9C90D14000B for ; Sat, 29 Jul 2023 19:34:43 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=none; spf=pass (imf09.hostedemail.com: domain of "SRS0=Uptn=DP=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=Uptn=DP=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690659283; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tVj6IBxUJBK4YUD7tPaZKYWvUxMow7Tl+0/fIlafWUs=; b=vV0oRS68daLWtOrzZzoIE8Igi+7O9Nuoh4tvMTm4+oJtay2lwikScemJ3i7KV9c5Xr0H3J qjJMWxgMVhLbLYuosp/KgnGZVX7S0hkRcvpU3DDZ91Otid8+7FqQ7R2NyX+edVRVVR4h03 JhPYgeETtnuoUUdA/foveK+MRJBnxbw= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; spf=pass (imf09.hostedemail.com: domain of "SRS0=Uptn=DP=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=Uptn=DP=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690659283; a=rsa-sha256; cv=none; b=n86NnMCKtLzWP+w2/KpjEWzB+0vHLOexvqs/KKXnv83EoE8qyxNTI5QRcLPMhAaM118rVf nqj+14rUjvgnCn/stw4BhDTuZ2sgS6fN3yFiCt4TL+jZ9OP8bV1vmtID2w3F4t2P2i1iAL jNnbRrJN5VzIUEgoDZMQpHIpOsgVimg= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B12916069B; Sat, 29 Jul 2023 19:34:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 27432C433C8; Sat, 29 Jul 2023 19:34:38 +0000 (UTC) Date: Sat, 29 Jul 2023 15:34:36 -0400 From: Steven Rostedt To: Valentin Schneider Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, x86@kernel.org, rcu@vger.kernel.org, linux-kselftest@vger.kernel.org, Masami Hiramatsu , Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Andy Lutomirski , Peter Zijlstra , Frederic Weisbecker , "Paul E. McKenney" , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Boqun Feng , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , Josh Poimboeuf , Jason Baron , Kees Cook , Sami Tolvanen , Ard Biesheuvel , Nicholas Piggin , Juerg Haefliger , Nicolas Saenz Julienne , "Kirill A. Shutemov" , Nadav Amit , Dan Carpenter , Chuang Wang , Yang Jihong , Petr Mladek , "Jason A. Donenfeld" , Song Liu , Julian Pidancet , Tom Lendacky , Dionna Glaze , Thomas =?UTF-8?B?V2Vpw59zY2h1aA==?= , Juri Lelli , Daniel Bristot de Oliveira , Marcelo Tosatti , Yair Podemsky Subject: Re: [RFC PATCH v2 05/20] tracing/filters: Optimise cpumask vs cpumask filtering when user mask is a single CPU Message-ID: <20230729153436.1e07bfa6@rorschach.local.home> In-Reply-To: <20230720163056.2564824-6-vschneid@redhat.com> References: <20230720163056.2564824-1-vschneid@redhat.com> <20230720163056.2564824-6-vschneid@redhat.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 9C90D14000B X-Rspam-User: X-Stat-Signature: iswgi35jpcoatmumenrcmu65j5ssbsa4 X-Rspamd-Server: rspam01 X-HE-Tag: 1690659283-922405 X-HE-Meta: U2FsdGVkX1+suEtnelg/ikZ+qQLMuCaleRcgXWiTLFVsVkDPLi2YyFzCFcWg+TxuLipaW2lsa3nE+tQU38HqIcwzVCIHN/ZUb15Nq2X8wBvEY/I1flS0ejkuam9ZL5yBLsn6G7sQPQ9NiUagbNHRcjze3u1SipLWV/x9KFHivq7LPv42ronD4A3DLHWzisuuNvFIOAK5Iq4Wz2H4BZXl+JxoCiojeDSXma/aKns4XqxgRVwH0HctHdhhtMU5Zi+wREcILAETiq8wtqmg5AV/vQ5rXh9XVziAfjSM/ukwkKCpEXlMO01aIxYUyDRxivUIP1/khFzJUrVWn1YAhk2HdjPRzuQo6L1dtGcgoq+9S47lAt/ahlsoBY0TAG+EZLFCkk7w1Zb03GJWDN4iptZwTJaBxuJiCzn2giO++Q66KcQ2vhUgnDVOg/HTST3DVnt3rjUXUdpMdGaZwcIuE0ZViUqumhfnx+2/wY7V7Cooh5mXZOnX5c51ABISr18CuxV3Ks1pdePILO/sYudJ9EsERf3uR99E/ieR0xZZJWzGrmT31N73S1GOCH6UTwhfKNg0TrxYT4UBmIBmwmkz2RhhaKZKONu+ZvBSQU6Pi4mLH4VABoEp3dRkuwKpAoUNgX1ncZDSW2/J1P4U75CvE5pV3oRn8519p6PvmYXiNOYhJ1X5NLL07UnpUMFcggYLkqa7cUjR/jemoyWnZKKDcnEmqE4J60sNvPtlBfz1wbZWXaoD5DEQiyGOqfoGXsczJNg1q31gBCx3px37vO3cvpNdLGtOZX5duG0xoahPV7pyPfH1uBJoiEvNttmUM0RfsE2XHqJ5a6zuZtpQoI6JHcNMooNYBQc6zyeBcW8d3i7eswUQkHjLzXHP5bXtJF7k/aA2RR+e3lQLviTWVUMYeKQ8Dqdfix4f1Mgy1Ite6640I4d1+zMMBdj8rOgxAdEet54kafSL+pyiNKfu/TsiPsN DbsSMPhB NCKEFKvdHNS11Z4n1BPrmXZXeKlFeeSUhc2v5ecY4/Fbr2Pn0QzBQacKGQMeIKBvqzABuiXs10BSYNp4phLaX8Vk7CdMxZ9z1fC7pDhe4E//8hlXR72wBIIjbj9vThuOMwdZNIxCW58XIN5rXN49Oa4Xw1VO52g6zMrNEOPyOUQz3tItBilvKShabZNtAYrOGJGoEvVvZIrjluNIB4v/ZpSYoZFIHTZRZYOj8yKTl0HRe2ovhSy05EFNV8JHxTsCtLT/5+54I//IUscmpFoT+tovy/CWE/ntGJlWezape/h6hOJzUm0sKWgynYS9LBgVEZBnYn94ON8ow33Tgp1FEniyPr3xlRSx43cscF8w5OKAEnKmMglO2g6p6xaRqa1wfOfGExaJb8wEDmXhvi60nXb7WlpfKE0sdelY/lB4TkIz9TYxYiTrZpNoxAA+V7B3laYBbEkm3t6y+kMg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 20 Jul 2023 17:30:41 +0100 Valentin Schneider wrote: > /* Move along */ > i++; > + > + /* > + * Optimisation: if the user-provided mask has a weight of one > + * then we can treat it as a scalar input. > + */ > + single = cpumask_weight(pred->mask) == 1; > + if (single && field->filter_type == FILTER_CPUMASK) { > + pred->val = cpumask_first(pred->mask); > + kfree(pred->mask); Don't we need: pred->mask = NULL; here, or the free_predicate() will cause a double free? -- Steve > + } > +