From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB246C0015E for ; Sat, 29 Jul 2023 15:15:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A40DD8D0002; Sat, 29 Jul 2023 11:15:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F0138D0001; Sat, 29 Jul 2023 11:15:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B7FA8D0002; Sat, 29 Jul 2023 11:15:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7CA068D0001 for ; Sat, 29 Jul 2023 11:15:11 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 4CF7BB19D2 for ; Sat, 29 Jul 2023 15:15:11 +0000 (UTC) X-FDA: 81064997622.17.3399094 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf29.hostedemail.com (Postfix) with ESMTP id 879BE120024 for ; Sat, 29 Jul 2023 15:15:09 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=oMdNaO3u; spf=pass (imf29.hostedemail.com: domain of djwong@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690643709; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BzEjeL6ZpFu/E7PHsa1I8JGdiFHX0PK5qbQZSZLtUFw=; b=UHYOywaom2f8gyTOfTXK9CGu4TVJ31rnoEuGbIGmFmFPrf5AYsAo87UaSyJ8+hq7Zcs/ue qs6ZLoJYKTnfwWPvFSe07H3iafsD6tF2ofQfyGoCpT6kXu5Kjjo/x4stj+FIhXzqh4h2AD eeVxRiQw0Jf7+IeiZz5OybG2ldSTg28= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690643709; a=rsa-sha256; cv=none; b=hkm+8u0E6HyqJss6YSLx5qishAAWVYXWjU6oscII00yK8sT5coXB34ztfxkceE4WQ5lQcp 5qu2Ga1KaYp43Ekm40dCk/x6+rHsf4lPaowSo696rfe9WDwKi6p6Enznla9VEksnWYfJzM nb+zpusiIxsH6wHSQHp+XRicIu+pKYA= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=oMdNaO3u; spf=pass (imf29.hostedemail.com: domain of djwong@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 58CDA60C86; Sat, 29 Jul 2023 15:15:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2FCE2C433C8; Sat, 29 Jul 2023 15:15:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690643707; bh=IxHYvtSESH4QSGvtXa6xtET3X0jMFi5eemFYKeB3HLs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oMdNaO3u5mxWsjwHP0X4vMjJzNHQM6/7ecOaQBECpk90h2L8gwKz5TPOCRoOgNWaI DQ+YBbu9ICWwvEbgdcsgabEr6xI4v+x8fvYM6/PJnrvswEsVWgamuKQhMK6xKnCbkp suQ8y1z0nXr2NJFkYNP42mhsf4hdwSI92HX8iICONv8qeNl787i9Vbybyt4rsphOxT jXQmJcRTRE3MSQTKByNgJfIpVWz7dbVvUgpO56wg/eCAD6S8rCyu67IsZnWbY6EB92 rexgJ2/tSprqCCdmc3XqNBJA3x3Xb9+XArz9eKmLWa160VgP8K3RAun8LtcmEN2knp OAjNrA4Y7lIqw== Date: Sat, 29 Jul 2023 08:15:06 -0700 From: "Darrick J. Wong" To: Shiyang Ruan Cc: linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev, linux-xfs@vger.kernel.org, linux-mm@kvack.org, dan.j.williams@intel.com, willy@infradead.org, jack@suse.cz, akpm@linux-foundation.org, mcgrof@kernel.org Subject: Re: [PATCH v12 2/2] mm, pmem, xfs: Introduce MF_MEM_REMOVE for unbind Message-ID: <20230729151506.GI11352@frogsfrogsfrogs> References: <20230629081651.253626-1-ruansy.fnst@fujitsu.com> <20230629081651.253626-3-ruansy.fnst@fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230629081651.253626-3-ruansy.fnst@fujitsu.com> X-Rspamd-Queue-Id: 879BE120024 X-Rspam-User: X-Stat-Signature: 1fu61ab3au7hiewyic43kjari46os61t X-Rspamd-Server: rspam03 X-HE-Tag: 1690643709-308474 X-HE-Meta: U2FsdGVkX194kOqEt2BlW9w368YNJ3Rv4Gf9EUHqnQHfqWr7p5UPi5E1yHy+Ba4KLdEXy1EcA4OrfkMchs8mJiWMzc4Dax24F+qAUlvX2CUbMe8RIlYi802l7OKHYLCrkIaAlr0OuOmn9pqopyQqbDpb6USTD0wvfpvfmiz6bfVUmQlpxiy78MjQ/kBH+UPNVriXrWytZJOX2/PILtlZm8YMrG4UsqekwMgWFTPSBNiF8K1jIVMFCqTF9Cs3NRlg/XDs6HJkjYe1mQ7Lsyq8J4XMV4j82OsNAyKfrtue8truHTVFsWwsXE7ATevG9+i5js9LJauBiYEiNBy9derZpZkZy4yH6p0XpvbJJjOIsMMYNXmMzXNFShZY7ia6X5+oT4vYG2Tv1OGKo6EWe94qU51tT5sWzOtNZ8TU3kVYys7GlKXxjLo7dmvcHV0SbTkSoLcZnwVDRWTte5Gcg1yyefGPASvPIVz+PqwKyTrNl+GwWr3CAss1+QGufomBfjOxMYcmt2SfB8Svkbg9kIvCwmsOOMiSt2oBdNLKkAWpizrkf26dqFglSt1HivyHZbfEEUaqyX9jDXTwLqVychXQZ4zHrAXyKMUDnQ79Y9JZjS4fSbJJDef6qWEPLwAcAWnL+r5yJA2XksIQ2e50aV7euIxCvt6rBf5dhLBN+JwFl93pxja/XtBjJxh0B76iOiJ+uXUFyRePeEEgfyALr7cetwh4xybtc9z9mUSf5aUTRJnrof0eLMHvkPNq7dYLlTFEg7tR0MEdSvvSDF6yTEmiK2HDIXf6rG9wih7NXmoyqrhWlxSnlxaZ9bSCzTlBYDPbN3pho2YfjI7vu8Ot/PUjolyNqhW8L1IAa7GZ6qY4wii+VuVKy4sKxPSe2s8OvkvoiIvPmKC4HRqOhuYnAhHWfnXxnSJNnbvgfylbVJPGyhdgqellQWhRiuKNMvDIQLIFOUHrPHOLrjtEBMuANj1 +S1peS7a F4zglyfxXXxHkWCqnjOFlalIRu60P3knx/Xw5mFJ2m617d6y5u99c1EYq139MKrjr1n984yBJnSOHY05cFHh5kYXzjppeQRuJ9k7ZYqFHcjzIEoRKMoUo79UwOWOTd22ggfplMlewPv8FWkdsWThioJWiyxenFnng4aTIOKWmLVRS3R6SuGfDLuhH/s9cZkSuze61fcY4XD9vl4ZlG/H+ySSgkGffRqIbllLwUk9aUb5yUKLqOoqbgv3zRJPB7EeZoMnZsOJnI3nei+Ppect169axbZG6yPzuCCOhZbUqAVpgkpHpgfkOFT9eJw6QVBDOFzU2EZBZHXdwuX16G0Htj2tFKsx+QUewcrJJHvhev2S+pd+chSo23Sm6OySamJ0T39zZSfCfXIiib4e1B6jUNn1apxqDdSFJmI2nAXDqFsbU+7uFPP11RycD1cgzr+2IpIDi X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 29, 2023 at 04:16:51PM +0800, Shiyang Ruan wrote: > This patch is inspired by Dan's "mm, dax, pmem: Introduce > dev_pagemap_failure()"[1]. With the help of dax_holder and > ->notify_failure() mechanism, the pmem driver is able to ask filesystem > on it to unmap all files in use, and notify processes who are using > those files. > > Call trace: > trigger unbind > -> unbind_store() > -> ... (skip) > -> devres_release_all() > -> kill_dax() > -> dax_holder_notify_failure(dax_dev, 0, U64_MAX, MF_MEM_PRE_REMOVE) > -> xfs_dax_notify_failure() > `-> freeze_super() // freeze (kernel call) > `-> do xfs rmap > ` -> mf_dax_kill_procs() > ` -> collect_procs_fsdax() // all associated processes > ` -> unmap_and_kill() > ` -> invalidate_inode_pages2_range() // drop file's cache > `-> thaw_super() // thaw (both kernel & user call) > > Introduce MF_MEM_PRE_REMOVE to let filesystem know this is a remove > event. Use the exclusive freeze/thaw[2] to lock the filesystem to prevent > new dax mapping from being created. Do not shutdown filesystem directly > if configuration is not supported, or if failure range includes metadata > area. Make sure all files and processes(not only the current progress) > are handled correctly. Also drop the cache of associated files before > pmem is removed. > > [1]: https://lore.kernel.org/linux-mm/161604050314.1463742.14151665140035795571.stgit@dwillia2-desk3.amr.corp.intel.com/ > [2]: https://lore.kernel.org/linux-xfs/168688010689.860947.1788875898367401950.stgit@frogsfrogsfrogs/ > > Signed-off-by: Shiyang Ruan > --- > drivers/dax/super.c | 3 +- > fs/xfs/xfs_notify_failure.c | 86 ++++++++++++++++++++++++++++++++++--- > include/linux/mm.h | 1 + > mm/memory-failure.c | 17 ++++++-- > 4 files changed, 96 insertions(+), 11 deletions(-) > > diff --git a/drivers/dax/super.c b/drivers/dax/super.c > index c4c4728a36e4..2e1a35e82fce 100644 > --- a/drivers/dax/super.c > +++ b/drivers/dax/super.c > @@ -323,7 +323,8 @@ void kill_dax(struct dax_device *dax_dev) > return; > > if (dax_dev->holder_data != NULL) > - dax_holder_notify_failure(dax_dev, 0, U64_MAX, 0); > + dax_holder_notify_failure(dax_dev, 0, U64_MAX, > + MF_MEM_PRE_REMOVE); > > clear_bit(DAXDEV_ALIVE, &dax_dev->flags); > synchronize_srcu(&dax_srcu); > diff --git a/fs/xfs/xfs_notify_failure.c b/fs/xfs/xfs_notify_failure.c > index 4a9bbd3fe120..f6ec56b76db6 100644 > --- a/fs/xfs/xfs_notify_failure.c > +++ b/fs/xfs/xfs_notify_failure.c > @@ -22,6 +22,7 @@ > > #include > #include > +#include > > struct xfs_failure_info { > xfs_agblock_t startblock; > @@ -73,10 +74,16 @@ xfs_dax_failure_fn( > struct xfs_mount *mp = cur->bc_mp; > struct xfs_inode *ip; > struct xfs_failure_info *notify = data; > + struct address_space *mapping; > + pgoff_t pgoff; > + unsigned long pgcnt; > int error = 0; > > if (XFS_RMAP_NON_INODE_OWNER(rec->rm_owner) || > (rec->rm_flags & (XFS_RMAP_ATTR_FORK | XFS_RMAP_BMBT_BLOCK))) { > + /* Continue the query because this isn't a failure. */ > + if (notify->mf_flags & MF_MEM_PRE_REMOVE) > + return 0; > notify->want_shutdown = true; > return 0; > } > @@ -92,14 +99,55 @@ xfs_dax_failure_fn( > return 0; > } > > - error = mf_dax_kill_procs(VFS_I(ip)->i_mapping, > - xfs_failure_pgoff(mp, rec, notify), > - xfs_failure_pgcnt(mp, rec, notify), > - notify->mf_flags); > + mapping = VFS_I(ip)->i_mapping; > + pgoff = xfs_failure_pgoff(mp, rec, notify); > + pgcnt = xfs_failure_pgcnt(mp, rec, notify); > + > + /* Continue the rmap query if the inode isn't a dax file. */ > + if (dax_mapping(mapping)) > + error = mf_dax_kill_procs(mapping, pgoff, pgcnt, > + notify->mf_flags); > + > + /* Invalidate the cache in dax pages. */ > + if (notify->mf_flags & MF_MEM_PRE_REMOVE) > + invalidate_inode_pages2_range(mapping, pgoff, > + pgoff + pgcnt - 1); > + > xfs_irele(ip); > return error; > } > > +static void > +xfs_dax_notify_failure_freeze( > + struct xfs_mount *mp) > +{ > + struct super_block *sb = mp->m_super; Nit: extra space right ^ here. > + > + /* Wait until no one is holding the FREEZE_HOLDER_KERNEL. */ > + while (freeze_super(sb, FREEZE_HOLDER_KERNEL) != 0) { > + // Shall we just wait, or print warning then return -EBUSY? Hm. PRE_REMOVE gets called before the pmem gets unplugged, right? So we'll send a second notification after it goes away, right? If so, then I'd say return the error here instead of looping, and live with a kernel-frozen fs discarding the PRE_REMOVE message. > + delay(HZ / 10); > + } > +} > + > +static void > +xfs_dax_notify_failure_thaw( > + struct xfs_mount *mp) > +{ > + struct super_block *sb = mp->m_super; > + int error; > + > + error = thaw_super(sb, FREEZE_HOLDER_KERNEL); > + if (error) > + xfs_emerg(mp, "still frozen after notify failure, err=%d", > + error); > + /* > + * Also thaw userspace call anyway because the device is about to be > + * removed immediately. > + */ > + thaw_super(sb, FREEZE_HOLDER_USERSPACE); > +} > + > static int > xfs_dax_notify_ddev_failure( > struct xfs_mount *mp, > @@ -120,7 +168,7 @@ xfs_dax_notify_ddev_failure( > > error = xfs_trans_alloc_empty(mp, &tp); > if (error) > - return error; > + goto out; > > for (; agno <= end_agno; agno++) { > struct xfs_rmap_irec ri_low = { }; > @@ -165,11 +213,23 @@ xfs_dax_notify_ddev_failure( > } > > xfs_trans_cancel(tp); > + > + /* > + * Determine how to shutdown the filesystem according to the > + * error code and flags. > + */ > if (error || notify.want_shutdown) { > xfs_force_shutdown(mp, SHUTDOWN_CORRUPT_ONDISK); > if (!error) > error = -EFSCORRUPTED; > - } > + } else if (mf_flags & MF_MEM_PRE_REMOVE) > + xfs_force_shutdown(mp, SHUTDOWN_FORCE_UMOUNT); > + > +out: > + /* Thaw the fs if it is freezed before. */ > + if (mf_flags & MF_MEM_PRE_REMOVE) > + xfs_dax_notify_failure_thaw(mp); _thaw should be called from the same function that called _freeze. The rest of the patch seems ok to me. --D > + > return error; > } > > @@ -197,6 +257,8 @@ xfs_dax_notify_failure( > > if (mp->m_logdev_targp && mp->m_logdev_targp->bt_daxdev == dax_dev && > mp->m_logdev_targp != mp->m_ddev_targp) { > + if (mf_flags & MF_MEM_PRE_REMOVE) > + return 0; > xfs_err(mp, "ondisk log corrupt, shutting down fs!"); > xfs_force_shutdown(mp, SHUTDOWN_CORRUPT_ONDISK); > return -EFSCORRUPTED; > @@ -210,6 +272,12 @@ xfs_dax_notify_failure( > ddev_start = mp->m_ddev_targp->bt_dax_part_off; > ddev_end = ddev_start + bdev_nr_bytes(mp->m_ddev_targp->bt_bdev) - 1; > > + /* Notify failure on the whole device. */ > + if (offset == 0 && len == U64_MAX) { > + offset = ddev_start; > + len = bdev_nr_bytes(mp->m_ddev_targp->bt_bdev); > + } > + > /* Ignore the range out of filesystem area */ > if (offset + len - 1 < ddev_start) > return -ENXIO; > @@ -226,6 +294,12 @@ xfs_dax_notify_failure( > if (offset + len - 1 > ddev_end) > len = ddev_end - offset + 1; > > + if (mf_flags & MF_MEM_PRE_REMOVE) { > + xfs_info(mp, "device is about to be removed!"); > + /* Freeze fs to prevent new mappings from being created. */ > + xfs_dax_notify_failure_freeze(mp); > + } > + > return xfs_dax_notify_ddev_failure(mp, BTOBB(offset), BTOBB(len), > mf_flags); > } > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 27ce77080c79..a80c255b88d2 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -3576,6 +3576,7 @@ enum mf_flags { > MF_UNPOISON = 1 << 4, > MF_SW_SIMULATED = 1 << 5, > MF_NO_RETRY = 1 << 6, > + MF_MEM_PRE_REMOVE = 1 << 7, > }; > int mf_dax_kill_procs(struct address_space *mapping, pgoff_t index, > unsigned long count, int mf_flags); > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index 5b663eca1f29..483b75f2fcfb 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -688,7 +688,7 @@ static void add_to_kill_fsdax(struct task_struct *tsk, struct page *p, > */ > static void collect_procs_fsdax(struct page *page, > struct address_space *mapping, pgoff_t pgoff, > - struct list_head *to_kill) > + struct list_head *to_kill, bool pre_remove) > { > struct vm_area_struct *vma; > struct task_struct *tsk; > @@ -696,8 +696,15 @@ static void collect_procs_fsdax(struct page *page, > i_mmap_lock_read(mapping); > read_lock(&tasklist_lock); > for_each_process(tsk) { > - struct task_struct *t = task_early_kill(tsk, true); > + struct task_struct *t = tsk; > > + /* > + * Search for all tasks while MF_MEM_PRE_REMOVE, because the > + * current may not be the one accessing the fsdax page. > + * Otherwise, search for the current task. > + */ > + if (!pre_remove) > + t = task_early_kill(tsk, true); > if (!t) > continue; > vma_interval_tree_foreach(vma, &mapping->i_mmap, pgoff, pgoff) { > @@ -1793,6 +1800,7 @@ int mf_dax_kill_procs(struct address_space *mapping, pgoff_t index, > dax_entry_t cookie; > struct page *page; > size_t end = index + count; > + bool pre_remove = mf_flags & MF_MEM_PRE_REMOVE; > > mf_flags |= MF_ACTION_REQUIRED | MF_MUST_KILL; > > @@ -1804,9 +1812,10 @@ int mf_dax_kill_procs(struct address_space *mapping, pgoff_t index, > if (!page) > goto unlock; > > - SetPageHWPoison(page); > + if (!pre_remove) > + SetPageHWPoison(page); > > - collect_procs_fsdax(page, mapping, index, &to_kill); > + collect_procs_fsdax(page, mapping, index, &to_kill, pre_remove); > unmap_and_kill(&to_kill, page_to_pfn(page), mapping, > index, mf_flags); > unlock: > -- > 2.40.1 >