From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 457A1C001DC for ; Sat, 29 Jul 2023 06:43:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B8CE66B0071; Sat, 29 Jul 2023 02:43:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B3A186B0072; Sat, 29 Jul 2023 02:43:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A2AE68D0001; Sat, 29 Jul 2023 02:43:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 925DA6B0071 for ; Sat, 29 Jul 2023 02:43:14 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 61452A0174 for ; Sat, 29 Jul 2023 06:43:14 +0000 (UTC) X-FDA: 81063707508.13.6C8B7E2 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf27.hostedemail.com (Postfix) with ESMTP id B0D5440012 for ; Sat, 29 Jul 2023 06:43:12 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=FuAwOwKe; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf27.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690612992; a=rsa-sha256; cv=none; b=Ui/GfNwIfomC11V66j29UaaR3MPqTgtvuKMgFcncTP+ji48768d933zT+RcMnWfspC1udy ohbecAetYN5iztN53NAod+vCW+aJWv5svDJAhlpPPDNUf2CTQrjjqHkRmYS8nwwOB9QR6S 8tkur5blpWpUFnU+Pi6b4WoEpVs50pY= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=FuAwOwKe; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf27.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690612992; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8l/YtbJ0DFUpfFxWlaELGvHl5OpXy5A8CARjKiAEXy4=; b=XytlDwVvo2cyb/U9vb2FkBtVkIe9GHVGzEC1TZM8llzTASGA1IfWCls+2MJXomF4v+Vz6t IsDGhK/4PYiZ+lHnPrIGbj89Db98FWLkUHwDveig3gB7AtGpE+DAaGbB6VPk/SprisbFlM k2GYrQnSmvs7rtzMN/62Dfd0eju2+4A= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AFE0F6009E; Sat, 29 Jul 2023 06:43:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 47722C433C8; Sat, 29 Jul 2023 06:43:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690612991; bh=3umf+ONMIblL2nAVUVYoR39EvcxsUy91gC3porAPrFg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FuAwOwKe4/IrvZW96FVeiNu4RWLHWmB0VhtgEO9nFxUFx9oBTlA4uOIY+HNCzAkcU gfXunkPulxjvCaFeIBbjzsA05Z6tNxthhDiyoIZsnKed0KRKZKoYf8+mHX2404u5sF 88kS/F7yYFDWrJw2xpy8Ye9mgnMU5xFG8s8ijtVN7p1YTJ14+bzC1chMtNWwTrFF8t 5YQRzbAg7V+mkxE/sFzivz7E5GYcqWvFbQRv2ZVxcxLvFkcsG8NIFfK/t5VMAlzd0i W6K7g8PahV4VYz8loyiG6/y6Q1qcCuisXlnNsFv5XzXez3hiMklkA0Hz+3NDQ1wokE +lJVQUbKey8jg== Date: Sat, 29 Jul 2023 09:42:33 +0300 From: Mike Rapoport To: Usama Arif Cc: linux-mm@kvack.org, muchun.song@linux.dev, mike.kravetz@oracle.com, linux-kernel@vger.kernel.org, fam.zheng@bytedance.com, liangma@liangbit.com, simon.evans@bytedance.com, punit.agrawal@bytedance.com Subject: Re: [v1 3/6] memblock: add parameter to memblock_setclr_flag for selecting memblock_type Message-ID: <20230729064233.GE1901145@kernel.org> References: <20230727204624.1942372-1-usama.arif@bytedance.com> <20230727204624.1942372-4-usama.arif@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230727204624.1942372-4-usama.arif@bytedance.com> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: B0D5440012 X-Stat-Signature: j689uwd5yw1cr7haan6qz5jyzta5dqci X-HE-Tag: 1690612992-361286 X-HE-Meta: U2FsdGVkX19DtrUA8PCFK858SppHZyXAusZkIuLtZeqZlg5PlZKydiR89r+z3ThL8hBJWlfcSp6pydNUjqipP5rH9NSwh9sGpeTM0oEUO5n0Gl2bzmwZJcPnwq2B5wxPSWMlvBWgO4mxAqkrHIdEyvtP/Gwly/ToXIg7GDxNm3abts9SNRx/bEt4lwFwKbcFilMi1fgmOQDm9yN0B/K0RxOaJh9M4h/+9jiLjOYN63oy+9MMEbLSjr8Bne798oX9hBwwl1oSN1bFBCza4Hz28tQqYA6+yA35Qw29QcjqQn7yYoEkP9SkZuVNcNFxt7KZek8QCVIXbtzpUhzHnyCpB1CC77J/z0Xc5DKfvIa6sDj01dXngDvE2cKH6dDH9aWlT69GUIUnozxPv9cx59MQ3d0TVUcqleuwALAG3SF+feQ5uLSfcdsSHgkXUjUBvJp9H8nc9pE5GMNyeoT4K+lA53bb9BsCSciZOCUjfQcDzYzIrWnNNAnGwl2AzgQN6EzD1s55OZ5EsApg9uwWYkI2DSKxFoo0hEO0Pg57qklD04H5Wr+yCn/DZRTC+HUTwXJPFoWl6CbObaFeHt19E9N/tNndIRAEgA5LefVGakODhqyArd/fyxM84ILBL3+ScidxB7D/7ttnwib/YOwBmPj+sxCFvTBn2UXqWAkCFSvpgETqqrb1NpcFkFICIX5KC6TGm0NgBptCVgpxoDnXzAPrOlzT3gtcAlRqdCHUhNvGWOPl0ICHkZMcwWEnMUtteQVkvlSkEI/Q2dYg0HovCwe3uMXSeC8HmgUpf5dJtRDDGnSoKq+ZyVn7dth+wZiO8+d/PGTpQECcaglXJUd+wNI8CQy8Td+nlwRm1W3X6m6v8lnDLYRM1Kj+Ek8Uo51eJi72sAePxeb0VOopsKq/WFUT5VirZ19s2VXfAdha9yxOuhgMFx/7CXKN5DNET9XYa4ssm4EzOyJQATdS9a6r7fm u41SQsx5 T7zCxpMNVXfioK3GKt98iWLcBgVItyMVZYJguDeKyPU0lJQk8ra2rBuq6e1pPDyUJhVO2TfVXmWMCm6Ih9zee99nJ3STNmf+sNMVIe3HrAdRhTtqOi5db4GgoXkAdqPw97YA9FQ4Ck+/7Fa1AgzFV8sWfJFlpxUz5Tm6wr0aYTutKGKtu1TY0laLgcxYPPZt3F/qv9OhvscV2+idBYQ+MUNU+YBmddR3bPiQAl5YrpKkp1rnmtV1+hZBDoN/sjGrqwinT2qzPa6ejCzKvFH88XTQUEs7T3FFTF8rz8iBX3N4dbKr5R3slWx760a9vamwfkBE2B98VOZBwvG40ow5h7XM5zTHS4A1SqLqi/QzNncMpYvBWJ2zs55CPuTxpfHFugXWlSI94NSl6ldo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 27, 2023 at 09:46:21PM +0100, Usama Arif wrote: > This is in preparation for setting flags (for e.g. to not initialize > struct pages) on reserved memory region. > > Signed-off-by: Usama Arif > --- > mm/memblock.c | 19 ++++++++++++------- > 1 file changed, 12 insertions(+), 7 deletions(-) > > diff --git a/mm/memblock.c b/mm/memblock.c > index f9e61e565a53..4fd431d16ef2 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -897,11 +897,16 @@ int __init_memblock memblock_physmem_add(phys_addr_t base, phys_addr_t size) > * Return: 0 on success, -errno on failure. > */ > static int __init_memblock memblock_setclr_flag(phys_addr_t base, > - phys_addr_t size, int set, int flag) > + phys_addr_t size, int set, int flag, bool reserved) > { Please pass struct memblock_type * as the first parameter and set the flags unconditionally. The boolean parameters make code less readable. Besides if we'll add more flags for reserved regions it'll become really hairy. > - struct memblock_type *type = &memblock.memory; > + struct memblock_type *type; > int i, ret, start_rgn, end_rgn; > > + if (reserved) > + type = &memblock.reserved; > + else > + type = &memblock.memory; > + > ret = memblock_isolate_range(type, base, size, &start_rgn, &end_rgn); > if (ret) > return ret; > @@ -928,7 +933,7 @@ static int __init_memblock memblock_setclr_flag(phys_addr_t base, > */ > int __init_memblock memblock_mark_hotplug(phys_addr_t base, phys_addr_t size) > { > - return memblock_setclr_flag(base, size, 1, MEMBLOCK_HOTPLUG); > + return memblock_setclr_flag(base, size, 1, MEMBLOCK_HOTPLUG, 0); > } > > /** > @@ -940,7 +945,7 @@ int __init_memblock memblock_mark_hotplug(phys_addr_t base, phys_addr_t size) > */ > int __init_memblock memblock_clear_hotplug(phys_addr_t base, phys_addr_t size) > { > - return memblock_setclr_flag(base, size, 0, MEMBLOCK_HOTPLUG); > + return memblock_setclr_flag(base, size, 0, MEMBLOCK_HOTPLUG, 0); > } > > /** > @@ -957,7 +962,7 @@ int __init_memblock memblock_mark_mirror(phys_addr_t base, phys_addr_t size) > > system_has_some_mirror = true; > > - return memblock_setclr_flag(base, size, 1, MEMBLOCK_MIRROR); > + return memblock_setclr_flag(base, size, 1, MEMBLOCK_MIRROR, 0); > } > > /** > @@ -977,7 +982,7 @@ int __init_memblock memblock_mark_mirror(phys_addr_t base, phys_addr_t size) > */ > int __init_memblock memblock_mark_nomap(phys_addr_t base, phys_addr_t size) > { > - return memblock_setclr_flag(base, size, 1, MEMBLOCK_NOMAP); > + return memblock_setclr_flag(base, size, 1, MEMBLOCK_NOMAP, 0); > } > > /** > @@ -989,7 +994,7 @@ int __init_memblock memblock_mark_nomap(phys_addr_t base, phys_addr_t size) > */ > int __init_memblock memblock_clear_nomap(phys_addr_t base, phys_addr_t size) > { > - return memblock_setclr_flag(base, size, 0, MEMBLOCK_NOMAP); > + return memblock_setclr_flag(base, size, 0, MEMBLOCK_NOMAP, 0); > } > > static bool should_skip_region(struct memblock_type *type, > -- > 2.25.1 > -- Sincerely yours, Mike.