From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AC09C001DE for ; Fri, 28 Jul 2023 16:34:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B24D16B0071; Fri, 28 Jul 2023 12:34:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AAD726B0074; Fri, 28 Jul 2023 12:34:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 975338D0001; Fri, 28 Jul 2023 12:34:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 87A5C6B0071 for ; Fri, 28 Jul 2023 12:34:51 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 50EF580737 for ; Fri, 28 Jul 2023 16:34:51 +0000 (UTC) X-FDA: 81061569582.03.90CBAC5 Received: from mgamail.intel.com (unknown [134.134.136.24]) by imf27.hostedemail.com (Postfix) with ESMTP id A70A74000D for ; Fri, 28 Jul 2023 16:34:48 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=KP3Qdxkv; spf=pass (imf27.hostedemail.com: domain of lkp@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690562089; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PTb34PPYJ4VzakiAiwbigcPWN4u2UU8A5RGTkCcZtjw=; b=t2kJpH67Kw9ZhnI4rO2oMwbdjaOprPhV7NECHtuJXlvGErn/gWl5hNbVUEVNNUBDbXPqIa qVV/Pj6fIJ/KcfbYop6GxBI2emYOdPMNobxucLJhS1ftmpCbS01ebncR5tAuuvwnd6KL2b zjSuIdDe01TpWFCNd7lerqBxTh99HRE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690562089; a=rsa-sha256; cv=none; b=qnCbDhDmeXGhJSDdmr8dTiOFoLTfP+c60cAgj+g2cckRo8Qk0jeX9S4X23/FakSl+K0Vvf Le0pOKE2ZgQiOJsn/smBng/ripAy+xldjrZjrpJUNvUWsk1m00AYYBsWlqWM/FfdQSzVoe 8qybBzvc0Hsr25P4l/o39QrDBgKmxd4= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=KP3Qdxkv; spf=pass (imf27.hostedemail.com: domain of lkp@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690562088; x=1722098088; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=vq0+8lK1LOBofmSZdxT7FLCHIA8ARl33ApAwAmmruzQ=; b=KP3Qdxkv7DL8Vu9C+Mo6hMRtACq26w8KBXww0IPVPrlv8fPIIrvCnh65 RYMs7G35lCIH/BBe0WUl9l2kgoaaYFdXptMMoYi6WosE7obQFvMQ+u1ON NGJjEZILrsLGUvyVJ+x0doZ0+B9cXFAVdc7006LYTZwUNzeIYVexxyx+K we3e2uYIxwkJrZ4EDdjm2kQ4TDPx2TWbI9BeJ1iH0yrLh3RfMbCVprFHZ 0xssEne6vcYlEPD2r5v6RTunyljxCj6L2lP7yfrdPQFCZj9CKFhlc/FGU y6dRQ0XQqS++vDjPWNbeBsaVPaKFwqYv7ns6cHvD6Mb1snhR/MbfYTiYp Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10784"; a="371333594" X-IronPort-AV: E=Sophos;i="6.01,238,1684825200"; d="scan'208";a="371333594" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jul 2023 09:34:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10784"; a="792985287" X-IronPort-AV: E=Sophos;i="6.01,238,1684825200"; d="scan'208";a="792985287" Received: from lkp-server02.sh.intel.com (HELO 953e8cd98f7d) ([10.239.97.151]) by fmsmga008.fm.intel.com with ESMTP; 28 Jul 2023 09:34:29 -0700 Received: from kbuild by 953e8cd98f7d with local (Exim 4.96) (envelope-from ) id 1qPQPj-0003Nr-2a; Fri, 28 Jul 2023 16:34:09 +0000 Date: Sat, 29 Jul 2023 00:33:36 +0800 From: kernel test robot To: Usama Arif , linux-mm@kvack.org, muchun.song@linux.dev, mike.kravetz@oracle.com, rppt@kernel.org Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, fam.zheng@bytedance.com, liangma@liangbit.com, simon.evans@bytedance.com, punit.agrawal@bytedance.com, Usama Arif Subject: Re: [v1 6/6] mm: hugetlb: Skip initialization of struct pages freed later by HVO Message-ID: <202307290029.Kr5EEBeY-lkp@intel.com> References: <20230727204624.1942372-7-usama.arif@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230727204624.1942372-7-usama.arif@bytedance.com> X-Rspamd-Queue-Id: A70A74000D X-Rspam-User: X-Stat-Signature: m66bcrwk11ci57yoccorqn931pnsmcd8 X-Rspamd-Server: rspam03 X-HE-Tag: 1690562088-274231 X-HE-Meta: U2FsdGVkX19LimSjXP0jVEgGjtTQtsBySxfCy36bEnSluA3s16Gvmp4g3HZ95VZ3FoqPsaI6rwdytQCYAZJL8kiFStUrJz1Ov9MUr2fXlQW5ejqISEVf6PHJ5yX0KqklJUEBdA4HTfxb4k/oBNcxnMIrWrTpImFADArovdNiqJ3HMWzeDzO19cozoVxQ5KEv89c/SV/BE7TVpPG7EU68GA1O+4yOSuOMubScut8zeOVxhFQgL044tPg4KLtyKhonH40DrD8EoW36dlxquxKvp9sRYD926BtRKDbQ9pKh31icmf6+yTH+YYAig3kP5x+uIJGq0SbErux6nurUO3q+hk2L95NkVcKdY5HXqXOlQkOiroC0mYxFz+TRWtc3pqQ7asIKiGx5rmQ/dgJE1I9gVTkp5G3z5B8iLxQ8pH68T2hSz5WUBG94UQ1tWPBOCjd5kncP7VPDanrFCrpmuhsggcmw+MAYF1IoT87gIPdMI5BoRH94Csl2rQ6AQWhuZslg0kWAkoQGQqb8xjOLXCSaTB+UGd5vVbbXmeJgPfV3S2TSTFzAOD7h3qAQKw+90zRmJ6azjcYVcW5z54YGLml7XpLhwNQKQbvAFbAYm+wV8neHes1pxDiSMdmQFj1PtN7sS6IyzlrZqAlAm4xPW/rE/eN+tJ1ge1JtlRsbZES1YqBwFMDUM/27t3lS4fDuDWzdFqMSVJ0fFK8jvZ5fhrmRZXfgbJSOOEE+ZBDW4ECRAZsA7GVQt7nHRRf7xKfYCz4INAi8kpNAH+M7xoQEVNs3qpb0lZz1JDH8eOm3FMhGKV4mTanaqOGjLWzqtae5zBoAHDObFEf4RnVD7K4TLH6NmqKNz93OAw/vHhxCxdAIhNomTYFShSozNq2THUoyMdqtCQkN2EcjzSKYSej5XxPFf7ZhX5SGUL7sVvTk09ICS/fkmeGiK9sva9rrNWIwY1oDtgcHrr5lcqBotDQkBMc nmM49WGK gf6eDWIudgqIHCHuT4spRu3s8hdTrTfwYA4aLcmwdb1Qsu0gyUQMLyGRZ3n828d70NvVZt7VUPmTwRj4A3Jmeg7RDdHC3vSr1FJDEyezB+uQhkvjHWe5MyvoelxyCp09ACL6xp82v/GQrj9foeuuF5M9ke39YniGWY8E0fHX4dnHbmPoXk9twkzvfhPbsaS14QNOUty5pV6xj8SycnM2KfWWtASKjS56oFw/9Md1PxIfY9+fDBHUgPObb1+Ox7q6/uGJqzJnrr3Eba5gnAHeHlVkcS+8LxyIIEpjmE8vMpVgcY3x0Fm+jO2fPeflZUOfp3Xu3EbrwMVOwzq6Lom9u/BLLU8caLbMnzUN9dRf44eKqY8yj99T0Nv5DID0btv5CiJ3zKqK+vYcD1jsOW113n8qD35N9kLAUoABF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Usama, kernel test robot noticed the following build warnings: [auto build test WARNING on akpm-mm/mm-everything] url: https://github.com/intel-lab-lkp/linux/commits/Usama-Arif/mm-hugetlb-Skip-prep-of-tail-pages-when-HVO-is-enabled/20230728-044839 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20230727204624.1942372-7-usama.arif%40bytedance.com patch subject: [v1 6/6] mm: hugetlb: Skip initialization of struct pages freed later by HVO config: i386-debian-10.3 (https://download.01.org/0day-ci/archive/20230729/202307290029.Kr5EEBeY-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce: (https://download.01.org/0day-ci/archive/20230729/202307290029.Kr5EEBeY-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202307290029.Kr5EEBeY-lkp@intel.com/ All warnings (new ones prefixed by >>): In file included from mm/hugetlb.c:49: mm/hugetlb_vmemmap.h:56:6: warning: no previous prototype for 'vmemmap_should_optimize' [-Wmissing-prototypes] 56 | bool vmemmap_should_optimize(const struct hstate *h, const struct page *head) | ^~~~~~~~~~~~~~~~~~~~~~~ mm/hugetlb.c: In function '__alloc_bootmem_huge_page': mm/hugetlb.c:3198:17: error: 'HUGETLB_VMEMMAP_RESERVE_SIZE' undeclared (first use in this function) 3198 | HUGETLB_VMEMMAP_RESERVE_SIZE * sizeof(struct page); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ mm/hugetlb.c:3198:17: note: each undeclared identifier is reported only once for each function it appears in >> mm/hugetlb.c:3210:42: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] 3210 | (void *)((phys_addr_t) m + hugetlb_vmemmap_reserve_size)); | ^ >> mm/hugetlb.c:3210:33: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] 3210 | (void *)((phys_addr_t) m + hugetlb_vmemmap_reserve_size)); | ^ mm/hugetlb.c:3233:42: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] 3233 | (void *)((phys_addr_t) m + hugetlb_vmemmap_reserve_size)); | ^ mm/hugetlb.c:3233:33: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] 3233 | (void *)((phys_addr_t) m + hugetlb_vmemmap_reserve_size)); | ^ vim +3210 mm/hugetlb.c 3190 3191 int alloc_bootmem_huge_page(struct hstate *h, int nid) 3192 __attribute__ ((weak, alias("__alloc_bootmem_huge_page"))); 3193 int __alloc_bootmem_huge_page(struct hstate *h, int nid) 3194 { 3195 struct huge_bootmem_page *m = NULL; /* initialize for clang */ 3196 int nr_nodes, node; 3197 phys_addr_t hugetlb_vmemmap_reserve_size = 3198 HUGETLB_VMEMMAP_RESERVE_SIZE * sizeof(struct page); 3199 phys_addr_t noinit_base; 3200 3201 /* do node specific alloc */ 3202 if (nid != NUMA_NO_NODE) { 3203 m = memblock_alloc_try_nid_raw(huge_page_size(h), huge_page_size(h), 3204 0, MEMBLOCK_ALLOC_ACCESSIBLE, nid); 3205 if (!m) 3206 return 0; 3207 3208 if (vmemmap_optimize_enabled && hugetlb_vmemmap_optimizable(h)) { 3209 noinit_base = virt_to_phys( > 3210 (void *)((phys_addr_t) m + hugetlb_vmemmap_reserve_size)); 3211 memblock_rsrv_mark_noinit( 3212 noinit_base, 3213 huge_page_size(h) - hugetlb_vmemmap_reserve_size); 3214 } 3215 3216 goto found; 3217 } 3218 /* allocate from next node when distributing huge pages */ 3219 for_each_node_mask_to_alloc(h, nr_nodes, node, &node_states[N_MEMORY]) { 3220 m = memblock_alloc_try_nid_raw( 3221 huge_page_size(h), huge_page_size(h), 3222 0, MEMBLOCK_ALLOC_ACCESSIBLE, node); 3223 /* 3224 * Use the beginning of the huge page to store the 3225 * huge_bootmem_page struct (until gather_bootmem 3226 * puts them into the mem_map). 3227 */ 3228 if (!m) 3229 return 0; 3230 3231 if (vmemmap_optimize_enabled && hugetlb_vmemmap_optimizable(h)) { 3232 noinit_base = virt_to_phys( 3233 (void *)((phys_addr_t) m + hugetlb_vmemmap_reserve_size)); 3234 memblock_rsrv_mark_noinit( 3235 noinit_base, 3236 huge_page_size(h) - hugetlb_vmemmap_reserve_size); 3237 } 3238 3239 goto found; 3240 } 3241 3242 found: 3243 /* Put them into a private list first because mem_map is not up yet */ 3244 INIT_LIST_HEAD(&m->list); 3245 list_add(&m->list, &huge_boot_pages); 3246 m->hstate = h; 3247 return 1; 3248 } 3249 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki