From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9AD9C001DE for ; Fri, 28 Jul 2023 20:35:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3F00C8D0008; Fri, 28 Jul 2023 16:34:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 393778D000B; Fri, 28 Jul 2023 16:34:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 02EF18D0008; Fri, 28 Jul 2023 16:34:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D27C18D0009 for ; Fri, 28 Jul 2023 16:34:56 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A580980771 for ; Fri, 28 Jul 2023 20:34:56 +0000 (UTC) X-FDA: 81062174592.23.4D656B3 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf19.hostedemail.com (Postfix) with ESMTP id DD6DE1A0015 for ; Fri, 28 Jul 2023 20:34:54 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=YrOFSGFN; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf19.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690576495; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hHpclYYfcFMIQd/3SqHzyTRgnAlb9aEAxJFCK7Cjch4=; b=mGfAujv6GDePWyj2q657IuozgwA4V42L/R3f+manOZwOA0VTVAy+lh3T6sb1/FnkJ7SlXx IdNwgmIBlbUa94zQv1DJkDGdFND0xrm2LVuVk077bIUEbDZAhg79IQSq2qtIuFW/zcjQFQ MBNBQ4bHWPPH9MahJ/XsI4IIjAjHuHY= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=YrOFSGFN; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf19.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690576495; a=rsa-sha256; cv=none; b=nMCp3N7TsflGKEzoQVOAt3FagNigSeVCuDHyTYcojgF/FC1CTD+65G/t3ODbUt8KrUb2oH wFeLhryNZaN8n9F4EOGlsuVzn7tuMbk+5NannHiksAVmvk5dzuTodMg2LZZmlf0OorKz+K hl/j+hfPrfcE/bFRcF+0ppuMM9mHoUE= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9C3106220A; Fri, 28 Jul 2023 20:34:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A610AC433C9; Fri, 28 Jul 2023 20:34:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690576494; bh=lBNvXKzEBU9SpXm5U6wWrF6OxTFy+UZXhLu/dKriIQI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YrOFSGFNnrBc5Reg0+yJCBH7k9bWeWBT5Gq+TF4ipLVskyigsxce3viD7Y6iwy+S/ whBMJQI/svZuVbpeKEWFPGGOlDIiJ1yfXFd9TBr57ujIvjkA9LgLV0wAppx2r9Xt0K 3BdjuxLZa+l5OQTbe2UyHjBtMo0AYThLHmfBix6+VAbWj3e05tx9OkPH5QN0LcENxS 8msdjvmyMmwUNx//uRUz0LW6+dyERhdC6rb4ilktALtVGfP7mVHc1IcgSkbHlxDai0 zrFGFjGmYl8Nx8x2urnvKcX+I5dNy/iSIC/E6qe8SBndPORNPboomgqV2t0rO/e9Jn blzDGsBDvqg9w== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [RFC PATCH 08/13] mm/damon/core: implement target type damos filter Date: Fri, 28 Jul 2023 20:34:39 +0000 Message-Id: <20230728203444.70703-9-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230728203444.70703-1-sj@kernel.org> References: <20230728203444.70703-1-sj@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: DD6DE1A0015 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: j8udx44q19sio9gr5z85hwhrf9e4gfrz X-HE-Tag: 1690576494-173339 X-HE-Meta: U2FsdGVkX19cV3t33Lhasbto/7EmGwZNMoSUaxVswgF+Y1RZpqxiGgFvtbbn35zIadrTnGT98ZA2uEDqJKvAprhPAwgbySps/NWN7cVWMLyP0t8aE3V1CA6DtZg26Y6c90Z5H78sFXTI8R8H3PbxjpPX+EADIP6ZlXvLAvHd/UqFf4LkrwjYM2mBbSVxJjMNWZwSgKMYk89N3dUwIx96wSHkALzUlNI36fiCB7GhrtYrJUqEEdg3fL6VjAbiRNASMAHJp5G1uwHY43waGqpQqwqpi15Uy8haPf+EIhJvZNuvoi0KSTIYPMnW9doj7d1lyqQ3qKQIrVnkRak1rCwgB7Ih64ZgQqBX7AE+xATlAiCrVhAH0zQHFJDzIj08ZV827bGJaymbM3fte0h78BH9MF80RD7uxo0bnJ0EKfrUKoVYW+iF0uGRWE9eckCjjiRKH3HfnavBzC6EY4Fv2C4F7+HInfa3vbdQlF/dyZFD5n4qKlQvkBdzmxvDOTSL949GClFshsrYK5+Drgc/2cQWQb5oz5lkw4dAYSjEasYgekqBFYAFm+A+OM/2FX4WkgDu/D35LeEXeODGsbra8fxiJYynAtR8OuvyE5aYoTpKlaJdGZOgoMBAYo4pRch/g8iIm0KhXzm7yJ6L0k89uo5nGGn1dsF9JzcRAaYJfr9V00DurE9DCtw4vi1U+jyQ4kKwee+0/RWNwe3zwYmnaoK4IpsPAMCQNUApFmfUAqK5VRoeZ1H3YTRBDdbxEexJWXW5W+tF3ZheMVDDnEtI9k9OJn0aJeLwyf45qEhfcwo61G4I49Ho3j/TSnFz3HJnJElF2vL0rfSt2k25FDg7O/K01SPUUNjI7GdZ1RFVLjZ2H+2vE3rGe64bd2UPps2iIoITB36eqwtacmgg9SCXBkUqM5q5P/Uvy9NzDUWidaJcgf3WmIUPdvWE52C98PmksuUrmw8xcORAKCIqwN7ebB5 fFuC/c0v EPOk1qW5F4/lPqMFQDpvpc+8QfxeesPCR9qhKqc2pLGUQgXsAPLzZIiT/tiW1kFE5jWhisQAFQpwBR0l7e6HrEoa9+mfDCVSvNL96NmiTGK1Xtu3b5uGhQUZgr85R0WkfbsHV3o18XEtGE0lIEowtWL/1yoY6h1ezPjh7w6Ho6R9sH4hBLEMq3tEN7lJTiYS/EXLrhXKC8QtFH1gqrDZ3bqQwkCBqrx9ZR8WLDcM+6Jyea54T8d2QwbmQZqyTA5X0k3FbB7u2RXOj91xp54szIgRmx66/M//Fu3W5U91+y6wLHT3i6sC/ZOcTKMV78/VNaSuHb3S7EyAnNfoxeLkzRki5Uw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: One DAMON context can have multiple monitoring targets, and DAMOS schemes are applied to all targets. In some cases, users need to apply different scheme to different targets. Retrieving monitoring results via DAMON sysfs interface' 'tried_regions' directory could be one good example. Also, there could be cases that cgroup DAMOS filter is not enough. All such use cases can be worked around by having multiple DAMON contexts having only single target, but it is inefficient in terms of resource usage, thogh the overhead is not estimated to be huge. Implement DAMON monitoring target based DAMOS filter for the case. Like address range target DAMOS filter, handle these filters in the DAMON core layer, since it is more efficient than doing in operations set layer. This also means that regions that filtered out by monitoring target type DAMOS filters are counted as not tried by the scheme. Hence, target granularity monitoring results retrieval via DAMON sysfs interface becomes available. Signed-off-by: SeongJae Park --- include/linux/damon.h | 6 ++++++ mm/damon/core.c | 22 ++++++++++++++++------ 2 files changed, 22 insertions(+), 6 deletions(-) diff --git a/include/linux/damon.h b/include/linux/damon.h index 476f37a883a4..ae2664d1d5f1 100644 --- a/include/linux/damon.h +++ b/include/linux/damon.h @@ -227,6 +227,7 @@ struct damos_stat { * @DAMOS_FILTER_TYPE_ANON: Anonymous pages. * @DAMOS_FILTER_TYPE_MEMCG: Specific memcg's pages. * @DAMOS_FILTER_TYPE_ADDR: Address range. + * @DAMOS_FILTER_TYPE_TARGET: Data Access Monitoring target. * @NR_DAMOS_FILTER_TYPES: Number of filter types. * * The anon pages type and memcg type filters are handled by underlying @@ -244,6 +245,7 @@ enum damos_filter_type { DAMOS_FILTER_TYPE_ANON, DAMOS_FILTER_TYPE_MEMCG, DAMOS_FILTER_TYPE_ADDR, + DAMOS_FILTER_TYPE_TARGET, NR_DAMOS_FILTER_TYPES, }; @@ -253,6 +255,9 @@ enum damos_filter_type { * @matching: If the matching page should filtered out or in. * @memcg_id: Memcg id of the question if @type is DAMOS_FILTER_MEMCG. * @addr_range: Address range if @type is DAMOS_FILTER_TYPE_ADDR. + * @target_idx: Index of the &struct damon_target of + * &damon_ctx->adaptive_targets if @type is + * DAMOS_FILTER_TYPE_TARGET. * @list: List head for siblings. * * Before applying the &damos->action to a memory region, DAMOS checks if each @@ -266,6 +271,7 @@ struct damos_filter { union { unsigned short memcg_id; struct damon_addr_range addr_range; + int target_idx; }; struct list_head list; }; diff --git a/mm/damon/core.c b/mm/damon/core.c index c061d289c832..334bc5823d83 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -906,13 +906,23 @@ static void damos_update_stat(struct damos *s, s->stat.sz_applied += sz_applied; } -static bool __damos_filter_out(struct damon_target *t, struct damon_region *r, - struct damos_filter *filter) +static bool __damos_filter_out(struct damon_ctx *ctx, struct damon_target *t, + struct damon_region *r, struct damos_filter *filter) { bool matched = false; + struct damon_target *ti; + int target_idx = 0; unsigned long start, end; switch (filter->type) { + case DAMOS_FILTER_TYPE_TARGET: + damon_for_each_target(ti, ctx) { + if (ti == t) + break; + target_idx++; + } + matched = target_idx == filter->target_idx; + break; case DAMOS_FILTER_TYPE_ADDR: start = ALIGN_DOWN(filter->addr_range.start, DAMON_MIN_REGION); end = ALIGN_DOWN(filter->addr_range.end, DAMON_MIN_REGION); @@ -944,13 +954,13 @@ static bool __damos_filter_out(struct damon_target *t, struct damon_region *r, return matched == filter->matching; } -static bool damos_filter_out(struct damon_target *t, struct damon_region *r, - struct damos *s) +static bool damos_filter_out(struct damon_ctx *ctx, struct damon_target *t, + struct damon_region *r, struct damos *s) { struct damos_filter *filter; damos_for_each_filter(filter, s) { - if (__damos_filter_out(t, r, filter)) + if (__damos_filter_out(ctx, t, r, filter)) return true; } return false; @@ -982,7 +992,7 @@ static void damos_apply_scheme(struct damon_ctx *c, struct damon_target *t, } damon_split_region_at(t, r, sz); } - if (damos_filter_out(t, r, s)) + if (damos_filter_out(c, t, r, s)) return; ktime_get_coarse_ts64(&begin); if (c->callback.before_damos_apply) -- 2.25.1