From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86FAEC04FDF for ; Fri, 28 Jul 2023 15:36:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D423B8D0002; Fri, 28 Jul 2023 11:36:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CF20E6B0074; Fri, 28 Jul 2023 11:36:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B92BE8D0002; Fri, 28 Jul 2023 11:36:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A75E76B0071 for ; Fri, 28 Jul 2023 11:36:09 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 23C441A0753 for ; Fri, 28 Jul 2023 15:36:09 +0000 (UTC) X-FDA: 81061421658.15.4AE4C91 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf03.hostedemail.com (Postfix) with ESMTP id 330C220021 for ; Fri, 28 Jul 2023 15:36:06 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=p5Tu2hgT; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf03.hostedemail.com: domain of jpoimboe@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jpoimboe@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690558567; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mKbbS2x69AA4YcJ80Po3sbN43GvTzRqTYvI5Phy4cRk=; b=3DlQ1ltt5dyANCypdmckYyE94dAG/63TsxUn/wCEwNEUBL6tLSn/Tb8zNrmD0K7aP5zi+7 5lzzyOmH78spaSxsIWMKvC66RFk3KyGRlEbdcD2oZtVxMKMMJsrHKvZMl9HHw0wXRKbaSP vNij4+GmK2npMKjhP31E2OLnLQRxzFY= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=p5Tu2hgT; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf03.hostedemail.com: domain of jpoimboe@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jpoimboe@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690558567; a=rsa-sha256; cv=none; b=sYkiv9LM2lgb9IG598Iy+G/u7mXzSBThhfmwBFMgWr8ltUhDa1icxrT9eceUxXD/BRx+KU VZ3e7ZoRvU5KCF87IZfRT+EEtvXRDLYXvk3G0w5ZLdxDYvqAQiWhjtsY1nfaDMAq1NHfvA nWt9kLvtcWqZPm/mMAVRo2eZUOsCop8= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 117FA6217E; Fri, 28 Jul 2023 15:36:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5F875C433D9; Fri, 28 Jul 2023 15:35:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690558565; bh=RiameAJyaqASlv6hb4c10KMAlN4/6+6/hqnDkYkEzPY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=p5Tu2hgT+a6gPKQMW1urJHIGxB0ZTZOTtxLFvSij1f/yjSQQyTa3zf0mqdYayXPmV iccIrLhwD4QgY1Nagc4saDTCQBBcQAV3RcD1m6I2F1ForGzrpqfl32G6a840/Taa7m jAW0KefOuBEpEOxh9v1oNKyA0vJvkBsDdk4UOR1d8fmxbhTXNBN479coNCzX9EKVkf g7e48OjBzRhIJ1ioN6rN2lAkY9uA3PrFeg93sId02DNN6tLC0glfzPl7gZYl7gg3Gu 4sC+6Du26Ly24TZAb5B0eOcNMIwGZbynuoLApCVvleEIQpqXqssPsuv7UECOCOrQMQ 03M7Kq16bokjw== Date: Fri, 28 Jul 2023 10:35:57 -0500 From: Josh Poimboeuf To: Valentin Schneider Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, x86@kernel.org, rcu@vger.kernel.org, linux-kselftest@vger.kernel.org, Josh Poimboeuf , Steven Rostedt , Masami Hiramatsu , Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Andy Lutomirski , Peter Zijlstra , Frederic Weisbecker , "Paul E. McKenney" , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Boqun Feng , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , Jason Baron , Kees Cook , Sami Tolvanen , Ard Biesheuvel , Nicholas Piggin , Juerg Haefliger , Nicolas Saenz Julienne , "Kirill A. Shutemov" , Nadav Amit , Dan Carpenter , Chuang Wang , Yang Jihong , Petr Mladek , "Jason A. Donenfeld" , Song Liu , Julian Pidancet , Tom Lendacky , Dionna Glaze , Thomas =?utf-8?Q?Wei=C3=9Fschuh?= , Juri Lelli , Daniel Bristot de Oliveira , Marcelo Tosatti , Yair Podemsky Subject: Re: [RFC PATCH v2 12/20] objtool: Warn about non __ro_after_init static key usage in .noinstr Message-ID: <20230728153557.frzmaayyy3auibx3@treble> References: <20230720163056.2564824-1-vschneid@redhat.com> <20230720163056.2564824-13-vschneid@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230720163056.2564824-13-vschneid@redhat.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 330C220021 X-Stat-Signature: xf6fue36p47j91cyx8be7pbkuwku1c36 X-Rspam-User: X-HE-Tag: 1690558566-950425 X-HE-Meta: U2FsdGVkX197wKEn0+yWYyOaIh17PGbTJa3vVa6dCBixS1x5uAiDRD7/4OGt7WuLRY+Mjp5LDw8Ibeuhtr+7DIxiDKyZqRUzXi1lSeK32unFJZGqRvPHJ7T4WwCwuQ0pmar9Yr14mSlE6PIi2nIt0HvAIWCQBmrvRVz4IeIH+V2O3OcVGhvkv9E1J6Jrl0ob90lZaAxLZTTyPFJhvOiC8oHI+jDwfPHmtXugNYggYuKdgNG9+Hbmxp+a8ky3haSFU69MovuWGtKNX7KKHCTj05+qtS7vWnt/2KM/wbnBfNG9BrY9OOVs2A8ZiN7O3qE6M9CuSsgUNx8mwVYARAOqIORCo9ntvvTnNX9aorRUsEFNiK8TUQlHm0TVwgolH3M2Fxr3eEgBbOz1RgCosz3xZFNZ1gq1IrN68Qcd3tfw7bmjD6EWhFd2ucPBmRLgYlI+QilyCG/s9raHg16QUj38JpWuQ5kFXK1xPV05bGq02QEBOuW6E+7AuAZ+G2KHqYEBAb0SywEKqWt5HM70amgTkQgwh5ri5E4v1IpykG95FRKn+soB56ouul9dundUnBwYc/8ygWH/GqI4BYSbWnlucXIEyYYs1UhCgkE2jkKrRnPm+EEArBeP4B6nEeS3+GO34BkvNDebJWE8XK7DY8f9fj+KW6/sLg59oq6d1TggDavKOOIrMY37ctQuXENGSDuRK03AY+ZVygEcmHe95EdX/QX1Q/jsWD/r2OMyhwJVCpQ8lZSe0+qICX/sBXuvIOzmrkaxl2igow8Nxs8BapAdyMxVrPWjfqIjsihYnNSv9umCQoWxphEMP+6iOWx5gsgvjdVjCM6O4w6ySqYvqlfpN9QCSP9/2dtwVVd0NWtzGEbr0ChgBhyikogA/frmYAfAm1iyQ/Bcy7jmj61+kM3zhGvbc3c2T+IbqtBr2o7XAOjOFOLo037RMOq6P4x/8iikam6B51JKpufDFf1osrJ n8DPwOy6 SuaA09wLYVw2bgJUR3mNQbtwpUqZp9sli9FWWHTDXysNBrMZ31okZ8/NPmbDyHDb79k+ZDkWvrAVt6bdldj4taYxSZlHl/aNkzKJ4mw2Crz0akIb/mZU6tbSBSsVN7DV+LPW2OaYy1Z2IRetWatvffdG/makE7qcVNIQRWz81daMm1yLoWsSbbrrdPzVzOymr9tUy8HR+Zz0gXueDUZWrGGutJuhi5QFz+My9pBEQXO+6e8NLEGlftaZJd0Ldzl7ri5EbEwDO/g2jTdtLJOVXOaIREDxkcSRepsb3eNYrlQ5bJPAmt3flIbQrZJrpOo7qatwGKLNnoW5IjUDrFXKcjJ+aGjNpsd11eOhswuyJoMof/IrYyt7OQLp6HVcD+c48x/B4JI6YNQUvVTdxEU9uwNbSOg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 20, 2023 at 05:30:48PM +0100, Valentin Schneider wrote: > +static int validate_static_key(struct instruction *insn, struct insn_state *state) > +{ > + if (state->noinstr && state->instr <= 0) { > + if ((strcmp(insn->key_sym->sec->name, ".data..ro_after_init"))) { > + WARN_INSN(insn, > + "Non __ro_after_init static key \"%s\" in .noinstr section", For consistency with other warnings, this should start with a lowercase "n" and the string literal should be on the same line as the WARN_INSN, like WARN_INSN(insn, "non __ro_after_init static key \"%s\" in .noinstr section", ... > diff --git a/tools/objtool/special.c b/tools/objtool/special.c > index 91b1950f5bd8a..1f76cfd815bf3 100644 > --- a/tools/objtool/special.c > +++ b/tools/objtool/special.c > @@ -127,6 +127,9 @@ static int get_alt_entry(struct elf *elf, const struct special_entry *entry, > return -1; > } > alt->key_addend = reloc_addend(key_reloc); > + > + reloc_to_sec_off(key_reloc, &sec, &offset); > + alt->key_sym = find_symbol_by_offset(sec, offset & ~2); Bits 0 and 1 can both store data, should be ~3? -- Josh