From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC1C8C001DE for ; Fri, 28 Jul 2023 15:33:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E04678D0001; Fri, 28 Jul 2023 11:33:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D8DCC6B0074; Fri, 28 Jul 2023 11:33:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C06F38D0001; Fri, 28 Jul 2023 11:33:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id AEB476B0071 for ; Fri, 28 Jul 2023 11:33:48 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5BB95B1912 for ; Fri, 28 Jul 2023 15:33:48 +0000 (UTC) X-FDA: 81061415736.13.7C55B11 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf06.hostedemail.com (Postfix) with ESMTP id 7CB99180013 for ; Fri, 28 Jul 2023 15:33:46 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AD2p4MRx; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf06.hostedemail.com: domain of jpoimboe@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jpoimboe@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690558426; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tbRuuicCTVua6QIP5mIymL3++5dLnPccEGP2OFwtlVY=; b=EIENbR+4/rVxwYZkzLAr7Gtcs+Qz+2sRra0zcmJ0egW4y8y9nA3oNBITtsFMw5nVJo32i5 /6c3LohyX2EPNScANtqIaT7vNeskXox9maVSY5RLjkEnwaVuMfU4qh/pUdVjAaZkJYJ4m7 5L+yubEpU5u7R23IcsehYXIrfAT1zJM= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AD2p4MRx; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf06.hostedemail.com: domain of jpoimboe@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jpoimboe@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690558426; a=rsa-sha256; cv=none; b=CYnt4s0d7KfHVafwG/E5fZxuE2n+r5pCjfWr0x6LiCsAufi6/IE3EAXLgLhidA+JwYehu8 i0pBGHUOP+85vi1rGQIrvJuS08hLH2sg4sogghQOnOhBvz7LXX6SFDzYKp1RZ8+WWnq1us NjElYkvZ5LfJwNhmZFe+T+4Vnz0oouU= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7D15E62184; Fri, 28 Jul 2023 15:33:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D81C5C433C8; Fri, 28 Jul 2023 15:33:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690558424; bh=oINpRshoP8wUOrW0KrHyosEeCy6vm0dPU8gi9b4Apus=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AD2p4MRxVbTJMornW4rtnlVVyLtsVamKFOjKM/YtSATmK7lMhlOFDtRA8/G9pwgAF 1sWs1sWg4F/hukZR/JU7U6+l+wo+TWOewD4I0cwarQlOh0aRJ5NoYtpqB65I1MoNkZ 9eZ9o3jYY3UHmKnV1fAXG/Wsu+xLSUGP3fwhMzmUZYsiirR4cz2f0g0qO5oPqupzrV KVK6uhTCxPtxrv7b6kTCNn/0LI+haKYLBtnoLaTW2+Afw76EKbl/pDrq9Nr7zzTHx3 98waSBKvQ5Se6QKIDWgXNStJwQxe0LwKr5KRFMdIy2JGzu/oByxmUdnBja60W0N9t0 bBsDZIkwNMEcg== Date: Fri, 28 Jul 2023 10:33:34 -0500 From: Josh Poimboeuf To: Valentin Schneider Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, x86@kernel.org, rcu@vger.kernel.org, linux-kselftest@vger.kernel.org, Steven Rostedt , Masami Hiramatsu , Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Andy Lutomirski , Peter Zijlstra , Frederic Weisbecker , "Paul E. McKenney" , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Boqun Feng , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , Jason Baron , Kees Cook , Sami Tolvanen , Ard Biesheuvel , Nicholas Piggin , Juerg Haefliger , Nicolas Saenz Julienne , "Kirill A. Shutemov" , Nadav Amit , Dan Carpenter , Chuang Wang , Yang Jihong , Petr Mladek , "Jason A. Donenfeld" , Song Liu , Julian Pidancet , Tom Lendacky , Dionna Glaze , Thomas =?utf-8?Q?Wei=C3=9Fschuh?= , Juri Lelli , Daniel Bristot de Oliveira , Marcelo Tosatti , Yair Podemsky Subject: Re: [RFC PATCH v2 11/20] objtool: Flesh out warning related to pv_ops[] calls Message-ID: <20230728153334.myvh5sxppvjzd3oz@treble> References: <20230720163056.2564824-1-vschneid@redhat.com> <20230720163056.2564824-12-vschneid@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230720163056.2564824-12-vschneid@redhat.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 7CB99180013 X-Stat-Signature: i9w4wdbcsbyiyw7dyjeddz5mrgykfuk8 X-HE-Tag: 1690558426-821026 X-HE-Meta: U2FsdGVkX19Xz6GRwAXReieMlffbkwe0u1EaMj7EG6HnS3+JvXCQQ6t2B9uult4AGaQpIbt7O/R4lpyKTVdj0lJ5eIeUx68rkUm/VPrHcLm68ujhwZm9UKPGVCbDrESHM/8hJpjg7ZNgQXcBc6UGRxM6sXtBB9MWw/nbOTdMyIn/cgux+EV+yjLb02aoxH3a6LNMzQqnnXhwa0/oaBWF8iJZZQUb1LazwV9EnywiF0w4QqGCwnQ/gcoxgkUyHHQDOraO7DXq6RUofPfB5qNaW8EQhp0O8QUCBO6uaI6N3bTi6b/n67nV1BHI7fy/Ixjfd0OhdWERrFJIboJpTegJVN5XbX65ld6VQ+iRuq8gcdG8bgSE708SeiTYuoZMXldS4W0sAiRaJRv8+tgY7NCNbXt2/HocEocnPk8YEQ5IiPWbWqy7xfjLPIshzaQGmOCwe/ohshLl3qDK97YdijtEiHjh9CLHheF1pznrzBUl5DB5KpZADMHQah5V9SwmoOPBq65thSAditn0t91UuGCgNQpwqxkP4waBccs7BXpatgfEDEz8dfu1d6Z7iww7SHnyMnO+4vz6zPsm0odjI/cWUaXEtQC5lXQPcNhIP1hUnp27AnKx54wNPsRYTSxVeODY+fWQS52IVFLVYt0x/l8M4FxAdrrbTOD8seF4UMjUwA2yKUGHbNnlQnFp9t9XsHJ6WYzwRJdD9RhTQHJmBiK8UZRWO+88Ai7HvPbqm0APtCGJO6mH6cw+/qZveZr7ejrau1u/feMFny6RkqJJoodkZWVgsm/jdYN8xv+PN/iwZ5rRXp0wAPs3ittFZsyEQC5hFiVrVA4bhf05wB+YYNhaehRa26irwcvozyH8F/qUV+pyxN+Ai4ErnMxmXja+QJdNsxNglmSb48H1HvXYBgafJqhrTyOPlEkW4fZOy8smJPG5Rv7f0oBOeq6Q7qhGuT7plbpNExFHlbQ1bggFVk0 lyh4kirW RpU4wVkOvjk0F7uNI5IsUS9YSUupQpCBjNMXWLOl5a39JFULJYhptCYv4xHGVaBRrTuxRZ9U5g9ZOgMDtz5TDQ14RBJG+9La1lnnYEMo2LvMVJe7J+XcuDfgYiNzY3EeMAq++EnjEcCshf4fCaU59iMYI9Q/CrtUTgvT9z+MmApp4oqfEzr+/171alsXZHbJ7/pKE6El89gpi+gPOTRwhmo8HY9osuovhowu4Fa6O2Gupmcyor3iT/YzyNIZHaEqxqQPPsBRuOY1qgRz+UtvXWmf29Kza/tEmy+cdApAK5derxJ/SDdNGzyRUQOoQyxRjSZneXFxw/VjUAVy7iwGBKp/3XytVVLIaIv1cj1ZqOzZ+sPmvV/yV6KzwGG2C3VZm85GKBq6fbmQ7S3ma+mYhuoPN9HRDUJFJ+M8ytxeczPN5dzc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 20, 2023 at 05:30:47PM +0100, Valentin Schneider wrote: > I had to look into objtool itself to understand what this warning was > about; make it more explicit. > > Signed-off-by: Valentin Schneider > --- > tools/objtool/check.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/objtool/check.c b/tools/objtool/check.c > index 8936a05f0e5ac..d308330f2910e 100644 > --- a/tools/objtool/check.c > +++ b/tools/objtool/check.c > @@ -3360,7 +3360,7 @@ static bool pv_call_dest(struct objtool_file *file, struct instruction *insn) > > list_for_each_entry(target, &file->pv_ops[idx].targets, pv_target) { > if (!target->sec->noinstr) { > - WARN("pv_ops[%d]: %s", idx, target->name); > + WARN("pv_ops[%d]: indirect call to %s() leaves .noinstr.text section", idx, target->name); > file->pv_ops[idx].clean = false; This is an improvement, though I think it still results in two warnings, with the second not-so-useful warning happening in validate_call(). Ideally it would only show a single warning, I guess that would need a little bit of restructuring the code. -- Josh