From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 545A1C001E0 for ; Fri, 28 Jul 2023 17:41:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B2BFD6B0075; Fri, 28 Jul 2023 13:41:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ADBCC6B0078; Fri, 28 Jul 2023 13:41:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9CA798D0001; Fri, 28 Jul 2023 13:41:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 90BC16B0075 for ; Fri, 28 Jul 2023 13:41:10 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 59E9B1C96AA for ; Fri, 28 Jul 2023 17:41:10 +0000 (UTC) X-FDA: 81061736700.06.4FF40F8 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf21.hostedemail.com (Postfix) with ESMTP id 270B01C0005 for ; Fri, 28 Jul 2023 17:41:06 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=L1PBr6Tc; spf=pass (imf21.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690566067; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9DPcgcn7pzaeyR23aOkzMKbj+QF+0Iy5kf7XOtyyU1Y=; b=VlWdgYCvdGHZ2nrNy6s6wAmfhyDfhEJIMNdSiWkSyL2H8F2guMfOswf0cBa1NJ6Nk9wBy+ qAk3tBENnaVzabDakh+MJgzHnx/Uko7clfOb7IhI/0Ly1q4sf8qtcnX4MdhcudW9NQnpZ+ K+TZM63qVPhaX9ZE4eRPhGdeD7k75cw= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=L1PBr6Tc; spf=pass (imf21.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690566067; a=rsa-sha256; cv=none; b=QsFeEJBp70TeDiLTh75qZLw2IWuYT4IiBxoi5qpEUJSkdWOUoQz4U3MzPVxFg3pxY9VWQ4 /JSZaFc74TdWHZk4QaLkCOxzRn4APYYb7LBZAoLOpDnmbai07/0NsHExA1MIkzKwj7/+UQ ooYfYU+N09IrKUG0kSfh2imJvPT9y3k= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CB996621B9; Fri, 28 Jul 2023 17:41:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BC7C8C433C8; Fri, 28 Jul 2023 17:41:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1690566065; bh=9DPcgcn7pzaeyR23aOkzMKbj+QF+0Iy5kf7XOtyyU1Y=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=L1PBr6Tcnx3CaNQEzImZCiiC8GGuMXX0uCH/dKs0aevRVD6d5JIu6YMxG+VYk+KCZ WVk2deNn3J0NjN2Fq5eR6pBv5NTHGQv74VdNC900ARvpokqXhRTa1hlYR5Fx0p0OdZ 2TzU7RRdMzMlUG7kOF8e/GG1Udvzh0bEMGtaGvbE= Date: Fri, 28 Jul 2023 10:41:03 -0700 From: Andrew Morton To: Yin Fengwei Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, willy@infradead.org, vishal.moola@gmail.com, wangkefeng.wang@huawei.com, minchan@kernel.org, yuzhao@google.com, david@redhat.com, ryan.roberts@arm.com, shy828301@gmail.com Subject: Re: [PATCH 2/2] madvise: don't use mapcount() against large folio for sharing check Message-Id: <20230728104103.1357b394f9be6352a7c54c79@linux-foundation.org> In-Reply-To: <20230728161356.1784568-3-fengwei.yin@intel.com> References: <20230728161356.1784568-1-fengwei.yin@intel.com> <20230728161356.1784568-3-fengwei.yin@intel.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 270B01C0005 X-Rspam-User: X-Stat-Signature: 6gh3ajdit4rrd8by3osdgwb1obky9wim X-Rspamd-Server: rspam01 X-HE-Tag: 1690566066-464901 X-HE-Meta: U2FsdGVkX18w1CvDQU8/8NwvqkiHiqSOYdXtZy+IJsgS8i/zoYshkQ22VfVJgE2c+jN3oHuMJihH3+UlXLnf8ig4GihjSpDZJeT4OtKLzUkQ5Dja739y9x6xqAOVs11QMicpaaakFwJI/F65WI+6U1u1O1kq0iL33YfYNW9KLo53lqjQTJ+pJUkDxfzxW8T6x7aGPgsc2f6f2e36ya2Gv6K1PR+s50pRjnBc45VDX9FJAw7baNxh/Mq4axJ9gQ/Xsao1r3GvNfScGQyWGHbujgfux83JNaPY8nlk6GR+exmubhnCcqcUDizB44aRIQQDl3/hxwBYG/02WZw4kGtwPQqS14S1P2q0jNkVPy8FdMghjU/KRQ2kWiwqH5fVzBkJgG1QASMcW/0uLAfkiJ00VczW/C6kcglCPBxEws/NHc4ydxsBy6z2DwPWiZfVtPJ+qSd+cY2EjqdnRftvTlXqyYsRuFODjWpse5CYLqXuBXOocl31o7fG28hjfXccTtNly6JMagHBjVGpo+bwl4wueDdj1vufLB6SyvwCU72r8N8WrUrbe9ho+NDuTDWLmcd/jR5MCfoH6TeTvVQ8L8+puxRo+ysBJpofgb0XYhWdgXPGbEgdD5/OBvxOA2IUI6F9wpZJuBUBk5m+NzgAG2TCQI/ewkATt5r0BVc1D3xHZ2BSZBUIYR7sycHgSMifBdnwMx4aYt3Gcoq9H5FL0psIq13LstT0ui6sB7ov9IfGm+6K6Rjg2V6j1NcZunzy7mLytbLYFWAX03bqYtenEE7DW7H4/e07fo7fgtPFUovIp+/S2y3nfjMSxdPqhmiI7CWhtsg9i1JhIgYubO8qLnXAITUQ7uOSV/KTkolG1Kw/cxvEQqFRV3sxGwS9zeqiQTqJzaprdgkA2Zy7zYxPNLO0Va3FeKXnkn4Pyc82Z3xpQNsAZC0lWTejX8czGvXaIqz3TF0HGaJgiTeP+vVJQgQ MDojkM23 CBXJUdyKfDAeyJ3MqzqoDr1cJHiN1K7BN9lqdwu2FmvB743ticLDJ8rjXImaAOUS3lFyB9qw8a6O5ASeo7s6zKB+Cjj9he9utjpgPD1O0V52LWyoA0yqlCpnUNOGBe3gqt7HNLo+conVeGe1Kr8hgyaHfIK3rpWWD/RGDqrNWP+e9dQP8nfyQHTZBmqONft/bt0x1vgAJM8b1oC7mVT54PwCsN5Suv1/vU7hJl/oIJd2PjHoDlBDOtevPTypeOO7/owLoLLCRTWGA7+RoHrSefSCdNsYzyFqQ7UboYfy/g/2NvTmfLVFF+HEud4L7XtxeKJm/lDhTWOUplKy2ED87LE+uGIxm2hHjxBMy7rQalSQ3a02hwR5Fhy9QPcpNYUbIXm2lohxaaQzDA3ynk2zo02F+jr+bl2MXNPk7DwfNj4NUYPA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 29 Jul 2023 00:13:56 +0800 Yin Fengwei wrote: > Fixes: 98b211d6415f ("madvise: convert madvise_free_pte_range() to use a folio") > Fixes: fc986a38b670 ("mm: huge_memory: convert madvise_free_huge_pmd to use a folio") Having two Fixes: for one patch presumably makes backporting more complicated and adds risk of making mistakes. So I have split this into a three-patch series and I've fixed up the patch naming: Subject: madvise:madvise_cold_or_pageout_pte_range(): don't use mapcount() against large folio for sharing check Subject: madvise:madvise_free_huge_pmd(): don't use mapcount() against large folio for sharing check Subject: madvise:madvise_free_pte_range(): don't use mapcount() against large folio for sharing check I haven't added cc:stable at this time - that awaits the description of user-visible effects.