From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A883C0015E for ; Fri, 28 Jul 2023 17:24:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E2DDF8D0001; Fri, 28 Jul 2023 13:24:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DDEAE6B0074; Fri, 28 Jul 2023 13:24:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CCCA68D0001; Fri, 28 Jul 2023 13:24:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BE5806B0071 for ; Fri, 28 Jul 2023 13:24:10 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 909A2C06E9 for ; Fri, 28 Jul 2023 17:24:10 +0000 (UTC) X-FDA: 81061693860.10.CB482D0 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf01.hostedemail.com (Postfix) with ESMTP id BA5E340005 for ; Fri, 28 Jul 2023 17:24:08 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=sFJd3MIM; dmarc=none; spf=pass (imf01.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690565048; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1Vn7EagwvnZC/6DsA0lLEWURim5/xyyY2j2ujBJgwpk=; b=ES0CTLPqbGmxF5e0opF+I9v5Ln9rbjXPKzbecNu2yhKl+uU1XpKgUa1AJo39H62MHgWLZA jLl/ggzhBEpnZLK0JIxKJlkqFjPXsTmOoqNtv3E6C/VgVbRLbr1UWQKnWxgnLC4nxoxtCs FZ80gRmaWQBfcbRHnhU5S/dT4SCANzQ= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=sFJd3MIM; dmarc=none; spf=pass (imf01.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690565048; a=rsa-sha256; cv=none; b=vfpVOMeuFkqepNK8eIhLSOqy8Ultb6foJwgbIPEsxlBkFVHJfAiWezuuXd5WWOUW6IyNCH pRIywLATVH/k6opdoKqnuqysHuzthckno6BgpbTMXtQH+ugi8f18GrU+mcg2MPNn6mrAPe HSoexSTCSYgFgup94nfqwIRlMzeyalI= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B4027621A5; Fri, 28 Jul 2023 17:24:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9BC92C433C9; Fri, 28 Jul 2023 17:24:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1690565047; bh=F8PyAvW7AlD89TIBCGrOIiLigKuhVWKEHS84huiz2HA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=sFJd3MIMmW6vuBJv2YzUTpDJnSy3XvPNyIJCTyTWM+hJHpTqSR2u6vpmUp+fzAGNr v/UuYxprIai3L+04NHsC7FO0ulr8pk5uMzz243gYipF9/I7AP7yOzkkTvmevmExjgW FUZIM0B5+4Mj0SJXgqXhRym6YTaeNWnQ5wzUgdH8= Date: Fri, 28 Jul 2023 10:24:05 -0700 From: Andrew Morton To: Yin Fengwei Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, willy@infradead.org, vishal.moola@gmail.com, wangkefeng.wang@huawei.com, minchan@kernel.org, yuzhao@google.com, david@redhat.com, ryan.roberts@arm.com, shy828301@gmail.com Subject: Re: [PATCH 0/2] don't use mapcount() to check large folio sharing Message-Id: <20230728102405.7b456eb87fb46042fbce5e4b@linux-foundation.org> In-Reply-To: <20230728161356.1784568-1-fengwei.yin@intel.com> References: <20230728161356.1784568-1-fengwei.yin@intel.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: BA5E340005 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: bottkmwojyawp54no3mghmqgn7rpm6gd X-HE-Tag: 1690565048-391494 X-HE-Meta: U2FsdGVkX1+AuXUFffFYTG5bbrvRd2DFZ9OjHM1CL+24i1s5g5A6hg27q9nZXhBLX+thwiZTJ8M54V30U3zD5zpSumxvCFXw35XxAK6PwlaaAbsAKYGdlF75zykXQRyD6jQkd1C+XeYIkUEWfsy74KTt1ILHiWSOcrFit5MlzOJj5kZbMFjlAGIElbjlDuCzB+l2yEM0GHwtRn/IBgHqSRQyNOYC2sDvjQdf+0KHAAD4WgLij2JfZpvYrdr0Nx6sjJtjPokQFHSLx7ZbgAZVplklrakYP88UVwDQoqbkrNdjwlspxSYsP0FM0UNADEUkTpuH4OztSV6qR/Y665ijw6s4c+hwXgGDcScoRXXVv46mauB94+j0SosgFL1jKjFbTJnkeH9Oe5QjL8rBph6FPyUy/90O/NiLj1LyQ1L840IN0mlL5taB8lOdUak/DiQuXz3qDp/HVSkk1KqeAXwJerMMOrXkwM8p/nH5t7t4UYHfx4p10ukZcpGnaXWln/ebwT1231Ou3PuIpfxqIRcO05ToJm6gOb9uAIhDIzojaFoKlx2TpUHldpnrFRWhOLla0VlwbjmctUwXKoXQj1jaupzr2AIhrUOZ/pIWbIg8yPtIBEWT0UJyM7QPPSC9cV/c3AUBgMJFMbSR2F6spkEO5ryVH9U6iPjws7dYJyrtpWq7XBjWht6Wp5gMwHilp1bqJKx9+5x0CoJsEH95PlMMgB9V0lde89og6PouOAHhzlb/1j9/PbD4q8RA016Kg0zIvOAB2NPekptzfILpFexB93a5x4an8INzLpqvUYNrW0AM7hV1VHUmwnHy8yCSuDrF62xarrpexY4EWCTrxOcgBHf0jLiu5C5uTooM71SrMynhI8Szo3SJ+OPj+1nLpta2vAbiI1U6kCCEUPlW1MmamN2r8WkrA2oA97OM+PhNZXVNbq9uOzauMIQ9N3brqu21VVnQbXbGkDTc0vcB3OP rvvmv/TL W5o0Yv+qnHlB1ZYiI/0ZiU38rdONusiG2CjiGwo6837GFXJK7dCzWs/j5Qk5pDLytOLpiqqUV7DeCClPWlAQd4ysEuuZd3JeiDXoQhq2BrhSAk1JZN64AJzLxBZy7aPiwOwOv+/Gmw4dJFxHjl7GY7DEY6jX5RgIlvVhOnX0cr7QbJG/GHhTF8WEY+iXIyulQdrc9h/LaNpB53161PD7qYmqbHNymcGp0D4HTFU9si0abHgqjkJXgWa5Jyp+uhuGSXyk5G3d9Kwy9ZHQCLBUSKkVROQU7GvrrspIz41U4UuVozjnUSRHad806ujq9ZxuyD8sjA8571miGy+Ye15M8WwqyfPu8NKRoW72X0PKbFJokv8LNheAhxIobHShp73TSFX4dNkfzCfRzorQ5X+mSen4cGFyw2PcxMpI6FFLNCtIS5MG39GZszCc1YwhlDU9Cs4g2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 29 Jul 2023 00:13:54 +0800 Yin Fengwei wrote: > In madvise_cold_or_pageout_pte_range() and madvise_free_pte_range(), > folio_mapcount() is used to check whether the folio is shared. But it's > not correct as folio_mapcount() returns total mapcount of large folio. > > Use folio_estimated_sharers() here as the estimated number is enough. What are the user-visible runtime effects of these changes? (and please try to avoid using the same Subject: for different patches)