From: Yin Fengwei <fengwei.yin@intel.com>
To: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, yuzhao@google.com,
willy@infradead.org, david@redhat.com, ryan.roberts@arm.com,
shy828301@gmail.com, hughd@google.com
Cc: fengwei.yin@intel.com
Subject: [PATCH 1/3] mm: add functions folio_in_range() and folio_within_vma()
Date: Fri, 28 Jul 2023 15:09:27 +0800 [thread overview]
Message-ID: <20230728070929.2487065-2-fengwei.yin@intel.com> (raw)
In-Reply-To: <20230728070929.2487065-1-fengwei.yin@intel.com>
It will be used to check whether the folio is mapped to specific
VMA and whether the mapping address of folio is in the range.
Also a helper function folio_within_vma() to check whether folio
is in the range of vma based on folio_in_range().
Signed-off-by: Yin Fengwei <fengwei.yin@intel.com>
---
mm/internal.h | 69 +++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 69 insertions(+)
diff --git a/mm/internal.h b/mm/internal.h
index 5a03bc4782a2..63de32154a48 100644
--- a/mm/internal.h
+++ b/mm/internal.h
@@ -585,6 +585,75 @@ extern long faultin_vma_page_range(struct vm_area_struct *vma,
bool write, int *locked);
extern bool mlock_future_ok(struct mm_struct *mm, unsigned long flags,
unsigned long bytes);
+
+/*
+ * Check whether the folio is in specific range
+ *
+ * First, check whether the folio is in the range of vma.
+ * Then, check whether the folio is mapped to the range of [start, end].
+ * In the end, check whether the folio is fully mapped to the range.
+ *
+ * @pte page table pointer will be checked whether the large folio
+ * is fully mapped to. Currently, if mremap in the middle of
+ * large folio, the large folio could be mapped to to different
+ * VMA and address check can't identify this situation.
+ */
+static inline bool
+folio_in_range(struct folio *folio, struct vm_area_struct *vma,
+ unsigned long start, unsigned long end, pte_t *pte)
+{
+ pte_t ptent;
+ unsigned long i, nr = folio_nr_pages(folio);
+ pgoff_t pgoff, addr;
+ unsigned long vma_pglen = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;
+
+ VM_WARN_ON_FOLIO(folio_test_ksm(folio), folio);
+
+ if (start < vma->vm_start)
+ start = vma->vm_start;
+ if (end > vma->vm_end)
+ end = vma->vm_end;
+
+ pgoff = folio_pgoff(folio);
+ /* if folio start address is not in vma range */
+ if (pgoff < vma->vm_pgoff || pgoff > vma->vm_pgoff + vma_pglen)
+ return false;
+
+ addr = vma->vm_start + ((pgoff - vma->vm_pgoff) << PAGE_SHIFT);
+ if (addr < start || end - addr < folio_size(folio))
+ return false;
+
+ /* not necessary to check pte for none large folio */
+ if (!folio_test_large(folio))
+ return true;
+
+ if (!pte)
+ return false;
+
+ /* check whether parameter pte is associated with folio */
+ ptent = ptep_get(pte);
+ if (pte_none(ptent) || !pte_present(ptent) ||
+ pte_pfn(ptent) - folio_pfn(folio) >= nr)
+ return false;
+
+ pte -= pte_pfn(ptent) - folio_pfn(folio);
+ for (i = 0; i < nr; i++, pte++) {
+ ptent = ptep_get(pte);
+
+ if (pte_none(ptent) || !pte_present(ptent) ||
+ pte_pfn(ptent) - folio_pfn(folio) >= nr)
+ return false;
+ }
+
+ return true;
+}
+
+static inline bool
+folio_within_vma(struct folio *folio, struct vm_area_struct *vma, pte_t *pte)
+{
+ return folio_in_range(folio, vma, vma->vm_start, vma->vm_end, pte);
+}
+
/*
* mlock_vma_folio() and munlock_vma_folio():
* should be called with vma's mmap_lock held for read or write,
--
2.39.2
next prev parent reply other threads:[~2023-07-28 7:11 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 7:09 [PATCH 0/3] support large folio for mlock Yin Fengwei
2023-07-28 7:09 ` Yin Fengwei [this message]
2023-07-28 18:34 ` [PATCH 1/3] mm: add functions folio_in_range() and folio_within_vma() Andrew Morton
2023-07-29 13:54 ` Yin, Fengwei
2023-08-02 11:14 ` Ryan Roberts
2023-08-02 11:35 ` Ryan Roberts
2023-08-02 13:12 ` Yin, Fengwei
2023-08-02 15:12 ` Ryan Roberts
2023-08-03 1:36 ` Yin Fengwei
2023-08-02 12:50 ` Yin, Fengwei
2023-08-02 13:09 ` Ryan Roberts
2023-08-02 13:46 ` Yin, Fengwei
2023-08-02 14:08 ` Ryan Roberts
2023-08-02 14:14 ` Yin, Fengwei
2023-08-02 14:59 ` Ryan Roberts
2023-08-03 0:24 ` Yin Fengwei
2023-08-02 15:15 ` Ryan Roberts
2023-08-03 0:41 ` Yin Fengwei
2023-08-03 9:58 ` Ryan Roberts
2023-08-03 10:48 ` Yin Fengwei
2023-08-03 13:20 ` Ryan Roberts
2023-08-03 23:15 ` Yin, Fengwei
2023-08-04 8:46 ` Ryan Roberts
2023-08-04 9:05 ` Yin, Fengwei
2023-07-28 7:09 ` [PATCH 2/3] mm: handle large folio when large folio in VM_LOCKED VMA range Yin Fengwei
2023-07-28 7:09 ` [PATCH 3/3] mm: mlock: update mlock_pte_range to handle large folio Yin Fengwei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230728070929.2487065-2-fengwei.yin@intel.com \
--to=fengwei.yin@intel.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ryan.roberts@arm.com \
--cc=shy828301@gmail.com \
--cc=willy@infradead.org \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox