From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6D72C001DE for ; Fri, 28 Jul 2023 13:32:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DC5B56B0071; Fri, 28 Jul 2023 09:32:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D4EC76B0074; Fri, 28 Jul 2023 09:32:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BC8618D0001; Fri, 28 Jul 2023 09:32:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A8F896B0071 for ; Fri, 28 Jul 2023 09:32:42 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 75DAF41116 for ; Fri, 28 Jul 2023 13:32:42 +0000 (UTC) X-FDA: 81061110564.10.BD0A987 Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) by imf03.hostedemail.com (Postfix) with ESMTP id AF8C220006 for ; Fri, 28 Jul 2023 13:32:38 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=ventanamicro.com header.s=google header.b=SjWIgG6+; spf=pass (imf03.hostedemail.com: domain of ajones@ventanamicro.com designates 209.85.208.171 as permitted sender) smtp.mailfrom=ajones@ventanamicro.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690551158; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yfPWFATzg2F/vGl+Rugnp8J3pij37XeUvwzh4yvIFCk=; b=G88YcUCs5eWZDUWmWGShIy6E98dNdGI33y2VcxL+HmhueSu+zL3OteXVnigyH9nFpxg9o7 50nCcvlD7rBqEuRinhnQa8q/zGCUDJkhGOLM3vEzj1cW3kJ3iAHRAxJuOzgG6KGYMmGfB9 4OlANJ5FjNviDOigUH/OsA0P6NtiFH8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690551158; a=rsa-sha256; cv=none; b=LQRSafqrxTJRL24tB++saEDlr9Zz7LaSe/+y3zncL0hTUxSLKn+J2GHR/hmNomYBUEx+vN EIqX3N7OGSkFCht+vPRugkyArLmZ1y4YWOdYr/K+mWDrswQw2BhhWOR+0BbcvZHp/a44B6 G2et3zmmsvQkFo3tzgxj6z+YtRH7rrw= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=ventanamicro.com header.s=google header.b=SjWIgG6+; spf=pass (imf03.hostedemail.com: domain of ajones@ventanamicro.com designates 209.85.208.171 as permitted sender) smtp.mailfrom=ajones@ventanamicro.com; dmarc=none Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-2b703a0453fso32771621fa.3 for ; Fri, 28 Jul 2023 06:32:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1690551157; x=1691155957; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=yfPWFATzg2F/vGl+Rugnp8J3pij37XeUvwzh4yvIFCk=; b=SjWIgG6+pK5Kii8Yby+9NO7xIGyFBTEUn4+5wU/eQ5I0TU3hGh3GWvV9Scui3YYgFS AKpFsMUSp/P/TYQRDsiVUHZLauCM1MHhu2AkYu24OezBCBiGfpycIhgdfy/lx01Q8ia8 7uNmyrFh2/3iUkHZmihu706TB82aCptMxg2JYUJ2EE+zFVkcWqKyzYjYKmf6dCaSJ/KV ozszfhbwpEQXwR66f9qjQPwxFF6KCTPtQ1HO3Qb8lDbpMCmmmYmGSBW01NcP6jXg49vy tVOTwgYAsDmTDYDWHz8TMg9gRXcZJ29nzcG4/l1+BM7IBkWJdefiASqT3FJht9c0rWsr cLOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690551157; x=1691155957; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yfPWFATzg2F/vGl+Rugnp8J3pij37XeUvwzh4yvIFCk=; b=DtH4o/Gz4qVkt/hdYym2d0y4OXB11Yd94hntZIGYnMLcq5KMs1Y7ZYUPubgtohc7aO DKJj8IGm2qSd6T1eOnEelEdxrpph68dbriJIeqB2o+GLREOZPBD55vpj8UaQE4gZpHUv roMubBne/NNBh6WJaGRQ8cvoafF6AftwJ4thQqrNFMjEAzEAJufndoU/hVnwB2gIfw/z TmL/WDmO+09T9h6eGDeVvYAOvGQJvIg2gyFZ2ZbOoSuq6oqXF1mw2c2RVEwToqmW52ov 922o1omfwuODeikdCk4Wi1YMwPXvnSj/CevrDOaSg6HBpzS96mbcCuegSJhEOUGOxWpP iKHQ== X-Gm-Message-State: ABy/qLaSgkKp5+zLPfPz/vi9H1H6CBUe6tS+MxgsFss0Q//rQaG5PIPX tALN37BUZYDhjZVz8Ym6q20bcw== X-Google-Smtp-Source: APBJJlHNHIiJYvgDvTPgNH06lQmbcxMDN4FEykHkmvVCH47PAaXmVTITjQ2d4Z+FSuew7Waq+UFM2g== X-Received: by 2002:a2e:9444:0:b0:2b9:bbf5:7c6 with SMTP id o4-20020a2e9444000000b002b9bbf507c6mr1825736ljh.43.1690551156738; Fri, 28 Jul 2023 06:32:36 -0700 (PDT) Received: from localhost (2001-1ae9-1c2-4c00-20f-c6b4-1e57-7965.ip6.tmcz.cz. [2001:1ae9:1c2:4c00:20f:c6b4:1e57:7965]) by smtp.gmail.com with ESMTPSA id h19-20020a17090634d300b0098e422d6758sm2054351ejb.219.2023.07.28.06.32.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Jul 2023 06:32:36 -0700 (PDT) Date: Fri, 28 Jul 2023 15:32:35 +0200 From: Andrew Jones To: Alexandre Ghiti Cc: Will Deacon , "Aneesh Kumar K . V" , Andrew Morton , Nick Piggin , Peter Zijlstra , Mayuresh Chitale , Vincent Chen , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/4] riscv: Make __flush_tlb_range() loop over pte instead of flushing the whole tlb Message-ID: <20230728-f2cd8ddd252c2ece2e438790@orel> References: <20230727185553.980262-1-alexghiti@rivosinc.com> <20230727185553.980262-4-alexghiti@rivosinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230727185553.980262-4-alexghiti@rivosinc.com> X-Stat-Signature: wj59zriuog1e6uzkdw885o9u4nqswsrn X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: AF8C220006 X-Rspam-User: X-HE-Tag: 1690551158-984458 X-HE-Meta: U2FsdGVkX18co8mf1gSktXMPuYILFE61aeK/3qhojstojkuxIwEoPwq/wjlFX4HpDMg7kw7/HxY7qS6kpE4mXfeSElynB5pH/gtO3yXtpZUUXpnzPebBvemvpKD2dmJAao0dA4hNdnyKmFhgKpV26Iavi3XYK5uZXzcd9OTr5BBLpYL9a3fZheJEFLoRQMn7qGLYxiKLc9PToZg9MP9f4SDngPzThZxdhl0ZpSpxXX2vlHiMYnDwjT3mFJGe5s81BBkPA6c4YyWHYVxvziZULET1oY9MYnof/4la70Eylt1bOKmI929jKfaJku8eUxqZvuMp5AG2IavuseGuxIVn4TL3lzE60Eiodw5brEqM66JAr9cmJzvRwBEoAiZdb1lB51bq5DIJhbof8CXmTs3R7MjnHoPcJ77SeRsquCozJF72O1zUiil0I8HCOy6W9E8nB9HmlG/7GkTgMifyIgQGI1u424P+ltjmK70Gw4QKYNTFxYzpguG79nl96rWS7sK/YF4rZPonZzcXAT/K7DBcg0qWD1RY2dDXvAe6oRqaNIGryIYM/LY07nuf9y0jQeyoxkjRW8KiSwIIYBJ1d3c5vYDLTi7VeP4Nzc3/QmSfrE1AbbjzxLiRA2Q/UUoL0OiMJvX4XFl7bktni67pUO6KasAPqWFEVbkXzRC7aGYA1dBzHhGDhsOayuJ2MkfG1m4stO+G+ZpWco+C8XcHY1Gm1bKYcFSyQsJexnyYYmzGKYbz9zUyUk9j4rmmwktLY6ITjrb83mknsNpDbua2pyuPVX5K3vCi18MzBxQQFw+c8FNlj+CHmWtROPx+/w8s3OS+e9YL2KtJzOfx4NMybNTaVlzXaDoNirBFmCHWyup7HZIpgZUJpY99D9EH0DNkFZ1/E7RVx5b3qUHpGDESZAhcr1RHclBUK4jIjSFCJ64dBaHTZ4uslzODxDd+Bec25lx+eoOCsNU9sjWdXHJCSQS EEQ8dRuA Y5WLP7Iyw7+QRycouMbLTK9gHUuDHyXHoLR32nA6LtZtH7VkyUeGPhb8fx1xjAOfBkvsYTDIXTYhFz2JjPOaFcirPpGgES3yP0KCMZInmgwddaACdI9SLY0xnDVF02Lcc8sIXQIxNT67DZ5YAmn78unsga79GG00MeKIpk0Ko1m37fic3nVYqvdizoTulnHJRvtz8qDtE8q5lU6GmZAYFfZoUR1qLrNFC6S3eT+YDXB7SKcPYRfcwzLAbI/p24+9gAFiyxoJPp0++2So58yDSd0hIeawtf+jmhP5ihXkwtUcU/AutcRsdPOj32i0CPaya9gpNU1S8P4rn1MXOWPkKaH7CbnGidJGqssS2yLcqIuExZYStNbPQkIUdNviEq0x6kN/Wsn/LsF66wCXi4tnj9KGwzo5CHGvPZendc5WJG9OgOjJoZpQtFzt+dtyk1e410QS9ozt+WAzJkt4irIm9wR4viWRG1lmu43wISGyXf9M9FpA/t3/8nQvV/w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 27, 2023 at 08:55:52PM +0200, Alexandre Ghiti wrote: > Currently, when the range to flush covers more than one page (a 4K page or > a hugepage), __flush_tlb_range() flushes the whole tlb. Flushing the whole > tlb comes with a greater cost than flushing a single entry so we should > flush single entries up to a certain threshold so that: > threshold * cost of flushing a single entry < cost of flushing the whole > tlb. > > This threshold is microarchitecture dependent and can/should be > overwritten by vendors. > > Co-developed-by: Mayuresh Chitale > Signed-off-by: Mayuresh Chitale > Signed-off-by: Alexandre Ghiti > --- > arch/riscv/mm/tlbflush.c | 41 ++++++++++++++++++++++++++++++++++++++-- > 1 file changed, 39 insertions(+), 2 deletions(-) > > diff --git a/arch/riscv/mm/tlbflush.c b/arch/riscv/mm/tlbflush.c > index 3e4acef1f6bc..8017d2130e27 100644 > --- a/arch/riscv/mm/tlbflush.c > +++ b/arch/riscv/mm/tlbflush.c > @@ -24,13 +24,48 @@ static inline void local_flush_tlb_page_asid(unsigned long addr, > : "memory"); > } > > +/* > + * Flush entire TLB if number of entries to be flushed is greater > + * than the threshold below. Platforms may override the threshold > + * value based on marchid, mvendorid, and mimpid. > + */ > +static unsigned long tlb_flush_all_threshold __read_mostly = 64; > + > +static void local_flush_tlb_range_threshold_asid(unsigned long start, > + unsigned long size, > + unsigned long stride, > + unsigned long asid) > +{ > + u16 nr_ptes_in_range = DIV_ROUND_UP(size, stride); > + int i; > + > + if (nr_ptes_in_range > tlb_flush_all_threshold) { > + if (asid != -1) > + local_flush_tlb_all_asid(asid); > + else > + local_flush_tlb_all(); > + return; > + } > + > + for (i = 0; i < nr_ptes_in_range; ++i) { > + if (asid != -1) > + local_flush_tlb_page_asid(start, asid); > + else > + local_flush_tlb_page(start); > + start += stride; > + } > +} > + > static inline void local_flush_tlb_range(unsigned long start, > unsigned long size, unsigned long stride) > { > if (size <= stride) > local_flush_tlb_page(start); > - else > + else if (size == (unsigned long)-1) The more we scatter this -1 around, especially now that we also need to cast it, the more I think we should introduce a #define for it. > local_flush_tlb_all(); > + else > + local_flush_tlb_range_threshold_asid(start, size, stride, -1); > + > } > > static inline void local_flush_tlb_range_asid(unsigned long start, > @@ -38,8 +73,10 @@ static inline void local_flush_tlb_range_asid(unsigned long start, > { > if (size <= stride) > local_flush_tlb_page_asid(start, asid); > - else > + else if (size == (unsigned long)-1) > local_flush_tlb_all_asid(asid); > + else > + local_flush_tlb_range_threshold_asid(start, size, stride, asid); > } > > static void __ipi_flush_tlb_all(void *info) > -- > 2.39.2 > Otherwise, Reviewed-by: Andrew Jones Thanks, drew