From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57FBEC0015E for ; Fri, 28 Jul 2023 13:40:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B0A6E8D0001; Fri, 28 Jul 2023 09:40:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ABAE16B0074; Fri, 28 Jul 2023 09:40:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9819B8D0001; Fri, 28 Jul 2023 09:40:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8573A6B0071 for ; Fri, 28 Jul 2023 09:40:45 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4EBC91CA2B4 for ; Fri, 28 Jul 2023 13:40:45 +0000 (UTC) X-FDA: 81061130850.08.33A5D7F Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) by imf13.hostedemail.com (Postfix) with ESMTP id 660212001C for ; Fri, 28 Jul 2023 13:40:43 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=ventanamicro.com header.s=google header.b=IQ3Zqni+; dmarc=none; spf=pass (imf13.hostedemail.com: domain of ajones@ventanamicro.com designates 209.85.208.53 as permitted sender) smtp.mailfrom=ajones@ventanamicro.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690551643; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dOr1yk/G929iC/UP6Gxb6LGjnTgc9novxErxvxKlMFA=; b=AbHsUkBbQaHlRRZFW7m2QbdRJ9p1raMnsvUcL0MfNovKKfHx2rNq5YQWqy8tYwfOVkNdDK QMEutyvLlek65NW1hAoHB0AXg1LQn/iYhEEreIDvrE0xebB/Wi494fbrCp5N42Uvb6TSm0 V18c+ILYkJhJx8kSpD79X4VYFkXmNXc= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=ventanamicro.com header.s=google header.b=IQ3Zqni+; dmarc=none; spf=pass (imf13.hostedemail.com: domain of ajones@ventanamicro.com designates 209.85.208.53 as permitted sender) smtp.mailfrom=ajones@ventanamicro.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690551643; a=rsa-sha256; cv=none; b=dQ4WzmGVDQ/Ovdzmx8PeP1DgKZ9NIi2TRzInY274xSCTvT1tnxuOdMdDEymA++eQO4tdGy 7HEFd89e157JiZP47HgpudvGEtAr7KDHeGuRXBklMi3NQEOqCu8pCPmd9bboq5GlJEaL+w Vqx0iUayQSmfxEX/kNulOKpMiNTIdJA= Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-5227e5d9d96so2744933a12.2 for ; Fri, 28 Jul 2023 06:40:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1690551642; x=1691156442; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=dOr1yk/G929iC/UP6Gxb6LGjnTgc9novxErxvxKlMFA=; b=IQ3Zqni+xYE1E5lTEQCioxb550A8Se+B6M1Ky+b3SqepfB3cIr/HCWGJX+F1OF9wFY Z4yeLGUnJ/oTaoCRLbn5dO6tb8bTXejCeBqLZ7/D40XmUa8r3M/Ybd47vGLBGzJPlPDF wythpCmiNF6GioB3CydtOcNhd+WykncVDXx47mMWaLhkYrxT2oNi3amn7v+9lDKXD4TX c3u12ZTfhWRCNqyovbhmli3c5z3wUupr6p/p3pgDv2ocqNMCb0yEFtAuhpPo3u4Jn6Xr VmnoMR+9E7F3gazk4FFRopYBoipA+G//nAndzJXlx57BZFwsVE/j/hlNPlJ5PE+YqjLL YOBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690551642; x=1691156442; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dOr1yk/G929iC/UP6Gxb6LGjnTgc9novxErxvxKlMFA=; b=OKDNEgkDi8CHmmBqDQvd/LXcxHc3v8/qvaFSk8D0OZi82TXGZs9EDjMc6aIEs9H6AH 5KEFQqVgtoRhCbR5v+S1+neCUDjMkRCsCZc8RyKWCf+mZ2yGOQYtWD2YM2r0drsuENSZ W4CO0X5jgr0P2crR+efOTgvXFfFlNyEncK/Q5dpyxs+gv6S4NJVs8TTvB27btRY4r1+K DQy7qZcitjT1noh6saNSlP4Cal8ZQHfgXMXaE8Hi26iTkHIQcH5WeRZHtyvGh6Rqx1zt iv6o0rH2EsGr9M0KTie4fceQRZQd49zejYtI7+T/jwqIw5HCbpmTeEIBj/LD0kGmUWS+ F+bg== X-Gm-Message-State: ABy/qLZy0mxc23RSlwam5UhDTpKR9+8d3MTIDBOZOcIN3/zoPnh0lP4J C8n5uehLh9eFBmOoMQSTBPvOJw== X-Google-Smtp-Source: APBJJlEYSSoWqY1AZEvMkgejX1YVuSwDTsDWEeWUKTMmJ78xen4aK3pxBR2H/MQNoqMbOAxqyZGevg== X-Received: by 2002:a05:6402:1148:b0:51f:f1a4:edc6 with SMTP id g8-20020a056402114800b0051ff1a4edc6mr1701888edw.37.1690551641712; Fri, 28 Jul 2023 06:40:41 -0700 (PDT) Received: from localhost (2001-1ae9-1c2-4c00-20f-c6b4-1e57-7965.ip6.tmcz.cz. [2001:1ae9:1c2:4c00:20f:c6b4:1e57:7965]) by smtp.gmail.com with ESMTPSA id i23-20020aa7c717000000b0051bed21a635sm1822857edq.74.2023.07.28.06.40.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Jul 2023 06:40:41 -0700 (PDT) Date: Fri, 28 Jul 2023 15:40:40 +0200 From: Andrew Jones To: Alexandre Ghiti Cc: Will Deacon , "Aneesh Kumar K . V" , Andrew Morton , Nick Piggin , Peter Zijlstra , Mayuresh Chitale , Vincent Chen , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/4] riscv: Improve flush_tlb_range() for hugetlb pages Message-ID: <20230728-50d247a7253aaf9468cd8b3d@orel> References: <20230727185553.980262-1-alexghiti@rivosinc.com> <20230727185553.980262-3-alexghiti@rivosinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230727185553.980262-3-alexghiti@rivosinc.com> X-Rspamd-Queue-Id: 660212001C X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: shfdt545eiior8nj5487ztpobu16hqcr X-HE-Tag: 1690551643-209513 X-HE-Meta: U2FsdGVkX1+pjmxmICCTJPsT+i1aniOwn40yKvsvKoWRe64V8Vn9btyVsTbFApfp6ylYJWoIaCUksIII2Y7JN82upRxhdOTJMofUoPso6VnqZ9iUGnKFS0TfAemCax1Nu/j8voLX/9pVx29YwbVQgWnf2OeleaXya+cV+ADc5aPTG20ib456Y51e09hvIzWqXgAq/NZULTQg/TzrJvmndwC1OrXYjf6CBkAYdN/0lAtlPVe9RliqGSmibj/t5gbLqvOfvHcI+lRWNaUEGwIeHJFdLGnxaBlnpJ+1J2JRtGgsb9Z7Bwfa8aJCZbkwaKs5zAqOg02h7gcMs+GhtREdxRWBBEiPaNKMnyfV9nQOqvnb87SqHOCl/q13jFjZGb5eIUZvrf8aX83j697cqDmADJ9ozwnfxyMkrG5qQHuyHipa2nAwuyaO5RrfTict8o83eLh1MP80i4BOFUmb74F/62jbEluATGXKKxEcIcqQ1QO75m9iGQkx4cZCTVg7tt8Gc48CpexFbWdGXHT7vYrd6LDTJr6MxNAtD5zpvz2cgNgYjcKT86Rew9bm6JojFoaRPyqq2ad8UU8vUH0SoshVktZ9QLHt4zinjFXr7KCASMajZj0fAFZ5DcldspXBH9fQ2lljKeTqvwM6Y/89RDZzWdQlQDsA7bM88yFcG5Qbv9g3ZPaI32o3nPL+fxlhTvoUp8xvbqMMSFASDx1xjEWZCLf5kHRJstFAM8kezLMuZ4lcU2J2FIkdMzTlbvvTDFKRnA6XW5RHWTzTSunAT2hZHjcs39oF9gk5EpL3p+47CwHv6bnW1QWXPCR3VBsDxmhWsZWGINy/32GqDpi+AXxePpSEIAUKT1RhU97imEszDj3vAe+9xojITt2HsGYU6k5sJqzTG0O7SCNqT2yWzds7Fcp4z5COe5slJ5haymeaQSzgAQH83d+YZ+J9ajqybzq5JMqNGxnIHjZhxYaFJMv /JmIWvV1 x/RCGIA9MQBmu6cC1f6qT3r6lkTD61ZHXTHxXBCzaq2Fwj4PcM+7ZhyzoteILJr46l+Ugwce0kOzNPvKrTHJ35ubVqdokrInjtrGiwbyc8aKb3S0Mdfq0GzJg6giEdwT9huiBDnKvn+nF2NtVwMU5Eq/MXtxNxXc3CVCoEolqrg71pp8WOrcKxxYpB6AuaPj7/kLYC0rlOSPeItxLAvc59iVrCbMQDLInRkrBwSYfcXYFMYAx9a3PgB3PjvdgmahfDdaGYBqfBJmvww+5iAZLqYLTmLwAlUFpXn4C+HNqZiKWUFiYPMT8SzoidKjfa3577WtPFZORiDMzFNfTfXUUsNpZyLN/FGTqtGVNvdmfN9qtTd+aK8OZav3CLF7tUkeSGqo2RXy+vbaYGC/b4F+uE0IS5oWWMiCn26muX5AiCgj+n/tNz6AZ22C3mRztmAvk/3CR0k3WRO/AO4Y2X4PpfagAMqLnUdfDtIHk6sKCxTQcWBG8nZ8FHgWp0w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 27, 2023 at 08:55:51PM +0200, Alexandre Ghiti wrote: > flush_tlb_range() uses a fixed stride of PAGE_SIZE and in its current form, > when a hugetlb mapping needs to be flushed, flush_tlb_range() flushes the > whole tlb: so set a stride of the size of the hugetlb mapping in order to > only flush the hugetlb mapping. > > Note that THPs are directly handled by flush_pmd_tlb_range(). > > Signed-off-by: Alexandre Ghiti > --- > arch/riscv/mm/tlbflush.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/arch/riscv/mm/tlbflush.c b/arch/riscv/mm/tlbflush.c > index fa03289853d8..3e4acef1f6bc 100644 > --- a/arch/riscv/mm/tlbflush.c > +++ b/arch/riscv/mm/tlbflush.c > @@ -3,6 +3,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -147,7 +148,14 @@ void flush_tlb_page(struct vm_area_struct *vma, unsigned long addr) > void flush_tlb_range(struct vm_area_struct *vma, unsigned long start, > unsigned long end) > { > - __flush_tlb_range(vma->vm_mm, start, end - start, PAGE_SIZE); > + unsigned long stride_shift; > + > + stride_shift = is_vm_hugetlb_page(vma) ? > + huge_page_shift(hstate_vma(vma)) : > + PAGE_SHIFT; We want the size below instead of the shift, so we can just use huge_page_size() and PAGE_SIZE here. > + > + __flush_tlb_range(vma->vm_mm, > + start, end - start, 1 << stride_shift); Shouldn't need to wrap this line. > } > #ifdef CONFIG_TRANSPARENT_HUGEPAGE > void flush_pmd_tlb_range(struct vm_area_struct *vma, unsigned long start, > -- > 2.39.2 > Otherwise, Reviewed-by: Andrew Jones Thanks, drew