From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1932FEB64DD for ; Thu, 27 Jul 2023 21:53:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9836A6B0074; Thu, 27 Jul 2023 17:53:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9627F6B0075; Thu, 27 Jul 2023 17:53:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 821586B0078; Thu, 27 Jul 2023 17:53:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 738366B0074 for ; Thu, 27 Jul 2023 17:53:24 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 3965BA0382 for ; Thu, 27 Jul 2023 21:53:24 +0000 (UTC) X-FDA: 81058743528.01.A68C9C1 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf11.hostedemail.com (Postfix) with ESMTP id 848F34001C for ; Thu, 27 Jul 2023 21:53:22 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="BRxP92P/"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf11.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690494802; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZDkzd+2i426GnRLW30HMSh+NlacL7lmFQuQ0sVOO/Do=; b=oAAGZJvuAJdaFUT6oC6+4oLxZZLXv9gZfWb/tMejrecSnGIkwnGIzkco065mF1UJ7W0mej sBbpFlpzDJR+4AXbqgRcFIKOMpfuvzlKxXO5TW4D7uz9gKTFIKY1M+smfSIREzUrqz4N5c HU/SKZMOZ03j2NOUVsy164Tmqh09d8M= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="BRxP92P/"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf11.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690494802; a=rsa-sha256; cv=none; b=5yiNHA16cGPSBLCE7NBgWqOTvHjEazrCc0bELD37S/h2HXGKekDG+5JjbmB1A8ehrcIhY+ 873jolVyLcqtXzr0D3oZ5Xds1IMGDWkxyLmFcEPdeP4l6Dnn8aPNCtbUqg0HlmUOXlo05k fp4Y4x4IBc9UDsFTNiFWIcuAx5Cw/78= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4D06161F64; Thu, 27 Jul 2023 21:53:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3B3F2C433C9; Thu, 27 Jul 2023 21:53:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690494800; bh=Y3Xmaq/xTIj2r6AHGezOL4uhwn8qF3iH6+f0u/RI6rw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BRxP92P/stHqjvuis4AuCMW2avLQAKUzM4EQjZEhatWhnIKf0crT/tVy71isi/IMa d/GA0VqH09UbRGsIoNxztvM1e84wd3K/jHpF32HpB6WbJFeoQmnznf3rpuBooA8Vxg 7kdPEva+zMQwe8g7eaxAsk01mrHvH1Xpp3Den2NWpUMa0LvbJ2R/KngxlatoavhedI o2AvdI2tJBSsBTv32SGAF3Y/8mT1OaY2i/z83/eJ9g8F6bIfKqArpdmOXdvul08n3O yDealoqZHntihTZg4n4baAQskMqpxHen0o//hmwEoSdqCvgbRBoPZK9J8LE2Qdtwq9 PiEOltJy4lQTA== From: SeongJae Park To: Levi Yun Cc: sj@kernel.org, akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] damon: Use pmdp_get instead of drectly dereferencing pmd. Date: Thu, 27 Jul 2023 21:53:18 +0000 Message-Id: <20230727215318.43455-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230727212157.2985025-1-ppbuk5246@gmail.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 848F34001C X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 7ta6gge4dww95yy1h69fzbpq1o7jh9hi X-HE-Tag: 1690494802-791444 X-HE-Meta: U2FsdGVkX19HJZdjjj1TgBVtkzpKlmW4pU9P3fgJT1CKTkH9nqBNNstwngtx1j97DWDAtS1JVO6uiVERXNrVkQ8YRXmZ4YSVJIF1uwU1fIiTkxo/6ZcZJlchda4/hafD5ZW31ZUg+5vil/+j1kt1UNAxyWAjn1gVaKLgTolGO+AxvW6xjgEpSoY2gk5HbdmJ8lECE5xiEqtxs9xCYoLQbharjj46A8+w59v7EewBCctk8bfu85dr6QWZOyW/hPJT/tL+32nf0V0V5BruLRZbo8pgiwurzb1/zTLX5m/PnRZ5VhkwoDaxO8HFDfpqfo0FtI3dvz5EfvbWqjQ2QFi86603/gYKsUrMwnAMcWQj0xb6FfpA8KQKlgjk/MKuttb3SvBBI06QU/kGDaiVGvTjn0R2FsRi2YEwSYocc4pnUFWqM8t/1p2zyYeLNPQK7sir9kBCUIhhnrOZDGvYmcjHUkOuZjjsQ6LzkdCRNvP2w1Z1FP/s0paTDb6Lm+oDo6Lktyd3HC0JPsUdz48XhRerJuReqdsmsWN78rujgginCn751hIc924M7ZGeWNgNPGO0TGQ7XHZbCVs11KT6mJl4p3+VCleU+PHg2EEukuJcra2LTVVlRwoqKckG9GQpEe5JLvKXZARHNF5lbWYXkvY6C+khAwJQmM5rL/bVIgDWGnv9x2e6qobTqgGrpxcBGy2Od5cvIBG25Cen3q8N1ZfCCNAI4BRwI7Gm2d5Z+0iOBqJSwOYu1XUrqJ/K0wjaGe9SbwT48P70j3lxV844ESNdMFCoW0qnvWVwNdecz87FEP8D00BElY6GYNkupWMMe/zwLzxV8PEvu7xAfmrTBKX4dzFmdL9VXR+by8TigA0dDDCiu1uEw2fSg+syAgUunbLq5OiQsvbxg8YrFCRp1FuJyWClYtcSRysXFZd/KUv4cnMgrR+HDmkfTIM+HAoLsyM8h6WwuoU7GTDyboLXGo4 kjo8jYTh 78FLJVGz4AKLYWsOFvGutNgdWGCkg28WyBKKoXjM8lZlMxagTcfOHqVEgGd7AJgrTE0kGVQwFS9yyYOKMI30bCxgK37gnjcfwLGpgtmDOVw/D3sSVIzyzSK+36zH6nh9Uw12nBXhnquVHOoiGEG4IjTrep8kxrFJaJtBRR7Dv7dxECnANJBucCRYfjs5WkJxBkFtlPkGvlXFbALPSCen2i8Zf0JTzX1ByOUoEMrgCr7oH75v720LLtnObWDTNMC6tcIJFLmIIUHtNFcrqEOX6BGiQN8C4F1/7TvExUQqmgLJtSudNyD3BMqlhDene86tSpk4To1K1dJXZYynxUWGfGUBAQK4oakDuBF28qLup1Z8w7ViH6uVror6ZjI36KiN21edEpZyhac1/t77mYfJOcrcMxsh28OMGjPdZVOFw+gpnNP2UrhzBSErO1BsQ2idG29hp X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Levi, Thank you for quick respin. I still hope the subject to drop the ending period, and start the subject with lowercase, like other mm/damon/ commits. On Fri, 28 Jul 2023 06:21:57 +0900 Levi Yun wrote: > As ptep_get, Use the pmdp_get wrapper when we accessing pmdval > instead of directly dereferencing pmd. Based on the usual git commit message line length recommendation (72 characters), there is nothing really wrong, but putting 'instead' at the first line may look more consistent with other messages. > > Signed-off-by: Levi Yun > --- Since this is the good place to put additional comments not suitable for the changelog[2], it would be helpful if you could put changes of this patch that made after the v1 here, from next time. Above comments are only my trivial and personal preferences, so I wouldn't ask you to respin, unless you really want to. Reviewed-by: SeongJae Park [1] https://github.com/torvalds/linux/pull/17 [2] https://docs.kernel.org/process/submitting-patches.html#the-canonical-patch-format Thanks, SJ > mm/damon/ops-common.c | 2 +- > mm/damon/paddr.c | 2 +- > mm/damon/vaddr.c | 23 +++++++++++++++-------- > 3 files changed, 17 insertions(+), 10 deletions(-) > > diff --git a/mm/damon/ops-common.c b/mm/damon/ops-common.c > index e940802a15a4..ac1c3fa80f98 100644 > --- a/mm/damon/ops-common.c > +++ b/mm/damon/ops-common.c > @@ -54,7 +54,7 @@ void damon_ptep_mkold(pte_t *pte, struct vm_area_struct *vma, unsigned long addr > void damon_pmdp_mkold(pmd_t *pmd, struct vm_area_struct *vma, unsigned long addr) > { > #ifdef CONFIG_TRANSPARENT_HUGEPAGE > - struct folio *folio = damon_get_folio(pmd_pfn(*pmd)); > + struct folio *folio = damon_get_folio(pmd_pfn(pmdp_get(pmd))); > > if (!folio) > return; > diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c > index 40801e38fcf0..909db25efb35 100644 > --- a/mm/damon/paddr.c > +++ b/mm/damon/paddr.c > @@ -94,7 +94,7 @@ static bool __damon_pa_young(struct folio *folio, struct vm_area_struct *vma, > mmu_notifier_test_young(vma->vm_mm, addr); > } else { > #ifdef CONFIG_TRANSPARENT_HUGEPAGE > - *accessed = pmd_young(*pvmw.pmd) || > + *accessed = pmd_young(pmdp_get(pvmw.pmd)) || > !folio_test_idle(folio) || > mmu_notifier_test_young(vma->vm_mm, addr); > #else > diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c > index 2fcc9731528a..d01cc46f4bf4 100644 > --- a/mm/damon/vaddr.c > +++ b/mm/damon/vaddr.c > @@ -301,16 +301,19 @@ static int damon_mkold_pmd_entry(pmd_t *pmd, unsigned long addr, > unsigned long next, struct mm_walk *walk) > { > pte_t *pte; > + pmd_t pmde; > spinlock_t *ptl; > > - if (pmd_trans_huge(*pmd)) { > + if (pmd_trans_huge(pmdp_get(pmd))) { > ptl = pmd_lock(walk->mm, pmd); > - if (!pmd_present(*pmd)) { > + pmde = pmdp_get(pmd); > + > + if (!pmd_present(pmde)) { > spin_unlock(ptl); > return 0; > } > > - if (pmd_trans_huge(*pmd)) { > + if (pmd_trans_huge(pmde)) { > damon_pmdp_mkold(pmd, walk->vma, addr); > spin_unlock(ptl); > return 0; > @@ -439,21 +442,25 @@ static int damon_young_pmd_entry(pmd_t *pmd, unsigned long addr, > struct damon_young_walk_private *priv = walk->private; > > #ifdef CONFIG_TRANSPARENT_HUGEPAGE > - if (pmd_trans_huge(*pmd)) { > + if (pmd_trans_huge(pmdp_get(pmd))) { > + pmd_t pmde; > + > ptl = pmd_lock(walk->mm, pmd); > - if (!pmd_present(*pmd)) { > + pmde = pmdp_get(pmd); > + > + if (!pmd_present(pmde)) { > spin_unlock(ptl); > return 0; > } > > - if (!pmd_trans_huge(*pmd)) { > + if (!pmd_trans_huge(pmde)) { > spin_unlock(ptl); > goto regular_page; > } > - folio = damon_get_folio(pmd_pfn(*pmd)); > + folio = damon_get_folio(pmd_pfn(pmde)); > if (!folio) > goto huge_out; > - if (pmd_young(*pmd) || !folio_test_idle(folio) || > + if (pmd_young(pmde) || !folio_test_idle(folio) || > mmu_notifier_test_young(walk->mm, > addr)) > priv->young = true; > -- > 2.37.2 > >