From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2513C001DC for ; Thu, 27 Jul 2023 16:35:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3D51C6B007B; Thu, 27 Jul 2023 12:35:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 384BA6B007E; Thu, 27 Jul 2023 12:35:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 24CC16B0080; Thu, 27 Jul 2023 12:35:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 173A86B007B for ; Thu, 27 Jul 2023 12:35:36 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id DD8A71C93A4 for ; Thu, 27 Jul 2023 16:35:35 +0000 (UTC) X-FDA: 81057942630.28.E710546 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf07.hostedemail.com (Postfix) with ESMTP id F2B6C40022 for ; Thu, 27 Jul 2023 16:35:31 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=OMOPTeOJ; dmarc=none; spf=pass (imf07.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690475732; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=atwiMTM56OgFfjcG6trk81TRDGIYi6PmWI6CzXJV6Go=; b=xTKL6phS4TeYrC08k4vuYk22cWshd91NnpolT1iDwR3DNXwyEP4T3AJ6hto0/3jDsT1X0h JkbtfL5PPymhAjLYqR5PPSTMhcTAu9srUcDrzUVwZNEjZBOLNJwexGq//zNIsREXtraJIv 4yY3gi/j1mXpbezeWj+ycabPnWtOWeQ= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=OMOPTeOJ; dmarc=none; spf=pass (imf07.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690475732; a=rsa-sha256; cv=none; b=IgQykeIkpvTZV4RUCgGlEFZVlA98LUNMkJLGFJ0Jv26B1onKftW8XizQy+IkwcxPcAaV+d zqk7JTeq1AEd7JAdZ1gEYYiTbF1gDSlWz64QlBInlKpXbxIpg9+158JkVM7UWCWI++TYXX cGsLULzEbOqXF61jO8e4GWzwSRfoegI= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E2E9B61ED2; Thu, 27 Jul 2023 16:35:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D3F2DC433C8; Thu, 27 Jul 2023 16:35:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1690475730; bh=xxSAimQXBy8LTexe+HxsAaFK570YSxyX6ulLt13STYQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=OMOPTeOJM3E8IsDW0ELqoK6LluFeGCmacBrLYfqXHj09OdTl9QniJ7ztd9rd3G908 Pya4jart2BSNg2KlkuDLGmCRZMOeWuF9/jnBJhzD0yFn/GxMxIwoprXinjDatR7RFt aCSsi9YxGQ4TPKv4EhtDN/VqBmVj/sZhTzhWeJxU= Date: Thu, 27 Jul 2023 09:35:29 -0700 From: Andrew Morton To: David Howells Cc: Hugh Dickins , Christoph Hellwig , Jens Axboe , Al Viro , John Hubbard , David Hildenbrand , Matthew Wilcox , Chuck Lever , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/2] shmem: Fix splice of a missing page Message-Id: <20230727093529.f235377fabec606e16c20679@linux-foundation.org> In-Reply-To: <20230727161016.169066-2-dhowells@redhat.com> References: <20230727161016.169066-1-dhowells@redhat.com> <20230727161016.169066-2-dhowells@redhat.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: 3zgcyk7wrtahx4q5f1mn6wdjnfsska8a X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: F2B6C40022 X-HE-Tag: 1690475731-452547 X-HE-Meta: U2FsdGVkX1+FVycLm3Wzl/qiixJRxXCvs2T0aqkRATZa5f0qk5vX1UCOHf7TtKigsxgBrcXKNIQc9YOhKgqqDZ5cnWQQCO/cVt3aIYHiICpHw9fsCMW/UlYDP7pDxhOgA2MQ9INkf8D9TsMsQIa+hge9GNyrY8Myu0SSQQyVDc7QCYG1pni2Zv8XRqxXdlRyOTGAyRNhwo/D8hOQTbrjVPSY0V+BsWcsBY95nUEEx4N5JWPEzs6QGP46FoAkNhV3yqSXDqyTv+AjLH2jXUW3WifYErezZTG7UKA7OYzkYXe7pfCNpZloI55mDIWLtfUvbrcLFH1ym2tyUSvpm9A2nYxYKLikQUhDiVtD96512SPWEOAUG1vi+67UC9FkpVSx0w1GShnwabP9xepWmwchgS1+KKK8iIxWhu1ucVjfjECDZkHUC7sElM4Eu/S7YyX5tR9SJHqUDgeR0o2H9dRKf6xBuLfPeXngJBUkPEsXqIj4XOytzeabeVk0x9E+/R1hHpostipmE8qO1GWK8EbSGgkEfgUQEiMpCUAForDA31iNgAqSiHJZpJAuJwKCh8uXon1CatAno6t4ICaj/6185rz1zkOhA7ycBaI93/Pmp/LWlTqqLs+uzsJ2o99S5Grl2EryO6x/Fa4Xp/ILhamx7cLnmr+toDnUARsl3EP3mRDHFtdpcRJ19AisSH0tMy3QLqGnZDmvL2bqHxnncffrCQVEUKGV6N1+kVLQXjYVHrXvga1lNHvJTOnqhy0coQ8yBF8htGO5BAQZyw7AWXGvkkOLD3Km1zeKbrcjgktfdPHgZSpbXv5qVGp7Tchl3vEskZrmltPRXBw07lg+daZcW7pFfxtA2VU0bl9i2xlwvvgwyaMo2AcgNjKXoVJs3tsm1QbZKxpg2S42IbRcTDQaXU0TyONdcw9x17poKD0lSeFmYJv/P352M2MIkzaVs9iRJaSx4TYnMy6ClKHG65b 2Z+sfP5G McJyhIDswcKoQ9tOjr/7WC2Xj7IJceTRQxJlBq4VNmdsft4bI0FFljUESebD9Tim0IrmzCYzuDxBKLCffyWz+AWnSfOJHMwrCc8Z3D72Xt+6TC2D+LS3xbhLJOEWHq2YD4NxLnkciQdWFLXJnF9mudMrs06nlADpuHozPH8SSvYxiG8P/gPEURCHdI5EViUr6rnq8Zp+ReXlsiefFRui1ATFy6NEaxTOtSuyRkXeIyTrtWMjNnxlAJ0v+nNVBg/1wPrfUSO6egxgiBWp5zLfh8sMOk5GAfrnYoAzlo4Scsk7bfhwqBWE/VCC8zR2V8vGQKf+5+TxWDmqbgo1+uG2qwOkhOFIg5XpNyRxKn9nF4vBLuy465zh1nHCJ7m1dgZb8Dhs8fmOpA7unDLrDk2VIYM5Z8OoIRCblmvkq7R4O/3+2dHJRI8XKkZWtCA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 27 Jul 2023 17:10:15 +0100 David Howells wrote: > Fix shmem_splice_read() to splice only part of the partial page at the end > of a splice and not all of it. > > This can be seen by splicing from a tmpfs file that's not a multiple of > PAGE_SIZE in size. Without this fix, it splices extra data to round up to > PAGE_SIZE. This is already in mm-unstable (and hence linux-next) via Hugh's "shmem: minor fixes to splice-read implementation" (https://lkml.kernel.org/r/32c72c9c-72a8-115f-407d-f0148f368@google.com)