From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32575C04A94 for ; Wed, 26 Jul 2023 19:42:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AE52F8D0001; Wed, 26 Jul 2023 15:42:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A954B6B0075; Wed, 26 Jul 2023 15:42:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9353B8D0001; Wed, 26 Jul 2023 15:42:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8497B6B0074 for ; Wed, 26 Jul 2023 15:42:06 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 4E3D5A02EF for ; Wed, 26 Jul 2023 19:42:06 +0000 (UTC) X-FDA: 81054783852.01.EC0463C Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf09.hostedemail.com (Postfix) with ESMTP id 832CE140011 for ; Wed, 26 Jul 2023 19:42:04 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=sLyIAGyV; spf=pass (imf09.hostedemail.com: domain of jpoimboe@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jpoimboe@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690400524; a=rsa-sha256; cv=none; b=hQXvKrEMMi94CEe9ip2TRGFK/CttMYvH7T9W8LpLGeeap9ElmZlonZoyIolri/SxyIRtGf D9Pzwrw7YuxYc6TwvLwXeOOyYUifTuwkoz6l8hmqOrqEO6woNG/g08/ZyHMjBZvHxJ36J2 G+60Msy/lnhBXkdqpvEqeJQt90kzzg0= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=sLyIAGyV; spf=pass (imf09.hostedemail.com: domain of jpoimboe@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jpoimboe@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690400524; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1d7CaZpDV/78YrgFG/0uGdIQQxppheEYZxRbbWhaTp8=; b=6fhu9WcPHQWP7IPP4STrDPMnPf8aPw0aUoS17XKtBgXm953V1kkGaDO58IcS6FNWxW++VU KaP16kVTyg8vu66XjYofXWhzbWwHG4YKJ+aj0+jusUB9PNdYacNYkufgHeDBP6x2Nrmtgh Mwulq0tRjHR66jL3zSKuCUTy+4flgtU= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6018361CBC; Wed, 26 Jul 2023 19:42:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0408AC433C7; Wed, 26 Jul 2023 19:41:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690400522; bh=6e6cReriYF7em75Hf0iAxdRhfTIt48diinTa2LCaE+U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sLyIAGyV6TUHuowqKx/5JfDcmeo0WhbUg1yCQ8GAUu2bA1CHQXElka+Q1GRT7V1yv R0EddtJuV1su72lOKWDmqPZkTqr3rjqushe4n3Y0JyPwiujSaR6lzMnBE/bXB37uce 8O1V4aPEPJ7CtaWT6N1qd3sf2g3qg1GZ/ysRkHn0W2duBIi4pMtC3lDu6nsoC6Pt3/ swHIlZLsRsV+7qlwiW9MPLzwOhahR6eIG7+fvoyQ2iGsIvPP2A61lMuC8l5VN12v0v 2zw+8Jdxg6lE+m401O76ze1xAH8enmcSNQ3pjVXumpOLBXI9Yvybgks7Mc9qIvNX4N FrlfiSoNf+zHg== Date: Wed, 26 Jul 2023 12:41:48 -0700 From: Josh Poimboeuf To: Valentin Schneider Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, x86@kernel.org, rcu@vger.kernel.org, linux-kselftest@vger.kernel.org, Steven Rostedt , Masami Hiramatsu , Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Andy Lutomirski , Peter Zijlstra , Frederic Weisbecker , "Paul E. McKenney" , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Boqun Feng , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , Jason Baron , Kees Cook , Sami Tolvanen , Ard Biesheuvel , Nicholas Piggin , Juerg Haefliger , Nicolas Saenz Julienne , "Kirill A. Shutemov" , Nadav Amit , Dan Carpenter , Chuang Wang , Yang Jihong , Petr Mladek , "Jason A. Donenfeld" , Song Liu , Julian Pidancet , Tom Lendacky , Dionna Glaze , Thomas =?utf-8?Q?Wei=C3=9Fschuh?= , Juri Lelli , Daniel Bristot de Oliveira , Marcelo Tosatti , Yair Podemsky Subject: Re: [RFC PATCH v2 02/20] tracing/filters: Enable filtering a cpumask field by another cpumask Message-ID: <20230726194148.4jhyqqbtn3qqqqsq@treble> References: <20230720163056.2564824-1-vschneid@redhat.com> <20230720163056.2564824-3-vschneid@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230720163056.2564824-3-vschneid@redhat.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 832CE140011 X-Stat-Signature: q7qznytoyd8ucaqzt9qib53w6o5s545g X-Rspam-User: X-HE-Tag: 1690400524-77623 X-HE-Meta: U2FsdGVkX1/zymOkwI0qu2CLKcou1yfiqW1DOfSNzGTDJl3AjUp7Hir1ugFhwWfgDjZhcz0WRW4iBGtm1/GTSAB4LMURS1gLpCtZvco1NfLUfflubsy5Z3ckFdecuw5lIGRfWOBbmsSRUHTXmlky+R0dCCEBmwwZG0jxgRzUc3lv6CBzX1L341js3yGrMWBpIBqezvoIMiBIGsP01Up5qVcrFgQeo4M/bzCibhX1rq0sf2GChp+FN+WXUPpZy2oWmgWHRrJ1aLRZJmPgdnD5KOUftBR1OhYWeOBBQHpuj4a0O+Yfze4/g96mWCN6Zvl/Mqs2Ej6IBlpAxRLKjXb3mh8O4f8P+DS5mkqNI4FEEn62oOw7Q2r8kXTk8AsRkkzLdUJz7bIVs9uA9+X78IqwUN5547Jhb4Pv43O458PuBFB7fAkPK718o3EMKo0qyFG5H1iynW1fXNbyF/KH4r+sFWbjOFAApj1hGye9+Z1VHvp2YQPSm9Zep5J8Mt+QvPyhKTikQTZCeMVTF7b0tQrpD1eh4zABZboyzxkifScWBWlblrhjpNrwc0R7uN+aJKkYtNnioMbwDTw8Gw6uxk27kDi3ucfRictwTz8Nntm+gWQ6jQakB2CvpqVG6kH0Sg1OvxjZiRsbdKZhquCvjSUZYjLyDY51qyyWoBSO5ZtL/n1MkCbFLyURX0E7chnlIyLcswRCOy+z3bEj93JGV5PDYLl7WLjDmyz+DO4UJ9+LSU/tm4LCep+KHSnYdYIV/fI9Ma7DYVpr/gjEnGOwJ6TSZmqXcBqhWctJ0SXzvx4vu+v/YvXcQYdQ0em6ZW956W3zyRUu4UTDrUbgcqhUNuyDidq2CaHA0Hpqun+wEtPQLhQZYAGQyDM/RyCai0Q8FbvGqEdaonu0iXidE9T+wbK6hbewQ3XVC75VwELbON2qDU0E5yl/z5I/uDqg3yTaQcwmIJ22JfILmRKSHqqDczr +vXSl2YU GQ/TdeZtucAVwMfZtkL0Ehs5m6RU73imcxXevuUaVYmFVDZB9EMod3t2lJCy7iyDG4B3LvVEroCq731VcSC10EvcXSJVxgwRaoGEhMtCSNncCqjenwGGVFrBrDFAHoFsyzYiWoMIVHmBJRchIAyhwWK4b6xTGBvFr+oa5AhRogAJnkryz156cT+hyN/iEDUQZgsqZ9ak8+seL0TVjW7zhErWBfF1znMuQsQrjuhmeWDXhUWm85QlC6ADtCD3F6dc+HC1zaCxhqvbjCsgJMerel0HSCIq1jXoooioDEJWLkX4GjF6CriDcq8XVckFQonSG9NgRp/Pqj7jeqZXhGJczS0+piKwmR0dNeJM/gV7j2wry/2w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 20, 2023 at 05:30:38PM +0100, Valentin Schneider wrote: > int filter_assign_type(const char *type) > { > - if (strstr(type, "__data_loc") && strstr(type, "char")) > - return FILTER_DYN_STRING; > + if (strstr(type, "__data_loc")) { > + if (strstr(type, "char")) > + return FILTER_DYN_STRING; > + if (strstr(type, "cpumask_t")) > + return FILTER_CPUMASK; > + } The closing bracket has the wrong indentation. > + /* Copy the cpulist between { and } */ > + tmp = kmalloc((i - maskstart) + 1, GFP_KERNEL); > + strscpy(tmp, str + maskstart, (i - maskstart) + 1); Need to check kmalloc() failure? And also free tmp? > + > + pred->mask = kzalloc(cpumask_size(), GFP_KERNEL); > + if (!pred->mask) > + goto err_mem; > + > + /* Now parse it */ > + if (cpulist_parse(tmp, pred->mask)) { > + parse_error(pe, FILT_ERR_INVALID_CPULIST, pos + i); > + goto err_free; > + } > + > + /* Move along */ > + i++; > + if (field->filter_type == FILTER_CPUMASK) > + pred->fn_num = FILTER_PRED_FN_CPUMASK; > + -- Josh