From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 670BDEB64DD for ; Wed, 26 Jul 2023 02:57:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 09EB18D0001; Tue, 25 Jul 2023 22:57:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 04F056B0078; Tue, 25 Jul 2023 22:57:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E59498D0001; Tue, 25 Jul 2023 22:57:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D6C406B0075 for ; Tue, 25 Jul 2023 22:57:19 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A39AE120C18 for ; Wed, 26 Jul 2023 02:57:19 +0000 (UTC) X-FDA: 81052251798.30.E7F7127 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) by imf05.hostedemail.com (Postfix) with ESMTP id B2E6D10000F for ; Wed, 26 Jul 2023 02:57:17 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Lx3RvL8P; spf=pass (imf05.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.215.180 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690340237; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KzW/rGy0LH4fLap0MWB55Z1wHu6aT4al09wHOfF+Fkg=; b=VD5C9rFSQ2P7dmBdu4s1rNsEdcdMXiapLNciSC70Au0U1CFqasNblpLmMKn7HeNgJjtmIM OGqn2QCG+UklcKuT8wUKA4uNwCfWv5e+neDpjwLewObnzvioKXW/F4I/nVC2pY3xXHcbRR /ZzWaBcIJYaxSYzjGEdjimI2On9yuVM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690340237; a=rsa-sha256; cv=none; b=yckKlNPvE/p7E9zvNPZMk5oYQxdjlEOgtyuI6sUq/J4WZdDXQkZN27FLt6WvQPwYwHBVMf DQv8yS6fckHlK1B0TT9MECWkatxELlsBSpM/VZ4V7h7Tyfw+T1IRfWVoqOKbho4RODu39U 4LZPPXZ8A6mIiISe52opx53heyMcrKQ= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Lx3RvL8P; spf=pass (imf05.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.215.180 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-563e21a6011so207409a12.0 for ; Tue, 25 Jul 2023 19:57:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1690340236; x=1690945036; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=KzW/rGy0LH4fLap0MWB55Z1wHu6aT4al09wHOfF+Fkg=; b=Lx3RvL8PGnRpdj0gs5Nff7ZN5lTV1K2HUd8DXaOCVSlt00IXLloat8B9zWzAXj8gd7 YN0go/qOiXHWOOqIkdMfr7Wd+MzLSf6z3DXj1efrB9MelA8ezROYuDZsFAF6yfGMOp76 DpnfxX6QRJR6B1/00mAG7FntmlZ5qhRrOsM9k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690340236; x=1690945036; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KzW/rGy0LH4fLap0MWB55Z1wHu6aT4al09wHOfF+Fkg=; b=G9q9oBsLlEkbzvX58YP8aL7SaUfDLblESuA0t0nXtXLmoZMwD+mpklqaiF9te6WbVa X5qNZxi6fvSIrqAjIw02nobXfIvgoxGaRrwztkuTNki5qPTYgcXoMnE5pmWS5l0zujNN EX+q1DGT5FmX75hc8HT4n4bfFAmj9LJuWK665Xbt/yDnZu71aNff0xTWkA9xk0amMY1O T8onHT9rVgENXhS9YnUYMcjYaByZxrMInJw3lVtwCJTOtgoujoLXmnkPflGW7uQUVLcT aeE5zfYLTF552nc5es5GssRYYCawKzRvYdPLF2grLzmFK89NbWqDBnzUtss8MxsusYBk mp2Q== X-Gm-Message-State: ABy/qLYgBahA12jSDwE2Lvg5pKMIVELfi7kDyPTQijWIDoiQb3Cnzj8N jRBnI3rU5PfS6qlY8+AqvLDOnQ== X-Google-Smtp-Source: APBJJlFUk0Z43kk1Az93vm7xK9BJbIOtVoFyjdZiRzE/WW3xC26bs5uXcxwhdbRPXvg8cpevnX5lgA== X-Received: by 2002:a05:6a20:3d10:b0:133:71e4:c172 with SMTP id y16-20020a056a203d1000b0013371e4c172mr1061473pzi.15.1690340236429; Tue, 25 Jul 2023 19:57:16 -0700 (PDT) Received: from google.com ([2401:fa00:8f:203:a2a4:d590:6375:66ba]) by smtp.gmail.com with ESMTPSA id i5-20020a170902c94500b001bb1f0605b2sm11726272pla.214.2023.07.25.19.57.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Jul 2023 19:57:16 -0700 (PDT) Date: Wed, 26 Jul 2023 11:57:11 +0900 From: Sergey Senozhatsky To: Andrew Yang Cc: Minchan Kim , Andrew Morton , Matthias Brugger , AngeloGioacchino Del Regno , Sebastian Andrzej Siewior , wsd_upstream@mediatek.com, casper.li@mediatek.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Sergey Senozhatsky Subject: Re: [PATCH] zsmalloc: Fix races between modifications of fullness and isolated Message-ID: <20230726025711.GI955071@google.com> References: <20230721063705.11455-1-andrew.yang@mediatek.com> <20230726023122.GH955071@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230726023122.GH955071@google.com> X-Rspamd-Queue-Id: B2E6D10000F X-Rspam-User: X-Stat-Signature: r5fnuyor8tikajokm9ur34tmwqjk7sqq X-Rspamd-Server: rspam03 X-HE-Tag: 1690340237-336377 X-HE-Meta: U2FsdGVkX18A8mxciFEnre1ZS9zcJ9UGCEijznOE2SYJUnQK7erIyAjA1YXqDrH+9VptyA/ps9QrvwXTcILgVdebPpz2m6audLwt+HLkF+OgbCQRUGt3EwnFNIDRQOdmCKRJZDJ1y8kPEsq08PWRJWnMmmOUR+JhfC2Z9nt+ns5DUuqoMlTBUdzOw4853xQQvNkdr45tRh6ON9jSJ1T1mRsRecvcnf8qL33JzF929XjLgSR2lH/eokhBR3g4FK00vbSCqGY7sVL4Cx0sHR7K+2Mf4bTiVsxmWfRPdqpysZYjfP2PJZUkpz4fXcwXx4xEj2Nurr1SQs+S4ICl0se2BEvBoEwrE5c6P2mPCePd3QAapw5S3y0melZthe2vpFh7eYLWOavI1PzPccewKQ+Qp1Er7quTt0SSjJCaKDd9CaGJwduzz+N0qU+svfF2lcA/y84BcncQYkfA/0JIx78sTO5qhVYf/OfS91tx2G4u2QxtwnB5hAh14WCEkbxOhCTffdjoUaq3rpAN3qSpehiVVk2LBOC/SPxeR453FEa2XTKtfv2yyE9DTu8tJ82hDsN7g+0MJ2lRNbVJq8DV/G2kz0N8UXA9FNzrK43PqiH3SCadvkUlv+5QtenBHixfvWMzpHwwsEhLSKZgGI+9S0cCy2E3B6YZs3rmE3UTXUgj61/NMjNCTCnro+v8HMAGpmqrDj09P90ejV2+C/xkt57D9SB8xRu66jdGkrwr+5X0gf+wFuzmQ17isEuySNlsORGLlUi/1GWUTnidB4LqjtkCzQ9LHlqooa5O3YW82HayQGWMoPdXYiOHrGtqQXEEb4Cp5UjYbq2pVPai1AwPMLDk8gykhVi89oHjCyc83LsTIHvHkITh9k/JwBPn+hJWL7MWZOwWappZzFheV8q4s0kFBGirTaAZmOzE4tnSVlR/g9SFtZ4jR4xSprfYe3UOUWxUes5szlOBIjreJurFtDx wMePMZV8 xnEh17+fYZl/xVYCk+3uNg07yptJTcajlREfd2HxySQgvLOjT08Iy8UhUGAJ3WAT3E9B2kHzSti9dMgpEPa/pgB/pgin3DZo2fqWCHNxJ/XQmKxcD7lr8VzfaX+GDwruFy4jJDuAs+YFULDEgIRd+fXYyS2U0WQyuHYUVwy994RaUyJ7k79/KG3Ck+wmbI9D4wb1qiZAc0GqCnLGPrl9+OL18gzbpOdN+FzUzjuSGspdoYue3Ihuv+8L6dQJ5S5imRE3YTgZWfRAbh33XH/imTJA4I1n5ShOAWPOCIGdg41hr0Je2xJ/3RWfyef46PwZkqT9aKn8tVN6BAnO2H1b4MQGfCiUjQh1+EyJXBJ8nQ+79fSs3q5ISCi7DJXGu2SsyOVmFcE7lThpNhrwP+pydwlE0SrW1zfsaTUAXk855Q95ZjYc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.144965, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (23/07/26 11:31), Sergey Senozhatsky wrote: > On (23/07/21 14:37), Andrew Yang wrote: > > > > Since fullness and isolated share the same unsigned int, > > modifications of them should be protected by the same lock. > > Sorry, I don't think I follow. Can you please elaborate? > What is fullness in this context? Oh, my bad, so that's zspage's fullness:FULLNESS_BITS and isolated:ISOLATED_BITS. I somehow thought about something very different (page isolated, not zspage isolated).