From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61F03C001DE for ; Tue, 25 Jul 2023 17:43:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E8A018D0001; Tue, 25 Jul 2023 13:43:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E39AE6B0074; Tue, 25 Jul 2023 13:43:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D292E8D0001; Tue, 25 Jul 2023 13:43:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C8AEF6B0071 for ; Tue, 25 Jul 2023 13:43:15 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 95254120DF9 for ; Tue, 25 Jul 2023 17:43:15 +0000 (UTC) X-FDA: 81050855550.11.8686C9A Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf28.hostedemail.com (Postfix) with ESMTP id B076FC0019 for ; Tue, 25 Jul 2023 17:43:13 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="xoVJF9/q"; dmarc=none; spf=pass (imf28.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690306993; a=rsa-sha256; cv=none; b=WQe3FOWdi4V1vBa2uTyJ48vn6wkkb1ZfYYDFOpBmwKgP7i0MehDB6M1kW+aPTvd4cp+Esw 4uraX4nxiqjFmOjM2AxOdH1/tcWEiqECfUFhw5QSfcSzrXLAXXC/uDzagjrPUFZ0aAf7cL rUZBLzxPun5tDERpiqSmPoSB3Ot2+zI= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="xoVJF9/q"; dmarc=none; spf=pass (imf28.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690306993; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lvBtawaJ3EexUMJTLs1T6uVkk976jUhaV2eerZFuUz4=; b=unMMGg4HWT+hl2jF5/pmjyq2bhsA30TEfHFXExjt1Bpwkp6DJ0sfxhcpNxoOMO7n5ShzJR f/BvDdyjSCykdOA6GI9BA2egGdb7I8Zwa2KfGcwVED25qg6WMix9FFodp0f4hKzw1/wOAX NY6aX2vSj5YlMYFET0G2IjA5I7PQQoo= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AF15261842; Tue, 25 Jul 2023 17:43:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B1F20C433C8; Tue, 25 Jul 2023 17:43:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1690306992; bh=fu3IBUmM1hIiTky2e88ZAQ1t8ZP4sqKPRBI5GS1mp2k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=xoVJF9/q0IT6pL9/yc5wwBX7EHfCwvlEl4/DiYssHgWeqQNMhcfXcGDzScpcyCIMd tlnZ8bZIOgFu+gE3EABqIhknibOnNkJ9hjO7Qa23BWJSdiOehqY3no7LPHsYODoLUE rXXfP+4vkrQHN/YDiIx2d2B+GU/qfbLduSUExjYY= Date: Tue, 25 Jul 2023 10:43:10 -0700 From: Andrew Morton To: Johannes Weiner Cc: Yosry Ahmed , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm: memcg: use rstat for non-hierarchical stats Message-Id: <20230725104310.ac652a03ab92357a162b1f92@linux-foundation.org> In-Reply-To: <20230725140435.GB1146582@cmpxchg.org> References: <20230719174613.3062124-1-yosryahmed@google.com> <20230725140435.GB1146582@cmpxchg.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: B076FC0019 X-Stat-Signature: c31huufx9nik8wgsca9jpanaeibt454g X-HE-Tag: 1690306993-232550 X-HE-Meta: U2FsdGVkX1+7qHRpYvRAr5G+Azn+zNc9sQmAQ+xIcpFGeMzDSWQfoe416e7T67DcQEEBj27cn2y2vcn1WjJEOpfjVivNKjK00uVI7wTK7Jn2VLd7W868rE5mhrz8yfTp3qbLvIRcOxh4jseLWTAT8RwvMIBZFQnQb7lvQav2fsIUGjnsRvxAaMgblGj9eKdwCmxl5sc2gKKHv+D9ZJrTWfsrkzmISqZ3f/vNjGbYkK5Y9+bHda9mHfNd2tWkd/QN0JAnVZEeiPqP3A6fIqX/ywyGG6bkRDMCXNH5sP2LiIADRjIRN2i0dceiI9um1STYd5mDd/d9PM1TP264YRVk16Jyf4Wp13HLQ5U8yi1t4mYsGnI5xOZd0hp0ByR+ZtGWYdel0VPYCv0H4RO80seRJrqAvtZh7choNuyIEmpRVwDwGhRMosJ6QaxlyysaNJo7TbE9HfvjBGG7shLr7TCIzZVTHd4HDLlZU9wA4Pa69i1jS9eH2/M5r2qhaSisTi+kecPI0ApBaT1jiiyhXpOe2jIzcY55bE+NLg+mcfqwmVREox5vVPnG10H9BWmxDowHEv6ljpaPFbS0AMmxamBOOE4m3dLVYVhrFf7TRdC6e9eDYxR+BVVwShLAwgh9G26R8heu/IZA56oMB2TsW2d7p7+rR8N323gWkkK6qXSiw/4xhGk7reVnUbcIagZbcoH8sgdyxmGxmSpvt1NRRntBSfYukeKx29v07l6U4NM8wFUaj76COu7wPsRygXVaFrQ18ibefQydvx4Z1QvSbn4qTitv4NSCmNgqWb8cUhrpRM6mV98GWIoLDTJ1F2/Ftu+xA194vZvlJIuFHEyRVu7LIcieRoMnWmwqiHlfAnnoYayUt81QUHl7LPhD729uyhQphQ6UiZof8IhGgLzrPc1rbncnnRTmrU2Z9v4lvxNn/6HJYlLtK3YHX5SNoT2/o9sDjl2Ky5wfAhkAe0NgMhc QAI9lTlQ o1qhm7DSBOa9WfNzGk9IUOwadO+YIOhhGAiAuphpS/vERKq9QnaQSuJfc8yHO0Ov3O+EeAGSbYp1VreFkP38RbuD0FHwYMhYi66miF7tViooLUiVzqfALR3zCeF/CD2E8gm8Xx/qHetUD1dKaaXxZQnF63UEZ0s3b+EgQakX41FlmWnZ70S1LAHRwwI9oV3m8JqkYTDrFVxgq4+dyAspHWgWAO31Nojmf6lC3KfCYEBNCnCR9bExWVe2We/11aXIVzJVsUX14UQu5Lb/yIGGPkfkVcaMvic8uncrimDen4O775vCyHreEf7GmLSa+K8e+++n52kqZ34ruzCnbDOVqvqN51kocU4C2rewe2wScOV7tIyB7IlVJcTsFaa5m+GcwJCH9yA2HshYMwcjfcJwbS2Rw0g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 25 Jul 2023 10:04:35 -0400 Johannes Weiner wrote: > > Signed-off-by: Yosry Ahmed > > Acked-by: Johannes Weiner > > But I want to be clear: this isn't a regression fix. It's a new > performance optimization for the deprecated cgroup1 code. And it comes > at the cost of higher memory footprint for both cgroup1 AND cgroup2. Thanks. Yosry, could you please send along a suitably modified changelog?