From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F2A0C001DF for ; Tue, 25 Jul 2023 10:05:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2FF3B6B007B; Tue, 25 Jul 2023 06:05:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 287858D0001; Tue, 25 Jul 2023 06:05:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1021F6B0085; Tue, 25 Jul 2023 06:05:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id EB1CE6B007B for ; Tue, 25 Jul 2023 06:05:17 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id ACE10120D4B for ; Tue, 25 Jul 2023 10:05:17 +0000 (UTC) X-FDA: 81049701474.06.D3EDF78 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf12.hostedemail.com (Postfix) with ESMTP id 2D3A140021 for ; Tue, 25 Jul 2023 10:05:14 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=QElIOO9R; spf=pass (imf12.hostedemail.com: domain of aneesh.kumar@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=aneesh.kumar@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690279515; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qsU83/eOe5kjugOv8M+CXiuvNzVVJM8wGItDRM9Ulbo=; b=oSujOGyRYAv4GOrMQc0IQKQTVx4xX1w9nISTfrX0NEHehb+jwMRMkGPg/kO4nMGGdYEFir P5+FZH2CFJodw9F2f7AfvTlVSGksT/2oo6TLk4+U37aUxZJoQgrjedn5fLitaMKy4sGM+h Lv9rayO7ScuAu4TPz+OWE6qh8+GCZ9M= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690279515; a=rsa-sha256; cv=none; b=GqE4yz+G5uINOlR/1gHwbUJqXIE98PJjvVIcQHcgJu6XtnN+g/HwNDesl+kEabfU/bogRY Qq1PUcCvIlCzelNDSdIhBmMgissoXwdFtdbbQ1Op8TUkCNI/rCfyMIwqUE8GVBDIn9P61Q JZurYBBmRHsV06ATh2eThy5LCufjMNU= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=QElIOO9R; spf=pass (imf12.hostedemail.com: domain of aneesh.kumar@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=aneesh.kumar@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 36P97otW017483; Tue, 25 Jul 2023 10:05:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=pp1; bh=qsU83/eOe5kjugOv8M+CXiuvNzVVJM8wGItDRM9Ulbo=; b=QElIOO9R1cijdKArOb+/7MCXxstibU/v0zTCAk1EYsZx70DW26j2sv4u4NeBYNkpi23Q NRjpUGcvZmPpwf+7TPpaJsgYjn0ML+w07xILY2XB5BQa3si3kQ75XBJDUTmEo7umTyTU RTzwRmDOhBDSGrTmX50TETQ+4HIJwwfHVyMvBWEDn9rcEh5O8qtzFI3O9S3SlhSjm0pT PI/GSmoJsnvFZtP6ukFn+mz1TcPgq+MwpwOMnLelZMYx8UymbAQ+YBCkyHrchYaHnfx8 x5pHGL//nnMAe+rB9P3GTOHcUYwwPQRmO2FE3+KkweY6MiV9/2PeXUC/EGjhoLHPG2qj YQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3s20jtf5j7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 25 Jul 2023 10:05:06 +0000 Received: from m0360083.ppops.net (m0360083.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 36PA0SC2030029; Tue, 25 Jul 2023 10:04:45 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3s20jtf4b7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 25 Jul 2023 10:04:42 +0000 Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 36P8da4t003714; Tue, 25 Jul 2023 10:02:54 GMT Received: from smtprelay03.wdc07v.mail.ibm.com ([172.16.1.70]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3s0txjtusc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 25 Jul 2023 10:02:54 +0000 Received: from smtpav02.dal12v.mail.ibm.com (smtpav02.dal12v.mail.ibm.com [10.241.53.101]) by smtprelay03.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 36PA2pRd2884346 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 25 Jul 2023 10:02:51 GMT Received: from smtpav02.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 56A215805F; Tue, 25 Jul 2023 10:02:51 +0000 (GMT) Received: from smtpav02.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F148E58051; Tue, 25 Jul 2023 10:02:47 +0000 (GMT) Received: from skywalker.in.ibm.com (unknown [9.109.212.144]) by smtpav02.dal12v.mail.ibm.com (Postfix) with ESMTP; Tue, 25 Jul 2023 10:02:47 +0000 (GMT) From: "Aneesh Kumar K.V" To: linux-mm@kvack.org, akpm@linux-foundation.org, mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, npiggin@gmail.com, christophe.leroy@csgroup.eu Cc: Oscar Salvador , David Hildenbrand , Michal Hocko , Vishal Verma , "Aneesh Kumar K.V" Subject: [PATCH v5 7/7] mm/hotplug: Enable runtime update of memmap_on_memory parameter Date: Tue, 25 Jul 2023 15:32:12 +0530 Message-ID: <20230725100212.531277-8-aneesh.kumar@linux.ibm.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230725100212.531277-1-aneesh.kumar@linux.ibm.com> References: <20230725100212.531277-1-aneesh.kumar@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: fXFt-EK2vDamQt_gvKn28gyP6SRS3QRX X-Proofpoint-GUID: _Ks0d0ClKFtg6SwX-t9KGdVTXczUJ7Za X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-25_04,2023-07-24_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=743 clxscore=1015 priorityscore=1501 impostorscore=0 phishscore=0 mlxscore=0 bulkscore=0 malwarescore=0 spamscore=0 suspectscore=0 lowpriorityscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2307250087 X-Rspamd-Queue-Id: 2D3A140021 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 6nn46tdw4bkam35ghmnej1ec7f9cm3fm X-HE-Tag: 1690279514-555639 X-HE-Meta: U2FsdGVkX1/u7tn8Biq7zOF7UW3/nODIt98mhX0cc+p7EkzYfy0w6qN+PQUd/ir+K03lUpe5JMWuZKrW0AMM9HgV+QIAUMB1cRy0rBc+R9oP07gVfxlwVIGy0X5LNmI6Z8Xaq0Q4YZCyyf+tXrhHYeNqosgsYqAsc4uFINNYX55QsyRk0HjQ6occ4ve1DVovFBY+Vajc76QngeBVQHU6aDD4/fwd0tYinHiNFlW43aVNu9EBRgx/xby5SPXBdXsqnwzE3jYnUO5e96sCwi7Sj/GhqUyqdMQTeo1pPNK9bbzXgxUMglVpwweIT0mlGxCNy8ol09YhSkCzeuj2kvxpErj10eRG3ccwy7BO3IGkhmK+0RdhZ6vSZ8dkFyN2bxK3yXAHx1uxKMu4zjJg8BCwdt0GoTEBnnEfvAxIxFJrHm+w3eQxRZnYF5OEkDx1FFtADZVvHfiRRnQfP3XlpBeyrIMfxNwCAXhBA2h0EpSrL/dBLYPGPDgkGrWIFR4Bh8CcFx+SIqXZKZ9PhivQDfWmo/Qe58/CNx0RdO6a3kpnoL7vJyn2VQpl9HlH2GaFA7STXu7Nk4yo8JNxeveCbgI7oJLk/LJbW7MrL5OfO0lRCi41iSqVs+jttHJM0qLaEZOJP00dt3HF/FGl59T1e2Ybz529KdS9F3GNE/0cGEGDKg+FCfdzrFewhxDTR+3+nyneMYOByZYkQv2AgYx0SnpmOpk2Hqw/ziUTVk+QveraIKujdy/pATyV2Wjv1gpGcrG8nEyiK6FCas4y/seAr1eAvkhNmHDJlnFP3dl1bNPs83jaFlYzWAXiL9an3VK2sRrKKfn3ql9CAMAjewnhnyOKa5h2QXj6oI6sZJ3hOHHVS2mtnVb+APGTcVOiAldiCG35Unw7eyFiq2u9jSzsn7DLaWYFHK2biwFJc11qwWYVNFioeqV8cpro3voKlJv8WLZ7FSAy9+NRC5d3zxje9XS EtgMXXi4 ajaABLFl+ZIJ01PqcOfumHHEp2VKCOaKvHoA43RXUWTSB4iLjvV7pDb6FIxEYw3xsh1rfX7BDc/J9Mh1hHU0kD07P4aBn/fWjMzv+lisciAcR/fyf9WH7I26R/jtZnafS0BqXdt3BDPuU/PHYx8ApJK1S6EqWqqRQjM8HldMhPv4Nt9fvkj+zg4dRgg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Signed-off-by: Aneesh Kumar K.V --- mm/memory_hotplug.c | 27 +++++++++++++++------------ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index 96e794f39313..6cb6eac1aee5 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -95,7 +95,12 @@ static int set_memmap_mode(const char *val, const struct kernel_param *kp) mode = MEMMAP_ON_MEMORY_DISABLE; matched: + /* + * Avoid changing memmap mode during hotplug. + */ + get_online_mems(); *((int *)kp->arg) = mode; + put_online_mems(); if (mode == MEMMAP_ON_MEMORY_FORCE) { unsigned long memmap_pages = memory_block_memmap_on_memory_pages(); @@ -116,7 +121,7 @@ static const struct kernel_param_ops memmap_mode_ops = { .set = set_memmap_mode, .get = get_memmap_mode, }; -module_param_cb(memmap_on_memory, &memmap_mode_ops, &memmap_mode, 0444); +module_param_cb(memmap_on_memory, &memmap_mode_ops, &memmap_mode, 0644); MODULE_PARM_DESC(memmap_on_memory, "Enable memmap on memory for memory hotplug\n" "With value \"force\" it could result in memory wastage due " "to memmap size limitations (Y/N/force)"); @@ -2175,18 +2180,16 @@ static int __ref try_remove_memory(u64 start, u64 size) * We only support removing memory added with MHP_MEMMAP_ON_MEMORY in * the same granularity it was added - a single memory block. */ - if (mhp_memmap_on_memory()) { - ret = walk_memory_blocks(start, size, &mhp_altmap, - get_vmemmap_altmap_cb); - if (ret) { - if (size != memory_block_size_bytes()) { - pr_warn("Refuse to remove %#llx - %#llx," - "wrong granularity\n", - start, start + size); - return -EINVAL; - } - altmap = &mhp_altmap; + ret = walk_memory_blocks(start, size, &mhp_altmap, + get_vmemmap_altmap_cb); + if (ret) { + if (size != memory_block_size_bytes()) { + pr_warn("Refuse to remove %#llx - %#llx," + "wrong granularity\n", + start, start + size); + return -EINVAL; } + altmap = &mhp_altmap; } /* remove memmap entry */ -- 2.41.0