From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D530C0015E for ; Mon, 24 Jul 2023 12:26:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C74CF8E0003; Mon, 24 Jul 2023 08:26:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BFDA58E0002; Mon, 24 Jul 2023 08:26:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A9E8A8E0003; Mon, 24 Jul 2023 08:26:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 939758E0002 for ; Mon, 24 Jul 2023 08:26:28 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2B04780A15 for ; Mon, 24 Jul 2023 12:26:28 +0000 (UTC) X-FDA: 81046428456.10.059039E Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf03.hostedemail.com (Postfix) with ESMTP id A8C2A20002 for ; Mon, 24 Jul 2023 12:26:24 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="ZIw/NB6u"; spf=none (imf03.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690201586; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FgtQe2iC/0NBUdTIYwU6FvaIC/2mZu3i/WpphGYT+1k=; b=D6gqqxW7BkPZziWeJlL87/2k+VJ4AZxMQVAWxaKMfQDKcnS9wrjLOBQaGiGcuRhr912fiv 1MH28bao8YZmhvIMBnZSLSF2G2B87UDtHbOsQMyg2XksxUeb69qcuqjwPFYhwVKnnWLOMd iuKvSIWkymUmh1/cH7AcDJZCDOnN+HE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690201586; a=rsa-sha256; cv=none; b=YwHxlEh/E8/Eq3lkcxN+WQAz7hb9c2PHLWXIIPxb9A8W9EaNoW4GmiPbKhLTaUdhsWggUn iYVRib6BiG6Yw94R90vB4bZL6PN3CikCA8BYpTuiG5HgzGC3SRvmJRUcZX2bxXlsuu35Pk jpYFYzjkIBZHyvXBwEfzbEj6ZYBQw/Q= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="ZIw/NB6u"; spf=none (imf03.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=FgtQe2iC/0NBUdTIYwU6FvaIC/2mZu3i/WpphGYT+1k=; b=ZIw/NB6uEo0641+Wq8EzNrbHBV rrdS2AkdlanLUW4jtuNV7YJmE8dx65rhuqNN6d+O2A+YB9l53nFIBcRLIER24dz2SZGSbQpUdfRFt O+SQB8u46jmJ0V3lkB2dv55l0XkOFJ2vLXAjC15/xKJogcvcsepgRzVe5Zf2VfboPt9BBV/mRWBu/ r1HeDooSZKO8KrM91YanEuhJbHVgQEIeOAYvY50OE9Oa0XF31R7B/jnZvsmScHku30xY6VnjseHTr PXjdkkROSxxW+REohqgqj+xc5EAtZBuKqFbmv/xo9QoVvk4ORWEH1k1N/to1rfbfNrbjLNy69S5M/ AYY+hq7g==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1qNudM-004Ned-Mr; Mon, 24 Jul 2023 12:25:53 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id B0440300195; Mon, 24 Jul 2023 14:25:49 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 5C178266885CD; Mon, 24 Jul 2023 14:25:49 +0200 (CEST) Date: Mon, 24 Jul 2023 14:25:49 +0200 From: Peter Zijlstra To: Qi Zheng Cc: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org Subject: Re: [PATCH v2 03/47] mm: shrinker: add infrastructure for dynamically allocating shrinker Message-ID: <20230724122549.GA3731903@hirez.programming.kicks-ass.net> References: <20230724094354.90817-1-zhengqi.arch@bytedance.com> <20230724094354.90817-4-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230724094354.90817-4-zhengqi.arch@bytedance.com> X-Rspamd-Queue-Id: A8C2A20002 X-Rspam-User: X-Stat-Signature: 6xfhhyi9asn4nhwyk7g69joizh9oxhiu X-Rspamd-Server: rspam03 X-HE-Tag: 1690201584-448137 X-HE-Meta: U2FsdGVkX1/CF30ZyG8eX9ffac+42ZRxT283GS8uty4GXGXDp5PnVp5c2OiTnQdKfUgyBTLZGAM8ITr3rci665FUFL9RgInxg4tuNai+I3J+kXQORVbKXBGUDjmWmRKAvUq6o4cOxO6uZbjDlvOVsqw7XUDQYTeqdJg+pImYJWIOzKCzEsUP4Lc7L+nsSvLFXeK3nwIBa61QLMAkVmAEGTTLY0pMiF0/x+WIwRMA53yAvfSBF5XzASbW8aMNVSxSHc7TrJm0IhMqUd5ILSV7LunCXhkuHvp19uYpWIJYX3Pr/vBdGm1W8P9rQ8+dZWzg0gdmByj2GecTOggRb1qCPLRzwb413vBeaYe2SLahsC/sg+Ay/gtqYqL9iPdJBaFtAtdExTs7l28H84/AIrGpc/89Ecufirkv80LeQjX2Zcr2vCzPaH2iAtvbKc5F3P7Dcjv505ZuAaF3BG2ZlG8EC5ro4XDfpkyAWIUxD40dZGWPC90/S6Gr2yt2yqFUA7IBqZPCjuKuNJuQtb9cm06XWTqaOHa9AtBUbEKS7eQz5AOgh8AimyivdJoqZgg4D6LXbrvWCaNL95n63Kdl8G/oZMxRl+BYYkZlTQGlLraUbAWo9VOQAeLeRLJYhJ8dZFoEs6RAtEMvweJncke7iNe+a2EWD73F5AFhca+yRU/1YPNGkwOBVFHEEIUKu7SgB4oLfBrmlRNYlDxHVUd7clzJBrHX8zQZ/BgY7yJlF5e6ABN2K+XdmJnm+UGO+IP/7NcKIVAWXlWn6rwAL26FVSp9wMYEKGZpzwXH1aBs3pk3s2G9gGpD5GwV9e1LadHm6JeSM3DwRAs7zCmO6ZXAYs8IfeDgW47V+elgCETbIK+0Wy6bTi/Y3Mh0uK/atX9VR4ycz+JNUskJd1bGCXVsdDQ8C1p2KtShAMVFUnG2Qw4hq9XeE9slJeqiOEHh1EW/dB1Ma7UGf4NPfjzpqYNT+Mf DCaooZyF qUDYim17rVaeSwk1WdMnrjy9iqsJdZKZGEK/s7MFpvYze8RcAdWnOr2sy+4g5ESB91/Q01htaDmQ7ZldsS5K6r5vCjuw8vUDfgmWz+SNZTlN0RatQYPYBqoNK78ZNZVnBH26F9RhNUpWwr9c= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 24, 2023 at 05:43:10PM +0800, Qi Zheng wrote: > +void shrinker_unregister(struct shrinker *shrinker) > +{ > + struct dentry *debugfs_entry; > + int debugfs_id; > + > + if (!shrinker || !(shrinker->flags & SHRINKER_REGISTERED)) > + return; > + > + down_write(&shrinker_rwsem); > + list_del(&shrinker->list); > + shrinker->flags &= ~SHRINKER_REGISTERED; > + if (shrinker->flags & SHRINKER_MEMCG_AWARE) > + unregister_memcg_shrinker(shrinker); > + debugfs_entry = shrinker_debugfs_detach(shrinker, &debugfs_id); > + up_write(&shrinker_rwsem); > + > + shrinker_debugfs_remove(debugfs_entry, debugfs_id); Should there not be an rcu_barrier() right about here? > + > + kfree(shrinker->nr_deferred); > + shrinker->nr_deferred = NULL; > + > + kfree(shrinker); > +} > +EXPORT_SYMBOL(shrinker_unregister);