From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62554EB64DD for ; Fri, 21 Jul 2023 12:16:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD18F2801C8; Fri, 21 Jul 2023 08:16:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A81A02801C2; Fri, 21 Jul 2023 08:16:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 949912801C8; Fri, 21 Jul 2023 08:16:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 850182801C2 for ; Fri, 21 Jul 2023 08:16:55 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 361E94027F for ; Fri, 21 Jul 2023 12:16:55 +0000 (UTC) X-FDA: 81035517990.21.4EBB107 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf19.hostedemail.com (Postfix) with ESMTP id 3F8451A0014 for ; Fri, 21 Jul 2023 12:16:51 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=TxOHpAHG; spf=none (imf19.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689941813; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5PS40R3k/WtSAiwAETN7aeanCVo4MyLNg3uSnAAedI8=; b=dgp8BKMTfCjKhRmdpohBCt79AMUkWqk741ge5KurHJSF5zKlpLr8mLHBzfTcEwFMoNpOuq oboF3ksi/ga05ON/U0doaPpT3fWhTbojXinCsWyktnwIO218rBhW388VJLu1akAZmmgU40 CwurXFhUqLMaqh5CLNGHphP+ZGt3eW8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689941813; a=rsa-sha256; cv=none; b=VS+UGiunx+2V0/wRfjZSnJIjZc1pNQ5f+D7emuILptOqcSdgwgLn95/M1Fml66FdkJBimb wHf4fW4/h4wTgeeNmOqcDH9yHzGVDI+1Y8drX0+4IKfmr+ReVbWMghnxx31fE+hwxkSz6J 9s7SzMs7V7f1hBircsyzLak2fRQaRPk= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=TxOHpAHG; spf=none (imf19.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=5PS40R3k/WtSAiwAETN7aeanCVo4MyLNg3uSnAAedI8=; b=TxOHpAHGpLJBGmu1TgPgQJ9djs tkakXwliMQBgD/Q/rGnbZliHw3eGXj5g93St8GOHjJ31j01BaRvXkzFgqwWV6/zUoXNE3CqSeFIVc DrPQSnG1YaZFPs5Nb3wNJK/c0X2PuwDaMB71nsTM5oUCXPdGeQsLtRArqGumtJ6/TCCnH2ei7M11o T2TXNRrKfFsKkE1th0kXHKusb8xABSQQTw83t0cBa8z7DKfTA97nPw1lbOlXbjKMUedAPULZ4UNok y5jsWckcBkqN8wfJ6yyelWqsMnJtUZRIxecbV2jCkSZhbnLuULmlp8MoHSFgKjdr8fsCIOG7+4J7W GZhqVS6A==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1qMp3o-0016AW-Oi; Fri, 21 Jul 2023 12:16:41 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id BF9E73001E7; Fri, 21 Jul 2023 14:16:38 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 8B4C0264557F8; Fri, 21 Jul 2023 14:16:38 +0200 (CEST) Date: Fri, 21 Jul 2023 14:16:38 +0200 From: Peter Zijlstra To: tglx@linutronix.de, axboe@kernel.dk Cc: linux-kernel@vger.kernel.org, mingo@redhat.com, dvhart@infradead.org, dave@stgolabs.net, andrealmeid@igalia.com, Andrew Morton , urezki@gmail.com, hch@infradead.org, lstoakes@gmail.com, Arnd Bergmann , linux-api@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, malteskarupke@web.de Subject: Re: [PATCH v1 11/14] futex: Implement FUTEX2_NUMA Message-ID: <20230721121638.GH3630545@hirez.programming.kicks-ass.net> References: <20230721102237.268073801@infradead.org> <20230721105744.434742902@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230721105744.434742902@infradead.org> X-Rspamd-Queue-Id: 3F8451A0014 X-Rspam-User: X-Stat-Signature: ctwe1zecdh1d6qoiiyzey1q8e884b1df X-Rspamd-Server: rspam03 X-HE-Tag: 1689941811-651091 X-HE-Meta: U2FsdGVkX191icLM/Vw/qt3bAPV8jAAJ4XES+iJNS3CkZtn4FXyrQTX+JYvjYrbaTKA/6BU8Cnfsjdy+kUFlzj00PQzmwTqcj9olo61H9f0zNMA/iRyVmhJ+qfFwW1KpqY7PcmopjixOpa2iZije1NVpLPvetGZZoUzhkGaejNP2jpx4ArgdScgodBQqnVfSK9ShaGMIvIrwU81Pbjp/9LL0yd8cmjlUNr5areUvE92MxL9mMONZNbd/8bUYYD8WTi19BX+6OBVsQdGFOPQNGPcAy/l8YupttpmXNRofIW4KuYXkygYEaP2lijUWkKFX3TIvvyp8s8kfz0ESjV9kmQSzkAd6DHI/Bp6PCliuo5uEVKvRNvmDKtau/Pq3KW9DvwhoJcI+Tkma0VoCZC5W2p4VMqHzmfNcYVokadkiHPD4U528kbQdDzy3VZB4ZdbMUs1p1nARPLRREtvI+amA9Msrbec/Fo2xNlrHd8I1wcYkS/3vIMekC5Wj8SdzM2daOHXI4ahZZzFmsIJb4D8gIMo79np6Z6kHzOKUuqpQEbw/g7I3bLKeB6J9Xngq//PdEL4AS9Xusj/tWPVcekaYCOxtf6BB89SBCNc7iWcEpcEgCXZrVQD1w8c5+hNmImiir3NDYl7Bn8Q6RW1ucjJXJGsIQWzH4jNvkYWtgGANSjdH5FZ5rB3xupVDxSyQztZgOZ3/JUFNS9YDAa1wNshEioY89mj+rnYlJXEjGmWFcgW7m3xsoDRO4mEjdy+PCoXYNC85fAwJ4luO9QxXJtmCU8rEk7AsNR59OA0HToqTQipxB8vNJtTdjB22bCyTDviRkuXsKfYuQ0GU+J/LMzRtvCrw7PGToeVlGecej3H00VFvCwWUn5QEO7VSXj6c+tB1yy0HI9TUSl/RqdjbjFy+L46c7spKhYThbgXUApE0IWTA0qlekKe1io4ou2PoWjxxuTG5pzhxRou+0Vwx2YY eVbC0ii+ a8Lj9hkJloCELIaHLlU1+6PZ4lwV0IQktOJwnbW3MjGHA1rTLKVumGkNs3+vFmKbLVtC4Jdx4327dveB3P/JIipHWh5Z4Qs5EaSZKdPxueTIVFPblS/X21ahgf4Zsf31/BHrHY2ZczqjFOg1IVeAfmTC77RXJGvn2LvZ6c3NPCq0LJYP7yT5sRbiU5w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 21, 2023 at 12:22:48PM +0200, Peter Zijlstra wrote: > @@ -217,32 +259,55 @@ static u64 get_inode_sequence_number(str > * > * lock_page() might sleep, the caller should not hold a spinlock. > */ > -int get_futex_key(u32 __user *uaddr, unsigned int flags, union futex_key *key, > +int get_futex_key(void __user *uaddr, unsigned int flags, union futex_key *key, > enum futex_access rw) > { > unsigned long address = (unsigned long)uaddr; > struct mm_struct *mm = current->mm; > struct page *page, *tail; > struct address_space *mapping; > + int node, err, size, ro = 0; > bool fshared; > > fshared = flags & FLAGS_SHARED; > + size = futex_size(flags); > > /* > * The futex address must be "naturally" aligned. > */ > key->both.offset = address % PAGE_SIZE; > + if (unlikely((address % size) != 0)) > return -EINVAL; This enforces u32 alignment for: struct futex_numa_32 { u32 val; u32 node; }; Or do we want to enfore u64 alignment for that? > address -= key->both.offset; > > + if (flags & FLAGS_NUMA) > + size *= 2; > + > + if (unlikely(!access_ok(uaddr, size))) > return -EFAULT;