From: Yin Fengwei <fengwei.yin@intel.com>
To: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, minchan@kernel.org, yuzhao@google.com,
willy@infradead.org, david@redhat.com, ryan.roberts@arm.com,
shy828301@gmail.com
Cc: fengwei.yin@intel.com
Subject: [RFC PATCH v2 2/4] madvise: Use notify-able API to clear and flush page table entries
Date: Fri, 21 Jul 2023 17:40:41 +0800 [thread overview]
Message-ID: <20230721094043.2506691-3-fengwei.yin@intel.com> (raw)
In-Reply-To: <20230721094043.2506691-1-fengwei.yin@intel.com>
Currently, in function madvise_cold_or_pageout_pte_range(), the
young bit of pte/pmd is cleared notify subscripter.
Using notify-able API to make sure the subscripter is signaled about
the young bit clearing.
Signed-off-by: Yin Fengwei <fengwei.yin@intel.com>
---
mm/madvise.c | 18 ++----------------
1 file changed, 2 insertions(+), 16 deletions(-)
diff --git a/mm/madvise.c b/mm/madvise.c
index f12933ebcc24..b236e201a738 100644
--- a/mm/madvise.c
+++ b/mm/madvise.c
@@ -403,14 +403,7 @@ static int madvise_cold_or_pageout_pte_range(pmd_t *pmd,
return 0;
}
- if (pmd_young(orig_pmd)) {
- pmdp_invalidate(vma, addr, pmd);
- orig_pmd = pmd_mkold(orig_pmd);
-
- set_pmd_at(mm, addr, pmd, orig_pmd);
- tlb_remove_pmd_tlb_entry(tlb, pmd, addr);
- }
-
+ pmdp_clear_flush_young_notify(vma, addr, pmd);
folio_clear_referenced(folio);
folio_test_clear_young(folio);
if (folio_test_active(folio))
@@ -496,14 +489,7 @@ static int madvise_cold_or_pageout_pte_range(pmd_t *pmd,
VM_BUG_ON_FOLIO(folio_test_large(folio), folio);
- if (pte_young(ptent)) {
- ptent = ptep_get_and_clear_full(mm, addr, pte,
- tlb->fullmm);
- ptent = pte_mkold(ptent);
- set_pte_at(mm, addr, pte, ptent);
- tlb_remove_tlb_entry(tlb, pte, addr);
- }
-
+ ptep_clear_flush_young_notify(vma, addr, pte);
/*
* We are deactivating a folio for accelerating reclaiming.
* VM couldn't reclaim the folio unless we clear PG_young.
--
2.39.2
next prev parent reply other threads:[~2023-07-21 9:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 9:40 [RFC PATCH v2 0/4] fix large folio for madvise_cold_or_pageout() Yin Fengwei
2023-07-21 9:40 ` [RFC PATCH v2 1/4] madvise: not use mapcount() against large folio for sharing check Yin Fengwei
2023-07-21 18:57 ` Yu Zhao
2023-07-23 12:26 ` Yin, Fengwei
2023-07-25 5:22 ` Yu Zhao
2023-07-21 9:40 ` Yin Fengwei [this message]
2023-07-25 5:55 ` [RFC PATCH v2 2/4] madvise: Use notify-able API to clear and flush page table entries Yu Zhao
2023-07-26 2:49 ` Yin Fengwei
2023-07-26 3:26 ` Yu Zhao
2023-07-26 4:44 ` Yin Fengwei
2023-07-26 5:40 ` Yu Zhao
2023-07-26 6:21 ` Yin Fengwei
2023-07-27 3:28 ` Yu Zhao
2023-07-28 16:14 ` Yin, Fengwei
2023-07-21 9:40 ` [RFC PATCH v2 3/4] mm: add functions folio_in_range() and folio_within_vma() Yin Fengwei
2023-07-25 5:42 ` Yu Zhao
2023-07-21 9:40 ` [RFC PATCH v2 4/4] madvise: avoid trying to split large folio always in cold_pageout Yin Fengwei
2023-07-25 5:26 ` Yu Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230721094043.2506691-3-fengwei.yin@intel.com \
--to=fengwei.yin@intel.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=shy828301@gmail.com \
--cc=willy@infradead.org \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox