From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5BFAEB64DA for ; Thu, 20 Jul 2023 23:55:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 52F3628016F; Thu, 20 Jul 2023 19:55:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4DF4928004C; Thu, 20 Jul 2023 19:55:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3CE4428016F; Thu, 20 Jul 2023 19:55:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 2CBEE28004C for ; Thu, 20 Jul 2023 19:55:20 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 00AB7C0319 for ; Thu, 20 Jul 2023 23:55:19 +0000 (UTC) X-FDA: 81033649200.23.8B8A0E5 Received: from out-38.mta0.migadu.com (out-38.mta0.migadu.com [91.218.175.38]) by imf08.hostedemail.com (Postfix) with ESMTP id 1C90216000E for ; Thu, 20 Jul 2023 23:55:16 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ClcEmJFv; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf08.hostedemail.com: domain of naoya.horiguchi@linux.dev designates 91.218.175.38 as permitted sender) smtp.mailfrom=naoya.horiguchi@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689897317; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qbChIIegeF8b7DBlkfq1kqpyVn4AFCoYXtz9ldaoy2E=; b=nKnLK3X2Qb0qdcbVh+24fMy9tm/4+/RvxISGR94BIJdo0CqY6ymYitgruJbLnR+914EZ1I PrFYS9C4+eMH+wGuqMhK3OBBJSIqwlJ09OOmrwt2pg02tfan2FV76NAuocyt1G05MSvksT YjZsFzJ5x+OfNv93ap2uQ0H9ytzaolM= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ClcEmJFv; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf08.hostedemail.com: domain of naoya.horiguchi@linux.dev designates 91.218.175.38 as permitted sender) smtp.mailfrom=naoya.horiguchi@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689897317; a=rsa-sha256; cv=none; b=6t/2DXmUWvAAhMOp8jHVhHWop9uIC5utSOgdoNHyOEN5AWPu+wpWVOCWwRhJidXlGKorXv N0slfnNMqzUsTSf7slFl/AFeQDTQB55RFNaRbZHEW/RLLDFm4ynPxG5W2GJR01zT9jrXl4 +RAnHXQ4vPXxO/Zg0FuTF5CG06O0ASk= Date: Fri, 21 Jul 2023 08:55:07 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1689897314; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qbChIIegeF8b7DBlkfq1kqpyVn4AFCoYXtz9ldaoy2E=; b=ClcEmJFv+fA6sN063MX5EOZtHotpyMqcnkzqcAMohi+ZzAPQE62F+/bzrPAJCmZU7IeZLy WSMSCuvrbdxh2gzY4uQwYfrUpz3qtciOZcG2iyfC0f2fnJ/AUwzu8fU/A5QDK2h1PgcwiP 66i1pM+Vc6CDcxmcDpRRnaA6dlxyo/I= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Naoya Horiguchi To: Miaohe Lin Cc: akpm@linux-foundation.org, naoya.horiguchi@nec.com, shy828301@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] mm: memory-failure: add PageOffline() check Message-ID: <20230720235507.GA2069669@ik1-406-35019.vs.sakura.ne.jp> References: <20230715031729.2420338-1-linmiaohe@huawei.com> <20230715031729.2420338-5-linmiaohe@huawei.com> <20230720010953.GC1583723@ik1-406-35019.vs.sakura.ne.jp> <0161d32a-79d8-912c-0981-496a15f3eebf@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <0161d32a-79d8-912c-0981-496a15f3eebf@huawei.com> X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 1C90216000E X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 54e8y14oy6mm5e47ouraf4czh9584tys X-HE-Tag: 1689897316-392036 X-HE-Meta: U2FsdGVkX1/wlhImqsZSLTDtqL7qLqrpH8A24+LS/DEIN6FcgqTtRHeUbg/s5KNLq4UthMgj69w7ao84puflJtfhHxLmMT8307dLPFIDwq8L1zFgorR+JLGk1pgzaKnNDbYwe2b/kirT9FWdzaFBlsO5d7niajeP8H3ra+PBpXm+ku64gwMxNM18SOWgOVNGY6q/5YIX2LaqsxIgzMpRyd99CGTAZKXM81h184RNGK+TcCn7lzAcgxc0Cb2V/kiFxyMA/s3j9jwdBeQaYFCG6JmyD1Af0n4z6b+T3uI9s9PjEezpsO0MI5D4ojFx8W2ZfMz6RbX81zD+oSzzMKtqd38RU2CgvJZb2YFXwKz+ZX37ydUnpO4jg9Sfsfwj80rVP0dvgQYHxEnldlfTCzgaNx4mkEn3CDUBsMWi2+uErMcxVOPopaTOPHwgpMRmycL+OB8u2sU+yrVEF7VnYrNN2dqRYex3gzUm5oR8dBv+nq6APM2TsM4vTgZFqgijekqrFtvPs56flVPw7Kg3ZogpRWtqO7jIXrsaHhjohyEvX5/2A7FgiqNEYlJlk4X6ptOVn79F2WFjjm9ejj+tMrgbwtxj2+YTfc0qRH64BX9M8H7o8nm9dFEDWoxpGm3xiKozz7fC6cBLjNdHT+nM1eD1reQB0o0sgRKuWEmgNOUkiNSvwbZRPEZWVVB+Ils0Fzr3SlqlAKgPU1tbLqbO9dC6CFpEeljq0l0c77r0oOFpREU2kh90W5IXlOCrW5dfAowKMBlPE+kFqo7+OusvQzmT1w80kAAITnepMF/wOQ+NCGL1WoHj665jBsBn77ZNmpBXlgE+9/wWytDYTyursVXkvmK83iilmMeEvxxIlWnwnSwMX8OSJDp7efxK2eRAaYo+NfALwAEPi4XEvPRczCYoQQxDJ1wwz8YqKPd+ha1n8V+yB65yM7KYR6MA721SE/PnrCM9mcyOsS6sgUKcDXP RbWe9Oyg x4wkgYzQXJlwxfJpRqKUtM86kjx07gVFCBpBoXu3A3FFInZk2rilFH0VBj+Ckzxgcyeypr1/yjQE6Z9sljUzQAle4ScpvMHzEHxZM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 20, 2023 at 04:42:04PM +0800, Miaohe Lin wrote: > On 2023/7/20 9:09, Naoya Horiguchi wrote: > > On Sat, Jul 15, 2023 at 11:17:29AM +0800, Miaohe Lin wrote: > >> Memory failure is not interested in logically offlined page. Skip this > >> type of pages. > >> > >> Signed-off-by: Miaohe Lin > >> --- > >> mm/memory-failure.c | 5 +++-- > >> 1 file changed, 3 insertions(+), 2 deletions(-) > >> > >> diff --git a/mm/memory-failure.c b/mm/memory-failure.c > >> index 42e63b0ab5f7..ed79b69837de 100644 > >> --- a/mm/memory-failure.c > >> +++ b/mm/memory-failure.c > >> @@ -1559,7 +1559,7 @@ static bool hwpoison_user_mappings(struct page *p, unsigned long pfn, > >> * Here we are interested only in user-mapped pages, so skip any > >> * other types of pages. > >> */ > >> - if (PageReserved(p) || PageSlab(p) || PageTable(p)) > >> + if (PageReserved(p) || PageSlab(p) || PageTable(p) || PageOffline(p)) > > > > hwpoison_user_mappings() is called after some checks are done, so I'm not > > sure that it's the right place to check PageOffline(). > > hwpoison_user_mappings() is called after the "if (!PageLRU(p) && !PageWriteback(p))" check in memory_failure(). > So the page can't also be PageReserved(p) or PageSlab(p) or PageTable(p) here? I think the check here just wants > to make things clear that only user-mapped pages are interested. Or am I miss something? No, you're right, So this "if (PageReserved(p) || PageSlab(p) || PageTable(p) || PageOffline(p))" can be considered as checking potential deviation. OK, so the patch is fine. Acked-by: Naoya Horiguchi