From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8926DC0015E for ; Wed, 19 Jul 2023 09:44:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B4542280043; Wed, 19 Jul 2023 05:44:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AF4BC28003D; Wed, 19 Jul 2023 05:44:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9BC7E280043; Wed, 19 Jul 2023 05:44:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 881AE28003D for ; Wed, 19 Jul 2023 05:44:55 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4D12C1C87EF for ; Wed, 19 Jul 2023 09:44:51 +0000 (UTC) X-FDA: 81027877182.15.AC0F702 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf13.hostedemail.com (Postfix) with ESMTP id C5C8420021 for ; Wed, 19 Jul 2023 09:44:45 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=QftIU3p1; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf13.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689759885; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ki2oAQogwvaHtT4NyCdMUwqRIzGzUIFDL6djHp0F4s8=; b=dK+7MdNe/YpDeqMBxpcCe+BIxa2DW77u0tvZ9cPITgnFEapkYiBdw03GQrApos2b7RT2UQ rwHZrRF/LYPrcWcEhpAt7/LaUWXdrP1XVuWJ3dZE1vUJbbgvlyx5o/jVwPd0EeNDcZB+Wm XHQDekofvhYTWwEHYFSKClq6pQ16pNs= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=QftIU3p1; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf13.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689759885; a=rsa-sha256; cv=none; b=RyvPqxXaJWfef1/TWROcfXK7nIxRlRjAJVQdZxvZ8cq4eruYtkKZp6uzyq7pOTThRvbAc3 DetxmIjfFwCq28YWBRhAZMNf9NOvH9ql40+YRQBqgbM7U2Hj1/8J5Ej4Bh+Vuft+aAS54R dmr0tqo+9G02WanQxaEtFkvrocenrRo= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BDF1061354; Wed, 19 Jul 2023 09:44:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4B008C433C8; Wed, 19 Jul 2023 09:44:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689759884; bh=oyC8+51fu/8hbXHd/jdrqz4m+gvM97rqzFKz9D8GHDE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QftIU3p1IxnDxY7dPXrEYITZSubiWsVyp7D72Oyi0f2+X4h9qsdvLBZwQ0H7Gg5V0 PBVs3fS3sdduA3S8hhWU+nglPHV9vG2XOFX/K6eic4wrADJrKEiQ17Bs04ae0EO+OB LkdUU7jNFnMmOE57efP87/pE3mFLkQ+IoEgnl1Tq61ZCcUcUhEpvMWi424YvLby/Mz jiZ9V7CCEGuouVdLguUAGwRODVcVc8Xg9lG0w2ZxA+Gy8JY7GNvZkN2amKyHd7C1ti DfV+4PJEeeICA8+ttHBLKa9xCGIPD+YzFpILpa8XS/P1Ko0bFtuFRzlhG8+jIxA9Bg H7LCg7KvYTPeg== Date: Wed, 19 Jul 2023 12:44:21 +0300 From: Mike Rapoport To: Kemeng Shi Cc: akpm@linux-foundation.org, pasha.tatashin@soleen.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] add page_ext_data to get client data in page_ext Message-ID: <20230719094421.GI1901145@kernel.org> References: <20230718145812.1991717-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230718145812.1991717-1-shikemeng@huaweicloud.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: C5C8420021 X-Stat-Signature: gup3nt4w9ynhdtrxbqgh7darkhny1gkq X-Rspam-User: X-HE-Tag: 1689759885-177654 X-HE-Meta: U2FsdGVkX19gPtmLUjzM+E9SxyBryQYv004hz9PbsXcT9Nv77yyF8iSrqbvm3/mTAvEdBINoDijoVsOX0c3Qu8Sb/FRDvVnaIodhC0PgEV0Sadxg8YlFb8v5xEVXnHCaBqEHkyKdWZdCMaX7ej1L4y8m3j/zTG5wr1IngwYv92cwxHzq66GQAWQnyr2854IJoFl5PhkqhC4ca8K7eXrh8bqBzgIiDrwa3Rtc9CmpoLIAveNUesMeiPMIX+dCXKa0piqI8wz7p+ZlFH9J26k94IoON8gQPZLBPLb4wYBYAjVBtKBTqu9jezOUI7enuUs+hbzvPa7562ZmP2fqkEhZnF5dHFukGc8m2vWDTs2UGKUoqVNJ/YCKDb5oKF7u8S4W3UHUkyJBh4vMpTGeCshXqpXzA2pkrTYxZ8brEdHZYRFtpMtxvb3lb+5T8EMgH7im8+GASDZZwyqBDJQesJhuc+PQZIdGl5wK6Y61MuHdgpH92/2dvhbWz11/uQGfl/p2NnnJhqVC9W7x3cUEF9ROc12kRLxzAo1tPyhf8U1oEcEDoH4TM2zKQOK9SR/51tK1G5kKGbQdhV5XKmBoHzYiWyV9pVuif8Iz0r/fI0G6GXY5PYNvo0Lv0ou/27b99kLlguuWM87wzeFcMQ35yDPFjjTVhMshLcc3NgyUBQ//YlJZ801EQaX1sYmbNLtY82QZakl0zh1XcaSPnE84QhKF0/+G2btN26Leof2SLNsVEqoDGgwoEUnQUJuLDU2yXtjgi/5o20YgduQB/9e8KTaSVqWkJFD4bh8c/iuve1rLiBA/6XRn2FwOecmwP88YRlsnO3279E1BuGTXzR4wXb8Wf6reMXxyjCN2viaj4/GVvf7MnsFsgCbGYNYebKNlnckFBDksW94K5kQRzZrwLHB9WYCCoJ/Zh5oXwFfiluao42TA8vYA0QmVU1yYMxCj/GJjVZuNbV93WQLkmEvp7ye q4RJ5Lvv bi6HxS1tsVmvMCrBPOQLTtvmrJDPmUQ4cfPVcV1nKf2P70fWr+eHXqBV/VFQuvr9IckCng/vlqzcABQoUKdbe06MgduDXnj7iYdyug902LcdIMd38BGbon5VVKdAmL4VbL1eUVVHmoMGxQBMGwSwtMg+1S2oiSfmVwFY/SK/rp+jyzv7ZvWT0ostywjzG5q+gQYy4fy49XYonbV2RNznZU4aXNqULerem0Cryx7TkH5BQFU1AwNcPfFURhDD2kZMmcJXFFeoCLNQ6eDnFTdEIWDNGVAqOOq8Nu/zMqJoHaJsNtbMrPwYqzRoX5oCtIC8GQGB5l2khTP6dGs1+HAiVVI5SoQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 18, 2023 at 10:58:09PM +0800, Kemeng Shi wrote: > Current client get data from page_ext by adding offset which is auto > generated in page_ext core and expose the data layout design insdie > page_ext core. This series adds a page_ext_data to hide offset from > client. Thanks! Implementers of page_ext_operations are anyway intimately related to page_ext, so I'm not convinced this has any value. > Kemeng Shi (3): > mm/page_ext: add common function to get client data from page_ext > mm/page_ext: use page_ext_data helper in page_table_check > mm/page_ext: use page_ext_data helper in page_owner > > include/linux/page_ext.h | 6 ++++++ > mm/page_owner.c | 2 +- > mm/page_table_check.c | 2 +- > 3 files changed, 8 insertions(+), 2 deletions(-) > > -- > 2.30.0 > > -- Sincerely yours, Mike.