From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE4C9EB64DC for ; Tue, 18 Jul 2023 16:19:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4BAE48D000E; Tue, 18 Jul 2023 12:19:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 46AC18D0001; Tue, 18 Jul 2023 12:19:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 359918D000E; Tue, 18 Jul 2023 12:19:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 21E678D0001 for ; Tue, 18 Jul 2023 12:19:39 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id EB1611A018F for ; Tue, 18 Jul 2023 16:19:38 +0000 (UTC) X-FDA: 81025243236.30.17F8247 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf11.hostedemail.com (Postfix) with ESMTP id CAD4340007 for ; Tue, 18 Jul 2023 16:19:36 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=GMAFV3pt; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf11.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689697176; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zEDVl88OnodKXzkoLyQ0hwCFuJLkdxJsfzeF7JXH508=; b=QTobQUL15EoOTvLPnY1U4o/EU3yTsn8Kk1D40WoaUrIiqpTdHMJwB0LGSKwMQJZ2aA7UcY wmqxvjHVVumEygfHjM9m6DFW8gSEmqOIwWdGqBkFWEQoHZ+ekOgNFUqcV6+2b3i2W9YQZP /utgmnTjyWq1Ft70lMu7meFz1SmWZHQ= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=GMAFV3pt; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf11.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689697176; a=rsa-sha256; cv=none; b=Mi/gNm7Ww2HUn0VtrcbBBIsmXKQsYkJ7uvloDPHdeYc7MnezOiodzT4pGkNiBHdQ6EaXkR GBdA9PMQ1NXfk78NIABGtcq+l7hTH2D0zZoBpZfYr6Vi3tzLudem5tu1FSueG0gBTyHgVi j2TK+jL/KNUNqV15ln+XJr6CjSFvAnE= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CFA8461632; Tue, 18 Jul 2023 16:19:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C0562C433C8; Tue, 18 Jul 2023 16:19:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689697175; bh=o6/z++iAsfxtC4ue21DXnPDGcjMDSp5m+OtMQDwMI+Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GMAFV3ptIcg8KmlYOr5yFD5yYC0pYLFymRyLCv81KtSWLVQ5kqJLQH9IRQ0DJ41Fl 9z2pxXwKnxXwaKcR4xYaxowByK6fkzYTAJyXavdvJEXRyQ0/mB/RG/yPMtw5GSToyQ fDd+3eKOmJHLkL/YqTFRSsf1/FGf5OxMspPNw4nTJYILEDqKLWOf7SR4oKSBHC3YzI f309AscsqKYbSBp5H8sXwEhKE2Or8RvZ14jGGMC3euDZZyXTx9fY2s6HYby6Dn6T6n aMhTGCP25yFGuIqKkUlEu9Cb0nFzgV4OvvM9S+9XCz44yiHq8x1Z/XueyBQfSKQnrS KpNg0fVUSwWYw== From: SeongJae Park To: SeongJae Park Cc: Feng Tang , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, damon@lists.linux.dev Subject: Re: [PATCH] mm/damon/core-test: Initialise context before test in damon_test_set_attrs() Date: Tue, 18 Jul 2023 16:19:33 +0000 Message-Id: <20230718161933.78949-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230718161656.78877-1-sj@kernel.org> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: CAD4340007 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: qry3wegupme4uowozqndwfcxyeergucu X-HE-Tag: 1689697176-275594 X-HE-Meta: U2FsdGVkX1/BERqlO4H3pMpLaItUbYOE69ZkfOttuJVT2n/5kr1YxaPhiGCv+qjtzk1RG7B7IqXYGWTC1/RJhxcNRryXUOLiLtraRi6Iku0vPWAPsK/7M55R4jg2EqWQt1Q6Wg93kKkGOUc5FBsZbkWxTb3tVjyBj4KcniLmUTAuqn1QCosynlfD6bZuJENBdTKTzqJ1aNkAD3GMwn5yRF5ZXEXwJxXZznyLy5X8XVX0T0x0xjGaOvQ8IroFkeOeYML5l501nrPW0bkygV1AVkmF7sjhUsdpRDvrOL5dbVrhYYlUbHqOLFPA9nmvy/OMkgeE1INq8NF3QDHq/Eo2cdqxTHWNriaYtchd61I/Weg/f54BKvoTSOkaRr38MRd3xs66e9aTD0RBD9VjErXbYzNgBSBrLKPjT9vdAyo+XhUTbtTVZpfkdFIhBIu14VxcXyWhMIwA2bidVcdYHIIHsJ8DQbIQuW+tj/IcBzX3vq5Hw5OluHSx+4t7664cNqLRR8OfguoiNuDBPjaxJJhcCmo6PWj99zH6UZEDlkLVSUui0d9q4KMZ0GCA8EgVGOM3R8xN+PMTzXU7Bm3VTElt+BmKBJZcDsAgUQbY+XsOd8MSbC7/HoNJW18oqPaZfvOSQBfc7swBBYFFVolkmkbyv6CDLIp/hsN4/Zdp3dVe+tn8UCB58BJbhVMLJkC9fz3zwQu4zNGlMpbK0wSAm4PxnDUC6w/fnE8LJVODzyWgmb3kCJ6kGQMpaYSoYGbSrIQNpvwsw+yBovc+ff/2JWPeOQ4v8/Vpd7BjnbDSJAduyLrgmkHEkSSsURsHXt8Ee3JqFDXfCLWLFruXwYrMhuTFoGlXX9J5lSDJfIVDeVkJt3AyYN6mOHmywo9fRDAygGxEs739EeFo5JKNznV+HdG5adNt8HGXylH2UaSc65Q7VPsOYjXwPGOU5me1y+K8H4vM3mRVokpzVo8T4RKHc1b x6OfIIkq +OLqjOsMDi0ZBz7c8mqZ1Ym9Aa863BNrbHDT1z2j/Nt3Iuc5hpq6TsILRK2SBvWTpq3ZW08wcpkWoDiH0/q+mmjrW2+uK4S/b1WEaOcNBq0Pr7QexaTx2AT0zYer9DpIGQxa7S2xjSx0a2uI7BaJTvRlivdmK/Oegje3s93aS7qys/MzjdAu+QxDensfBDRXnYfkVQWwe+LNRgPKBnOoXv7vE/A2V9VfTcRXsKb9lJTzWXpm5YnK0ihA4p3byH0p8qFKinqVuNTe38cNw7ltAD2REu4zdW4J7DVaYXJEvms+snaMSAU09VDjoQMefLv3oD5RnQj+yeBTxKfiNjsQCe81H4denCTV5yjqhZEpUsDe999dIGFML4puOdgCLZK8iRjXMkt+0aIZoHYtxPCwItWIqOw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Also, please note that it would be very helpful if you could Cc damon@lists.linux.dev for all DAMON-related patches from the next time. I'm cc-ing the list. Thanks, SJ On Tue, 18 Jul 2023 16:16:56 +0000 SeongJae Park wrote: > Hi Feng Tang, > > On Tue, 18 Jul 2023 13:28:11 +0800 Feng Tang wrote: > > > Running kunit test for 6.5-rc1 hits one bug: > > > > ok 10 damon_test_update_monitoring_result > > general protection fault, probably for non-canonical address 0x1bffa5c419cfb81: 0000 [#1] PREEMPT SMP NOPTI > > CPU: 1 PID: 110 Comm: kunit_try_catch Tainted: G N 6.5.0-rc2 #15 > > Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.15.0-1 04/01/2014 > > RIP: 0010:damon_set_attrs+0xb9/0x120 > > Code: f8 00 00 00 4c 8d 58 e0 48 39 c3 74 ba 41 ba 59 17 b7 d1 49 8b 43 10 4d > > 8d 4b 10 48 8d 70 e0 49 39 c1 74 50 49 8b 40 08 31 d2 <69> 4e 18 10 27 00 00 > > 49 f7 30 31 d2 48 89 c5 89 c8 f7 f5 31 d2 89 > > RSP: 0000:ffffc900005bfd40 EFLAGS: 00010246 > > RAX: ffffffff81159fc0 RBX: ffffc900005bfeb8 RCX: 0000000000000000 > > RDX: 0000000000000000 RSI: 01bffa5c419cfb69 RDI: ffffc900005bfd70 > > RBP: ffffc90000013c10 R08: ffffc900005bfdc0 R09: ffffffff81ff10ed > > R10: 00000000d1b71759 R11: ffffffff81ff10dd R12: ffffc90000013a78 > > R13: ffff88810eb78180 R14: ffffffff818297c0 R15: ffffc90000013c28 > > FS: 0000000000000000(0000) GS:ffff88813bd00000(0000) knlGS:0000000000000000 > > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > > CR2: 0000000000000000 CR3: 0000000002a1c001 CR4: 0000000000370ee0 > > DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > > Call Trace: > > > > damon_test_set_attrs+0x63/0x1f0 > > kunit_generic_run_threadfn_adapter+0x17/0x30 > > kthread+0xfd/0x130 > > Great. But it would be even greater if you could this kind of output after > decoding the addreses using 'scripts/decode_stacktrace.sh` or > 'scripts/faddr2line' from next time if possible. > > > > > The problem seems to be related with the damon_ctx was used without > > being initialized. Fix it by adding the initialization. > > Somehow the test always passed on my test machine, but maybe that's due to some > different behavior of my compiler. I agree that could be the root cause > because 'damon_set_attrs()' calls 'damon_update_monitoring_results()', which > accesses the context's fields including the targets list. Since the list is > not initialized in this test code, it would cause such error. > > > > > Fixes: aa13779be6b7 ("mm/damon/core-test: add a test for damon_set_attrs()") > > Signed-off-by: Feng Tang > > Reviewed-by: SeongJae Park > > > Thanks, > SJ >