From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44D2DC001DE for ; Tue, 18 Jul 2023 18:36:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A03E68D0018; Tue, 18 Jul 2023 14:36:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B40B8D0012; Tue, 18 Jul 2023 14:36:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 87BC38D0018; Tue, 18 Jul 2023 14:36:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 776278D0012 for ; Tue, 18 Jul 2023 14:36:25 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 4EC3A12028D for ; Tue, 18 Jul 2023 18:36:25 +0000 (UTC) X-FDA: 81025587930.05.39F3878 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf11.hostedemail.com (Postfix) with ESMTP id 536E440007 for ; Tue, 18 Jul 2023 18:36:23 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=rSwv4V3D; dmarc=none; spf=pass (imf11.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689705383; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jYSPh1HqTa1Mmt1zonFerUrCN5745Tn8Vat/FJeFoEs=; b=CFdTaW1lOTC6gzVxw0Pgmlznca0TCTWF4n+gY7YgLoEwjXZ3CJjPsbOs9ag+VSBQ1KQFfj DtuSc1hCupP/V3SP6bsXejzK9k51pPEwkLN79Nx6ccrCEavbVLKYyiHHiIQUGnTaPQS8yg tD2Q2sjAysPlCrHRoggdQQ8kT7oTREw= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=rSwv4V3D; dmarc=none; spf=pass (imf11.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689705383; a=rsa-sha256; cv=none; b=ftjN+Yx0izi7ivnMSSZblrUVyE19NL3GWhdLXkQecE/Qryba981zIlHSUf0UEyNJlN83Hm 2AeGm8Xg9o2MJC+fUAXfw/pwWeHyEsjZUXlkGStFpi7Op8MCgT3ECWeAvE5I/lABhIKbgC /8BloVYCfY/JShghMD0GG/+4QWMEIZs= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 33063616A8; Tue, 18 Jul 2023 18:36:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CE9F2C433C8; Tue, 18 Jul 2023 18:36:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1689705381; bh=JgrHe5DZ5UnZ31Le+DdrjV7UqhJAEhx+BMwzO0I0pyk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=rSwv4V3DUswnOOwtuqviHoHg8mtQl8Mycp8naGrr017s7gsEUs+LUFgW78b59OlD6 RJ07+aYugwPVV2ffN02N+TbXLoW/RPNxLL/RW1q/hReBJmWPBWvyF6ARM4VWnVkHi/ WwOrnVSIGZK5bXjK7yuuDSaj1cyDMcQJVsSO4MIU= Date: Tue, 18 Jul 2023 11:36:20 -0700 From: Andrew Morton To: Jason Gunthorpe Cc: Alistair Popple , ajd@linux.ibm.com, catalin.marinas@arm.com, fbarrat@linux.ibm.com, iommu@lists.linux.dev, jhubbard@nvidia.com, kevin.tian@intel.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au, nicolinc@nvidia.com, npiggin@gmail.com, robin.murphy@arm.com, seanjc@google.com, will@kernel.org, x86@kernel.org, zhi.wang.linux@gmail.com Subject: Re: [PATCH 1/4] mm_notifiers: Rename invalidate_range notifier Message-Id: <20230718113620.fb29217344238307c3be76d7@linux-foundation.org> In-Reply-To: References: X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 536E440007 X-Stat-Signature: ta7r3b59khz3jobaabf9gh8gb33fz4zs X-Rspam-User: X-HE-Tag: 1689705383-857687 X-HE-Meta: U2FsdGVkX19ltYuhEaw9XVU/HQj/kpg42vFg8JVEp94tPopC60glRhQt5BLvPULaAhqSPd89BG2RV4n7m81Zv780q50fkaQOG1yO2BabYpocXUEQ8nkYXDvxuWB6QCJs4PmMouODBCdx/mKIIJfWRu/HuMClwDKAbgxUClXtfzsqHYaCPgbJ/wAoQMEB17ovCazBXcAJHJrd4BBUOrGGUkXeNTifIjH5J+bQtTS2sxBI1rOTe6Z4Ie+4G3YjNwcVbecqpaCOx1slclmI+KCtbaNshIzOKOIttNXq0gBiI8RktBvLh1/ywHELG0e8bKN4xmeRMrg2rC5k7oYRyqS1fI7kwkepO579wfb8tTS/Bs0+ufAhcXkmnr8fMS4glDV330deJQCw9hrVMObiAZ/Gv+qGpDa0+WMvnQuSeejK6EH2ILXO81Irt/bjIcz7+hNR4PDXOeAxnNfDZ7oTv6hBkZblJKhSQnG1onRveEAirwH28u+tdovijqYIpgcXuh9idQXbcLmMfe5kaRtXMHdpBwncJxmMVwXVnToN0r+sRN2oCwdjJPau8B8QG4rBtEa5W9cVzRu1wdtbkn40NgvsAIHd6p5i+Qrd6C/uq3tfssm2xuS7fG9muCgVxNOHIU1eUsqfqw4aeMcd6GcWTRQUg5R4RtUoNqFUM5uxJwI7n1CP1jXAiEYnGs59GFY/GDtnO5tRUE9rMa60nZjMWyZhSYt1NPTDPTTD4kl3I1L9zSoZiUvrCOqbQ3KLswbK2ri26l2j5S71oTjwFI+j+k2KnH8VL31ZIJFWVuwzukRxrHCbM8cCebAgq+ScgroRoyU9hvVRd8wjEMkXBxIct0QU8MU6MaCdQjFE22BNCJoB8aXxhXHm6L91F6n9ukWSiMTtPGzvg6TobevH2BuZrs7Yw211N2iVogb7enPXPfz8ZoT+YTutiJgT8v6pZgPZaHDG1h8Utu4MSbfscKW+JAx MP2wSY9D rBvlqjv/TG8ZjFQNTeO8RjVKxOc/e/TvdnJeN+DWfhQptmpyXyZm4YsHJtjpmlIzw8ze8O5dk3GsfjOfycDp/kAgzG4epaXntKvS2JbWjOEoNuR1GoMWKqdkX3j4tzg15+E/0sL69FMlxIgPySZ8xCMPHvnpgE8qi6rYmpbYPWXu5B/YiXKVLtL/W/oJ89QL9BtBkE9W8fhqjeBus+EtSrAQiqAUH4WXuUQ9P6gaP2C0i09NNf7JoB/uNI4PO7B4tHxUXQvL9MXRAi4G74nJmsQIFzqKxg7B0ju9Nl20JV70kiSXq9DrjEIHbaTUZ1X9qVX8OS2SrWTby4zwvKDLvl8FhsWkVX6mdK4nYldMI0gWt/od7QxFawidAfe434YGRQIiCA0HQFIaJg8YER5Z8ws8bujJfjlC1HuwPzjqPROvSdZ/cOwcWRPLkQbFJh26OtSA32W8roy1rRITpNOfHoFzYrTAxTNtZFHy0Zo8ar9MQHi2HELfbuNsqAQbjN9JGEfzu X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 18 Jul 2023 14:57:12 -0300 Jason Gunthorpe wrote: > On Tue, Jul 18, 2023 at 05:56:15PM +1000, Alistair Popple wrote: > > diff --git a/include/asm-generic/tlb.h b/include/asm-generic/tlb.h > > index b466172..48c81b9 100644 > > --- a/include/asm-generic/tlb.h > > +++ b/include/asm-generic/tlb.h > > @@ -456,7 +456,7 @@ static inline void tlb_flush_mmu_tlbonly(struct mmu_gather *tlb) > > return; > > > > tlb_flush(tlb); > > - mmu_notifier_invalidate_range(tlb->mm, tlb->start, tlb->end); > > + mmu_notifier_invalidate_secondary_tlbs(tlb->mm, tlb->start, tlb->end); > > __tlb_reset_range(tlb); > > Does this compile? I don't see > "mmu_notifier_invalidate_secondary_tlbs" ? Seems this call gets deleted later in the series. > But I think the approach in this series looks fine, it is so much > cleaner after we remove all the cruft in patch 4, just look at the > diffstat.. I'll push this into -next if it compiles OK for me, but yes, a redo is desirable please.