From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2480AEB64DC for ; Tue, 18 Jul 2023 17:17:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6C96D8D0014; Tue, 18 Jul 2023 13:17:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 67A088D0012; Tue, 18 Jul 2023 13:17:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 541448D0014; Tue, 18 Jul 2023 13:17:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 441C08D0012 for ; Tue, 18 Jul 2023 13:17:40 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id BE1BD16021D for ; Tue, 18 Jul 2023 17:17:39 +0000 (UTC) X-FDA: 81025389438.02.521C65A Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf11.hostedemail.com (Postfix) with ESMTP id D40BC4000C for ; Tue, 18 Jul 2023 17:17:37 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ExelwVvv; spf=pass (imf11.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689700658; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=G6ZvtxXz8LWuh3BEkRQdSDw1LC62Bv63uPf/N/pI/hA=; b=CuLu5qkNhW+ZJE9tKFbNii149dhonHDqRPiLcLDNlhub8JMERDlP2p69uWvOhqW44ig+xT 3nnQaJGPqBUFuRUyHi55iPizKqoqEeX0OSp+sqDs28cO5MVFEB/WHXB6XWTY8JSGmB+jwd TV+AYqfNcPaE5sIrNj7lo2PCNejM4Iw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689700658; a=rsa-sha256; cv=none; b=NBV2i7Cw0oIHPjZZhb5RN2T+vj2CMpps7rokEagR/HklAOOVq4VyFsFNDjMNfJ/BlcpaIs yMC//jlngVm4FCW5mn4f9JvjeLU4rrgtbhD60COhKpOyviasRP6+rvvLLN6Re4r6raMdB+ evURkboBQboGeCx2Fq6mSJkmdwqL/Qg= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ExelwVvv; spf=pass (imf11.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A1B2B61683; Tue, 18 Jul 2023 17:17:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CE648C433C7; Tue, 18 Jul 2023 17:17:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1689700656; bh=+hnVIU5zZw20GkGYfgr8/6QlYnCVkhQQSbU4SSZMDx0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ExelwVvvbfz9f2iFh1sPcovf3jrbZCGCYNo3HuoHrWS22IhKYMGmb+qlDfN/XP56q VhumL5/yHIgtvTHSG0VffwaoPOXxYz8gjmQB3yn3n8SmEqhI3lv4Xkk3x0NCaeytTY xeLoXXDMUnbmlgNvEnGs5u9j05iQCt0Fns1DoEwA= Date: Tue, 18 Jul 2023 10:17:35 -0700 From: Andrew Morton To: sunran001@208suo.com Cc: dennis@kernel.org, tj@kernel.org, cl@linux.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/percpu.c: change GFP_KERNEL to GFP_ATOMIC Message-Id: <20230718101735.aa31791899e2f9e19e8e0a75@linux-foundation.org> In-Reply-To: <7aa3a1cee63518cb13906d11ea130c9c@208suo.com> References: <20230718063328.16140-1-xujianghui@cdjrlc.com> <7aa3a1cee63518cb13906d11ea130c9c@208suo.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: D40BC4000C X-Rspam-User: X-Stat-Signature: cbjq37hesubze4w1p6fuzmd78qgt77q1 X-Rspamd-Server: rspam03 X-HE-Tag: 1689700657-730109 X-HE-Meta: U2FsdGVkX1/1fUtXIl9HkqqdYxZWW72eb7M2panakLCgaZrX/rMbJ39PgMGVQkTCbDXMpQJSQIgMPYqdrtNSaSwzL5AHCRMonP7uBMe2ldi1UNQIEYDVKHQ4tAFFwiG3JdawGCvAAS1Fmbvy06Oyj+1pQ4oYf9tHqAGC7pczLEy6rNE/eFxwGVp3F7TcrGoR3PsHB2zrMzD49EwKd+p2QowvMKXsYyl6zsHat/hmU69q//tJB4boCaZUHQWQCzK7sADvY5U79yEPaz3MjCAanmyD+sDQoYiF2tamubuUJwSGadTNYzYPIB7/eVZqhREY5E4K8wO57+PtjTjMsDdP9D8hzJoB2NTfszxt5mx7/jYA7ZOpu0RhxLI++NqBQoMKRtRc4dVdIL/fin8a7vAiaRfn5ZTnTX1VOJcE/2C6WTWL3DLjIBYVZVVuwlk4CuhqwfdHZabi600GUiyyPixcz2wjcHgYljzJ3udWH/y71y5E5C/mp4F3VfLx5ayNbW092kd3pyza7Hfuj3JjhEdEcS3gL3dY39T6K/XqjWEE6zIe+w66GE/unhv8WPo8uSZnUCED8BE4vEbhLEfsubtMbF2zieVuteMMCAsSGPjDmbx/9OqjXNA6HGGwx0DFXaIWgR6u6D4OCKoQDP7eNiJR8eyLV+zLpqYhexoAaRN9meIAQqE+HfiLA0Y9CTIWU7CqZCgP/5XP0vGVntxX3AFkvOk5XPfIaAbzBLvelB4r4LNrwcapT6UBDPYz2TfHvEnEXPRzkHgj7HU51+CrwQe0wfrorqurHZUEW5TdBMTFNXQJGxtkFpuWU2hS2nl6xsJJwarXASvyrvucOEYlR/k8CsczZTQncbKY5cEuHhrSh+agvrQTTDd0nIm5AeRFfm0bd2BqbgJMm1IIzxMGtMQmRu0SPSn3sOrBHCafjdk8u0hGRROzNVcxL/M9uWe9q84XkbofPZU8pBjmPhXFXSi hEva5Isa a7yndj/k24I8J2MgsDEHvXlJipfyoCdgO4a6rCqh6EvvBbj/p7ykVQgMVD3zjn72yzyGey0Cm6K/XS23mXZya2jV6Sp0id+ZVPRxDEsipnyI+pAzHFNS8hLLr3oC0DOC56nHpFMQ8Y8smGPACtT20LKq9S+G0TAMKFn6xNQr9tMsVXitBgOERb1YLpgFz7/HpkPnnR1XTCqfihjDXLvuhphdXJjj/6CjbJRgeRDPXwiIja1TUMGvYtcm/uVLkhb4TQInjiHUgPIgBxT6epOr3uO2mdxMVBQ2O01IZfx0a5dx0kT7SEPaM7IqE2ZkGBzE/hSimWa4orM6L3DWy9Wo8m6n5gNZ7gbu7yGgRdiwUIrx0dZejTb5b4em6AVpyWbOO540NqEj38vokcajx5Ld6NmaMLJQR+k/UZ0Xg73BTTVaAkzXyOvJeczXxMQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 18 Jul 2023 14:35:11 +0800 sunran001@208suo.com wrote: > ERROR: function pcpu_balance_populated called on line 2238 inside lock > on line 2234 but uses GFP_KERNEL > > Generated by: scripts/coccinelle/locks/call_kern.cocci > > ... > > --- a/mm/percpu.c > +++ b/mm/percpu.c > @@ -2033,7 +2033,7 @@ static void pcpu_balance_free(bool empty_only) > static void pcpu_balance_populated(void) > { > /* gfp flags passed to underlying allocators */ > - const gfp_t gfp = GFP_KERNEL | __GFP_NORETRY | __GFP_NOWARN; > + const gfp_t gfp = GFP_ATOMIC | __GFP_NORETRY | __GFP_NOWARN; > struct pcpu_chunk *chunk; > int slot, nr_to_pop, ret; I don't believe this warning is correct. spin_unlock_irq(&pcpu_lock); ret = pcpu_populate_chunk(chunk, rs, rs + nr, gfp); cond_resched(); spin_lock_irq(&pcpu_lock);