From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 685A5EB64DC for ; Tue, 18 Jul 2023 00:40:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A14426B0071; Mon, 17 Jul 2023 20:40:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C4766B0074; Mon, 17 Jul 2023 20:40:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B2CB8D0001; Mon, 17 Jul 2023 20:40:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7BFF06B0071 for ; Mon, 17 Jul 2023 20:40:09 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 49EE31A0625 for ; Tue, 18 Jul 2023 00:40:09 +0000 (UTC) X-FDA: 81022875738.20.1511B5E Received: from out-56.mta0.migadu.com (out-56.mta0.migadu.com [91.218.175.56]) by imf12.hostedemail.com (Postfix) with ESMTP id 5589F40011 for ; Tue, 18 Jul 2023 00:40:07 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=uJhuq25p; spf=pass (imf12.hostedemail.com: domain of naoya.horiguchi@linux.dev designates 91.218.175.56 as permitted sender) smtp.mailfrom=naoya.horiguchi@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689640807; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oonA44LaLRDvTS4ilicUH+ynavGd842K8wUpEpyQ9nY=; b=EQdk9eVqlFSkJy4vpNj3fnlztoiFVDfjyyyHZKYXtuAIwllrxsYc1pK4LMywHVWSCblSZv DdZc2iHrTtuq5WRuVA7on+o8wwDJKqODNls4Lqc7Ej6asD0G9wOFnIyVrtL946peaelYv8 1/wboryBtkMcgLfz1f11fp5W3pvzEfo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689640807; a=rsa-sha256; cv=none; b=O1igIjE61salWKiwS3x0Sb75Kpifsz0FM79GyAnz8xW8l2OlfUFG8k05EmVkVC3aKajRtB iVamPoNE08rp5o5zbeCxYM7a4ZKa/qbVPzt7hZoycjeHPjb9mMGFkYYWVaSqZhmRsnMrn7 Ktm8Su9Cn9cXhd6m18dLdE32q4JqEI8= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=uJhuq25p; spf=pass (imf12.hostedemail.com: domain of naoya.horiguchi@linux.dev designates 91.218.175.56 as permitted sender) smtp.mailfrom=naoya.horiguchi@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Tue, 18 Jul 2023 09:39:56 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1689640803; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oonA44LaLRDvTS4ilicUH+ynavGd842K8wUpEpyQ9nY=; b=uJhuq25pmPIWf9+nQBunG34GUcm2YO3yXpUUZySwv8PUp2VHGgYNbrhc61Pj6wvxsr/JB3 cAy0lKeQ/hu6AwzcyS2Xw3YOEOMf4nZDY6TleIkctNKg/1hXfBMBLd+LR1z993gIf2Jvnn ne01sp7k5V1Lw4/vzW888W888o6mqVo= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Naoya Horiguchi To: Sidhartha Kumar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, willy@infradead.org, linmiaohe@huawei.com, naoya.horiguchi@nec.com, stable@vger.kernel.org Subject: Re: [PATCH] mm/memory-failure: fix hardware poison check in unpoison_memory() Message-ID: <20230718003956.GA762147@ik1-406-35019.vs.sakura.ne.jp> References: <20230717181812.167757-1-sidhartha.kumar@oracle.com> <20230718001409.GA751192@ik1-406-35019.vs.sakura.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230718001409.GA751192@ik1-406-35019.vs.sakura.ne.jp> X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 5589F40011 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 4tb8xjnop6shaywmsnra8hsxbm4y3k48 X-HE-Tag: 1689640807-293549 X-HE-Meta: U2FsdGVkX1+iii1BMrz0WQqaK1mH+JI8fSIJbtXE+BBg/kDkjWiGaWMNwuCc7yeKPFxpmudoCskDUAOYbW8pj1JkwixLTTbS0frQJu8sigwbIVggh3A3Iez+YTKkgKgZymH8BMXoZf00n57KL04bQBwX6yFNuMGiIpvdxyJ45v/+IiBux/t4VxNPEUeqdrPwaZDJELbMnSrbuAac+o8ZfMqD9Ue4Lj52USWAvB9mzsqS6QShIkL3/2vdaH0xPfjAIRbRMrO++8ZScx9TRlir5PhCsO6/7cmq5ekNw8grie9LuelbbcmXOa7sdKAbs1toYYIDPBgxjehR8huzPHDfcC6LFQ6xTBF57cACcOsoQnnPgA8jZUOwreuhHpJTkQdT/Oc4zOH+pDZGQQ/8LzkrtURyIbNJnBCY53Kix8VddAcMq1qfGj4sKWRrJbnnzGoBo0/qLybrnRdcn/tFkAYUjbpNg+9iAAXGdOJYoF2a8yIjml0gKsLT8T7sTFOioud9y2iB/pPqX55vRKYkhkdc37q5FcfumDZL9n99a7dkrbPvlqJb0r+d2+yCxmz/PDF0rq4B0ORu76uI1M/MuUjqv2vzvbDFlQy6m6V1HdklHYFfZB1Zu8WA97J19K0Kqr8KWEZBrtFOlUVVw8f80jJQ7sZjXYVQZMz7dBv7R0Ayar840dgWvTxDRhNy9SB2N3vGWZIcxZDrO2ui58z/+fqQ7p6anFNPw08W26yfkgteSFrcVazt9X1596z0EDFDTD7uu1XKdPZpcTBXYLQW5zOiob4KNPlbZiuO+fyyvH1A5yYxl0TVxsYBx0EDnWk+OlcJwYxoMvHT8nSjnTWwaHtJ2M5up8Cyms3JYaCLFZ1kcW9l+lK0sopwWW+WRkZjL+MgvyV7QJXgxIsZYi6MH+8Kf0aTE3lQYCrf9jhUnKpg8G5ZJCnJ3fnJIgwF9HkDgYNFOqyOjDPLT4HvWa7xmyZ 0JjHCUsm ixWAsrYiaN2WL/zmE+6IixPYOwm56ZgeQzDjdNriu74R880PQzAQaw6WVCP68nQXZDqheUdAobx6FMgWr6ddNHk+cojXXP9Se4JiCn/m22OGd1eQ15EpSBPwk6Ij2FKhGhrCHMcNi7u7HedwKA5FJgR62JO2PL//yGLcGoBiC4COdyNiMHMS8Z1aqXeTHVsz+O6OG8zE/RCRom5gmM0O5QkhlBHkVNMUiHv8I05PicGUHeY/ejFc7LFvT/6edyFQq13VX X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 18, 2023 at 09:14:09AM +0900, Naoya Horiguchi wrote: > On Mon, Jul 17, 2023 at 11:18:12AM -0700, Sidhartha Kumar wrote: > > It was pointed out[1] that using folio_test_hwpoison() is wrong > > as we need to check the indiviual page that has poison. > > folio_test_hwpoison() only checks the head page so go back to using > > PageHWPoison(). > > > > Reported-by: Matthew Wilcox (Oracle) > > Fixes: a6fddef49eef ("mm/memory-failure: convert unpoison_memory() to folios") > > Cc: stable@vger.kernel.org #v6.4 > > Signed-off-by: Sidhartha Kumar > > > > [1]: https://lore.kernel.org/lkml/ZLIbZygG7LqSI9xe@casper.infradead.org/ > > --- > > mm/memory-failure.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > > index 02b1d8f104d51..a114c8c3039cd 100644 > > --- a/mm/memory-failure.c > > +++ b/mm/memory-failure.c > > @@ -2523,7 +2523,7 @@ int unpoison_memory(unsigned long pfn) > > goto unlock_mutex; > > } > > > > - if (!folio_test_hwpoison(folio)) { > > + if (!PageHWPoison(p)) { > > > I don't think this works for hwpoisoned hugetlb pages that have PageHWPoison > set on the head page, rather than on the raw subpage. In the case of > hwpoisoned thps, PageHWPoison is set on the raw subpage, not on the head > pages. (I believe this is not detected because no one considers the > scenario of unpoisoning hwpoisoned thps, which is a rare case). Perhaps the > function is_page_hwpoison() would be useful for this purpose? Sorry, I was wrong. Checking PageHWPoison() is fine because the users of unpoison should know where the PageHWPoison is set via /proc/kpageflags. So this patch is OK to me after comments from other reviewers are resolved. Acked-by: Naoya Horiguchi Thanks, Naoya Horiguchi