From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 484E5C001B0 for ; Mon, 17 Jul 2023 21:51:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 549498D0001; Mon, 17 Jul 2023 17:51:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D2496B0074; Mon, 17 Jul 2023 17:51:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 34E588D0001; Mon, 17 Jul 2023 17:51:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 214566B0072 for ; Mon, 17 Jul 2023 17:51:10 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E8B9216048F for ; Mon, 17 Jul 2023 21:51:09 +0000 (UTC) X-FDA: 81022449858.19.F43D0E1 Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) by imf11.hostedemail.com (Postfix) with ESMTP id C1B9C40016 for ; Mon, 17 Jul 2023 21:51:07 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=cmpxchg-org.20221208.gappssmtp.com header.s=20221208 header.b=PrIrLbl6; spf=pass (imf11.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.176 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689630668; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HxHcLFiWi1qv3gg07rbnC3PGfypMywDH/jm9GrEbEsI=; b=WMHsB9uhmEyw+htnjLQklUEkUeenZcGFrQVsTmiFCb8XYLaW8BWcpbvqcKAPNaQhwsUiLb m5qa9PUXLsQonL4WYMfBSNRnvh5o1adev6BVZK84fl/YRNA6BpqyGoYbMbWMFspfcTKyfc OPSLtE7x8JxTKGvJ8Qzs+nTypWRb5QM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689630668; a=rsa-sha256; cv=none; b=hBfWxNF/kVvGe9zuuTUZeWzbroGltnC/N96OW5w6xVgK1auk+anYuTr78JuFy58efNtBsL oaLNMmGrnRN1o6KJsJ5I7i5eCm2f0oOODtEOOmwZWs2Sgnt6auetleLNTqC+mL80iGsgFf DYmx5jtH9juI+g6I2IWVe5KNwLKpMrQ= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=cmpxchg-org.20221208.gappssmtp.com header.s=20221208 header.b=PrIrLbl6; spf=pass (imf11.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.176 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org Received: by mail-qt1-f176.google.com with SMTP id d75a77b69052e-40292285362so35602321cf.3 for ; Mon, 17 Jul 2023 14:51:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20221208.gappssmtp.com; s=20221208; t=1689630666; x=1692222666; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=HxHcLFiWi1qv3gg07rbnC3PGfypMywDH/jm9GrEbEsI=; b=PrIrLbl61WfqvxPvTw244aArUIpbIIHoc1pMRUZrd3Lt9iiCKExp7VVWDrSh/kXfgj Gy1VxDqv0RZLanw8E8Y+hrwnxkAfaxnjXLsEsutLJrikmIYUtk8bnQZl4U7C0TtZGv90 RiLU8trzykMk4gram4QXWlumvDRCLAz+NmJfKjsvJuOKxhQHD/GZNRDvdMxPgxwU0Kc/ R1XmDCtRxmBj9v7vFQsdJpuJXcIzynJ/abbLJR4RH1ZHcAGYxB9ubH/WjK+bE8I19tsd zDUb1y/3pj87mwEM/gu+JyRHMh3ze9lRWjg2OfR9IWylOlbqfYPPr/iNUF2M8mX0FyYY NpAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689630666; x=1692222666; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HxHcLFiWi1qv3gg07rbnC3PGfypMywDH/jm9GrEbEsI=; b=GTxjivKMEKmeJANhI3aPbAofZd6Vg7dkha6Od6+x2qPvwCnPz489B2/2TQMJ4M1Z3U oNxN4bnMukmdxO884jw6ZYSkB6gJ5LSUsmhu36LnGFN5dfjHGcnZGz/ylrGPAPOS1oU4 LsXDsLKboQvO89wtq9qwWlYeRcSOyiQ+MeEdZIb3KLkG7BXEYZmBXjzm/kcunkvjEtE9 ZxLZwxWTikfkzqsUu4lvseUC2/84WlMPIwBmVLv6Vi6QVGrPGft9qdL7o3/2D5jPyOt2 6XxbNTUNSpFl8W+zeRH7BQMjPgVLoDV1ZJsPZcnGLPhsoBVnUPdTvgtCehlerDopPiHW +CqQ== X-Gm-Message-State: ABy/qLbnH2xKdyxj/Q9FWzGPUn5BGA51BsPrS7HhpjdbWT0dnzcSNXSZ pITGoYmMpQX8NwRLYKWPwPwy1A== X-Google-Smtp-Source: APBJJlFeJ3yCCpSjrofyFbOP99jmm7G6o/8YQsmYu9r7Ws+184BUiWZGhETF7W3gxnN6P+jaz7333g== X-Received: by 2002:a05:622a:1814:b0:403:b0f3:8a9 with SMTP id t20-20020a05622a181400b00403b0f308a9mr18684119qtc.61.1689630666751; Mon, 17 Jul 2023 14:51:06 -0700 (PDT) Received: from localhost (2603-7000-0c01-2716-8f57-5681-ccd3-4a2e.res6.spectrum.com. [2603:7000:c01:2716:8f57:5681:ccd3:4a2e]) by smtp.gmail.com with ESMTPSA id br22-20020a05622a1e1600b0040399fb5ef3sm186057qtb.0.2023.07.17.14.51.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jul 2023 14:51:06 -0700 (PDT) Date: Mon, 17 Jul 2023 17:51:05 -0400 From: Johannes Weiner To: Matthew Wilcox Cc: Vlastimil Babka , Andrew Morton , Yosry Ahmed , Christoph Hellwig , Nhat Pham , Domenico Cerasuolo , konrad.wilk@oracle.com, vitaly.wool@konsulko.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: kill frontswap Message-ID: <20230717215105.GA909920@cmpxchg.org> References: <20230714194610.828210-1-hannes@cmpxchg.org> <20230717141250.GA866068@cmpxchg.org> <901409ed-504b-9500-54d8-e42f832e07b0@suse.cz> <20230717160227.GA867137@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: C1B9C40016 X-Rspam-User: X-Stat-Signature: nc1xdocxqzfakp6yhgkzafx957en45ek X-Rspamd-Server: rspam03 X-HE-Tag: 1689630667-470959 X-HE-Meta: U2FsdGVkX1/8Q84+bN/pbYvXK5Cqu2A92rIsUpxZ5D1BQ6OgkGXeptHumzyrH0mVJMVCAA+CfllRJdoucdXx6UlsEieg0n1ZLqIcSlOt9naTzkAE/oUL2Z90YzXNq6SgBpZ2APbFfAujLcKaeVteylfflSGhYltmJFe56XoVtwheUhGk/+JbAQeS3hGtdxojS6SdB+m96O5sibTK+s7Ar1qAFKX36tmCc660+/kErWQid3ufrgUN1Ewcz5kwg0t/CrT1ZwG6DSt0Gby13gC9P+AsKPAV3lKiwAgfZQTAxbS64WOXyVXbXjlU8oXGi5VPriKw4ULdCkddYz+kwfKz9/la6+ojxu58OP/epMH3MJt7zDKb+TXzrPGsDNfrl63c9SKO/vb4/HLCoLdqx6brRuM8Gl0rYQEDpmGzD/RTJ10FbnJgYUXJ6yTdTE1Pt8xjXOTVxplLtADsjBKgh+EpuJ0zZhdnPPEsgqp1L2kGV3EpITxdIRkVrnwmGEFYzx+0cAp97sFxRVsyIFBnm9VRahG0YDaJds5C4I5BZOWlgiARdHFRATwpdkDDBzDaztHfr7XUOrBiSojXEgxRc1IEzT1dqDaKX4ejfKO+LSJ6WRBOz0OJANgIZM0ohxwQIdesf4zAwG4tbhxsFvy/flORboo74J1QANrAMURLRWHQO9igT3rFdkOut2T4Wlcr8e1UMgYU+zY4XKLz7eWtvla68Sc2/gXF+aIvXECHGUC0FYRS0vBJ7d/0uqecJNby8eeNkcgfimQ2Zy9Tek+vOuOPYjjUHVS4g8e7WzVrTvnDR5+l3rdGdJL2mcleII0cO/kPPb88NpWqGENYPuybk9ouphTSpk7gIzZ1FUBnLyO854OKLXx5FpSvMfDno0eDwjzDSaQ5nczRCg7fveAjxoLjY+PcQ/fmBytp9X7jaiXBE/oCgVOUm38cY4vRqvhaU37NxSs2+hpJNEWdXG4kBNw yjicXdDg Ysq01g/6QSq7sF10cLQqfsphAOUndEsqSti3rdPgKFtX4LqtoCgtS2ZIkhScrZTPhS+LsumQaN2Tc6Mk/DBep+B/Jb/clIjUJFUDURAJhZCN+SIvIhqjXdfPOIR25mA7B15CJktCX1RD6ZvyqztGed8i31xmDgmYI3TEj631SrK4Xw1iCWD3NMqpYvaTeSt4WsGzQ68npcC6ojZXQKB5WZf9u2e81VlR2wl1G5wExymHq51+1cW16X4dH4tKt+BuMW8YvMXGPNYHEqjWclwMRnPGMZlyFKUawYEQsIoQ0xlteaIkFWB1YAmS/kSLcJBjbOqIJEXZ6VnuVi24bqmPtMgQg3VJdTvQCLhoC5nqGzig8aGzWBDYchGf+M1rPeNFVnJU/SKTJaoL4YWA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 17, 2023 at 05:07:46PM +0100, Matthew Wilcox wrote: > On Mon, Jul 17, 2023 at 12:02:27PM -0400, Johannes Weiner wrote: > > - pr_info("Adding %uk swap on %s. Priority:%d extents:%d across:%lluk %s%s%s%s%s\n", > > + pr_info("Adding %uk swap on %s. Priority:%d extents:%d across:%lluk %s%s%s%s\n", > > p->pages<<(PAGE_SHIFT-10), name->name, p->prio, > > nr_extents, (unsigned long long)span<<(PAGE_SHIFT-10), > > (p->flags & SWP_SOLIDSTATE) ? "SS" : "", > > (p->flags & SWP_DISCARDABLE) ? "D" : "", > > (p->flags & SWP_AREA_DISCARD) ? "s" : "", > > - (p->flags & SWP_PAGE_DISCARD) ? "c" : "", > > - (frontswap_map) ? "FS" : ""); > > + (p->flags & SWP_PAGE_DISCARD) ? "c" : ""); > > Is it useful information (to the sysadmin) that zswap is enabled? If so, > we might want to print a "Z" instead of a "FS" here (would need to > know whether enabling zswap succeeded ...) I don't think it is needed in this particular place. zswap prints to dmesg when it is initialized. And it's easy to runtime check in sysfs or in /proc/meminfo if it's enabled - that's where I would look first if I checked a system that's showing zswap issues - not in the dmesg that may have long wrapped since swapon. There is also a warning to dmesg if zswap fails to enable for a given swapfile. But with the current page allocator implementation this can't actually fail.