From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 624B0C001DC for ; Mon, 17 Jul 2023 22:52:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5FC496B0074; Mon, 17 Jul 2023 18:52:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A6DC8D0003; Mon, 17 Jul 2023 18:52:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 403368D0002; Mon, 17 Jul 2023 18:52:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 2C8936B0072 for ; Mon, 17 Jul 2023 18:52:12 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E9867A05ED for ; Mon, 17 Jul 2023 22:52:11 +0000 (UTC) X-FDA: 81022603662.10.EAD8FE9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf13.hostedemail.com (Postfix) with ESMTP id DC67E20018 for ; Mon, 17 Jul 2023 22:52:09 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WSU35uqK; spf=pass (imf13.hostedemail.com: domain of alex.williamson@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=alex.williamson@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689634329; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8wy84DSSq8n2YYiK0mWellsvoswCFp/2kMAmdZ+UHHc=; b=zYKbHKIw5wDwH9lV+C0msxafrGyxUuEcUQH03o4H0Hes96EWfsd0VL3tsUrMBOqq/RlM5m DCZPLHpj6aKQrkUhv7Ta98n0TUYfXZqoamjDtvDLKOpAuNyxyH1nshtQFusy3fpuBmlVhT m/c6CwYzqE2lohmqxKf1f9HAX6MQJhY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689634329; a=rsa-sha256; cv=none; b=r2QDBGTFzXREyI9SygYJd2O+Y3mmJGA00GpWfFH0wfmenrprOOWBCxRNZdqcSpK6s88oEk iZPl5GD/rWC+wOC1Ecq+V2JYe7pJ5xtRsjffx+YGS+Q7bmdY53G1ZxBxzZ3si4LvGWReHb 2z5Hy6uJ+QUXqLrO/Y8DCf8WfWFZDqY= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WSU35uqK; spf=pass (imf13.hostedemail.com: domain of alex.williamson@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=alex.williamson@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689634329; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8wy84DSSq8n2YYiK0mWellsvoswCFp/2kMAmdZ+UHHc=; b=WSU35uqKWX5qXsL9Eqi4qqS9SCAvtRdUoP1pqlX2O/1cZK2gLwhVZqB5eExNH9bGJCaIvz BDObKB9Pjgy9nnNWI0Mg64rgQFu1m48ni/wL21sFRtdMbxZw6ZsGTbH7RccOeY6fV1KDLB hn5FNoggx6POG5Pi2hj0zNHisqxMXTQ= Received: from mail-io1-f72.google.com (mail-io1-f72.google.com [209.85.166.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-190-dYkISPDpM9qfewVsmT3opQ-1; Mon, 17 Jul 2023 18:52:07 -0400 X-MC-Unique: dYkISPDpM9qfewVsmT3opQ-1 Received: by mail-io1-f72.google.com with SMTP id ca18e2360f4ac-786d9d4d9a6so318100239f.2 for ; Mon, 17 Jul 2023 15:52:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689634327; x=1692226327; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=8wy84DSSq8n2YYiK0mWellsvoswCFp/2kMAmdZ+UHHc=; b=e6/xDgSM/awf6IhzIel5p8ui5TxWbmUb0q6eDnjywvkTDqldfU1YE8jdw0qzmlEZcj P4wt4ewqTRjHCM8xLCp19HWKnT8dTYTynW+OGaizmtq3o/2GXcDoUXh4SQ+q8FB6ePxD 5WcI9UIcDH/uIINvcFQA6otVfK40tkKP8AwG09f/mjal0BqQMLZSXwha87TSU7i3YCOu uGh+LtuMRkIdFoa/XQUOrNveW/DEfwafqhYeBZR/XbPjZICiGm5JEn0ixzelZqHCHmlH 7lpVSZ/LmaR3xgX2BboTFfL9/mJEYMmIhKUXRWmm1GUreQxPHWRlCLZRAzU6/m6Lqr1P 3ibw== X-Gm-Message-State: ABy/qLYZBwJe3qTHIhldHRN6pP+fnbHN1kSgOFjZnjnmjkzipvCjmkPg FffkvfXE+wyZZsST6tIGo7WhlMQsr2WZsJvXfwrHmwUTsaCEY9ztjU07ePlWVFwgtHQNc/sy+tK CQIrWpr8cxM0= X-Received: by 2002:a92:c651:0:b0:347:693a:7300 with SMTP id 17-20020a92c651000000b00347693a7300mr1012079ill.26.1689634327080; Mon, 17 Jul 2023 15:52:07 -0700 (PDT) X-Google-Smtp-Source: APBJJlGlBYmCdY1EaUds5QDcX7E6PqePOm9wJTOwk2wgOBkeJp+9wxIVvWJlHjSTuTXhWw/m+atXtQ== X-Received: by 2002:a92:c651:0:b0:347:693a:7300 with SMTP id 17-20020a92c651000000b00347693a7300mr1012015ill.26.1689634326829; Mon, 17 Jul 2023 15:52:06 -0700 (PDT) Received: from redhat.com ([38.15.36.239]) by smtp.gmail.com with ESMTPSA id d10-20020a92ddca000000b00341c0710169sm242627ilr.46.2023.07.17.15.52.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jul 2023 15:52:06 -0700 (PDT) Date: Mon, 17 Jul 2023 16:52:03 -0600 From: Alex Williamson To: Jason Gunthorpe Cc: Grzegorz Jaszczyk , Christian Brauner , linux-fsdevel@vger.kernel.org, linux-aio@kvack.org, linux-usb@vger.kernel.org, Matthew Rosato , Paul Durrant , Tom Rix , Jason Wang , dri-devel@lists.freedesktop.org, Michal Hocko , linux-mm@kvack.org, Kirti Wankhede , Paolo Bonzini , Jens Axboe , Vineeth Vijayan , Diana Craciun , Alexander Gordeev , Xuan Zhuo , Shakeel Butt , Vasily Gorbik , Leon Romanovsky , Harald Freudenberger , Fei Li , x86@kernel.org, Roman Gushchin , Halil Pasic , Ingo Molnar , intel-gfx@lists.freedesktop.org, Christian Borntraeger , linux-fpga@vger.kernel.org, Zhi Wang , Wu Hao , Jason Herne , Eric Farman , Dave Hansen , Andrew Donnellan , Arnd Bergmann , linux-s390@vger.kernel.org, Heiko Carstens , Johannes Weiner , linuxppc-dev@lists.ozlabs.org, Eric Auger , Borislav Petkov , kvm@vger.kernel.org, Rodrigo Vivi , cgroups@vger.kernel.org, Thomas Gleixner , virtualization@lists.linux-foundation.org, intel-gvt-dev@lists.freedesktop.org, io-uring@vger.kernel.org, netdev@vger.kernel.org, Tony Krowiak , Tvrtko Ursulin , Pavel Begunkov , Sean Christopherson , Oded Gabbay , Muchun Song , Peter Oberparleiter , linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, Benjamin LaHaise , "Michael S. Tsirkin" , Sven Schnelle , Greg Kroah-Hartman , Frederic Barrat , Moritz Fischer , Vitaly Kuznetsov , David Woodhouse , Xu Yilun , Dominik Behr , Marcin Wojtas Subject: Re: [PATCH 0/2] eventfd: simplify signal helpers Message-ID: <20230717165203.4ee6b1e6.alex.williamson@redhat.com> In-Reply-To: References: <20230630155936.3015595-1-jaz@semihalf.com> <20230714-gauner-unsolidarisch-fc51f96c61e8@brauner> <20230717130831.0f18381a.alex.williamson@redhat.com> Organization: Red Hat MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: 86rt3ymsd6tufj9f4xkaw94y67pa9nr7 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: DC67E20018 X-Rspam-User: X-HE-Tag: 1689634329-526710 X-HE-Meta: U2FsdGVkX1+S1AXZHVqhvU7FYkh7XC0OhtfYMAifxfDaKtf7lAE4zspUri+rF6/JDOc8sayKqLCA0ZX/+vDSjaueEI922YIwBk1xHhgPl8jggAsbitBteNKOjvEtEbxDTBDWFsjIsLuNfON9Mm0FnBA8G5+eElTymUJrVb7QlmSQj5ImC8zzk8ptGjNLNGyDsqSXnZ7EIU2//MnUfR6cE8Ymc1RVfYRyUHMRNikSrHmjhJH0WNhYyCJiIeM9SqI37LMLBwXkQ48az2ln6dn9haLlHfWaEinkJC/ZgNhCyO2i5XqqpHJIgfj4iLAN/z6XVLgzvSvDnIBRlT5A8ciPZ8GXvieQ81QODPrHql2VXrhPfrp1Cc57K5HoYmHcr5A49MLnbt0sfEsEBvCb3B05uW2X7wvgyQbvNtUyhQyB784rSvFGwtpUC2K/Qm8Th62zjYsWMth3D3sxskv8XHY3huMs3OyBe0U4ibDDg3EdK1r59iqcIcX0wYokH71c1nNhi4H+l5b4bcZsxZMMX7EKqumMFHeJ6ywbVCnBIEn7skbszqc2PVfKGu7NKQRXjDjpb/g7cKTD0IsbvbRrola88nNaLQz/6AQ0SUQYqEGmt5DkrPmwIbX3E4TQ4KhegXPKU7h6Jzn9sQKeD6scpwXsxLGxhvjRUBvpBBDeDEUNprs8rL6FDScBoBMvQvatW3AenUvdmOl8RydchRNJ3BEp23IdO9zNsojqED3Jsw7t5T+kndqbu1ChdnZbIPDyDnQJa+f4/l88Qfjn58hsXbmT/6AcBnjrCzH5Lz2BA8ScNjvhhJ5fqvohu04R6z8IPmyCWL29U5xHMH+SHrNVEpXxZxH3NBP2AkcoI81LXmbOrsaRwbzkkbB8Wja2iFxu++UjYjGvphnTJdNtiwEb9sMyGiSFJFIX7Bdp4zrutWMXy9LPqsHf9P3WuhTAuqVVg4HuZ1xi7zPeZ1YvZv+5zWS sy9eGx4D EvfT8vA73nnqRiqdC2PmYQHBYI9THgBFCF7Ljn+Q4zmF8mLlCiv5IAXDhvMqEPRE27JwERHPfiL/8dHYaS1dIduxkai1tF5c4b61z4mts9FManjVUrMnsOVEOJLpTRqJu80JWVTGs2JX6k8xXdAsdqJbk6Tmckc/Lwi1wHzga0CbfgpeU/5CuteygWkt6jez+EaxMRq87n0X7FzBKzDfhGHR0UVIGI84A3w6WdYizt5j8tWmcZQtQTv9UNl2+xv/iVvTHTekh4GNQJH/XiexI3Oj6QvXWiirFwijgOUFHB1LN4N0blc6P1NIkUV+xDa8rukEeyzQIn0aFsKSRIgwYr0pV1rJbwXanaGMRkVjYX1rKpbp0EVAWBjPjKpe19OKb6PWCfhbOycxX365KHeYIt3RTXReG/+WQbiHhu9I+aWClPwKRVx/Ff/MToCYRQHx/MqEWrC0k4vKpv/cHKeEiohNoRgSJFy4TqY1H/0J2RvT35F40mKm/HeU2N8a90ziOTvAVzpf7irLJRbhM3TMTsjyIdw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 17 Jul 2023 19:12:16 -0300 Jason Gunthorpe wrote: > On Mon, Jul 17, 2023 at 01:08:31PM -0600, Alex Williamson wrote: > > > What would that mechanism be? We've been iterating on getting the > > serialization and buffering correct, but I don't know of another means > > that combines the notification with a value, so we'd likely end up with > > an eventfd only for notification and a separate ring buffer for > > notification values. > > All FDs do this. You just have to make a FD with custom > file_operations that does what this wants. The uAPI shouldn't be able > to tell if the FD is backing it with an eventfd or otherwise. Have the > kernel return the FD instead of accepting it. Follow the basic design > of eg mlx5vf_save_fops Sure, userspace could poll on any fd and read a value from it, but at that point we're essentially duplicating a lot of what eventfd provides for a minor(?) semantic difference over how the counter value is interpreted. Using an actual eventfd allows the ACPI notification to work as just another interrupt index within the existing vfio IRQ uAPI. Thanks, Alex