From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BA26EB64DC for ; Mon, 17 Jul 2023 14:12:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 88C218D0001; Mon, 17 Jul 2023 10:12:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 83C7F6B0074; Mon, 17 Jul 2023 10:12:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 72A268D0001; Mon, 17 Jul 2023 10:12:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6533A6B0072 for ; Mon, 17 Jul 2023 10:12:56 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id CE77AB0BA6 for ; Mon, 17 Jul 2023 14:12:55 +0000 (UTC) X-FDA: 81021295110.03.5D09D32 Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) by imf10.hostedemail.com (Postfix) with ESMTP id D2C05C0013 for ; Mon, 17 Jul 2023 14:12:52 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=cmpxchg-org.20221208.gappssmtp.com header.s=20221208 header.b=ku2rfNUK; spf=pass (imf10.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.180 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689603173; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mUo+6I0vtoW6cfyVYK79jK4ZqLeZxYB4Nx9OKnhgx0U=; b=LBXAGXBHcfZdkj6Eymcm7QS4pjheSIffIotEISyjs51Fbkq7sr/S31Rv6Sw0eZKiNQVrFo qo3Z8lR5Zb3sxqP8DJwAwSVqePCsRn+WW9ToYjwAaGvcD77McakGilEantAzNkfKofMFU2 rf6WvDg3CcY0fdHHAHiSY9jefLgyyFw= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=cmpxchg-org.20221208.gappssmtp.com header.s=20221208 header.b=ku2rfNUK; spf=pass (imf10.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.180 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689603173; a=rsa-sha256; cv=none; b=fCKXZYvYrp6QI9SgnLiM7gqPSP1YQyAp8RYorBMd4BdSOjFHlIT/OwFM1nt/OwicUcUkz+ WJqueCZK/amcjPv3ao+1gz2UHnn4PWQ/Smy86CA0X8knIU73OheeoYvu183vk/kkOGNOrl pz7ectN7UAZ1lRgPQi9KhyQdeqayyYM= Received: by mail-qk1-f180.google.com with SMTP id af79cd13be357-76731802203so431178685a.3 for ; Mon, 17 Jul 2023 07:12:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20221208.gappssmtp.com; s=20221208; t=1689603171; x=1692195171; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=mUo+6I0vtoW6cfyVYK79jK4ZqLeZxYB4Nx9OKnhgx0U=; b=ku2rfNUK+DU5Hrx59tES8EpLWBWpNHDaYQK9aNkA4w7I0J6zKbMmk+t71+OCIFjDeN CpAwZDk/+R0b8mf/fupiKX8yYumHwfH3rEZ15qGdcz7FEC0D9B4V1XlBaJhFA7QVr4Gp D+1Ah9nHuE7ee9o2aD94yyPfhzILFyfl+q3Ip0gkSBDZomcxvUeXgSXRSYvsl+G0K7Er M0V8S1otEmVOCDpCD7a+/+NXta2i/4m9BnZ9Z2a8GAjsu8DeiuOwA6t+Gl8+YPDzypov orC75KUozuXSyf76NwcwEOtlfnyVdIKLKenze5MwGV40O2k7X76Ot4tpnvSptuE+21db g5bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689603171; x=1692195171; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mUo+6I0vtoW6cfyVYK79jK4ZqLeZxYB4Nx9OKnhgx0U=; b=G7p7qKX6YWbnNNK6XelPbHtomtmo486y95iUjSGQIR4liHVvJW2+tn0E1GMa4UIOR1 7XgDfGz+cOxZnpNtFfe89vGqAsW2cW0NJZCcDHEluw4U1Ghs8QOZeImtzV9JCOx3gsd7 gLlXfTrZq0lA3CDgyhaGZMRqaGcsZ8byt5NBsjN4l5nIS+oxSlymSfJvCEkl0CkB6m81 P64Z99vN5es8IbaCeK/P0LLSA5O2QYhXO0cpIHoesC8BBgv85UG/o7dVaNcvHgtgv2Eq Vz9jrVe5CWA4xrCrVfyVkeyde6pFV+UvBt68eUV6mBvtPlaiYiByb1oLVLsfCO5klzwg V9tw== X-Gm-Message-State: ABy/qLZWXtDHKYqaYiQ9btngZoHSm0wghLyeqvrMf4WHZHeCB3nUEbnF qFkZE44Ls66AWvp5dleft2kE4w== X-Google-Smtp-Source: APBJJlGAGULC7enn5gfZAvLy/hJHQS3JtiaNt8i0W6K9lNpDSglVC/a8mnN/bspkZOik1rny8T6p0w== X-Received: by 2002:a05:620a:4087:b0:765:3380:2005 with SMTP id f7-20020a05620a408700b0076533802005mr15636201qko.61.1689603171377; Mon, 17 Jul 2023 07:12:51 -0700 (PDT) Received: from localhost (2603-7000-0c01-2716-8f57-5681-ccd3-4a2e.res6.spectrum.com. [2603:7000:c01:2716:8f57:5681:ccd3:4a2e]) by smtp.gmail.com with ESMTPSA id d1-20020a05620a136100b00767cfac77c3sm6069128qkl.134.2023.07.17.07.12.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jul 2023 07:12:51 -0700 (PDT) Date: Mon, 17 Jul 2023 10:12:50 -0400 From: Johannes Weiner To: Matthew Wilcox Cc: Andrew Morton , Yosry Ahmed , Christoph Hellwig , Nhat Pham , Domenico Cerasuolo , konrad.wilk@oracle.com, vitaly.wool@konsulko.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: kill frontswap Message-ID: <20230717141250.GA866068@cmpxchg.org> References: <20230714194610.828210-1-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: D2C05C0013 X-Rspam-User: X-Stat-Signature: cmaf8sx4tjaqkhiun4q6insjjeqem161 X-Rspamd-Server: rspam01 X-HE-Tag: 1689603172-843428 X-HE-Meta: U2FsdGVkX19d9Vpru1g/r51qZe0F7AnV6HBsWl8W4zsPimDtC2hG95wo0NfMFJKiUp5Gonpe/QlIHdA8E47hE3afoNUKAuvdYAIWDtTawCJ4NKg4alPTp8HXy0nMafI7ipWS5bkxXodDJn/W2nwYaLYSiAIJ++0lD3Hx4ew+44Ft3OjcR9s7qF7QXfEoGgPxm85s/i2VmPGXkaaTezNfGv9GFlPeuRFSo3vpT6dSxX6I0yoZpJ5rjT11falT9uGK3pg4/WVPb8vmIrHz3jix+eoqOg0Ife1fp/CeLw+WNvqoA5+Y6YKRrkZ5Mo7KvZmWFHtnJtW40diapCW3Jj7HwMsmJEdMowJuZuX4KeHHYs23kxKSGaVq4jOFmz8pXkxKU9/tCeWzPEL1U1yS6CJdEdwl2cm2H+Ep7rfjPCmLAb20Zj6XYOAhdshi2+mWM5sIAegopngAaHPOKcFqJmozK3JkIvh5yxI7w/0WL3Cwe8oVjWCAqcucVr28oGb74AKrTdDrI3cidGEBK8akFHL1kmjOfqFcv7qWylS2f4C5w5LbgXArnok8xKDPJJAjGrXSN+AtloMhCfdBa2loClyc1FEP0v2tYs86eY5FRgmc3sjjw4KTx8m9JhsBrPc2hTcZVXLa8L69ayrs6VAckAtsgOOQn0ZMgVg6HXrTEFyNrBYj8AsqR/3J4kFLift2MzyDxkb3EwB9w3SnL/QPBhKnNr4yWD2QGmh/dmSIdoCTCBmDzAtWnHiL5KJUvive3/zz300hXhTP/lKLUUe1FB/OnZZiuErkEP07nMJLu3inZmsa10YtGsu6x5hl/L2MlfF2iCE6+SoJQNZBNfpsug8AYsWqgx2YIVMWMPaL8Q+HbGJKdjcueFj7xxo+Kfy1UlSXtKAV2Dpf+Bsr997+OgZylAv0YTj54eDxB0smc8y9fUANsyJ85EjSi+jrdYOP3l+pmQKMFwOx1OAPQC0uN7P 7jmPsyzk FpEDBR2k0O2r1EXcBCj7x15KE1HiqT+VpiwUveruNzXgTjCA5BrjN7F7pkdImpeJ8MQb6troE5hafs7V5hBMP/quUnVwjCI0kCw0bOzAgnEQamxTG/tWCzZfAncFckQAL+xjfRDlEN0FesdUPj/WWUTGx1QxgO/JIoW6xsAUzj7mbC822KRp6WNs7piJTVIJA6ujNXsJ0TiMcf6iSi81J7lUGTjbDgk244QgV0V7SrWqJz4V6wy5BHgatTM4gMaUr03ceTb+96ZLQRxYCqI1oGRUza/yPY763yCKsvuJ+Y1V6ud8IDDbSDutVIKPk8KHL3YDkL6kCV0OqEB0XnvaBVdcBT+xC9SjnQXn3IHu/yK5wqHJoq+DZYRSWA4G6Pmtkti3mm3Kif+ESMp0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jul 15, 2023 at 04:42:13AM +0100, Matthew Wilcox wrote: > On Fri, Jul 14, 2023 at 03:46:08PM -0400, Johannes Weiner wrote: > > diff --git a/mm/zswap.c b/mm/zswap.c > > index 62195f72bf56..1b0128060792 100644 > > --- a/mm/zswap.c > > +++ b/mm/zswap.c > > @@ -2,7 +2,7 @@ > > /* > > * zswap.c - zswap driver file > > * > > - * zswap is a backend for frontswap that takes pages that are in the process > > + * zswap is a cache that takes pages that are in the process > > * of being swapped out and attempts to compress and store them in a > > * RAM-based memory pool. This can result in a significant I/O reduction on > > * the swap device and, in the case where decompressing from RAM is faster > > @@ -20,7 +20,6 @@ > > #include > > #include > > #include > > -#include > > #include > > #include > > #include > > To make this patch compile, I had to add zswap.h to the include list. I can fix that up, but I'm curious what kind of failure you saw. It built fine for me, not even a warning.