* [PATCH 1/3] mm/page_poison: remove unused page_ext.h from page_poison
[not found] <20230717113227.1897173-1-shikemeng@huaweicloud.com>
@ 2023-07-17 11:32 ` Kemeng Shi
2023-07-17 11:32 ` [PATCH 2/3] mm/vmstat: remove unused page_ext.h from vmstat Kemeng Shi
` (2 subsequent siblings)
3 siblings, 0 replies; 4+ messages in thread
From: Kemeng Shi @ 2023-07-17 11:32 UTC (permalink / raw)
To: akpm, linux-mm, linux-kernel; +Cc: shikemeng
No page_ext function or structure is used in page_poison. Just remove
page_ext header from page_poison.
Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
---
mm/page_poison.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/mm/page_poison.c b/mm/page_poison.c
index 98438985e1ed..b4f456437b7e 100644
--- a/mm/page_poison.c
+++ b/mm/page_poison.c
@@ -4,7 +4,6 @@
#include <linux/mm.h>
#include <linux/mmdebug.h>
#include <linux/highmem.h>
-#include <linux/page_ext.h>
#include <linux/poison.h>
#include <linux/ratelimit.h>
#include <linux/kasan.h>
--
2.30.0
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH 2/3] mm/vmstat: remove unused page_ext.h from vmstat
[not found] <20230717113227.1897173-1-shikemeng@huaweicloud.com>
2023-07-17 11:32 ` [PATCH 1/3] mm/page_poison: remove unused page_ext.h from page_poison Kemeng Shi
@ 2023-07-17 11:32 ` Kemeng Shi
2023-07-17 11:32 ` [PATCH 3/3] mm/page_ext: move page_ext_operations definition under CONFIG_PAGE_EXTENSION Kemeng Shi
2023-07-19 3:41 ` [PATCH 0/3] minor cleanups to page_ext header Kemeng Shi
3 siblings, 0 replies; 4+ messages in thread
From: Kemeng Shi @ 2023-07-17 11:32 UTC (permalink / raw)
To: akpm, linux-mm, linux-kernel; +Cc: shikemeng
No page_ext function or structure is used in vmstat. Just remove
page_ext header from vmstat.
Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
---
mm/vmstat.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/mm/vmstat.c b/mm/vmstat.c
index b731d57996c5..00e81e99c6ee 100644
--- a/mm/vmstat.c
+++ b/mm/vmstat.c
@@ -26,7 +26,6 @@
#include <linux/writeback.h>
#include <linux/compaction.h>
#include <linux/mm_inline.h>
-#include <linux/page_ext.h>
#include <linux/page_owner.h>
#include <linux/sched/isolation.h>
--
2.30.0
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH 3/3] mm/page_ext: move page_ext_operations definition under CONFIG_PAGE_EXTENSION
[not found] <20230717113227.1897173-1-shikemeng@huaweicloud.com>
2023-07-17 11:32 ` [PATCH 1/3] mm/page_poison: remove unused page_ext.h from page_poison Kemeng Shi
2023-07-17 11:32 ` [PATCH 2/3] mm/vmstat: remove unused page_ext.h from vmstat Kemeng Shi
@ 2023-07-17 11:32 ` Kemeng Shi
2023-07-19 3:41 ` [PATCH 0/3] minor cleanups to page_ext header Kemeng Shi
3 siblings, 0 replies; 4+ messages in thread
From: Kemeng Shi @ 2023-07-17 11:32 UTC (permalink / raw)
To: akpm, linux-mm, linux-kernel; +Cc: shikemeng
page_ext_operations should only be defined when CONFIG_PAGE_EXTENSION is
enabled.
Besides, this may detect missing rely on CONFIG_PAGE_EXTENSION from
future Page Extension client at compile time.
Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
---
include/linux/page_ext.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/include/linux/page_ext.h b/include/linux/page_ext.h
index 67314f648aeb..8dd21d87e0da 100644
--- a/include/linux/page_ext.h
+++ b/include/linux/page_ext.h
@@ -8,6 +8,7 @@
struct pglist_data;
+#ifdef CONFIG_PAGE_EXTENSION
/**
* struct page_ext_operations - per page_ext client operations
* @offset: Offset to the client's data within page_ext. Offset is returned to
@@ -29,8 +30,6 @@ struct page_ext_operations {
bool need_shared_flags;
};
-#ifdef CONFIG_PAGE_EXTENSION
-
/*
* The page_ext_flags users must set need_shared_flags to true.
*/
--
2.30.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 0/3] minor cleanups to page_ext header
[not found] <20230717113227.1897173-1-shikemeng@huaweicloud.com>
` (2 preceding siblings ...)
2023-07-17 11:32 ` [PATCH 3/3] mm/page_ext: move page_ext_operations definition under CONFIG_PAGE_EXTENSION Kemeng Shi
@ 2023-07-19 3:41 ` Kemeng Shi
3 siblings, 0 replies; 4+ messages in thread
From: Kemeng Shi @ 2023-07-19 3:41 UTC (permalink / raw)
To: akpm, linux-mm, linux-kernel
Hi Andrew, sorry for the bother. I notice that you have taken my patches sent
later and I do appreciate it. I send this email just to avoid this series sent
early is missed for some unknow reasons. Thanks!
on 7/17/2023 7:32 PM, Kemeng Shi wrote:
> Hi all, this series does page_ext header relevant cleanups.
> First two patches remove unused page_ext header from page_poison and
> vmstat. The last patch move page_ext_operations definition under
> CONFIG_PAGE_EXTENSION. Thanks!
>
> Kemeng Shi (3):
> mm/page_poison: remove unused page_ext.h from page_poison
> mm/vmstat: remove unused page_ext.h from vmstat
> mm/page_ext: move page_ext_operations definition under
> CONFIG_PAGE_EXTENSION
>
> include/linux/page_ext.h | 3 +--
> mm/page_poison.c | 1 -
> mm/vmstat.c | 1 -
> 3 files changed, 1 insertion(+), 4 deletions(-)
>
--
Best wishes
Kemeng Shi
^ permalink raw reply [flat|nested] 4+ messages in thread