From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
vitaly.wool@konsulko.com, cerasuolodomenico@gmail.com,
nphamcs@gmail.com, hch@infradead.org, yosryahmed@google.com,
akpm@linux-foundation.org
Subject: [PATCH 4/5] swap: Remove some calls to compound_head() in swap_readpage()
Date: Sat, 15 Jul 2023 05:23:42 +0100 [thread overview]
Message-ID: <20230715042343.434588-5-willy@infradead.org> (raw)
In-Reply-To: <20230715042343.434588-1-willy@infradead.org>
Replace six implicit calls to compound_head() with one call to
page_folio().
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
mm/page_io.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/mm/page_io.c b/mm/page_io.c
index b9fda7fb4e75..e5b6f1402506 100644
--- a/mm/page_io.c
+++ b/mm/page_io.c
@@ -495,14 +495,15 @@ static void swap_readpage_bdev_async(struct page *page,
void swap_readpage(struct page *page, bool synchronous, struct swap_iocb **plug)
{
+ struct folio *folio = page_folio(page);
struct swap_info_struct *sis = page_swap_info(page);
- bool workingset = PageWorkingset(page);
+ bool workingset = folio_test_workingset(folio);
unsigned long pflags;
bool in_thrashing;
- VM_BUG_ON_PAGE(!PageSwapCache(page) && !synchronous, page);
- VM_BUG_ON_PAGE(!PageLocked(page), page);
- VM_BUG_ON_PAGE(PageUptodate(page), page);
+ VM_BUG_ON_FOLIO(!folio_test_swapcache(folio) && !synchronous, folio);
+ VM_BUG_ON_FOLIO(!folio_test_locked(folio), folio);
+ VM_BUG_ON_FOLIO(folio_test_uptodate(folio), folio);
/*
* Count submission time as memory stall and delay. When the device
@@ -516,8 +517,8 @@ void swap_readpage(struct page *page, bool synchronous, struct swap_iocb **plug)
delayacct_swapin_start();
if (zswap_load(page)) {
- SetPageUptodate(page);
- unlock_page(page);
+ folio_mark_uptodate(folio);
+ folio_unlock(folio);
} else if (data_race(sis->flags & SWP_FS_OPS)) {
swap_readpage_fs(page, plug);
} else if (synchronous || (sis->flags & SWP_SYNCHRONOUS_IO)) {
--
2.39.2
next prev parent reply other threads:[~2023-07-15 4:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-14 19:46 [PATCH] mm: kill frontswap Johannes Weiner
2023-07-14 21:10 ` Konrad Rzeszutek Wilk
2023-07-14 22:25 ` Nhat Pham
2023-07-15 3:42 ` Matthew Wilcox
2023-07-17 14:12 ` Johannes Weiner
2023-07-17 14:31 ` Vlastimil Babka
2023-07-17 16:02 ` Johannes Weiner
2023-07-17 16:07 ` Matthew Wilcox
2023-07-17 21:51 ` Johannes Weiner
2023-07-17 22:58 ` Nhat Pham
2023-07-18 18:52 ` Yosry Ahmed
2023-07-19 14:28 ` Johannes Weiner
2023-07-19 15:22 ` Yosry Ahmed
2024-01-16 20:09 ` Andrew Morton
2024-01-16 20:18 ` Matthew Wilcox
2024-01-16 20:22 ` Yosry Ahmed
2024-01-16 21:35 ` Andrew Morton
2023-07-15 4:23 ` [PATCH 0/5] Followup folio conversions for zswap Matthew Wilcox (Oracle)
2023-07-15 4:23 ` [PATCH 1/5] fix-frontswap Matthew Wilcox (Oracle)
2023-07-15 4:23 ` [PATCH 2/5] zswap: Make zswap_store() take a folio Matthew Wilcox (Oracle)
2023-07-15 4:23 ` [PATCH 3/5] memcg: Convert get_obj_cgroup_from_page to get_obj_cgroup_from_folio Matthew Wilcox (Oracle)
2023-07-15 4:23 ` Matthew Wilcox (Oracle) [this message]
2023-07-15 4:23 ` [PATCH 5/5] zswap: Make zswap_load() take a folio Matthew Wilcox (Oracle)
2023-07-20 6:00 ` [PATCH] mm: kill frontswap Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230715042343.434588-5-willy@infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=cerasuolodomenico@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nphamcs@gmail.com \
--cc=vitaly.wool@konsulko.com \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox