linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Miaohe Lin <linmiaohe@huawei.com>
To: <akpm@linux-foundation.org>, <naoya.horiguchi@nec.com>
Cc: <shy828301@gmail.com>, <linux-mm@kvack.org>,
	<linux-kernel@vger.kernel.org>, <linmiaohe@huawei.com>
Subject: [PATCH 4/4] mm: memory-failure: add PageOffline() check
Date: Sat, 15 Jul 2023 11:17:29 +0800	[thread overview]
Message-ID: <20230715031729.2420338-5-linmiaohe@huawei.com> (raw)
In-Reply-To: <20230715031729.2420338-1-linmiaohe@huawei.com>

Memory failure is not interested in logically offlined page. Skip this
type of pages.

Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
 mm/memory-failure.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/mm/memory-failure.c b/mm/memory-failure.c
index 42e63b0ab5f7..ed79b69837de 100644
--- a/mm/memory-failure.c
+++ b/mm/memory-failure.c
@@ -1559,7 +1559,7 @@ static bool hwpoison_user_mappings(struct page *p, unsigned long pfn,
 	 * Here we are interested only in user-mapped pages, so skip any
 	 * other types of pages.
 	 */
-	if (PageReserved(p) || PageSlab(p) || PageTable(p))
+	if (PageReserved(p) || PageSlab(p) || PageTable(p) || PageOffline(p))
 		return true;
 	if (!(PageLRU(hpage) || PageHuge(p)))
 		return true;
@@ -2513,7 +2513,8 @@ int unpoison_memory(unsigned long pfn)
 		goto unlock_mutex;
 	}
 
-	if (folio_test_slab(folio) || PageTable(&folio->page) || folio_test_reserved(folio))
+	if (folio_test_slab(folio) || PageTable(&folio->page) ||
+	    folio_test_reserved(folio) || PageOffline(&folio->page))
 		goto unlock_mutex;
 
 	/*
-- 
2.33.0



  parent reply	other threads:[~2023-07-15  3:17 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-15  3:17 [PATCH 0/4] A few fixup and cleanup patches for memory-failure Miaohe Lin
2023-07-15  3:17 ` [PATCH 1/4] mm/swapfile: fix wrong swap entry type for hwpoisoned swapcache page Miaohe Lin
2023-07-15  3:50   ` Matthew Wilcox
2023-07-17  2:33     ` Miaohe Lin
2023-07-17  2:53       ` Matthew Wilcox
2023-07-17  5:55         ` Miaohe Lin
2023-07-23  2:23         ` Miaohe Lin
2023-07-15  3:17 ` [PATCH 2/4] mm: memory-failure: fix potential unexpected return value from unpoison_memory() Miaohe Lin
2023-07-19 23:48   ` Naoya Horiguchi
2023-07-20  8:44     ` Miaohe Lin
2023-07-15  3:17 ` [PATCH 3/4] mm: memory-failure: avoid false hwpoison page mapped error info Miaohe Lin
2023-07-15  3:59   ` Matthew Wilcox
2023-07-19 23:50   ` Naoya Horiguchi
2023-07-15  3:17 ` Miaohe Lin [this message]
2023-07-20  1:09   ` [PATCH 4/4] mm: memory-failure: add PageOffline() check Naoya Horiguchi
2023-07-20  8:42     ` Miaohe Lin
2023-07-20 23:55       ` Naoya Horiguchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230715031729.2420338-5-linmiaohe@huawei.com \
    --to=linmiaohe@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=naoya.horiguchi@nec.com \
    --cc=shy828301@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox